Change in ovirt-host-deploy[master]: Updated README.environment
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Updated README.environment
......................................................................
Updated README.environment
Update README.environment with keys added up to 1.5.1
Updated some modules doc-text to align with existing moduels
documentation style
Change-Id: Id6ba44b62406dbc42ae0b7cc732b7e26639a03e1
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1332586
---
M README.environment
M src/plugins/ovirt-host-common/hosted-engine/packages.py
M src/plugins/ovirt-host-deploy/gluster/nrpe.py
M src/plugins/ovirt-host-deploy/tune/tuned.py
4 files changed, 112 insertions(+), 10 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61705
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6ba44b62406dbc42ae0b7cc732b7e26639a03e1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: vm full-list to work with only the id of the host
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: vm full-list to work with only the id of the host
......................................................................
core: vm full-list to work with only the id of the host
As TODO comments in different places in the code suggest, there is no
real need to get the whole VDS object for querying the full-list of a
VM. This patch changes the FullList to get only the identifier of the
host that the VM runs on.
Change-Id: If9880b0d886098d03eddd70bc5eee6b329b1ef97
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FullListVDSCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FullListVDSCommand.java
5 files changed, 9 insertions(+), 17 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/61913
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9880b0d886098d03eddd70bc5eee6b329b1ef97
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: image upload - exception on validation
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: image upload - exception on validation
......................................................................
webadmin: image upload - exception on validation
Image upload dialog:
fixed ArrayIndexOutOfBoundsException exception on validation.
Change-Id: Ie1d948841729540d41ae4746a48e618b47115ce2
Bug-Url: https://bugzilla.redhat.com/1352857
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Amit Aviram: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/61942
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1d948841729540d41ae4746a48e618b47115ce2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: unlock vms properly in vm-devices monitoring
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: unlock vms properly in vm-devices monitoring
......................................................................
core: unlock vms properly in vm-devices monitoring
Obviously, We should unlock the VMs that VM-devices monitoring locks
inside a finally block.
Change-Id: Id8f7f7eafc6b91550cd85e810db4a4a74a3d663c
Bug-Url: https://bugzilla.redhat.com/1361860
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java
1 file changed, 9 insertions(+), 6 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/61912
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8f7f7eafc6b91550cd85e810db4a4a74a3d663c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in jenkins[master]: Revert "ppc64le: add support to generate multi arch cfg"
by eedri@redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Revert "ppc64le: add support to generate multi arch cfg"
......................................................................
Revert "ppc64le: add support to generate multi arch cfg"
This reverts commit abdbda4d475ab487c38baa9114df1fe95fbe0922.
This change broke the experimental jobs, need to revert.
Change-Id: Ieb141401667ec68bb05cc8defc5261d803cf8154
Signed-off-by: gbenhaim <galbh2(a)gmail.com>
---
M jobs/confs/shell-scripts/mock_setup.sh
D mock_configs/epel-7-ppc64le.cfg
D mock_configs/epel-7-ppc64le_proxied.cfg
3 files changed, 1 insertion(+), 113 deletions(-)
Approvals:
Gal Ben Haim: Verified; Ready for review
Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61951
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb141401667ec68bb05cc8defc5261d803cf8154
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Gal Ben Haim <galbh2(a)gmail.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: reduce number of nested levels in VmDevicesMonitoring#...
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: reduce number of nested levels in VmDevicesMonitoring#flush
......................................................................
core: reduce number of nested levels in VmDevicesMonitoring#flush
Since most of the code in this method should be inside a try block so
the unlock of the VMs would be inside a finally block, this patch
reduces the number of nested level in this method so it would be
easier to read.
Change-Id: I758127759083585f584e346edc6c33affb8965fe
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java
1 file changed, 3 insertions(+), 6 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61911
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I758127759083585f584e346edc6c33affb8965fe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: fix the serialization of vm statistics for gwt
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix the serialization of vm statistics for gwt
......................................................................
core: fix the serialization of vm statistics for gwt
VmStatistics class used to use collections that gwt cannot deserialize to
store the history of different statistics (cpu, memory, network). It was not
a problem before because the UI got VmStatistics that were retrieved from
the database and during the construction of the entities, collections that
can be deserialized by gwt were used instead. But now that were going to
send VmStatistics that are managed in-memory we must use collections that
can be deserialized by gwt.
Change-Id: Ibd0a60f24fda02a665edf5eb5c67e0766804b5c0
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/61899
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd0a60f24fda02a665edf5eb5c67e0766804b5c0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: engine: ad_aggregator_id column added to interface table
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: ad_aggregator_id column added to interface table
......................................................................
engine: ad_aggregator_id column added to interface table
Adding ad_aggregator_id to interface table.
Change-Id: I404b2eff8c93a120292481366cf5da3da0031bd8
Bug-Url: https://bugzilla.redhat.com/1281666
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_01_0210_add_ad_aggregator_id_to_interface.sql
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59848
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I404b2eff8c93a120292481366cf5da3da0031bd8
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: engine: Set ad_aggregator_id from GetCaps into interface
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Set ad_aggregator_id from GetCaps into interface
......................................................................
engine: Set ad_aggregator_id from GetCaps into interface
This patch sets the network inerface ad_aggregator_id
property recieved by the GetCaps command into VdsNetworkInterface.
Change-Id: If2cbf1ceca6bac1965b278ae6a52313fd9a4e157
Bug-Url: https://bugzilla.redhat.com/1281666
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59850
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2cbf1ceca6bac1965b278ae6a52313fd9a4e157
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: engine: Adding ad_aggregatior_id to VdsNetworkInterface
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Adding ad_aggregatior_id to VdsNetworkInterface
......................................................................
engine: Adding ad_aggregatior_id to VdsNetworkInterface
Change-Id: Iff893116260d2da43e7f82c6ac1ad23929e1c935
Bug-Url: https://bugzilla.redhat.com/1281666
Signed-off-by: mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/network_sp.sql
5 files changed, 35 insertions(+), 9 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59849
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff893116260d2da43e7f82c6ac1ad23929e1c935
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months