Change in ovirt-engine[ovirt-engine-4.0]: core: add logicalName to DiskAttachment
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: add logicalName to DiskAttachment
......................................................................
core: add logicalName to DiskAttachment
In v3 of the the REST API, the logical name of a disk could be retrieved
from ovirt-engine/api/v3/vms/<vm_id>/disks.
Since in v4 DiskAttachmentsService replaces DisksService, the field
logicalName should be added to DiskAttachment so that it can be
retrieved from /ovirt-engine/api/vms/<vm_id>/diskattachments and
/ovirt-engine/api/vms/<vm_id>/diskattachments/<disk_attachment_id>.
Change-Id: I102e2e79dcf39aef22bdd36dd12d323564458930
Bug-Url: https://bugzilla.redhat.com/1358271
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskVmElement.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskVmElementDaoImpl.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskAttachmentMapper.java
M packaging/dbscripts/create_views.sql
5 files changed, 20 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/61894
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I102e2e79dcf39aef22bdd36dd12d323564458930
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: automation: use 4.0 repos
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: automation: use 4.0 repos
......................................................................
automation: use 4.0 repos
Change-Id: Ib1869d928a19871a9bc26873a1a26ba1df743e46
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M automation/build-artifacts.repos
M automation/check-merged.repos
M automation/check-patch.repos
3 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61893
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1869d928a19871a9bc26873a1a26ba1df743e46
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 3 months
Change in ovirt-engine[master]: core: GetUnusedGlusterBricksQuery type inference
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: GetUnusedGlusterBricksQuery type inference
......................................................................
core: GetUnusedGlusterBricksQuery type inference
Change-Id: I5afb71f1931e8de6686e3d68687f074d1347e12e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetUnusedGlusterBricksQuery.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61886
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5afb71f1931e8de6686e3d68687f074d1347e12e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: GetUnusedGlusterBricksQuery streams
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: GetUnusedGlusterBricksQuery streams
......................................................................
core: GetUnusedGlusterBricksQuery streams
Use Java 8's streams to make the code cleaner and more elegant.
Change-Id: Iacb62373d7837ea19f2ca88bb8ecf8e72d0c89fc
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetUnusedGlusterBricksQuery.java
1 file changed, 8 insertions(+), 18 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Sahina Bose: Looks good to me, but someone else must approve
Ramesh N: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/61887
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iacb62373d7837ea19f2ca88bb8ecf8e72d0c89fc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: ScheduleGlusterVolumeSnapshotCommand type inference
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ScheduleGlusterVolumeSnapshotCommand type inference
......................................................................
core: ScheduleGlusterVolumeSnapshotCommand type inference
Change-Id: I3ce8dc04ebb6f3a0a13f6884930311dfde5d6c55
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61888
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ce8dc04ebb6f3a0a13f6884930311dfde5d6c55
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-log-collector[master]: ovirt-log-collector: added --with-kerberos engine option
by rmartins@redhat.com
Rafael Martins has submitted this change and it was merged.
Change subject: ovirt-log-collector: added --with-kerberos engine option
......................................................................
ovirt-log-collector: added --with-kerberos engine option
Change-Id: I6960a9a7bde8944f2884f944ef170dccf059bc27
Bug-Url: https://bugzilla.redhat.com/1363684
Signed-off-by: Rafael Martins <rmartins(a)redhat.com>
---
M src/__main__.py
M src/helper/hypervisors.py
M src/ovirt-log-collector.8
3 files changed, 36 insertions(+), 11 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Rafael Martins: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/61880
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6960a9a7bde8944f2884f944ef170dccf059bc27
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-iso-uploader[master]: ovirt-iso-uploader: added --with-kerberos engine option
by rmartins@redhat.com
Rafael Martins has submitted this change and it was merged.
Change subject: ovirt-iso-uploader: added --with-kerberos engine option
......................................................................
ovirt-iso-uploader: added --with-kerberos engine option
Change-Id: I3a3f9ab278e2f0f2feebc92de9804d7c93f06f1a
Bug-Url: https://bugzilla.redhat.com/1363681
Signed-off-by: Rafael Martins <rmartins(a)redhat.com>
---
M src/__main__.py
M src/ovirt-iso-uploader.8
2 files changed, 30 insertions(+), 10 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Rafael Martins: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/61879
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a3f9ab278e2f0f2feebc92de9804d7c93f06f1a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-image-uploader[master]: ovirt-image-uploader: added --with-kerberos engine option
by rmartins@redhat.com
Rafael Martins has submitted this change and it was merged.
Change subject: ovirt-image-uploader: added --with-kerberos engine option
......................................................................
ovirt-image-uploader: added --with-kerberos engine option
Bug-Url: https://bugzilla.redhat.com/1340963
Change-Id: Ia0e8aedf8050bc88f916b638da0154f147352200
Signed-off-by: Rafael Martins <rmartins(a)redhat.com>
---
M src/__main__.py
M src/ovirt-image-uploader.8
2 files changed, 30 insertions(+), 10 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Rafael Martins: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/61324
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0e8aedf8050bc88f916b638da0154f147352200
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: master
Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: webadmin: widen Interface column in attach disk to vm
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: widen Interface column in attach disk to vm
......................................................................
webadmin: widen Interface column in attach disk to vm
The interface column is cropped and thus needs to be wider.
Change-Id: I43efe9b7a84b0b63bd913aaaf26a7ab93fa48cf0
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/61884
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43efe9b7a84b0b63bd913aaaf26a7ab93fa48cf0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in jenkins[master]: copy-create-job-artifact: drop fc23 engine on 3.6
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: copy-create-job-artifact: drop fc23 engine on 3.6
......................................................................
copy-create-job-artifact: drop fc23 engine on 3.6
Change-Id: Iec19d4ada9a638ec1809af05cdeb7af685167910
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/yaml/builders/copy-create-job-artifact.yaml
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61890
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec19d4ada9a638ec1809af05cdeb7af685167910
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months