Change in ovirt-engine-sdk[master]: Fix parsing of multi-byte UTF-8 characters
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Fix parsing of multi-byte UTF-8 characters
......................................................................
Fix parsing of multi-byte UTF-8 characters
Currently the Reader.read method assumes that strings need to be encoded
using UTF-8 before parsing them. This is only true in Python 3, where
strings are sequences of 16 bits characters. But it isn't true in Python
2, and trying to do so fails if the string is already encoded using
UTF-8. To avoid that this patch changes the Reader.read method so that
it only does this encoding when running with Python 3.
Change-Id: I6ab2764da91bfcd1bd50ebec228b2225eac2c446
Bug-Url: https://bugzilla.redhat.com/1461060
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/lib/ovirtsdk4/reader.py
M sdk/tests/test_vm_reader.py
M sdk/tests/test_xml_reader.py
3 files changed, 43 insertions(+), 5 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78112
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ab2764da91bfcd1bd50ebec228b2225eac2c446
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine-sdk[sdk_4.1]: Removed 'Requires: python3-enum34' from spec.fc*.in
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Removed 'Requires: python3-enum34' from spec.fc*.in
......................................................................
Removed 'Requires: python3-enum34' from spec.fc*.in
Fedora spec files don't need to contain 'Requires: python3-enum34',
because python3 doesn't contain package python3-enum34.
Change-Id: I50689a545e8788387b6e278e4d172088de0e9b6b
Bug-Url: https://bugzilla.redhat.com/1459613
Signed-off-by: Fabrice Bacchella <fabrice.bacchella(a)orange.fr>
---
M packaging/spec.fc24.in
M packaging/spec.fc25.in
2 files changed, 0 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50689a545e8788387b6e278e4d172088de0e9b6b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Fabrice Bacchella <fabrice.bacchella(a)orange.fr>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine-sdk[sdk_4.1]: Removes now useless Provides and Obsoletes from spec.*.in
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Removes now useless Provides and Obsoletes from spec.*.in
......................................................................
Removes now useless Provides and Obsoletes from spec.*.in
Change-Id: I094030d19cf5ee0c4932a23fa98e105c6f080d88
Bug-Url: https://bugzilla.redhat.com/1459625
Signed-off-by: Fabrice Bacchella <fabrice.bacchella(a)orange.fr>
---
M packaging/spec.el7.in
M packaging/spec.fc24.in
M packaging/spec.fc25.in
3 files changed, 0 insertions(+), 9 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78202
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I094030d19cf5ee0c4932a23fa98e105c6f080d88
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Fabrice Bacchella <fabrice.bacchella(a)orange.fr>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine-sdk[master]: Removed 'Requires: python3-enum34' from spec.fc*.in
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Removed 'Requires: python3-enum34' from spec.fc*.in
......................................................................
Removed 'Requires: python3-enum34' from spec.fc*.in
Fedora spec files don't need to contain 'Requires: python3-enum34',
because python3 doesn't contain package python3-enum34.
Change-Id: I50689a545e8788387b6e278e4d172088de0e9b6b
Bug-Url: https://bugzilla.redhat.com/1459613
Signed-off-by: Fabrice Bacchella <fabrice.bacchella(a)orange.fr>
---
M packaging/spec.fc24.in
M packaging/spec.fc25.in
2 files changed, 0 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78023
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50689a545e8788387b6e278e4d172088de0e9b6b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Fabrice Bacchella <fabrice.bacchella(a)orange.fr>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine-sdk[master]: Removes now useless Provides and Obsoletes from spec.*.in
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Removes now useless Provides and Obsoletes from spec.*.in
......................................................................
Removes now useless Provides and Obsoletes from spec.*.in
Change-Id: I094030d19cf5ee0c4932a23fa98e105c6f080d88
Bug-Url: https://bugzilla.redhat.com/1459625
Signed-off-by: Fabrice Bacchella <fabrice.bacchella(a)orange.fr>
---
M packaging/spec.el7.in
M packaging/spec.fc24.in
M packaging/spec.fc25.in
3 files changed, 0 insertions(+), 9 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78022
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I094030d19cf5ee0c4932a23fa98e105c6f080d88
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Fabrice Bacchella <fabrice.bacchella(a)orange.fr>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine-sdk[master]: Add Fedora 26 support
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add Fedora 26 support
......................................................................
Add Fedora 26 support
Change-Id: I73a0b93f7aa2acebca95972f8c454756cf05e4d7
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A automation/build-artifacts.packages.fc26
A automation/build.packages.fc26
A automation/check-merged.packages.fc26
A automation/check-patch.packages.fc26
A packaging/spec.fc26.in
5 files changed, 88 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78190
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I73a0b93f7aa2acebca95972f8c454756cf05e4d7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: webadmin: Context menu to bootstrap drop down
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Context menu to bootstrap drop down
......................................................................
webadmin: Context menu to bootstrap drop down
- Replaced popupmenu with bootstrap drop down for
the grid context menus.
Change-Id: I9d1def97c1ee2f2b7d917fe7e0bc1c705ee76bc6
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementTooltipUtils.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/SubTabTreeActionPanel.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tab/SimpleTabPanel.ui.xml
6 files changed, 98 insertions(+), 108 deletions(-)
Approvals:
Alexander Wels: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77412
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d1def97c1ee2f2b7d917fe7e0bc1c705ee76bc6
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: webadmin: selection model fix
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: selection model fix
......................................................................
webadmin: selection model fix
- Made the selection model final and populated it based
on if the list model is single select or multi select.
Change-Id: I64d8eebeafd3ff8d017a1e8669a1a321af79da90
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/SimpleActionPanel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java
2 files changed, 21 insertions(+), 25 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78187
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64d8eebeafd3ff8d017a1e8669a1a321af79da90
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: userportal, webadmin: work around GWT-P memory leak
by Code Review
>From Vojtech Szocs <vszocs(a)redhat.com>:
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal, webadmin: work around GWT-P memory leak
......................................................................
userportal, webadmin: work around GWT-P memory leak
We encountered a fairly large memory leak in the latest
version of GWT-P. All GWT-P popups have a resize handler
attached to them, but this handler lives at window scope
and never lets go. Therefore, every popup is completely
leaked when closed.
However, luckily, the method in GWT-P that sets up this
handler has a hook/template method for disabling the addition
of the handler:
if (repositionOnWindowResize()) {
Window.addResizeHandler(new ResizeHandler() ...
We simply overload repositionOnWindowResize() to always
return false and the leak is worked around.
See: https://github.com/ArcBees/GWTP/issues/823
Change-Id: I4e6d4da68e3f50f5863f4e33e62581b97e36dd2d
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractPopupView.java
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78025
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e6d4da68e3f50f5863f4e33e62581b97e36dd2d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-4.1]: frontend: Fix issues with GWT symbol map assembly & install
by Code Review
>From Oved Ourfali <oourfali(a)redhat.com>:
Oved Ourfali has submitted this change and it was merged.
Change subject: frontend: Fix issues with GWT symbol map assembly & install
......................................................................
frontend: Fix issues with GWT symbol map assembly & install
- maven-assembly-plugin 3.0.0 -> 2.4
- update install-gwt-symbols script, removing assumption
about $(MAVEN_OUTPUT_DIR)/frontend/... file structure
Change-Id: I83f807061808c8db92fc8411f7b78ea6ff2b346c
Bug-Url: https://bugzilla.redhat.com/1431545
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M Makefile
M frontend/webadmin/modules/frontend-assemblies/src/main/resources/assemblies/gwt-symbols.xml
M pom.xml
3 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/78149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83f807061808c8db92fc8411f7b78ea6ff2b346c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Dusan Fodor <dfodor(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months