June 2017 - Engine-commits - oVirt List Archives

Change in ovirt-log-collector[master]: inventory: Check for Windows VMs with incorrect timezone
by Code Review 01 Jun '17

01 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Check for Windows VMs with incorrect timezone ...................................................................... inventory: Check for Windows VMs with incorrect timezone Display a message if any Windows VM contain incorrect timezone. Change-Id: I5b4bdcb549fa29df8188a3a90d3d71ebfc0537d3 --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/vms_query_windows_vms_with_incorrect_timezone.sql 4 files changed, 175 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77614 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b4bdcb549fa29df8188a3a90d3d71ebfc0537d3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Donald Berry <dberry(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: metrics: Install fluentd collectd-nest and viaq_data_model p...
by Code Review 01 Jun '17

01 Jun '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. Change subject: metrics: Install fluentd collectd-nest and viaq_data_model plugins ...................................................................... metrics: Install fluentd collectd-nest and viaq_data_model plugins Change-Id: I1ea33e27c099c0969b37f8c3d3d0ec0d382f9b25 Bug-Url: https://bugzilla.redhat.com/1426900 Bug-Url: https://bugzilla.redhat.com/1426903 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/plugins/ovirt-host-deploy/fluentd/packages.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/77650 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ea33e27c099c0969b37f8c3d3d0ec0d382f9b25 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Include jcl-over-slf4j into tools modules
by Code Review 01 Jun '17

01 Jun '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: Include jcl-over-slf4j into tools modules ...................................................................... core: Include jcl-over-slf4j into tools modules Apache commons-logging libraries are reimplemented within WildFly. In older versions the reimplementation has been provided by 'org.slf4j.jcl-over-slf4j' module, but in newer version reimplementation has been changed to 'org.jboss.logmanager.commons.logging'. This works fine if application is executed inside running WildFly, but we are using those libraries also outside running EAP in command line tools. In order to be able to use slf4j as our logging frontend we are using standard slf4j implementation instead of WildFly reimplementation of slf4j for our command line tools. Apache commons-logging is used indirectly through commons-configuration also in command line tool engine-config, so we would need to add 'org.slf4j.jcl-over-slf4j' into our special modules for command line tools to override this reimplementation change. Change-Id: Ia3fce0af7de78f5757a13a18c06dcd885dc7c215 Bug-Url: https://bugzilla.redhat.com/1457810 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/dependencies/tools/pom.xml A backend/manager/dependencies/tools/src/main/modules/org/apache/commons/logging/main/module.xml A backend/manager/dependencies/tools/src/main/modules/org/slf4j/jcl-over-slf4j/main/module.xml M ovirt-engine.spec.in 4 files changed, 50 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77640 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3fce0af7de78f5757a13a18c06dcd885dc7c215 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: code simplificatons, to simplify extensibility
by Code Review 01 Jun '17

01 Jun '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: core: code simplificatons, to simplify extensibility ...................................................................... core: code simplificatons, to simplify extensibility code in touched classes was not necessarily complex to just repackage data from one class to another. I need to touch this code, and without this changes, these methods would become even more painful to read. Change-Id: I144f2391c893878ad76a219da3edcf6868546fa8 Bug-Url: https://bugzilla.redhat.com/1445171 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageLabeledNetworksParametersBuilderImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/PropagateLabeledNetworksToClusterHostsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/transformer/NetworkClustersToSetupNetworksParametersTransformerImpl.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/CollectionUtils.java 4 files changed, 68 insertions(+), 73 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I144f2391c893878ad76a219da3edcf6868546fa8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: logic to be insync, shouldn't be dispersed across classes
by Code Review 01 Jun '17

01 Jun '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: core: logic to be insync, shouldn't be dispersed across classes ...................................................................... core: logic to be insync, shouldn't be dispersed across classes … but it should be confined inside of single class Change-Id: I593d7c961ac97dd905794cfa859066546ec5dd34 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/IsRoleNetworkIpConfigurationValid.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java 3 files changed, 75 insertions(+), 45 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I593d7c961ac97dd905794cfa859066546ec5dd34 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: spec: Require fluentd viaq_data_model plugin
by Code Review 01 Jun '17

01 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: Require fluentd viaq_data_model plugin ...................................................................... packaging: spec: Require fluentd viaq_data_model plugin Change-Id: I58b6ae6587acb9dc493ef00c8c32c8ed4a1e3d92 Bug-Url: https://bugzilla.redhat.com/1426898 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/77653 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58b6ae6587acb9dc493ef00c8c32c8ed4a1e3d92 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add email notification to node-ng and added Yuval and infra
by Code Review 01 Jun '17

01 Jun '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Add email notification to node-ng and added Yuval and infra ...................................................................... Add email notification to node-ng and added Yuval and infra Change-Id: I95789e150dfbce6bf1e94b6fb52c7b3f3b09d3cb --- M jobs/confs/projects/ovirt-appliance/ovirt-appliance.yaml M jobs/confs/projects/ovirt-node-ng/ovirt-node-ng.yaml 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Daniel Belenky: Verified -- To view, visit https://gerrit.ovirt.org/77503 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95789e150dfbce6bf1e94b6fb52c7b3f3b09d3cb Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>

1 0

Change in jenkins[master]: Remove old repoclosure jobs
by Code Review 01 Jun '17

01 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: Remove old repoclosure jobs ...................................................................... Remove old repoclosure jobs Jira: https://ovirt-jira.atlassian.net/browse/OVIRT-1429 As today repoclosure is being checked dynamically during OST, we no longer need the old repoclosure jobs. This patch is removing the jobs, and all the related failes. Change-Id: Iddda73b01fa71efb75f597f0cbbd0c5dadde5307 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- D jobs/confs/groovy-scripts/repos-check-closure_post-build.groovy D jobs/confs/projects/repos-check-closure/repos-check-closure.yaml D jobs/confs/shell-scripts/repos-check-closure_apply-cherry-pick.sh D jobs/confs/shell-scripts/repos-check-closure_run-check.sh D jobs/confs/yaml/templates/repos-check-closure.yaml D jobs/packaging/repo_closure_check.sh 6 files changed, 0 insertions(+), 333 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Ready for merge Daniel Belenky: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddda73b01fa71efb75f597f0cbbd0c5dadde5307 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VmHandler#getMaxNumberOfMonitors streams
by Code Review 01 Jun '17

01 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: VmHandler#getMaxNumberOfMonitors streams ...................................................................... core: VmHandler#getMaxNumberOfMonitors streams Rewrite VmHandler#getMaxNumberOfMonitors using Java 8's streams instead of a boiler-plate for loop. Change-Id: I913f1dfaf900e19ee60a20f0a602ac6e65a65f76 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I913f1dfaf900e19ee60a20f0a602ac6e65a65f76 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmHandler config value treatment
by Code Review 01 Jun '17

01 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: VmHandler config value treatment ...................................................................... core: VmHandler config value treatment Config.getValue(ConfigValues.ValidNumOfMonitors) returns a List<String>. This patch fixes VmHandler#getMaxNumberOfMonitors to use that list directly instead of converting it to a string and then paring it to an array of strings. Change-Id: If7facfc4631ef2a90e558776e8257ab4f18ddd96 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77464 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7facfc4631ef2a90e558776e8257ab4f18ddd96 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0