June 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: NumberOfMonitorsConstraint null checks
by Code Review 01 Jun '17

01 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: NumberOfMonitorsConstraint null checks ...................................................................... core: NumberOfMonitorsConstraint null checks The ValidNumOfMonitors config value should always be present. If it isn't, there's a problem with the installation, and the code should error out instead of silently failing the validation. This patch removes the wrong null check on the config value's result. With this check eliminated, the code can be slightly optimized to avoid retrieving the config value if the passed value was null. Change-Id: Ib5a74c917336cdc0d60b7559abb20710f8d123e9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NumberOfMonitorsConstraint.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5a74c917336cdc0d60b7559abb20710f8d123e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: NumberOfMonitorsConstraint type inference
by Code Review 01 Jun '17

01 Jun '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: NumberOfMonitorsConstraint type inference ...................................................................... core: NumberOfMonitorsConstraint type inference Change-Id: Ic189fd7ad89af1914ef6c79d315e0d673c40aba6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NumberOfMonitorsConstraint.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic189fd7ad89af1914ef6c79d315e0d673c40aba6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Search by Vms: next_run_config_exists
by Code Review 01 Jun '17

01 Jun '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Search by Vms: next_run_config_exists ...................................................................... core: Search by Vms: next_run_config_exists Added ability to search VMs with NEXT_RUN snapshot waiting to be applied on VM shutdown. The query will look like: Vms: next_run_config_exists = true Change-Id: Ia821c070e88ef879b730f43fa9c87c349ce4a6ff Bug-Url: https://bugzilla.redhat.com/1432912 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia821c070e88ef879b730f43fa9c87c349ce4a6ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Improve README.adoc
by Code Review 01 Jun '17

01 Jun '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Improve README.adoc ...................................................................... Improve README.adoc This patch improves the SDK usage introduction included in the README.adoc file. Change-Id: I33f48f6a89a31a725fca026b2995e5c53de5feee Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 364e355c01f051bc12494473abd9c31055a0d884) --- M sdk/README.adoc 1 file changed, 615 insertions(+), 23 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77627 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33f48f6a89a31a725fca026b2995e5c53de5feee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Improve README.adoc
by Code Review 01 Jun '17

01 Jun '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Improve README.adoc ...................................................................... Improve README.adoc This patch improves the SDK usage introduction included in the README.adoc file. Change-Id: I33f48f6a89a31a725fca026b2995e5c53de5feee Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/README.adoc 1 file changed, 615 insertions(+), 23 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75320 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33f48f6a89a31a725fca026b2995e5c53de5feee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lucy Bopf <lbopf(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused DiskValidator#getVdsBroker()
by Code Review 01 Jun '17

01 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused DiskValidator#getVdsBroker() ...................................................................... core: Remove unused DiskValidator#getVdsBroker() Change-Id: I9354d912ed712a18c466c2a2980ed4601132c28d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/77569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9354d912ed712a18c466c2a2980ed4601132c28d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: edit Vm from pool did not show the RNG config
by Code Review 01 Jun '17

01 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: edit Vm from pool did not show the RNG config ...................................................................... webadmin: edit Vm from pool did not show the RNG config The problem was that the updateRngDevice() checked if the getIsRngEnabled() is changable or not. This is an incorrect check in the edit VM from pool where (almost) all fields are disabled. Solved by removing this check completely because it could never result to "false". Change-Id: I00da6580da7c458bdd5585b8e921097880cd83d1 Bug-Url: https://bugzilla.redhat.com/1429912 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 3 files changed, 0 insertions(+), 18 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00da6580da7c458bdd5585b8e921097880cd83d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live 4.1.3 tc2
by Code Review 01 Jun '17

01 Jun '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: build: ovirt-live 4.1.3 tc2 ...................................................................... build: ovirt-live 4.1.3 tc2 Change-Id: Id1f0a248cd0f00c145bcb8bba6d717af5e5b44d2 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lev Veyde: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77622 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1f0a248cd0f00c145bcb8bba6d717af5e5b44d2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: sos: fix configuration on engine host
by Code Review 01 Jun '17

01 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: fix configuration on engine host ...................................................................... sos: fix configuration on engine host Fixed sos configuration for execution on engine host adding logs plugin correctly. Change-Id: I7e0ae57a2a853ba8bccdc25c8ec278bad8de7987 Bug-Url: https://bugzilla.redhat.com/1447790 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit a5501d6368101510f2e8997630d690273f8da211) --- M src/__main__.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e0ae57a2a853ba8bccdc25c8ec278bad8de7987 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: use runQuery to get a StorageServerConnection
by Code Review 01 Jun '17

01 Jun '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: use runQuery to get a StorageServerConnection ...................................................................... restapi: use runQuery to get a StorageServerConnection BackendStorageDomainsResource -> getStorageServerConnection: use 'runQuery' instead of 'getEntity' in order to return a correct error code in case of a missing storage connection for a storage domain (500 instead of 404). Change-Id: Idd737198b59dc5feb2fb5e60c0eba96873756919 Bug-Url: https://bugzilla.redhat.com/1448399 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/77322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd737198b59dc5feb2fb5e60c0eba96873756919 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0