Change in ovirt-engine[master]: rest: setting permissions on new created VM in user level ap...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: rest: setting permissions on new created VM in user level api (#869699)
......................................................................
rest: setting permissions on new created VM in user level api (#869699)
https://bugzilla.redhat.com/show_bug.cgi?id=869699
When creating a VM in the user-level API, the creator should be set as
the owner of it.
Change-Id: Ia9734547ab6a6a91c64982f854b4713cd7bfdab9
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8806
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9734547ab6a6a91c64982f854b4713cd7bfdab9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: core: Introducing SEAT
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: Introducing SEAT
......................................................................
core: Introducing SEAT
Introducing the concept of Serial Execution of Asynchronous Tasks.
This feature splits a single CommandBase up in to several
SPMAsyncTaskHandlers.
Each such handler performs some synchronous code and ends with an
asynchronous SPM task. Once the task is completed, endAction() is
called, and the next handler is executed.
Change-Id: I4f2d113ced0276a9d849b7f00c7757e003d35f4c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTaskHandler.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskHandlerCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
7 files changed, 366 insertions(+), 15 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f2d113ced0276a9d849b7f00c7757e003d35f4c
Gerrit-PatchSet: 28
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: restapi: Error when attaching a disk to a VM #854479
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Error when attaching a disk to a VM #854479
......................................................................
restapi: Error when attaching a disk to a VM #854479
https://bugzilla.redhat.com/show_bug.cgi?id=854479
Change-Id: I6d10c3f1c790e4a8d99975bd6b8714de4a4fbb97
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8804
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d10c3f1c790e4a8d99975bd6b8714de4a4fbb97
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: tools: rhevm-config help: Need to make cver optional (#86888...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: rhevm-config help: Need to make cver optional (#868889)
......................................................................
tools: rhevm-config help: Need to make cver optional (#868889)
In rhevm-config --help "cver" option discription needs to be changed
to indicate that it is required only when the version is not "general".
Change-Id: If182c0f47b7e786bfd61c335f70c0888f7b85474
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=868889
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/tools/engine-config/src/main/resources/engine-config
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ravi Nori: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If182c0f47b7e786bfd61c335f70c0888f7b85474
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: core: adding storage_pool_id and task type fields to async_t...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: adding storage_pool_id and task type fields to async_tasks
......................................................................
core: adding storage_pool_id and task type fields to async_tasks
For purpose of upgrade from 3.1 -> 3.2 to present running
tasks information during upgrade.
Change-Id: I23cc8694c17471d38f5e24f26f77c78a7b3b1034
Bug-Url: https://bugzilla.redhat.com/868672
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/dbscripts/async_tasks_sp.sql
A backend/manager/dbscripts/upgrade/03_01_1460_add_storage_pool_id_and_task_type_to_async_tasks.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/async_tasks.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
8 files changed, 68 insertions(+), 5 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23cc8694c17471d38f5e24f26f77c78a7b3b1034
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: core: adding timestamp to async tasks ...
by Gerrit Code Review
Anonymous Coward has submitted this change and it was merged.
Change subject: core: adding timestamp to async tasks ...
......................................................................
core: adding timestamp to async tasks ...
adding timestamp to async tasks and compensation tables
This patch deals with two issues:
1. adds timestamp columns to both async_tasks and
business_entity_snapshot tables in order to track when an async task or
compensation entry was issued.
2. Adds a "startTime" field based on the added column
to async_tasks , and eliminates the usage of VdcActionParametersBase.startTime
Bug-Url: https://bugzilla.redhat.com/868636
Change-Id: Id7a5c609083584e4ae304a3f7af7c0e3b4f9b408
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/dbscripts/async_tasks_sp.sql
A backend/manager/dbscripts/upgrade/03_01_1450_add_timestamp_to_async_tasks_and_compensation.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/async_tasks.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
10 files changed, 49 insertions(+), 27 deletions(-)
--
To view, visit http://gerrit.ovirt.org/8668
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7a5c609083584e4ae304a3f7af7c0e3b4f9b408
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: webadmin: "Fully configured" message for guide me dialogs (#...
by achub＠redhat.com
Alexey Chub has submitted this change and it was merged.
Change subject: webadmin: "Fully configured" message for guide me dialogs (#850439)
......................................................................
webadmin: "Fully configured" message for guide me dialogs (#850439)
http://bugzilla.redhat.com/850439
Change-Id: I16d72904dfebe8fa0a29065e587c829998da782f
Signed-off-by: Alexey Chub <achub(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.java
2 files changed, 60 insertions(+), 28 deletions(-)
Approvals:
Alexey Chub: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8435
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16d72904dfebe8fa0a29065e587c829998da782f
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexey Chub <achub(a)redhat.com>
Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: packaging: Remove redundant DB user name
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Remove redundant DB user name
......................................................................
packaging: Remove redundant DB user name
The presence of the database user name in the security section of the
connection pool together with a security domain is not allowed but
previous versions of JBoss AS didn't enforce this restriction. It is
enforced now and it makes the deployment of the applicatoin fail.
Change-Id: I8506e88a16619476c661b1f3f17c0f564b240da4
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M packaging/fedora/engine-service.xml.in
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8506e88a16619476c661b1f3f17c0f564b240da4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: engine: Adding @DisableInMaintenanceMode to RegisterVdsQuery
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Adding @DisableInMaintenanceMode to RegisterVdsQuery
......................................................................
engine: Adding @DisableInMaintenanceMode to RegisterVdsQuery
The following annotation is added in order to disable a running such query during maintaince mode.
Reason is: these query is addding a new host to the system
Change-Id: Idc68dad1dcfeaeba5631f1544572efb804f13eec
Bug-Url: https://bugzilla.redhat.com/868639
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc68dad1dcfeaeba5631f1544572efb804f13eec
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: core: adding engine Maintenance and Prepare mode.(#868639)
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: adding engine Maintenance and Prepare mode.(#868639)
......................................................................
core: adding engine Maintenance and Prepare mode.(#868639)
Adding support for engine Maintenance/Prepare mode that is controlled by a new
configuration key named EngineMode (String).
Adding support for engine Prepare mode - value is PrepareMode.
Adding support for engine Maintenance mode - value is MaintenanceMode.
The default value of those configuration keys is Regular, however, this
value can be set to PrepareMode/MaintenanceMode in order to prevent new commands from being
processed by the backend class.
MaintainceMode will prevent of running all commands and some queries marked by
@DisableInMaintenanceMode annotation.
PrepareMode will prevent of running all commands marked by @DisableInPrepareMode
annotation.
Change-Id: Idd86f9f9008a447e160edc913ee8a6cd70912dcb
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
Bug-Url:https://bugzilla.redhat.com/868639
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserFromVmFromPoolCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DisableInMaintenanceMode.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DisableInPrepareMode.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackendTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/EngineWorkingMode.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
33 files changed, 155 insertions(+), 58 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd86f9f9008a447e160edc913ee8a6cd70912dcb
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 2 months