Change in ovirt-engine[master]: engine: Backend bean clean up
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Backend bean clean up
......................................................................
engine: Backend bean clean up
Garbage removed
Change-Id: Ic3a2bc61f2912c4aa8baffd628351997c788c169
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
1 file changed, 3 insertions(+), 55 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8771
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3a2bc61f2912c4aa8baffd628351997c788c169
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: core: Remove redundant vds_interface from fixtures
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Remove redundant vds_interface from fixtures
......................................................................
core: Remove redundant vds_interface from fixtures
Refer to subject.
Change-Id: I90acdf515e9c620c881fdbb199b6d263d4c63b1e
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M backend/manager/modules/dal/src/test/resources/fixtures.xml
1 file changed, 0 insertions(+), 20 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90acdf515e9c620c881fdbb199b6d263d4c63b1e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: core: Query GetVdsAndNetworkInterfacesByNetworkId
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Query GetVdsAndNetworkInterfacesByNetworkId
......................................................................
core: Query GetVdsAndNetworkInterfacesByNetworkId
This patch adds the query above as part of the
Network Main Tab feature.
Change-Id: If53281fdc70c9fb2b19145e62bb8f0a5ae3491c0
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M backend/manager/dbscripts/network_sp.sql
M backend/manager/dbscripts/vds_sp.sql
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsAndNetworkInterfacesByNetworkIdQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVdsAndNetworkInterfacesByNetworkIdQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/InterfaceDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/InterfaceDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/NetworkViewDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
13 files changed, 298 insertions(+), 5 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8499
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If53281fdc70c9fb2b19145e62bb8f0a5ae3491c0
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: core: Query GetVdsGroupsAndNetworksByStoragePoolId
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Query GetVdsGroupsAndNetworksByStoragePoolId
......................................................................
core: Query GetVdsGroupsAndNetworksByStoragePoolId
This patch adds the query above as part of the
Network Main Tab feature.
Change-Id: I5602c19e731cf0c3fe1377a574eac9ac42d351b6
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsGroupsAndNetworksByNetworkIdQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVdsGroupsAndNetworksByNetworkIdQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
3 files changed, 130 insertions(+), 0 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5602c19e731cf0c3fe1377a574eac9ac42d351b6
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: webadmin: disks tabs - adding tool-tips icon columns
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: disks tabs - adding tool-tips icon columns
......................................................................
webadmin: disks tabs - adding tool-tips icon columns
* Status column (active/inactive/locked):
Added the relevant tool-tips - moved icon creation to
DiskStatusColumn (extending ImageResourceColumn),
thus DiskStatusCell is no longer needed).
* Bootable/shareable/DirectLUN columns:
** Added to disks sub-tab.
** Added icons and tool-tips to the headers.
Change-Id: I88eae57989e31dda08b747009a035aa695c0bebf
Bug-Url: https://bugzilla.redhat.com/851856
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskStatusCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskStatusColumn.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ImageResourceColumn.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java
10 files changed, 107 insertions(+), 84 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8795
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88eae57989e31dda08b747009a035aa695c0bebf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: core: notify user about broken domain tasks (#753591)
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: notify user about broken domain tasks (#753591)
......................................................................
core: notify user about broken domain tasks (#753591)
Adds warning-level auditlog that the user receives when a storage domain
goes down while there are tasks running on it.
The patch also modifies the canDoAction in
DeactivateStorageDomainCommand so that the action is not rejected if
running on an export domain and initiated internally.
Bug-Url: https://bugzilla.redhat.com/753591
Change-Id: I2b6239668eece2be39b96c9bd360af2bd310a3b0
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 26 insertions(+), 0 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7957
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b6239668eece2be39b96c9bd360af2bd310a3b0
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: core: MoveDisk - pass WipeAfterDelete property
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: MoveDisk - pass WipeAfterDelete property
......................................................................
core: MoveDisk - pass WipeAfterDelete property
Passing WipeAfterDelete property when moving a disk.
Removing redundant postZero property.
Change-Id: I2f422e5b20853b5f9769736b15f95d26881ea469
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyImageGroupParameters.java
6 files changed, 2 insertions(+), 17 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8794
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f422e5b20853b5f9769736b15f95d26881ea469
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 2 months
Change in ovirt-guest-agent[master]: replaced agent license to apache software license (asl) 2.0.
by bazulay＠redhat.com
Barak Azulay has submitted this change and it was merged.
Change subject: replaced agent license to apache software license (asl) 2.0.
......................................................................
replaced agent license to apache software license (asl) 2.0.
Change-Id: Ibc18a1761236b91644c526a6f4c17eef2ffd7e65
Signed-off-by: Gal Hammer <ghammer(a)redhat.com>
---
M COPYING
M README
M gdm-plugin/gdm-ovirtcred-extension.c
M gdm-plugin/gdm-ovirtcred-extension.h
M gdm2-plugin/gdm-ovirtcred-extension.c
M gdm2-plugin/gdm-ovirtcred-extension.h
M gdm2-plugin/plugin.c
M ovirt-guest-agent.spec
M ovirt-guest-agent/CredServer.py
M ovirt-guest-agent/GuestAgentLinux2.py
D ovirt-guest-agent/LICENSE_GPL_v2
M ovirt-guest-agent/LockActiveSession.py
M ovirt-guest-agent/OVirtAgentLogic.py
M ovirt-guest-agent/VirtIoChannel.py
M ovirt-guest-agent/WinFile.py
M ovirt-guest-agent/ovirt-guest-agent.el5.rules
M ovirt-guest-agent/ovirt-guest-agent.py
M ovirt-guest-agent/ovirt-guest-agent.rules
18 files changed, 350 insertions(+), 752 deletions(-)
Approvals:
Barak Azulay: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc18a1761236b91644c526a6f4c17eef2ffd7e65
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: core: avoid having SD active on vdsm and not in engine
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: avoid having SD active on vdsm and not in engine
......................................................................
core: avoid having SD active on vdsm and not in engine
When running RecoveryStoragePool command which triggers reconstruct
engine shouldn't use compensation on the newly
added domain in case the reconstruct succeeded on vdsm side even if we
have a failure afterwards.
Change-Id: Ida51b027b8078555ffab5b80d2ffe54572fa6cca
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=845838
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java
2 files changed, 28 insertions(+), 16 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8390
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida51b027b8078555ffab5b80d2ffe54572fa6cca
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
12 years, 2 months
Change in ovirt-engine[master]: core: Move Pair class to common.utils
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Move Pair class to common.utils
......................................................................
core: Move Pair class to common.utils
This patch moves the Pair class from utils to
common.utils, to be used by frontend.
Change-Id: I358b2feb95c1d62cce2d76e3d35e46ac5e7239be
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingNFSStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingSANStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetExistingStorageDomainListQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java
R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/Pair.java
R backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/PairTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetStorageDomainInfoVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainInfoVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
18 files changed, 25 insertions(+), 20 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8697
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I358b2feb95c1d62cce2d76e3d35e46ac5e7239be
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
12 years, 2 months