Change in ovirt-engine[master]: core: Fix possible NPE in GetoVirtISOsQuery.
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: Fix possible NPE in GetoVirtISOsQuery.
......................................................................
core: Fix possible NPE in GetoVirtISOsQuery.
FindBugs issue -
GetoVirtISOsQuery.java:186, NP_DEREFERENCE_OF_READLINE_VALUE, Priority: Low
Dereference of the result of readLine() without nullcheck in org.ovirt.engine.core.bll.GetoVirtISOsQuery.readVdsmCompatibiltyVersion(String)
The result of invoking readLine() is dereferenced without checking to see if the result is null. If there are no more lines of text to read, readLine() will return null and dereferencing that will generate a null pointer exception.
Change-Id: I334832b5fefa24de732f919555b3ad26f11b8d08
Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8686
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I334832b5fefa24de732f919555b3ad26f11b8d08
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: core: ImagesHandler cleanup.
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: ImagesHandler cleanup.
......................................................................
core: ImagesHandler cleanup.
FindBugs issue -
ImagesHandler.java:685, MS_SHOULD_BE_FINAL, Priority: Low
org.ovirt.engine.core.bll.ImagesHandler.log isn't final but
should be A mutable static field could be changed by malicious
code or by accident from another package. The field could be made
final to avoid this vulnerability.
Change-Id: I744b65dc531357c079560017b85087ae01d1ec2a
Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8687
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I744b65dc531357c079560017b85087ae01d1ec2a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: core: don't re-migrate vm after migration was canceled (#867...
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: don't re-migrate vm after migration was canceled (#867347)
......................................................................
core: don't re-migrate vm after migration was canceled (#867347)
https://bugzilla.redhat.com/show_bug.cgi?id=867347
if migration was canceled, vm went back to up on the source,
this is identified as failure in migration, and re-run is called,
causing migration to run again.
this patch remove the vm from the async-running-vms list on
cancel-migration,
that way the vm will not be re-run when migration will be identified as
failed.
Change-Id: I9a8bf38bef90e5dfd0458cc13b8bb704f11d9f58
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CancelMigrateVDSCommand.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8658
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a8bf38bef90e5dfd0458cc13b8bb704f11d9f58
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
11 years, 6 months
Change in ovirt-engine[master]: userportal: VMs are not refreshed after edit
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal: VMs are not refreshed after edit
......................................................................
userportal: VMs are not refreshed after edit
In PUP: edit VM, click OK, edit VM again
The values will still be the old ones and you need
to wait until the next refresh cycle to actually
get them refreshed.
The refreshing after edit works like this:
When the popup is closed (the window model is set
to null), the ModelBoundPopupHandler
catches this event and calls the hideAndClearPopup
which calls the force refresh. This ensures,
that after the values are edited, the screen
contains the updated data.
The problem was, that the UserPortalListModel
called the cancel() method right after the
command to update the values has been sent to the server.
Before the call returned, the force refresh
tried to get the updated data, but they
was not necessarily updated yet.
Changed to call the cancel() after the
specific commands returns to ensure that the
data are actually modified.
Change-Id: If37dfffaafd72e385dfed03b3aafbd07cd82ba2d
Bug-Url: https://bugzilla.redhat.com/864059
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
2 files changed, 6 insertions(+), 24 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If37dfffaafd72e385dfed03b3aafbd07cd82ba2d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: engine: Wrong templates displayed for iscsi DC
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: Wrong templates displayed for iscsi DC
......................................................................
engine: Wrong templates displayed for iscsi DC
1. Make sure you have iscsi,nfs local DCs.
2. Create templates for each DC
3. Try to create a pool for iscsi DC
Wrong templates are listed in dropdown menu. The problem was caused by NPE in
the Template_SelectedItemChanged method of the NewPoolModelBehavior class. The
template is previously set to null in the ItemsChanged method of the ListModel
class. Fixed by adding check for null in the Template_SelectedItemChanged
method.
Change-Id: I1dbee5e31ec945b8ee07407cac5045d7cf8c39bf
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=863149
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1dbee5e31ec945b8ee07407cac5045d7cf8c39bf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: core: Handling transactivity at ShutdownVmCommand
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Handling transactivity at ShutdownVmCommand
......................................................................
core: Handling transactivity at ShutdownVmCommand
This patch removes global transactions from
ShutdownVmCommand related flows, and introduces
shorter transaction + compensation where needed.
Change-Id: I373d921fbecbd2fee79c5a430b428f7f20246051
Bug-Url: https://bugzilla.redhat.com865086
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
3 files changed, 52 insertions(+), 14 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8571
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I373d921fbecbd2fee79c5a430b428f7f20246051
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: core: WipeAfterDelete defaults to true in GUI, but false in ...
by Gerrit Code Review
Anonymous Coward has submitted this change and it was merged.
Change subject: core: WipeAfterDelete defaults to true in GUI, but false in REST API (#845466)
......................................................................
core: WipeAfterDelete defaults to true in GUI, but false in REST API (#845466)
WipeAfterDelete in gui default to false for File Storage Domains and
for Block storage domains the value is defined by SANWipeAfterDelete
configuration value.
The backend logic has been changed to mimic this behaviour.
Change-Id: I8cb77b017282733d72ff66af499b576674674e01
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=845466
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/WipeAfterDeleteUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java
3 files changed, 34 insertions(+), 4 deletions(-)
Approvals:
Michael Pasternak: Looks good to me, approved
Objections:
Omer Frenkel: Do not submit
--
To view, visit http://gerrit.ovirt.org/8628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8cb77b017282733d72ff66af499b576674674e01
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 6 months
Change in ovirt-dwh[master]: etl: made etl sleep cycles more accurate (#840866)
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: made etl sleep cycles more accurate (#840866)
......................................................................
etl: made etl sleep cycles more accurate (#840866)
Stopped using tSleep component that uses seconds granularity and
added pure java component with miliseconds granularity.
bug-url: https://bugzilla.redhat.com/840866
Change-Id: If58b528ea8c1793c93ebc9c97a9f2665b40a00ea
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/dailytimekeepingjob_3_1/DailyTimeKeepingJob.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/deletetimekeepingjob_3_1/DeleteTimeKeepingJob.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/hourlytimekeepingjob_3_1/HourlyTimeKeepingJob.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/parallelrun_3_1/ParallelRun.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/sampletimekeepingjob_3_1/SampleTimeKeepingJob.java
M data-warehouse/history_etl/tos_project/process/DailyTimeKeepingJob_3.1.item
M data-warehouse/history_etl/tos_project/process/DailyTimeKeepingJob_3.1.properties
M data-warehouse/history_etl/tos_project/process/DeleteTimeKeepingJob_3.1.item
M data-warehouse/history_etl/tos_project/process/DeleteTimeKeepingJob_3.1.properties
M data-warehouse/history_etl/tos_project/process/HourlyTimeKeepingJob_3.1.item
M data-warehouse/history_etl/tos_project/process/HourlyTimeKeepingJob_3.1.properties
M data-warehouse/history_etl/tos_project/process/ParallelRun_3.1.item
M data-warehouse/history_etl/tos_project/process/ParallelRun_3.1.properties
M data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.1.item
M data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.1.properties
M data-warehouse/history_etl/tos_project/talend.project
16 files changed, 1,511 insertions(+), 1,437 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8665
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If58b528ea8c1793c93ebc9c97a9f2665b40a00ea
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: restapi: RSDL does not document '?current' query parameter (...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: RSDL does not document '?current' query parameter (#864836)
......................................................................
restapi: RSDL does not document '?current' query parameter (#864836)
update on cdrom triggers vm update (and it fails with appropriate error message)
unless '?current' query parameter.
A new parameter has been added in RSDL via metadata.
Change-Id: Ica908b058917083c18f5dfb9dd5f08f23fd36d6b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=864836
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8607
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica908b058917083c18f5dfb9dd5f08f23fd36d6b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: core: Fixing some race during start up of JBOSS
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Fixing some race during start up of JBOSS
......................................................................
core: Fixing some race during start up of JBOSS
The following patch will solve unneeded race which
can occurre during start up of JBOSS.
A race is update of status of vdsm and running of monitoring process of
vdsm
Change-Id: Ic440c2f5532ce063af158c3e7d1761950bb9807f
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Michael Kublin: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8643
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic440c2f5532ce063af158c3e7d1761950bb9807f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 6 months