Change in ovirt-engine[master]: user-portal, web-admin: es, fr, pt_BR, zh_CN
by vszocs@redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: user-portal,web-admin: es,fr,pt_BR,zh_CN
......................................................................
user-portal,web-admin: es,fr,pt_BR,zh_CN
Changed user portal and web-admin's gwt.xml to declare
support in the following locales: es,fr,pt_BR,zh_CN.
Also, changed the user portal and web-admin pom.xml files to
compile also es,fr,pt_BR,zh_CN as part of the "all-langs"
profile.
Change-Id: If8e199443b12bd852f9f4275efeafd120dd140bb
Signed-off-by: Einav Cohen <ecohen(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8e199443b12bd852f9f4275efeafd120dd140bb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: packaging: Stopped using --column-inserts in pg_dump
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Stopped using --column-inserts in pg_dump
......................................................................
packaging: Stopped using --column-inserts in pg_dump
Using --column-inserts slows down the dump operation.
Change-Id: I69c2e5309bbd7ba26875de234a1ea612055d526a
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/fedora/setup/common_utils.py
M packaging/fedora/setup/engine-cleanup.py
M packaging/fedora/setup/engine-upgrade.py
3 files changed, 0 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8566
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69c2e5309bbd7ba26875de234a1ea612055d526a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: engine:cannot start stateless VM
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine:cannot start stateless VM
......................................................................
engine:cannot start stateless VM
1. create a vm with disk
2. edit vm -> check the stateless checkbox
3. run the vm
The machine doesn't run with NPE. The problem was that the parent command and
its parameters were set incorrectly in classes CreateAllSnapshotsFromVmCommand
and RunVmCommand. Fixed by setting the right parent command/parameters.
Change-Id: I6152049360dd0254b9bd07b2397abd9d7d56c5d8
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=863766
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
2 files changed, 7 insertions(+), 4 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8461
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6152049360dd0254b9bd07b2397abd9d7d56c5d8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: packaging: updated handling of pgpass file between versions
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: updated handling of pgpass file between versions
......................................................................
packaging: updated handling of pgpass file between versions
This patch handles the new location of the pgpass file
(/etc/ovirt-engine/.pgpass). It defined an environment
variable PGPASSFILE with a new location and uses this
variable in DB-related calls
(utils.execCmd and utils.execRemoteSql).
Change-Id: I1d44297725d7270982e8724e4aeefda8bc7a88e2
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/fedora/setup/common_utils.py
M packaging/fedora/setup/engine-cleanup.py
M packaging/fedora/setup/engine-upgrade.py
M packaging/fedora/setup/output_messages.py
4 files changed, 63 insertions(+), 48 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8135
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d44297725d7270982e8724e4aeefda8bc7a88e2
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: core: Fix removal of Gluster storage on Posix FS (#857632)
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix removal of Gluster storage on Posix FS (#857632)
......................................................................
core: Fix removal of Gluster storage on Posix FS (#857632)
When a domain is detached from a storage pool, the advanced options
did not pass to the ConnectStorageServer VDS command and thus in case
of Gluster storage the vfstype option did not pass to the host and it
doesn't try to mount it as a Gluster storage, this was fixed by including
the vfstype option even if the domain is detached
Change-Id: I5de20f13a1c03f230298f92bfe19643be8900ac0
Bug-Url: https://bugzilla.redhat.com/857632
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8576
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5de20f13a1c03f230298f92bfe19643be8900ac0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: core: simplify 'is null' sql expression
by lhornyak@redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: simplify 'is null' sql expression
......................................................................
core: simplify 'is null' sql expression
The original logic generates conditional expressions like
(tab.col = null or tab.col is null)
tab.col = null never evaluates to true on known sql database
engines, so the generated expression can be simplified with this.
The new generated condition will be just
(tab.col is null)
Change-Id: I6d186f0f354026086a7f7039deaca1c236cfc7be
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7047
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d186f0f354026086a7f7039deaca1c236cfc7be
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 3 months
Change in ovirt-engine[master]: core: QuotaManager Test - test 5,6
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: QuotaManager Test - test 5,6
......................................................................
core: QuotaManager Test - test 5,6
RollbackQuota test
RemoveQuotaFromCache test
Change-Id: Ia371593a4233c6411798b57b8377f0add8dcf1ab
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java
1 file changed, 84 insertions(+), 13 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8465
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia371593a4233c6411798b57b8377f0add8dcf1ab
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: core: QuotaManager Test - test 2,3,4
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: QuotaManager Test - test 2,3,4
......................................................................
core: QuotaManager Test - test 2,3,4
DecreaseStorageQuota test (currently ignored).
ValidateAndSetClusterQuota For VCPU test
ValidateAndSetClusterQuota For Memory test
Change-Id: I0bf60a6cc6b6e6842ea6b53c0e1feac134b508b2
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java
1 file changed, 143 insertions(+), 5 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8464
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bf60a6cc6b6e6842ea6b53c0e1feac134b508b2
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: core: Fix quota calculation for specific storage quota
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: Fix quota calculation for specific storage quota
......................................................................
core: Fix quota calculation for specific storage quota
In cases where quota setting is limiting specific storage domains. When
one of the domains limitation is not exceeded, the domains in the rest
of the list are not checked for quota limitations.
This was due to an unnecessary break.
Change-Id: Id19b7874401fb85e16f284931f6eaf5c0cfee52e
Bug-Url: https://bugzilla.redhat.com/864814
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8451
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id19b7874401fb85e16f284931f6eaf5c0cfee52e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: restapi: Yaml cleanup - clean update disk signature
by oliel@redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Yaml cleanup - clean update disk signature
......................................................................
restapi: Yaml cleanup - clean update disk signature
Change-Id: I0e5437b1dc9b6f86f7716df718a5f3fe276da91d
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
1 file changed, 0 insertions(+), 20 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8568
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e5437b1dc9b6f86f7716df718a5f3fe276da91d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 3 months