November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Changed edit VM disk to use run single action (#84...
by tnisan＠redhat.com 27 Nov '12

27 Nov '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Changed edit VM disk to use run single action (#848806) ...................................................................... webadmin: Changed edit VM disk to use run single action (#848806) The edit VM disk command in uicommon used run multiple actions for no reason due to this the VM disks list was not refreshed after the command excution and waited for the next timer interval to refresh, this caused the update data to appear only after a few seconds instead of immediately Change-Id: I75f4ebe1f20ce8e924f2d5d79ab1b1b6e3d6ef27 Bug-Url: https://bugzilla.redhat.com/848806 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 1 file changed, 8 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75f4ebe1f20ce8e924f2d5d79ab1b1b6e3d6ef27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in samples-portals[master]: typo fix: Action Faild
by shavivi＠redhat.com 27 Nov '12

27 Nov '12

Shahar Havivi has submitted this change and it was merged. Change subject: typo fix: Action Faild ...................................................................... typo fix: Action Faild Change-Id: Ibc3e1bde594301367cc4e67990e96ac249b46d7a Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M python/WebHandler.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc3e1bde594301367cc4e67990e96ac249b46d7a Gerrit-PatchSet: 1 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in samples-portals[master]: Python Sample: first commit
by shavivi＠redhat.com 27 Nov '12

27 Nov '12

Shahar Havivi has submitted this change and it was merged. Change subject: Python Sample: first commit ...................................................................... Python Sample: first commit Working sample of Python user portal using REST API Change-Id: I1d15dd5df8992c84b2c9529168919d05ba88bc33 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- A python/Broker.py A python/README A python/RestClient.py A python/RestCommand.py A python/WebHandler.py A python/ovirt.conf 6 files changed, 422 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d15dd5df8992c84b2c9529168919d05ba88bc33 Gerrit-PatchSet: 3 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in samples-portals[master]: Typo fix in user VMs table
by oourfali＠redhat.com 27 Nov '12

27 Nov '12

Oved Ourfali has submitted this change and it was merged. Change subject: Typo fix in user VMs table ...................................................................... Typo fix in user VMs table Change-Id: Ic7329f6c4c2935c6ae59bc8f8fc2c811b2304384 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M python/WebHandler.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7329f6c4c2935c6ae59bc8f8fc2c811b2304384 Gerrit-PatchSet: 1 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: better general VDSM exception handling
by rgolan＠redhat.com 27 Nov '12

27 Nov '12

Roy Golan has submitted this change and it was merged. Change subject: core: better general VDSM exception handling ...................................................................... core: better general VDSM exception handling refactor error translation to separate network exceptions and protocol exception so error on XML formatting could be propagated and logged correctly. Change-Id: Id2391ec81626cd984f64b9a738adca9be4116d5a Signed-off-by: Roy Golan <rgolan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/875725 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java 3 files changed, 14 insertions(+), 20 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2391ec81626cd984f64b9a738adca9be4116d5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:End failed live snapshot with warning.
by mlipchuk＠redhat.com 27 Nov '12

27 Nov '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core:End failed live snapshot with warning. ...................................................................... core:End failed live snapshot with warning. Engine fails to create Live-Snapshot during power off of VM. This is since the KVM process might be killed in the middle of the process and the synchronization between the engine VM and the KVM process in the VDSM are not reliable and could be racy. The proposed solution is to avoid the rollback of the entire operation, but instead finish the command with success, and add an appropriate audit log. That way will allow the VM to be configured to the new snapshot at the next run. Change-Id: I1b7f841d3fa02800fd58590c87d64e31227adfe5 Signed-Off-By: Maor Lipchuk <mlipchuk(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/870928 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 15 insertions(+), 7 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b7f841d3fa02800fd58590c87d64e31227adfe5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Change "Active" vnic to "Plugged"
by alkaplan＠redhat.com 27 Nov '12

27 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Change "Active" vnic to "Plugged" ...................................................................... webadmin: Change "Active" vnic to "Plugged" - VmInterface Dialog -change Activate checkobox to radio button- "Card Status". - Add plugged column to VM->VM Interface table. - Changed "Activated" property om VmInterfaceModel to "Plugged". Change-Id: Ib42f1e622ee1b55e65a6ec274e762cea9a08d531 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/template/TemplateNetworkInterfacePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseInterfaceListModelTable.java A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/network/icn_plugged.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/network/icn_un_plugged.png M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmInterfacePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineNetworkInterfaceView.java 18 files changed, 249 insertions(+), 78 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib42f1e622ee1b55e65a6ec274e762cea9a08d531 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix Moving Disk message (#856082)
by amureini＠redhat.com 27 Nov '12

27 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix Moving Disk message (#856082) ...................................................................... core: Fix Moving Disk message (#856082) Log message notifying about moving disk said "moveing", and is now corrected to "moving". The original message used ${Action}ing. The current one uses ${Action}, and MoveOrCopyDiskCommand is replacing it with Moving or Copying according to the operation taking place. Change-Id: I53bb3238d1a5e6b3e966adf488a10946e252ffe3 Bug-Url: https://bugzilla.redhat.com/856082 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 2 files changed, 8 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/9303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53bb3238d1a5e6b3e966adf488a10946e252ffe3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DB upgrade from 3.0 to 3.1 fails(#880350)
by emesika＠redhat.com 27 Nov '12

27 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core: DB upgrade from 3.0 to 3.1 fails(#880350) ...................................................................... core: DB upgrade from 3.0 to 3.1 fails(#880350) upgrade from 3.0.x to 3.1 failed in 2 points ; 1) 03_01_0950 Reason : script assumes that a storage is in only one DC and attempt to insert duplicate rows that violates primary key to the permission table Solution: check before inserting to permissions table that record with the same key does not exist 2) 03_01_1020 Reason :script adds a column_id column to the async_tasks table. Since this column type is UUID and is defined as NOT NULL, the addition will fail if at the point that this upgrade script is running the table is not empty Solution : Create the column with an empty UUID (00000.....000000) DEFAULT After this column was added , drop the default. Change-Id: Id9658673c16610da4a25e33c7969bcde61a64259 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/03_01_0950_add_permissions_on_storage_to_users.sql M backend/manager/dbscripts/upgrade/03_01_1020_add_command_id_to_async_tasks_table.sql 2 files changed, 14 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9658673c16610da4a25e33c7969bcde61a64259 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: [es_ES] heading "Virtual size" is truncated in Spa...
by oourfali＠redhat.com 27 Nov '12

27 Nov '12

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: [es_ES] heading "Virtual size" is truncated in Spanish (#871379) ...................................................................... webadmin: [es_ES] heading "Virtual size" is truncated in Spanish (#871379) https://bugzilla.redhat.com/871379 Increased the size of the "Virtual Size" column to fit all locales. Verified on all locales. Change-Id: Ie71097c4fae81753135eec2b28702ca9bf822f41 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/9505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie71097c4fae81753135eec2b28702ca9bf822f41 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0