November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: bootstrap: use LocalConfig for engine http host and port
by yzaslavs＠redhat.com 22 Nov '12

22 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: use LocalConfig for engine http host and port ...................................................................... bootstrap: use LocalConfig for engine http host and port This retires the VdcBootStrapUrl, PublicURLPort vdc_options in favour of the new configuration method. Change-Id: I01cd66cd83356c4dbaa0bae35ed0fe83c7c00852 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/tools/engine-config/src/main/resources/engine-config.properties M packaging/fedora/setup/engine-setup.py 5 files changed, 20 insertions(+), 18 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01cd66cd83356c4dbaa0bae35ed0fe83c7c00852 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Don't ask for password, before DNS SRV records are re...
by yzaslavs＠redhat.com 22 Nov '12

22 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Don't ask for password, before DNS SRV records are returned. ...................................................................... tools: Don't ask for password, before DNS SRV records are returned. This patch first performs DNS SRV query to get ldap servers (and KDCs) for domain, and only if sucueesful, the user will be prompted to enter password Change-Id: I9c5132300eb1f1fd94f771cab17efe5246dbeca8 Bug-Url: https://bugzilla.redhat.com/871585 Bug-Url: https://bugzilla.redhat.com/871591 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KerberosConfigCheck.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomainsResultEnum.java 4 files changed, 80 insertions(+), 13 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c5132300eb1f1fd94f771cab17efe5246dbeca8 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: some manage domains cleanup
by yzaslavs＠redhat.com 22 Nov '12

22 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: some manage domains cleanup ...................................................................... tools: some manage domains cleanup During working on a bug, I discovered we have an enum we no longer use, so I removed it. Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca1 Bug-Url: https://bugzilla.redhat.com/871585 Bug-Url: https://bugzilla.redhat.com/871591 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Extract Vlan Id Validation (#871864)
by msalem＠redhat.com 22 Nov '12

22 Nov '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Extract Vlan Id Validation (#871864) ...................................................................... engine: Extract Vlan Id Validation (#871864) This patch extracts repetitive code to the mutual parent class of AddNetworkCommand and UpdateNetworkCommand. Change-Id: Ifc54da41602245101d97f7afce86d5b97e6cfa36 Bug-Url: https://bugzilla.redhat.com/871864 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateNetworkCommand.java 3 files changed, 39 insertions(+), 45 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc54da41602245101d97f7afce86d5b97e6cfa36 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Fix ownership of deployments and contents
by juan.hernandez＠redhat.com 21 Nov '12

21 Nov '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Fix ownership of deployments and contents ...................................................................... packaging: Fix ownership of deployments and contents A previous commit (9d5af3) changed the .spec so that the backups directory is owned by the setup sub package. This is needed, but we also need to make sure that the deployments and contents directories are still owned by the backend package, otherwise the directories are not created and the service will not start. Change-Id: Ibb4745cfc9898b43a164781fd5866cf2b1fa4f82 Bug-Url: https://bugzilla.redhat.com/876164 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb4745cfc9898b43a164781fd5866cf2b1fa4f82 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.1]: packaging: Minor bugfix release 3.1.0-4
by oschreib＠redhat.com 21 Nov '12

21 Nov '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Minor bugfix release 3.1.0-4 ...................................................................... packaging: Minor bugfix release 3.1.0-4 This prepares for a minor bug fix release to fix the bugs indicated below. Change-Id: Ic145444a0b979123944b0be175007c6d4c9cbce5 Bug-Url: https://bugzilla.redhat.com/869457 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified Moran Goldboim: Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic145444a0b979123944b0be175007c6d4c9cbce5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: support python3 in make tarball
by juan.hernandez＠redhat.com 21 Nov '12

21 Nov '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: support python3 in make tarball ...................................................................... packaging: support python3 in make tarball This fix minor python3 related syntax change. Change-Id: Idec1402ff3eda6b4379b7a1562f8537f577fb994 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idec1402ff3eda6b4379b7a1562f8537f577fb994 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Messages grammar fixes
by amureini＠redhat.com 21 Nov '12

21 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: Messages grammar fixes ...................................................................... core: Messages grammar fixes The main issues (in file AuditLogMessages.properties): 1. "finish to XXX" is changed to "finished XXXing" etc. 2. "XXXing the disk ${disk}" is changed to "XXing disk ${disk}" 3. "the the" sequence replaced by just one "the". 4. Removed trailing spaces. Change-Id: Ic0c03b8d5d27212679d519e12d7e7bcbad81fa91 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 20 insertions(+), 20 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/9352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0c03b8d5d27212679d519e12d7e7bcbad81fa91 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: MoveDisk should support storage quota
by gchaplik＠redhat.com 21 Nov '12

21 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: MoveDisk should support storage quota ...................................................................... core: MoveDisk should support storage quota MoveDisk command encapsulate another command. we should support quota and call the commnad's getQuotaStorageConsumptionParameters(). Change-Id: I86c7bb9e86e0e5cd6811c5c037810dc86d1880e1 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDiskCommand.java 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86c7bb9e86e0e5cd6811c5c037810dc86d1880e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: fix date in ovirt-engine-sdk.spec.in
by mpastern＠redhat.com 21 Nov '12

21 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: fix date in ovirt-engine-sdk.spec.in ...................................................................... sdk: fix date in ovirt-engine-sdk.spec.in Change-Id: Iaffced84773a9d8f61ceeb36982267cc5efff1e5 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaffced84773a9d8f61ceeb36982267cc5efff1e5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0