November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: fix events grid view to fix ES locale
by shavivi＠redhat.com 05 Nov '12

05 Nov '12

Shahar Havivi has submitted this change and it was merged. Change subject: webadmin: fix events grid view to fix ES locale ...................................................................... webadmin: fix events grid view to fix ES locale Change-Id: Ieddf96a782d0657b58f4b16c26f72a9823199b60 Bug-Id: https://bugzilla.redhat.com/871391 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieddf96a782d0657b58f4b16c26f72a9823199b60 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removing reschedule of monitoring of vdsm by another v...
by mkublin＠redhat.com 05 Nov '12

05 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Removing reschedule of monitoring of vdsm by another vdsm ...................................................................... core: Removing reschedule of monitoring of vdsm by another vdsm The following patch will remove a reschedule of monitoring of vdsm, from other thread of monitoring. Such behaviour can cause to spending all quartz thread on reschedule of monitoring of the same vdsm. The use case: 1. We have 10 vdsms and 10 vms that are migrating to same vdsm 2. Each vdsm can schedule additional refresh of destination vdsm 3. Result : we has 10 quartz jobs that are trying to monitor the same vdsm and additional job which is regular monitoring (runs each 2 seconds) It is obvious that under load and in more big environment we will have a timeouts when all quartz threads will be busy by monitoring of the same vdsms Change-Id: I5534b3b627e992efbce152935ad207c978a7feed Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 2 files changed, 4 insertions(+), 37 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5534b3b627e992efbce152935ad207c978a7feed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Get Volume Advanced Details Query
by ofrenkel＠redhat.com 05 Nov '12

05 Nov '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Get Volume Advanced Details Query ...................................................................... engine: Get Volume Advanced Details Query - New entity classes for Volume Advanced Details - New Gluster Volume Advanced Details parameter class - New XmlRpc class for volume status - New bll and vds query - New Gluster Volume Dao method to fetch Nfs enabled volumes - Added Junit test for the query Change-Id: If6b590eaebeb1d06b7278300d5e12b2dab9eb093 Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- M backend/manager/dbscripts/gluster_volumes_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/BrickDetails.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/BrickProperties.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterClientInfo.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeAdvancedDetails.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeStatusOption.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/MallInfo.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/MemoryStatus.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/Mempool.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/ServiceInfo.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/ServiceType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeAdvancedDetailsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/gluster/GlusterCoreUtil.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeAdvancedDetailsVDSParameters.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/gluster/GlusterCoreUtilTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeAdvancedDetailsVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterVolumeStatusReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 30 files changed, 1,482 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Looks good to me, approved Dhandapani Gopal: Verified -- To view, visit http://gerrit.ovirt.org/7807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6b590eaebeb1d06b7278300d5e12b2dab9eb093 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Ensure "upgrade" alert on host general tab appears...
by achub＠redhat.com 05 Nov '12

05 Nov '12

Alexey Chub has submitted this change and it was merged. Change subject: webadmin: Ensure "upgrade" alert on host general tab appears correctly (#839336) ...................................................................... webadmin: Ensure "upgrade" alert on host general tab appears correctly (#839336) https://bugzilla.redhat.com/839336 Change-Id: I57002308a192c81e84f9730564d41fb03309d006 Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Alexey Chub: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57002308a192c81e84f9730564d41fb03309d006 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove unnecessary if clause
by masayag＠redhat.com 05 Nov '12

05 Nov '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove unnecessary if clause ...................................................................... engine: Remove unnecessary if clause Modified an if-else statement of the following structure: if (A) { ... } else if (!A) { ... } To: if (A) { ... } else { ... } Change-Id: I1ea9acbf5dce7608660fa7a8055eb4c6f45c2526 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VDSBrokerFrontendImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ea9acbf5dce7608660fa7a8055eb4c6f45c2526 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: remove empty constant from storage general tab
by shavivi＠redhat.com 04 Nov '12

04 Nov '12

Shahar Havivi has submitted this change and it was merged. Change subject: webadmin: remove empty constant from storage general tab ...................................................................... webadmin: remove empty constant from storage general tab No need to use constant for a separation line. Change-Id: I3300aadbf25e3b5c0bc223a73fc6e72181b5e9ad Bug-Id: https://bugzilla.redhat.com/870998 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageGeneralView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9012 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3300aadbf25e3b5c0bc223a73fc6e72181b5e9ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Network Main Tab- cleanup
by alkaplan＠redhat.com 04 Nov '12

04 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network Main Tab- cleanup ...................................................................... webadmin: Network Main Tab- cleanup - Formatting the new classes. - Fix non-logic comments from previous reviews (data members names, methods order...) Change-Id: I8773ac1cb7131123fed4a91fe751308c3575abcd Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/network/NetworkSubTabPanelPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkGeneralView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/SafeHtmlWithSafeHtmlTooltipColumn.java 13 files changed, 389 insertions(+), 470 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8773ac1cb7131123fed4a91fe751308c3575abcd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: LSM - rollback on non-running VM
by derez＠redhat.com 04 Nov '12

04 Nov '12

Daniel Erez has submitted this change and it was merged. Change subject: core: LSM - rollback on non-running VM ...................................................................... core: LSM - rollback on non-running VM LiveMigrateDiskCommand: Initiating rollback if the VM stops during migration. On each step of the migration process a new command is created (in order to execute the next task), if the VM is no longer running the previous tasks should be reverted/cleared. LiveSnapshotTaskHandler: On compensation, image's status should be reverted to OK. Updating status using DestinationImageId since ImageId might be obsolete - depending on which step the failure occurred (when taking a snapshot, a new active image is generated). CreateImagePlaceholderTaskHandler: Rollback should be DeleteImage. VmReplicateDiskStartTaskHandler: No rollback for task. Change-Id: I7aafc5cd63f961470124c984afb2e7a9d74a0de2 Bug-Url: https://bugzilla.redhat.com/872316 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskStartTaskHandler.java 4 files changed, 35 insertions(+), 21 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7aafc5cd63f961470124c984afb2e7a9d74a0de2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated interaction with user on async tasks
by oschreib＠redhat.com 04 Nov '12

04 Nov '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Updated interaction with user on async tasks ...................................................................... packaging: Updated interaction with user on async tasks * The previous try/finally clause included the initial interaction with the user, where tasks were found and user was asked whether to continue (and if user continues, then restart engine in maintenance mode), as well as some operations that could end with an exception. If, for example, user chooses not to continue, 'finally' will kick in, and try to restore the engine configuration, although it didn't change yet. Additionally, the setting "zombie tasks" timeout could fail and raise an exception, which would also try to restore both an engine AND "zombie tasks timeout", which is not set yes, leading to an incorrect setting. This patch aims to solve these issues by moving try/finally block to the later code, beginning only with the final loop, when a user has agreed to it. * Also, added additional try/finally block to the configureForMaintenance function, so that in case the creation of the temp configuration fails, we would still try to cleanup the file if it was created and raise the exception. * Also, changed the return value in getRunningTasks and getCompensation functions from "return None" to empty string "return ''". This improves the printouts to the user, and instead of printing "None" in tasks, nothing is printed if no tasks are found. Change-Id: Ia1f1aaf7ac812d69dc81f3fb8dee5a626bc7634a Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-upgrade.py M packaging/fedora/setup/output_messages.py 3 files changed, 66 insertions(+), 35 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1f1aaf7ac812d69dc81f3fb8dee5a626bc7634a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: redundant comma at the end of disabled command but...
by alkaplan＠redhat.com 04 Nov '12

04 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: redundant comma at the end of disabled command button tootip. ...................................................................... webadmin: redundant comma at the end of disabled command button tootip. The disabled command button tootip is a list of comma separeated reason. There should be a "," after the last reason. Change-Id: I5c8f5a87bb75a4c73f7dffc24c259794321adde5 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c8f5a87bb75a4c73f7dffc24c259794321adde5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0