November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Add/Edit logical networks- tooltip for disables ch...
by alkaplan＠redhat.com 04 Nov '12

04 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add/Edit logical networks- tooltip for disables checkboxes ...................................................................... webadmin: Add/Edit logical networks- tooltip for disables checkboxes - If VM Networks checkbox is disabled, tooltip should be displayed- Non-VM networks are not supported for Cluster version x.x - If override MTU is disabled, tooltip should be displayed- Overriding MTU configuration is not supported for Cluster version x.x Change-Id: Ibf0f34d1dc6e9927e08a152c90c3748ccb536639 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf0f34d1dc6e9927e08a152c90c3748ccb536639 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add/Edit network- Vlan tag before VM Network
by alkaplan＠redhat.com 04 Nov '12

04 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add/Edit network- Vlan tag before VM Network ...................................................................... webadmin: Add/Edit network- Vlan tag before VM Network Swap the locations of Vlan tag and VM Network. Change-Id: I40ceb004bd18837ead57435a010f619a6b3a443c Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40ceb004bd18837ead57435a010f619a6b3a443c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Network Main Tab- add remove vnic action
by alkaplan＠redhat.com 04 Nov '12

04 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network Main Tab- add remove vnic action ...................................................................... webadmin: Network Main Tab- add remove vnic action - Netwrok->VM,Template- adding action remove. - Moving the common code of remove vnic to RemoveVmInterfaceModel. Change-Id: I730eeb0597c56451908312fa20637df0ec3fedbd Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/RemoveConfirmationPopupPresenterWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateInterfaceListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RemoveVmInterfaceModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RemoveVmTemplateInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkTemplateView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkVmView.java 12 files changed, 408 insertions(+), 145 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I730eeb0597c56451908312fa20637df0ec3fedbd Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Allow quota memory size to excceed 65535MB
by gchaplik＠redhat.com 04 Nov '12

04 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Allow quota memory size to excceed 65535MB ...................................................................... webadmin: Allow quota memory size to excceed 65535MB Removed faulty restriction Change-Id: I2b5f672b1785215af489461e390f0186a9385d43 Bug-Url: https://bugzilla.redhat.com/870213 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaClusterModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b5f672b1785215af489461e390f0186a9385d43 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: updated reports' localiztion
by ydary＠redhat.com 04 Nov '12

04 Nov '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: updated reports' localiztion ...................................................................... reports: updated reports' localiztion Change-Id: I66d6571410db6b6364d4a8cca4f59c21ece987e9 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_es.properties.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_fr.properties.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_ja.properties.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_pt_BR.properties.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_zh_CN.properties.data 5 files changed, 314 insertions(+), 20 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66d6571410db6b6364d4a8cca4f59c21ece987e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated VDC utilities to accept alternative binar...
by oschreib＠redhat.com 04 Nov '12

04 Nov '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Updated VDC utilities to accept alternative binary ...................................................................... packaging: Updated VDC utilities to accept alternative binary * Renamed several parameters from _RHEVM_ convention to _ENGINE_ * Added the optional parameter for engine-conf binary in getVdcOptions function * Added the optional parameters for engine-conf binary and configuration in updateVdcOptions function. * Updated the definition of configureTasksTimeout function to utilize the aforementioned parameters. * Updated the usage of configureTasksTimeout function. Change-Id: Ica1c009bffbcd956c64929050e9ebb806be006af Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py 4 files changed, 31 insertions(+), 21 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica1c009bffbcd956c64929050e9ebb806be006af Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: cannot unpause VM started in paused mode
by rgolan＠redhat.com 04 Nov '12

04 Nov '12

Roy Golan has submitted this change and it was merged. Change subject: engine: cannot unpause VM started in paused mode ...................................................................... engine: cannot unpause VM started in paused mode Have 2 clusters, in each have one host. In one of this clusters create a VM. Run it in pause mode, wait until it starts in the pause mode and tham start it. The VM will not start. The problem was in VdsSelector in the check where it tried to find out, if the specific VM is migrating to the same host. This check makes sense for the migrating of the VM, but not for running it. Fixed by making the checks aware of if the VM is migrating or not. This patch also removes one duplication - one of the checks has been copy-pasted twice. There was also a workaround which ignored the situation that the VM would be migrated to the same host - it is already implmented in the HostValidator so removed. Change-Id: I8cca521f79bfb7d5762f2c996200916a10afc36a Bug-Url: https://bugzilla.redhat.com/872205 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PowerClientMigrateOnConnectCheckCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 4 files changed, 28 insertions(+), 49 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cca521f79bfb7d5762f2c996200916a10afc36a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Added quering alternative DB in checking version
by oschreib＠redhat.com 04 Nov '12

04 Nov '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Added quering alternative DB in checking version ...................................................................... packaging: Added quering alternative DB in checking version Added a dbName parameter to the unsupportedVersionsPresent() function that can be used to query an alternative DB. Change-Id: I9ac97021b568d370bb3a4bc22c330b2cbeda8ac0 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ac97021b568d370bb3a4bc22c330b2cbeda8ac0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: <placement_policy> should accept <host> by name (#7...
by mpastern＠redhat.com 04 Nov '12

04 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: <placement_policy> should accept <host> by name (#757115) ...................................................................... restapi: <placement_policy> should accept <host> by name (#757115) The addition of a VM by host name doesn't work as intended. The VM is being added without a host id. This patch fixes the issue by passing the computed host id from host name to the VmStatic class, which is used by the backend to create the VM. Change-Id: I09c9ad52db15e18813632598aca701e2b18af3d6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=757115 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09c9ad52db15e18813632598aca701e2b18af3d6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Support loading a VM snapshot when conf is not avail...
by derez＠redhat.com 02 Nov '12

02 Nov '12

Daniel Erez has submitted this change and it was merged. Change subject: engine: Support loading a VM snapshot when conf is not available. ...................................................................... engine: Support loading a VM snapshot when conf is not available. Enhance GetVmConfigurationBySnapshotQuery query to support loading a VM snapshot when OVF configuration is not available. This is mainly to handle snapshots that were taken with older versions of engine that didn't store full VM configuration as an OVF. Change-Id: Iddfae10354603e2ec9acb61f91e1361dd7504da4 Bug-Url: https://bugzilla.redhat.com/866173 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQuery.java 1 file changed, 41 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddfae10354603e2ec9acb61f91e1361dd7504da4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0