Change in ovirt-engine[master]: bootstrap: cleanup approve command
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: bootstrap: cleanup approve command
......................................................................
bootstrap: cleanup approve command
Do not use parent member if there is a method to access it.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875528
Change-Id: I212c7b7ab58dd45c56c8c94d62c49a9d2236d863
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java
1 file changed, 3 insertions(+), 6 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I212c7b7ab58dd45c56c8c94d62c49a9d2236d863
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: bootstrap: bootstrap: make approve command respect installat...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: bootstrap: bootstrap: make approve command respect installation failure
......................................................................
bootstrap: bootstrap: make approve command respect installation failure
Current implementation assumes success at all results, which is invalid.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875528
Change-Id: Iab010f40007ac11dd909350f60b6db1880edbf7f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java
1 file changed, 4 insertions(+), 12 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9443
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab010f40007ac11dd909350f60b6db1880edbf7f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: packaging: all-in-one: depend on ovirt-host-deploy-offline
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: packaging: all-in-one: depend on ovirt-host-deploy-offline
......................................................................
packaging: all-in-one: depend on ovirt-host-deploy-offline
The ovirt-host-deploy-offline configures the ovirt-host-deploy for
offline mode, and contains all relevant dependencies.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=878397
Change-Id: If145380ebcd3ab114197a931d4a7ce256c3ed78d
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/fedora/spec/ovirt-engine.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9371
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If145380ebcd3ab114197a931d4a7ce256c3ed78d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: bootstrap: rewrite bootstrap using the new ovirt-host-deploy...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: bootstrap: rewrite bootstrap using the new ovirt-host-deploy package
......................................................................
bootstrap: rewrite bootstrap using the new ovirt-host-deploy package
CURRENT IMPLEMENTATION
Host bootstrap is done via full blown bootstrap process via
the legacy vds_bootstrap project. It executes the vds_bootstrap scripts
twice one for 99% of the setup, then issue certificate and then again
for 1% of the setup.
Node bootstrap is done via short circuit between the vds_bootstrap
project, which at the very start checks if the host is a node and if it
is configure and restart vdsm_reg with one time password for it to
register into engine. [I have never seen this OTP registration working].
Node approval uses the vdsm_reg's vdsm-gen-cert, vdsm-complete scripts
in order to generate keys, and vdsm-complete to configure vdsm and
restart.
PROBLEM IN CURRENT IMPLEMENTATION
*** COMPLETXITY!!!! ***
Design and actual implementation.
MISSION
Retire VdsInstaller, OVirtInstaller implementations.
NEW IMPLEMENTATION
Use the new vdsm-bootstrap package that is dialog based.
Changes includes:
1. Same sequence for both host and ovirt-node bootstrap, not using
vdsm-reg, always run the same bootstrap process, while the bootstrap
is node aware.
2. vdsm-bootstrap log download.
3. vdsm-id is acquired from the dialog, engine should not know how
vdsm-id is generated, nor assume it can perform this remotely.
4. Much more freedom for the host side, it detects the host type
(host/node), it decides if reboot is required and finally it decides
if there was an error.
5. Use python tar implementation instead of system tar, as fedora-18
vanilla has no tar installed.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875528
Change-Id: If78c62601231f4729ca95da7653907b37856d672
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtInstaller.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/utils/pom.xml
D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/HostKeyVerifier.java
D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/IVdsInstallerCallback.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java
D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java
D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/DefaultValuesConfigUtil.java
D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java
M backend/manager/tools/engine-config/src/main/resources/engine-config.properties
M packaging/fedora/spec/ovirt-engine.spec.in
M pom.xml
16 files changed, 1,175 insertions(+), 2,141 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9175
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If78c62601231f4729ca95da7653907b37856d672
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 4 months
Change in ovirt-reports[master]: reports: fixed font sizes in all webadmin dashboards (#87323...
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: fixed font sizes in all webadmin dashboards (#873238)
......................................................................
reports: fixed font sizes in all webadmin dashboards (#873238)
bug-url: https://bugzilla.redhat.com/873238
Change-Id: I6d5356f375e3e96874bddff3c42058820652b8b5
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_ha_vm_uptime_status_dr13_files/cluster_ha_vm_uptime_status_dr13_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_host_resources_status_dr12_files/cluster_host_resources_status_dr12_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_host_uptime_status_dr6_files/cluster_host_uptime_status_dr6_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_summary_of_hosts_resources_usage_dr28_files/cluster_summary_of_hosts_resources_usage_dr28_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_top_five_busiest_hosts_dr23_files/cluster_top_five_busiest_hosts_dr23_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_vm_over_commit_status_dr14_files/cluster_vm_over_commit_status_dr14_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/top_five_ha_virtual_servers_downtime_dr20_files/top_five_ha_virtual_servers_downtime_dr20_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/top_five_hosts_downtime_dr18_files/top_five_hosts_downtime_dr18_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/datacenter_top_five_busiest_clusters_dr21_files/datacenter_top_five_busiest_clusters_dr21_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_host_resources_status_dr11_files/dc_host_resources_status_dr11_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_host_uptime_status_dr5_files/dc_host_uptime_status_dr5_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_storage_space_status_dr8_files/dc_storage_space_status_dr8_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_summary_of_cluster_hosts_resources_usage_dr27_files/dc_summary_of_cluster_hosts_resources_usage_dr27_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/top_five_clusters_host_downtime_dr16_files/top_five_clusters_host_downtime_dr16_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/system_dashboard/system_host_resources_status_dr10_files/system_host_resources_status_dr10_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/system_dashboard/system_host_uptime_status_dr4_files/system_host_uptime_status_dr4_jrxml.data
M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/system_dashboard/system_storage_space_status_dr7_files/system_storage_space_status_dr7_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/cluster_ha_vm_uptime_status_dr13_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/cluster_host_resources_status_dr12_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/cluster_host_uptime_status_dr6_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/cluster_summary_of_hosts_resources_usage_dr28_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/cluster_top_five_busiest_hosts_dr23_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/cluster_vm_over_commit_status_dr14_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/top_five_ha_virtual_servers_downtime_dr20_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/top_five_hosts_downtime_dr18_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/datacenter_top_five_busiest_clusters_dr21_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/dc_host_resources_status_dr11_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/dc_host_uptime_status_dr5_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/dc_storage_space_status_dr8_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/dc_summary_of_cluster_hosts_resources_usage_dr27_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/top_five_clusters_host_downtime_dr16_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/system_dashboard_files/system_host_resources_status_dr10_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/system_dashboard_files/system_host_uptime_status_dr4_jrxml.data
M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/system_dashboard_files/system_storage_space_status_dr7_jrxml.data
34 files changed, 81 insertions(+), 81 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9108
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d5356f375e3e96874bddff3c42058820652b8b5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: packaging: add release_suffix variable to spec
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: add release_suffix variable to spec
......................................................................
packaging: add release_suffix variable to spec
This will allow simpler jenkins automatic build to be able to add the
git hash as release suffix.
Example:
$ rpmbuild -tb -D "release_suffix ${git_head}" ovirt-engine-3.1.0.tar.gz
Change-Id: I080ee4b74790fe880b32fbab48050c078698527e
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/fedora/spec/ovirt-engine.spec.in
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I080ee4b74790fe880b32fbab48050c078698527e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: engine: Query getdisksvmguid caused postmaster processes to ...
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Query getdisksvmguid caused postmaster processes to consume constantly 100%cpu.
......................................................................
engine: Query getdisksvmguid caused postmaster processes to consume constantly 100%cpu.
The following bug occurrs because of the following query being run from
GetVmStatsVDSCommand every running VM in the system. The run is cyclic and runs in infinitive loop.
I don't see reason of that query, update of dynamic data ofor disc is done under lock, in worst case
the dynamic data will be updated with wrong values, in next run which occurring every 4 seconds, the
disk will be updated with correct values.
I think we can live with wrong values for 4 seconds in case of race
The change reduced CPU of machine with DB from 100% to 30%, which is still a high, but better
Change-Id: I9ef4a24908a75ab4fc1f02eed7c97a7125a5db41
Bug-Url: https://bugzilla.redhat.com/879930
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 22 insertions(+), 37 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9468
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ef4a24908a75ab4fc1f02eed7c97a7125a5db41
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: engine: Perfromance improvements at IrsBrokerCommand
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Perfromance improvements at IrsBrokerCommand
......................................................................
engine: Perfromance improvements at IrsBrokerCommand
The following patch is removing unneeded query for storage pool.
The objects can be passed to methods and not retrieved again from DB
Change-Id: I9b6054950b45793a8f37e7f8b261dbd315ff6859
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
1 file changed, 86 insertions(+), 90 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b6054950b45793a8f37e7f8b261dbd315ff6859
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: core: Fix storage quota release on stopStatelessVm
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: Fix storage quota release on stopStatelessVm
......................................................................
core: Fix storage quota release on stopStatelessVm
StopVmBase was defined QuotaStorageDependent and the
getQuotaStorageConsumptionParameters() was implemented to handle cases a
stateless vm is stopped (vm images are deleted).
Change-Id: I7088b94cd716bb93b2a4813963a980f4eab9e597
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
2 files changed, 22 insertions(+), 2 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9470
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7088b94cd716bb93b2a4813963a980f4eab9e597
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 4 months
Change in ovirt-engine[master]: core: Quota Dependency Test + RemoveSnapshot fix
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: Quota Dependency Test + RemoveSnapshot fix
......................................................................
core: Quota Dependency Test + RemoveSnapshot fix
Added a test that checks that is VdcActionType is defined quota
dependent - the correlating command is implementing the correct
interface.
RemoveSnapshotCommand did not implement QuotaStorageDependent. Fixed:
implementation added.
Change-Id: Ifd9e215abaa5de0fc03dae0609d9dc3ffc957f55
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaDependencyTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java
4 files changed, 106 insertions(+), 33 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9413
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd9e215abaa5de0fc03dae0609d9dc3ffc957f55
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 4 months