November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: remove unused private method from CommonVmPoolWithVmsC...
by lhornyak＠redhat.com 26 Nov '12

26 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: remove unused private method from CommonVmPoolWithVmsCommand ...................................................................... core: remove unused private method from CommonVmPoolWithVmsCommand getQuotaId is not used Change-Id: I715d25fe1bd99a5c0af435c4ad0dcd207d1a0aa6 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I715d25fe1bd99a5c0af435c4ad0dcd207d1a0aa6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: db - fixing wrong nfs_version argument in storage_san....
by rgolan＠redhat.com 26 Nov '12

26 Nov '12

Roy Golan has submitted this change and it was merged. Change subject: core: db - fixing wrong nfs_version argument in storage_san.sp ...................................................................... core: db - fixing wrong nfs_version argument in storage_san.sp 67761e1f513bdd17915ba7a47a6597ab23c4326d refactored nfs_version type and the insert sp but missed the update. Change-Id: Id9a2f060164f17e01db30f84bdf87a91c9b25769 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/dbscripts/storages_san_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9a2f060164f17e01db30f84bdf87a91c9b25769 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: upgrade from 3.0.7 to SI24.4 fail(#879918)
by emesika＠redhat.com 26 Nov '12

26 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: upgrade from 3.0.7 to SI24.4 fail(#879918) ...................................................................... upgrade from 3.0.7 to SI24.4 fail(#879918) upgrade from 3.0.7 to SI24.4 fails: ERROR: insert or update on table vm_device violates foreign key constraint fk_vm_device_vm _static This bug is a result of missing FK between vmt_guid in vm_interface and vm_guid in vm_static. This cause junk interface left in vm_interface when a template that has interfaces is removed. Since in upgrade from 3.0 to 3.1 we added the vm_device table, there is an attempt to insert those junk interfaces to vm_device that fails on the FK constraint between vm_device and vm_static. This patch fix the bug by: 1) Fixing the upgrade script to cleanup those junk interfaces before an attempt to insert it to vm_device is done. 2) Adds the missing FK between vm_interface and vm_static to prevent junk data in future. Change-Id: Iaf4af7908566b5d16e39ea5167c6d6dffc5884db Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/03_01_0440_vm_device_upgrade_data.sql A backend/manager/dbscripts/upgrade/03_01_1520_add_fk_vm_interface_vm_static_template.sql 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf4af7908566b5d16e39ea5167c6d6dffc5884db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: skip quota for flows with no storage pool
by rgolan＠redhat.com 26 Nov '12

26 Nov '12

Roy Golan has submitted this change and it was merged. Change subject: core: skip quota for flows with no storage pool ...................................................................... core: skip quota for flows with no storage pool Quota checks are being made based on a commands "quota dependency" which is being marked by an enum on the VdcActionType. The problem is that some commands, e.g. AddDisk may need quota check on regular disk but not on external floating LUN disk, mainly because this command will not have a storage pool (floating disk doesn't belong to a data center) thus - no quota could be calculated on it. As a way out, instead of breaking a command to two, (one quotable and one not) an empty list of quota params can be submitted so no quota checks will be made. Change-Id: Ie468db3709522653cd93c338564592e2ba439c4a Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParametersWrapper.java 2 files changed, 15 insertions(+), 7 deletions(-) Approvals: ofri masad: Looks good to me, but someone else must approve Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie468db3709522653cd93c338564592e2ba439c4a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix NPE on Clone VM from Snapshot
by mlipchuk＠redhat.com 25 Nov '12

25 Nov '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix NPE on Clone VM from Snapshot ...................................................................... core: Fix NPE on Clone VM from Snapshot Clone VM from snapshot throw NPE while using MoveOrCopyImageGroup. This happens since AddVmFromSnapshot creates the task first with the parameters and only after that it creates the disk in the DB. The proposed fix is to get the wipeAfterDelete flag from the parameters in case the destination disk is null. This fix should be revisited, to change the AddVmFromSnapshot to create the disk before the creation of task. Change-Id: I2c18b1ac552f598fc20e74aa67f81dabb915a8c2 Signed-Off-By: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c18b1ac552f598fc20e74aa67f81dabb915a8c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: OvfReader cleanup - remove unused parameter
by amureini＠redhat.com 25 Nov '12

25 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfReader cleanup - remove unused parameter ...................................................................... core: OvfReader cleanup - remove unused parameter Removed the vmDevice parameter from the getResourceType method. This method is private, and the parameter is not used, so we can be sure it is not required. Change-Id: Iaa9872617cc62539b2b8c33c5dbe2df21db355bb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa9872617cc62539b2b8c33c5dbe2df21db355bb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: OvfReader cleanup - correct DiskImage method
by amureini＠redhat.com 25 Nov '12

25 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfReader cleanup - correct DiskImage method ...................................................................... core: OvfReader cleanup - correct DiskImage method Replaced the usage of the deprecated DiskImage.set_imagegroup_id(Guid) with the newer DiskImage.setId(Guid) which it delegated to. Change-Id: I9b8f472eafe2ba98e8925508e6097b7093a70764 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b8f472eafe2ba98e8925508e6097b7093a70764 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: OvfReader cleanup - remove StringHelper
by amureini＠redhat.com 25 Nov '12

25 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfReader cleanup - remove StringHelper ...................................................................... core: OvfReader cleanup - remove StringHelper Removed usages of the deprecated StringHelper and replaced them with standard calls. * StringHelper.isNullOrEmpty(String) was replaced with apache commons' standard StringUtils.isEmpty(String). * StringHelper.EqOp(String, constant) was replaced with Java's standard constant.equals(String) Change-Id: I22f49eb0eec5c9849a4a2242a51ba0217718f0d1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 29 insertions(+), 30 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22f49eb0eec5c9849a4a2242a51ba0217718f0d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: OvfReader cleanup - document empty blocks
by amureini＠redhat.com 25 Nov '12

25 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfReader cleanup - document empty blocks ...................................................................... core: OvfReader cleanup - document empty blocks Documented the empty implementation of buildNetworks() and readSnapshostsSection(String) to avoid warnings by code analysis tools (e.g., Eclipse IDE's built-in inspection feature). Change-Id: I619991e6ebbbffac6c99a1ab2a98fa27aa57dadd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I619991e6ebbbffac6c99a1ab2a98fa27aa57dadd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replaced quartz job to thread job at MigrateVDSComma...
by mkublin＠redhat.com 25 Nov '12

25 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Replaced quartz job to thread job at MigrateVDSCommand ...................................................................... engine: Replaced quartz job to thread job at MigrateVDSCommand Because of we have more threads at the system and it is more covinient to open a thread instead of quarzt job with zero delay Change-Id: I7699a8d8e931ff336335d476fc4fc9251715b4fd Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java 1 file changed, 41 insertions(+), 52 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7699a8d8e931ff336335d476fc4fc9251715b4fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0