Change in ovirt-engine[master]: webadmin, userportal: Fix UI for cpu flags
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin, userportal: Fix UI for cpu flags
......................................................................
webadmin, userportal: Fix UI for cpu flags
The value of the "use host cpu" check-box was not saved in cases when
"Allow VM migration only upon..." is selected.
UI was fixed.
Change-Id: If3a994a419bc2d9271107a06bd9f7f7bad35ed0a
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
3 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3a994a419bc2d9271107a06bd9f7f7bad35ed0a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
12 years
Change in ovirt-engine[master]: webadmin: [SetupNetwork] networks detached when adding nic t...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: [SetupNetwork] networks detached when adding nic to a bond
......................................................................
webadmin: [SetupNetwork] networks detached when adding nic to a bond
When adding nic to a bond the networks on the nic should be attached to
the bond.
The bug is that the order was-
1. Detach the networks from the nic.
2. Determine the nic's networks.
3. Attach the nic's networks to the bond.
Step 1 and 2 should be switched.
Because after detaching there is no networks on the nic.
Change-Id: I5c2941106968dc08d8251d033a6274c9a272ade0
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
1 file changed, 7 insertions(+), 5 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c2941106968dc08d8251d033a6274c9a272ade0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years
Change in ovirt-engine[master]: restapi: Vnic's network update when portMirroring is set beh...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: restapi: Vnic's network update when portMirroring is set behaves wrong
......................................................................
restapi: Vnic's network update when portMirroring is set behaves wrong
If port mirroring is set, the port mirroring network should be equal to
the vnic's network. Otherwise, an exception should be thrown.
There was a bug, the equlity was checked just if the port mirroring was
updated.
So, in case that the network was updated and the port mirroring wasn't-
an exception wasn't thrown although it should be.
Change-Id: Icbb346805f91bd3964550a19b18b3d0a0c40e12c
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java
1 file changed, 42 insertions(+), 17 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbb346805f91bd3964550a19b18b3d0a0c40e12c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
12 years
Change in ovirt-engine[master]: engine: Model the smartcard as a device
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Model the smartcard as a device
......................................................................
engine: Model the smartcard as a device
Since the VDSM models the smartcard as a device, the engine
has been updated to model the smartcard as a device in
vm_device table too.
This is the firts phase - it does not remove the
is_smartcard_enabled from the vm_static.
Change-Id: I92c88b64f3efdf6e5b6fa829ac4b0dac47868e4a
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/smartcard/SmartcardSpecParams.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
7 files changed, 83 insertions(+), 2 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10302
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92c88b64f3efdf6e5b6fa829ac4b0dac47868e4a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
12 years
Change in ovirt-engine[master]: core : DB FK validation
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core : DB FK validation
......................................................................
core : DB FK validation
The purpose of this utility is to find inconsistent data that violates
FK(Forign Keys), display it and enable to remove it
Only support may access this utility with care
It is mandatory to run this utility on the original database before a
backup of the DB is taken for later
restore purpose, since if the database is backed up with the corrupted
data and the FK definition, the FK
will fail creation when the database is restored.
Use the -f flag to fix the problem by removing the data caused to the
FK violation.
Running this utility without the -f flag will only report the
violations.
Use the -f flag to fix the problem by removing the data caused to the
FK violation.
Sample Output:
>fkvalidator.sh -u postgres -d dbname
caution, this operation should be used with care. Please contact
support prior to running this command
Are you sure you want to proceed? [y/n]
y
psql:/tmp/tmp.fmQ0Q7O6ic:1: NOTICE: Constraint violation found in
weather (city) ... (2 records)
>fkvalidator.sh -u postgres -d dbname -f
Caution, this operation should be used with care. Please contact
support prior to running this command
Are you sure you want to proceed? [y/n]
y
psql:/tmp/tmp.8p8BXKVObk:1: NOTICE: Fixing weather (city) ... (2
records)
Change-Id: Ibe54bca7a832c1c358a5e8c7214e7825cb9e4fc3
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/dbscripts/common_sp.sql
M backend/manager/dbscripts/dbfunctions.sh
A backend/manager/dbscripts/fkvalidator.sh
3 files changed, 143 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10248
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe54bca7a832c1c358a5e8c7214e7825cb9e4fc3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years
Change in ovirt-engine[master]: Packaging: Fix answer-file typo in engine setup.
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: Packaging: Fix answer-file typo in engine setup.
......................................................................
Packaging: Fix answer-file typo in engine setup.
This patch fixes a typo.
Replacing "none-interactive" with "non-interactive"
Change-Id: Ib61bccf586de803f24784b955279266ce0f9238a
Signed-off-by: Ohad Basan <obasan(a)redhat.com>
---
M packaging/fedora/setup/engine-setup.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9813
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib61bccf586de803f24784b955279266ce0f9238a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
12 years
Change in ovirt-engine[master]: packaging: upgrade: support engine yum group
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: upgrade: support engine yum group
......................................................................
packaging: upgrade: support engine yum group
Change-Id: Iafbd1aac08925f4476fa83427a35070a4e29fe34
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/engine-upgrade.py
2 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafbd1aac08925f4476fa83427a35070a4e29fe34
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years
Change in ovirt-engine[master]: packaging: upgrade: rewrite rollbackAvailable
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: upgrade: rewrite rollbackAvailable
......................................................................
packaging: upgrade: rewrite rollbackAvailable
So far the query of local cache was for any package of this name.
Query the local for specific versions for each package that is marked as
'installed' in transaction.
This will have more chance to avoid rollback errors.
Change-Id: Ia9fff6270cd26f8ccbac1fcd07e38bb0b4397a09
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/fedora/setup/engine-upgrade.py
1 file changed, 7 insertions(+), 38 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10310
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9fff6270cd26f8ccbac1fcd07e38bb0b4397a09
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years
Change in ovirt-engine[master]: packaging: upgrade: print yum transaction details
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: upgrade: print yum transaction details
......................................................................
packaging: upgrade: print yum transaction details
Change-Id: I3fb61734f054637e05f4e2658f7b918f057547a6
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/fedora/setup/engine-upgrade.py
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10309
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fb61734f054637e05f4e2658f7b918f057547a6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years
Change in ovirt-engine[master]: packaging: sync miniyum implementation with recent otopi
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: sync miniyum implementation with recent otopi
......................................................................
packaging: sync miniyum implementation with recent otopi
Change-Id: I232c2c6d477aec5aa1fc5a764b49f153dc61e648
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/fedora/setup/common_utils.py
M packaging/fedora/setup/miniyum.py
2 files changed, 470 insertions(+), 295 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10308
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I232c2c6d477aec5aa1fc5a764b49f153dc61e648
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years