Change in ovirt-engine[master]: core : Master reconstruct leads to inconsistent state (#800...
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core : Master reconstruct leads to inconsistent state (#800839)
......................................................................
core : Master reconstruct leads to inconsistent state (#800839)
https://bugzilla.redhat.com/800839
The problem was by my opinion it is a transaction which was opened during all process of
SPM election, my solution is use transaction only when we finished with SPM election
Change-Id: I93b1e8931fc68b1233dd562a3776ca29494d5976
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4862
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93b1e8931fc68b1233dd562a3776ca29494d5976
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: USB Support
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: USB Support
......................................................................
webadmin: USB Support
Create/Edit VM dialog -> Console -> USB Support changed
according to:
http://www.ovirt.org/wiki/Features/SPICERelatedFeatures#GUI
Change-Id: I15208fadf9a84dfe55b3b896ed44c37ac3f3c7fc
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
4 files changed, 91 insertions(+), 19 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5067
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15208fadf9a84dfe55b3b896ed44c37ac3f3c7fc
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Inconsistent and confusing storage domain statuses (#8...
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Inconsistent and confusing storage domain statuses (#829275)
......................................................................
core: Inconsistent and confusing storage domain statuses (#829275)
https://bugzilla.redhat.com/829275
The following patch will solve a problem of switch storage domain status from Maintaice to Inactive.
The Maintaince status is not known for host, it is only for engine use, at that case a storage domain
status at host side is InActive.
At such case engine will not update status of domain
Change-Id: I94b0d505cd7deed0c19317f2d915c0629e147d99
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Michael Kublin: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5130
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I94b0d505cd7deed0c19317f2d915c0629e147d99
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: UnPowerMock RemoveQuotaCommandTest
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: UnPowerMock RemoveQuotaCommandTest
......................................................................
core: UnPowerMock RemoveQuotaCommandTest
Removed PowerMock dependency and replaced it with spying the command.
Change-Id: I14e2b059eb526c939a098a1b151bb3bdb65cad20
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveQuotaCommandTest.java
1 file changed, 5 insertions(+), 21 deletions(-)
Approvals:
Michael Kublin: Looks good to me, approved
Allon Mureinik: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5003
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14e2b059eb526c939a098a1b151bb3bdb65cad20
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: UnPowerMock UpdateVdsGroupCommandTest
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: UnPowerMock UpdateVdsGroupCommandTest
......................................................................
core: UnPowerMock UpdateVdsGroupCommandTest
Removed PowerMock dependency from UpdateVdsGroupCommandTest and replaced
it with spying the command and using MockConfigRule.
In order to achieve this improvement, some refactoring was done to
UpdateVdsGroupCommand where some DAO access methods and
CpuFlagsManagerHandler methods were wrapped and extracted.
Change-Id: I94f8ea93cc9af7c93660d905cbb888f23b33c3c4
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java
2 files changed, 126 insertions(+), 137 deletions(-)
Approvals:
Michael Kublin: Looks good to me, approved
Allon Mureinik: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4938
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I94f8ea93cc9af7c93660d905cbb888f23b33c3c4
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: UnPowerMock validator tests
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: UnPowerMock validator tests
......................................................................
core: UnPowerMock validator tests
Removed PowerMock dependency from the validator tests.
Mocking configuration was done directly, since ConfigMockRule is part of
the utils package, and not the common package.
Change-Id: I770362f4f64c89ad27ddcf266d6526b690faf9c2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MTUValidatorTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java
2 files changed, 18 insertions(+), 39 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
Allon Mureinik: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4937
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I770362f4f64c89ad27ddcf266d6526b690faf9c2
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Remove BaseMockitoTest
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Remove BaseMockitoTest
......................................................................
core: Remove BaseMockitoTest
Removed BaseMockitoTest which is no longer in use, and add PowerMock
dependecies to the project.
This class contianed utilities for PowerMocking various components of
commands, and is no longer required.
Change-Id: I5033c4d19b585f29c07de7911bf20dd37b4b55bc
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BaseMockitoTest.java
1 file changed, 0 insertions(+), 58 deletions(-)
Approvals:
Michael Kublin: Looks good to me, approved
Allon Mureinik: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4931
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5033c4d19b585f29c07de7911bf20dd37b4b55bc
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: UnPowerMock GetoVirtISOsTest
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: UnPowerMock GetoVirtISOsTest
......................................................................
core: UnPowerMock GetoVirtISOsTest
Removed PowerMock dependency from GetoVirtISOsTest and replaced it with
spying the query and using the new MockConfigRule.
In order to achieve this improvment, a slight refactoring to
GetoVirtISOsQuery was required so it will address the Config with lazy
getters instead of storing the config values upon class loading.
A test was added to assure that changing the functionality to lazy
getters does not break the class' behavior.
Change-Id: I3935138a255a5e91750543b35105e88d0e517084
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetoVirtISOsTest.java
2 files changed, 72 insertions(+), 48 deletions(-)
Approvals:
Michael Kublin: Looks good to me, approved
Allon Mureinik: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4930
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3935138a255a5e91750543b35105e88d0e517084
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: UnPowerMock RemoveAdGroupCommandTest
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: UnPowerMock RemoveAdGroupCommandTest
......................................................................
core: UnPowerMock RemoveAdGroupCommandTest
Removed PowerMock dependency from RemoveAdGroupCommandTest, and replaced
it with spying the command's relevant method.
In order to achieve this improvement a small refactoring was required in
RemoveAdGroupCommand.
CanRemoveAdGroup was turned into a private instance method (instead of a
static public one), and isLastSuperUserGroup was extracted so the
MultiLevelAdministrationHandler dependecy could be mocked away.
Change-Id: Icf5d7eb0e15c92a43b88f7705754ca8238a48d97
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAdGroupCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveAdGroupCommandTest.java
2 files changed, 34 insertions(+), 94 deletions(-)
Approvals:
Michael Kublin: Looks good to me, approved
Allon Mureinik: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4932
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf5d7eb0e15c92a43b88f7705754ca8238a48d97
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: UnPowerMock BackendTest
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: UnPowerMock BackendTest
......................................................................
core: UnPowerMock BackendTest
Removed PowerMock dependency from BackendTests, and replaced it with
spying a protcted method.
In order to achieve this improvement, the createQuery protected method
was extracted in the Backend class.
Change-Id: Iea0d953c9d999f096826583ec237b38d20edeca2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackendTest.java
2 files changed, 19 insertions(+), 28 deletions(-)
Approvals:
Michael Kublin: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/4936
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea0d953c9d999f096826583ec237b38d20edeca2
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months