Change in ovirt-engine[master]: webadmin: oVirt Modes - host action, dialog changes
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: oVirt Modes - host action, dialog changes
......................................................................
webadmin: oVirt Modes - host action, dialog changes
The following changes are done in GlusterOnlyMode.
1.Power Management in Host dialog, host general tab and action
will be hidden.
2.Confgiure Local Storage action is hidden
3.Host hooks sub tab is hidden
Change-Id: Ic7fd453269a91fc4a7146ae6cc00bdab313c9cfe
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHooksListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java
5 files changed, 53 insertions(+), 23 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4964
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7fd453269a91fc4a7146ae6cc00bdab313c9cfe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: userportal, webadmin: Element ID improvements
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal,webadmin: Element ID improvements
......................................................................
userportal,webadmin: Element ID improvements
Changes in 'gwt-common' module:
- BaseRefreshPanel now supports HasElementId contract:
refresh button has its element ID set according to
standard table ID convention, for example:
"SomeView_table_refreshPanel_refreshButton"
- AbstractSubTabTreeWidgetView's actionPanel now supports
element IDs, this affects VM Snapshot sub-tab in both
UserPortal and WebAdmin
Changes in 'userportal-gwtp' module:
- added element ID to connectAutomatically checkbox
(LoginPopupView)
- added element IDs to header links
-> logout, guide, about
- Extended main tab:
-> VM and Templates tab: added element IDs to all main
tab and sub tab tables, and VM Monitor sub tab
-> Resource tab: added element IDs to labels
- Basic main tab:
-> added element IDs to details panel widgets
Changes in 'webadmin' module:
- added element IDs to header links
-> logout, configure, guide, about
Change-Id: I96afff69eff17f653ec1184782ff4bc1debb545e
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractSubTabTreeWidgetView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/AbstractSideTabWithDetailsView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/HeaderView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.ui.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedTemplateView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/vm/SubTabExtendedVmMonitorView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/PercentageProgressBar.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/DiskImageWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/DisksImageWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java
16 files changed, 340 insertions(+), 221 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4697
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96afff69eff17f653ec1184782ff4bc1debb545e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: Setup Host Networks dialog fixes (#811605)
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Setup Host Networks dialog fixes (#811605)
......................................................................
webadmin: Setup Host Networks dialog fixes (#811605)
https://bugzilla.redhat.com/811605
1. Bonding two NICs (NetworkOperation.BOND_WITH) no longer causes
logical network(s) assigned to bonded NICs to disappear from
the dialog
Before NICs are bonded, logical network(s) assigned to them
are first detached (unassigned). After bonding, these networks
will be present as "Unassigned Logical Networks" in the
right-hand side of the dialog.
This behavior (detaching networks from NICs before bonding)
is consistent with "add NIC to bond" dialog operation
(NetworkOperation.ADD_TO_BOND).
2. Fixed a typo in unassigned network group label
3. Removed some redundant/unnecessary methods
Change-Id: Ibd21a9dda5eca8bb954d30be28eec5cfa8cbc203
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java
4 files changed, 8 insertions(+), 18 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4757
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd21a9dda5eca8bb954d30be28eec5cfa8cbc203
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Java 7: Fix use of namespaces in StAX writer
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: Java 7: Fix use of namespaces in StAX writer
......................................................................
core: Java 7: Fix use of namespaces in StAX writer
The way we currently use namespaces in the StAX writer for OVF
files doesn't work with Java 7. When trying to write attributes
without a namespace the following exception is generated:
java.lang.RuntimeException: Failed to write attribute
at org.ovirt.engine.core.compat.backendcompat.XmlTextWriter.WriteAttributeString(XmlTextWriter.java:44)
at org.ovirt.engine.core.utils.ovf.OvfWriter.WriteHeader(OvfWriter.java:49)
at org.ovirt.engine.core.utils.ovf.OvfWriter.<init>(OvfWriter.java:40)
at org.ovirt.engine.core.utils.ovf.OvfVmWriter.<init>(OvfVmWriter.java:26)
at org.ovirt.engine.core.utils.ovf.OvfManager.ExportVm(OvfManager.java:24)
Caused by: javax.xml.stream.XMLStreamException: NamespaceURI cannot be null
at com.sun.xml.internal.stream.writers.XMLStreamWriterImpl.writeAttribute(XMLStreamWriterImpl.java:611)
at org.ovirt.engine.core.compat.backendcompat.XmlTextWriter.WriteAttributeString(XmlTextWriter.java:42)
This patch changes the OVF writers so that the always provide the
namespaces explicitly.
Change-Id: I144bab6daee284b424805c1c56d53d385f80b8ee
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/IOvfBuilder.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
5 files changed, 200 insertions(+), 171 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4540
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I144bab6daee284b424805c1c56d53d385f80b8ee
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years, 7 months
Change in ovirt-iso-uploader[master]: tools: Do not print usage on errors (#813317)
by kroberts＠redhat.com
Keith Robertson has submitted this change and it was merged.
Change subject: tools: Do not print usage on errors (#813317)
......................................................................
tools: Do not print usage on errors (#813317)
https://bugzilla.redhat.com/813317
Don't pring usage on every error.
Change-Id: I96f3a930234886b637cfd3064a6e5f227e0aa099
Signed-off-by: Keith Robertson <kroberts(a)redhat.com>
---
M src/engine-iso-uploader.py
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Ofer Schreiber: Looks good to me, approved
Keith Robertson: Verified
--
To view, visit http://gerrit.ovirt.org/4923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96f3a930234886b637cfd3064a6e5f227e0aa099
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 7 months
Change in ovirt-log-collector[master]: tools: Collect logs in non-standard setups (BZ767797)
by kroberts＠redhat.com
Keith Robertson has submitted this change and it was merged.
Change subject: tools: Collect logs in non-standard setups (BZ767797)
......................................................................
tools: Collect logs in non-standard setups (BZ767797)
https://bugzilla.redhat.com/767797
Occasionally, a customer will place logs in non-standard locations.
SoS can usually figure this out; however, it doesn't do it by default.
To enable this behavior you need to supply -k general.all_logs=True.
In an effort to get all logs from the system on the first pass
we will enable this behavior in SoS by default.
Change-Id: Iab8f529787125b69544fbf8ae30ef04236973473
Signed-off-by: Keith Robertson <kroberts(a)redhat.com>
---
M src/rhev/logcollector.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Ofer Schreiber: Looks good to me, approved
Keith Robertson: Verified
--
To view, visit http://gerrit.ovirt.org/4922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab8f529787125b69544fbf8ae30ef04236973473
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: packaging: Remove components.war
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: packaging: Remove components.war
......................................................................
packaging: Remove components.war
These web application existed only to hold copies of the scripts
contained in the vdsm-bootstrap packages. Those files are copied
by one of the postinstallation scripts of the engine packages.
This patch removes that application and replaces it with a servlet
in the root web application that reads the scripts from their
original locations.
This also opens interesting possibilities, as that servlet could
be smarter (in the future) and return different versions of the
bootstrap scripts to different versions of hypervisors, or lookup
the files in diferent places.
Change-Id: I07601d8ac1e2c594c1e4098907eedba632b583e2
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
M ear/pom.xml
D frontend/wars/components-war/pom.xml
D frontend/wars/components-war/src/main/webapp/WEB-INF/context.xml
D frontend/wars/components-war/src/main/webapp/WEB-INF/index.html
D frontend/wars/components-war/src/main/webapp/WEB-INF/web.xml
D frontend/wars/components-war/src/main/webapp/index.html
M frontend/wars/pom.xml
M packaging/fedora/spec/ovirt-engine.spec.in
9 files changed, 54 insertions(+), 131 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4555
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07601d8ac1e2c594c1e4098907eedba632b583e2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: [CpuPinning] db support for cpu_pinning
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: [CpuPinning] db support for cpu_pinning
......................................................................
core: [CpuPinning] db support for cpu_pinning
- added column to vm_static
- stored procedures
- views
- DAO (VmDAO and VmStaticDAO)
- entities
http://www.ovirt.org/wiki/Features/Design/cpu-pinning
Change-Id: I8f252a4ab54d6e706aee490e759a766cffd69e61
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/dbscripts/create_views.sql
A backend/manager/dbscripts/upgrade/03_01_1160_add_cpu_pinning.sql
M backend/manager/dbscripts/vms_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java
8 files changed, 44 insertions(+), 12 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4595
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f252a4ab54d6e706aee490e759a766cffd69e61
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: [CpuPinning] cleanup VmStaticDAODbFacadeImpl
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: [CpuPinning] cleanup VmStaticDAODbFacadeImpl
......................................................................
core: [CpuPinning] cleanup VmStaticDAODbFacadeImpl
A short cleanup before really doing something.
http://www.ovirt.org/wiki/Features/Design/cpu-pinning
Change-Id: I8fc51d31609cd606e9d5969f4d4d3d462dfcd3d5
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java
1 file changed, 28 insertions(+), 80 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4594
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fc51d31609cd606e9d5969f4d4d3d462dfcd3d5
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months