Change in ovirt-engine[master]: core: Refactoring - start using diskId instead of imageId fo...
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Refactoring - start using diskId instead of imageId for msd feature
......................................................................
core: Refactoring - start using diskId instead of imageId for msd feature
The following change is done in order to use a diskId for multiple storage domain feature, instead
of imageId.
The change is done at rest, web clients and engine part.
Take attention: ImportVmtemplateCommand contains also a bug fixes, multiple storage domains scenario did not
work at all, including compenstaion part
Change-Id: I7bd10c634dbf06c48aa3dca1fa9cd66882623407
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java
17 files changed, 66 insertions(+), 68 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4893
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bd10c634dbf06c48aa3dca1fa9cd66882623407
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: remove obselete scripts (#819806)
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: remove obselete scripts (#819806)
......................................................................
core: remove obselete scripts (#819806)
Removing scripts which are no longer
needed by installer or tools
https://bugzilla.redhat.com/819806
Change-Id: I728836d77e9b00cbff24274a7f788ecdad0d48b2
Acked-By: Roy Golan <rgolan(a)redhat.com>
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
D backend/manager/conf/kerberos/kerberos-util.sh
D backend/manager/conf/kerberos/kerberosInstaller.sh
D backend/manager/conf/kerberos/kerberosUpdater.sh
3 files changed, 0 insertions(+), 178 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4569
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I728836d77e9b00cbff24274a7f788ecdad0d48b2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core : Last patch for removing internal_drive_mappings
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core : Last patch for removing internal_drive_mappings
......................................................................
core : Last patch for removing internal_drive_mappings
The following patch is removing a usage of internal_drive_mappings at the ovirt.
There were couple of commands which were based on internal_drive_mapping, but actually not in use any more.
The following commands, queries were removed
Change-Id: I11e51e457124ba1e5ea33ffe81b8ea32758530f7
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/dbscripts/create_dwh_views.sql
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromImportCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImagesFromImportCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddTemplateImagesFromImportCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromImportCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllImportCandidatesInfoQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmSnapshotsByDriveQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCandidateInfoQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImportCandidatesBase.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImportCandidatesInfoQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImportCandidatesQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllVmSnapshotsByDriveQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUserVmsByUserIdAndGroupsQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/BasicTestSetup.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddImageFromImportParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddImagesFromImportParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVMFromImportCandidateParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateFromImportParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IImage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ImagesComparerByName.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/CandidateInfoParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllImportCandidatesQueryParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllVmSnapshotsByDriveParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImportCandidatesQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetCandidateInfoVDSCommandParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetImportCandidatesVDSCommandParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ImportCandidateVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByDiskAliasComparator.java
D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByDriveMappingComparator.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractBaseDiskRowMapper.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDAOTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetCandidateInfoVDSCommand.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImportCandidateBase.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImportCandidatesInfoVDSCommand.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImportCandidatesVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ImportCandidateInfoReturnForXmlRpc.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ImportCandidateVDSCommand.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ImportCandidatesInfoReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsVMListReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateDiskListModelTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/SnapshotsTree.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/DataProvider.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/Linq.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/userportal/UserVmModel.java
D frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/GetAllVmSnapshotsExecutor.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/VmDiskListModel.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/VmImportDiskListModel.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/VmModel.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/VmSnapshotListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/GetAllVmSnapshotsExecutor.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/DiskImageWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportTemplatePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java
92 files changed, 87 insertions(+), 2,312 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4847
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I11e51e457124ba1e5ea33ffe81b8ea32758530f7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core : Removing internal_drive_mappings - db scripts
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core : Removing internal_drive_mappings - db scripts
......................................................................
core : Removing internal_drive_mappings - db scripts
The following patch is a db scripts part for removing internal_drive_mappings.
It provides a needed changes for views, tables and stored procedures
Change-Id: Ic58f01e4d346cd85f05ae915acd1c142a86a3301
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/dbscripts/base_disks_sp.sql
M backend/manager/dbscripts/create_views.sql
A backend/manager/dbscripts/upgrade/03_01_1170_remove_internal_drive_mapping_column.sql
3 files changed, 6 insertions(+), 11 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4846
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic58f01e4d346cd85f05ae915acd1c142a86a3301
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core : Removing of using internal drive mapping at all vm sc...
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core : Removing of using internal drive mapping at all vm scenarious
......................................................................
core : Removing of using internal drive mapping at all vm scenarious
The following patch will remove a using of internal drive mapping at all related
vm scenarious.
The clean up includes:
1. Removing passing of pararmeters for internal drive mapping at import, export vm scenarious
2. Removing a mapping of internal drive mapping to disk at Vm.getDiskMap() method
A clean up done at engine part and frontent part
Change-Id: Ic36b97bdfe4fe00ecdf508933f025c657217b31a
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsFromExportDomainQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUserVmsByUserIdAndGroupsQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/storage/VmBackupModel.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/ImportVmModel.java
M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/vms/VmImportDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
21 files changed, 65 insertions(+), 110 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4506
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic36b97bdfe4fe00ecdf508933f025c657217b31a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core : Start to remove internal drive mapping
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core : Start to remove internal drive mapping
......................................................................
core : Start to remove internal drive mapping
THe follwoing patch is a beginning of the remove of internal drive mapping property,
as first stage a clean up was done at AbstractDiskVmCommand.
The clean up at AbstractDiskVmCommand will also fix a bug, which will not allow to attach a shared disk to vm.
Also a clean up contains a removing of un needed pass of parameters at different images flows
Change-Id: I020b25f04820b6cbef60764ae8169050bcbdc5bc
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesContainterParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyImageGroupParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveImageParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RestoreFromSnapshotParameters.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
19 files changed, 13 insertions(+), 117 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4358
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I020b25f04820b6cbef60764ae8169050bcbdc5bc
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Fix vNIC validations (#756437)
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Fix vNIC validations (#756437)
......................................................................
core: Fix vNIC validations (#756437)
https://bugzilla.redhat.com/756437
Fixed following issues:
1. Check interface name only when creating or updating.
2. Error message for null name fixed.
3. Template vNIC has no MAC so no validations needed.
4. MAC validation for VM vNIC:
4.1. When creating, need to allow empty or null since in this case
it will be assigned from the MAC pool.
4.2. When updating, empty or null MAC is not allowed.
Notice that @Pattern validation consides null as valid, so only
@NotNull needed special treatment to discern VM vNIC from Template vNIC
update.
Change-Id: Iacec6a2cc4b12c115eb016754246f8ae0d4a0996
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterface.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/group/UpdateVmNic.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterfaceValidationTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 135 insertions(+), 27 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4977
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iacec6a2cc4b12c115eb016754246f8ae0d4a0996
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: Alerts footer and Search Bar adjustments
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Alerts footer and Search Bar adjustments
......................................................................
webadmin: Alerts footer and Search Bar adjustments
* Fixed search bar layout when a system tree item is selected.
* Fixed alerts/events footer broken layout when using Chrome.
Change-Id: I67323f008f5ce41a073c877e7c7d34f6901a6090
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/SearchPanelView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.ui.xml
3 files changed, 13 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4961
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67323f008f5ce41a073c877e7c7d34f6901a6090
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core : Removing AsyncQuery mechanism
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core : Removing AsyncQuery mechanism
......................................................................
core : Removing AsyncQuery mechanism
The AsyncQuery mechanism was introduced for compatability with wpf client.
The gwt client is not required such mechanism, becuase there are no any client
which is required such mechanism , the AsyncQuery mechanism will be removed.
All related code is removed
Change-Id: I3734abc8a99ebcfdd8e8c8ea8c6b3a674a139f10
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BackendCallBacksDirector.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CallBackData.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CallbackServer.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUserVmByUserIdAndByVmGuidQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ListIQueryableQueryData.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterQueryQuery.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchData.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SingleIQueryableQueryData.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UnregisterQueryQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ClientHandshakeSequenceTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdcQueryable.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/IBackendCallBackServer.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AsyncQueryResults.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/CanUpdateFieldGenericParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/CandidateInfoParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAdGroupByIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllImagesListParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllImportCandidatesQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllVmSnapshotsByDriveParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllVmSnapshotsByVmIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetBookmarkByIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetBookmarkByNameParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetConfigurationValueParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDbUserByUserIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImportCandidatesQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetNewVdsFenceStatusParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetPowerClientByClientInfoParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetResourceUsageParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStorageDomainsByConnectionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetSystemStatisticsQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagByTagIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagByTagNameParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagByTagNameParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagUserGroupMapByTagNameParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagUserMapByTagNameParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagVdsMapByTagNameParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagVmMapByTagNameParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagsByUserGroupIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagsByUserIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagsByVdsIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetTagsByVmIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUserMessageParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUserVmByUserIdAndByVmGuidParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsByVdsIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsGroupByIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsGroupByNameParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsGroupByVdsGroupIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmByVmIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmPoolByIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmPoolsMapByVmPoolIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/HasFreeVmsInPoolParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IRegisterQueryUpdatedData.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsStoragePoolWithSameNameExistParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsGroupWithSameNameExistParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsWithSameHostExistParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsWithSameIpExistsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsWithSameNameExistParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVmPoolWithSameNameExistsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVmTemlateWithSameNameExistParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVmWithSameNameExistParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ListIVdcQueryableUpdatedData.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ListIVdcQueryableUpdatedDataValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/MultilevelAdministrationsQueriesParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/RegisterQueryParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/RegisterableQueryReturnDataType.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/RegisterableQueryTypes.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageDomainAndPoolQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageDomainQueryParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StoragePoolQueryParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageServerConnectionQueryParametersBase.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/UnregisterQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VGQueryParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/CompatIllegalArgumentException.java
M frontend/api/genericapi/src/main/java/org/ovirt/engine/ui/genericapi/GenericApiService.java
81 files changed, 4 insertions(+), 1,526 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4912
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3734abc8a99ebcfdd8e8c8ea8c6b3a674a139f10
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: Create Volume - filter cluster, hosts (#826452)
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Create Volume - filter cluster, hosts (#826452)
......................................................................
webadmin: Create Volume - filter cluster, hosts (#826452)
https://bugzilla.redhat.com/826452
https://bugzilla.redhat.com/824389
This fixes the following issues.
1.Create Volume dialog shows clusters that aren't Gluster-enabled
2.Add Bricks dialog shows unavailable hosts
Change-Id: I7c8d7df17f98403b016579cace536c043b750317
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
2 files changed, 29 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4971
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c8d7df17f98403b016579cace536c043b750317
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months