July 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: DirectorySearcherTest: reduce timeouts

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: DirectorySearcherTest: reduce timeouts ...................................................................... core: DirectorySearcherTest: reduce timeouts DirectorySearcherTests mocks an LDAP query's timeout to test how we react to that behavior. There is no difference between mocking a 20 second timeout and a 1 second timeout, so we might as well speed up the test. Change-Id: I53ad69c8bb02058f4f90e2123a90c24331523719 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53ad69c8bb02058f4f90e2123a90c24331523719 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: Added service name parameter to checking Jboss st...

by oschreib＠redhat.com

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Added service name parameter to checking Jboss status ...................................................................... packaging: Added service name parameter to checking Jboss status Change-Id: I72c33b3c334775686c4761c5ceb9e7134afc0ee4 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72c33b3c334775686c4761c5ceb9e7134afc0ee4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Host does not move to non-operational (#822451)

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Host does not move to non-operational (#822451) ...................................................................... core: Host does not move to non-operational (#822451) https://bugzilla.redhat.com/822451 If an interface of required network (by cluster) is reported from VDSM as 'down', the host should move to non-operational. The patch modifies a problem of overriding broken status with a correct one, and loop for all of the interfaces to collect more information about additional problematic networks and interfaces. Change-Id: I8911ed41e2f9e01451c58b70b0679c6c606ea759 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 10 insertions(+), 16 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8911ed41e2f9e01451c58b70b0679c6c606ea759 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: STP is not being set via SetupNetworks (#839543)

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: STP is not being set via SetupNetworks (#839543) ...................................................................... core: STP is not being set via SetupNetworks (#839543) https://bugzilla.redhat.com/839543 The setupNetworks command doesn't pass the provided STP value to VDSM, therefore it does not appear on the interfaces scripts. The patch adds the STP value provided by the clients to the parameters being sent to VDSM. Change-Id: I3c50713b78477dfa33388b7fd96f6e2d81076bfe Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/6558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c50713b78477dfa33388b7fd96f6e2d81076bfe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core, webadmin: Support diskless snapshots

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core, webadmin: Support diskless snapshots ...................................................................... core, webadmin: Support diskless snapshots This patch removes the restriction on a diskless VM, in order to align the behavior with the current partial behavior - currently, you can create a VM with a single disk, take a snapshot, and then remove the disk from all the snapshots, leaving the snapshot diskless. In the backend: The code that finalizes the preview was extracted into a method, which is now called from two places: * If the snapshot has disks, it's called from EndSuccessfully(), after all the disks have been previewed. This is not a behavior change - the code that was there was simply extracted to a method. * If the snapshot does not have any disks, it's called at the end of the ExecuteVmCommand, since there are no async tasks that we're waiting for. In the frontend: * The restriction on taking a snapshot of a diskless VM was removed. Change-Id: I0193a7f4ba0e25ddeaacdf25b6a746d5ce50d698 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 2 files changed, 27 insertions(+), 47 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0193a7f4ba0e25ddeaacdf25b6a746d5ce50d698 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core:pre upgrade scripts will not run ...(#842119)

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core:pre upgrade scripts will not run ...(#842119) ...................................................................... core:pre upgrade scripts will not run ...(#842119) pre upgrade scripts will not run correctly upon 3.0 DB restore https://bugzilla.redhat.com/show_bug.cgi?id=842119 Restore a 3.0 database and running the 3.1 upgrade scripts on it is not working. This patch fixes this problem by : 1) force pre-upgrade scripts to run if any upgrade file is about to run , this will be done even if no change was detected in views, sp & upgrade files as it may occur when the database is restored. 2) make pre-upgrade and post upgrade scripts ordered since the configuration settings and some fixes in the custom sql file must run first. This is done by prefixing the script name with a 4 digit number. (0000 00010 00020 etc.) Change-Id: Ie23fba63cee81c5a5b3f1ad4076d627a06614fc0 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh R backend/manager/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql R backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql R backend/manager/dbscripts/upgrade/pre_upgrade/0010_custom.sql R backend/manager/dbscripts/upgrade/pre_upgrade/0020_add_comment_col_to_schema_version.sql 5 files changed, 9 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie23fba63cee81c5a5b3f1ad4076d627a06614fc0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Allow remove snapshot w/o disks (#825809)

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Allow remove snapshot w/o disks (#825809) ...................................................................... core: Allow remove snapshot w/o disks (#825809) https://bugzilla.redhat.com/825809 Some of the canDoAction validations in RemoveSnapshotCommand implicitly assume that the snapshot contains disks. This patch ignores these validations in case the snapshot does not contain any disks, since they are not valid. Change-Id: Ie65a93e75419b8b63e6c7e46fd9137f3db7684c4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java 2 files changed, 121 insertions(+), 18 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie65a93e75419b8b63e6c7e46fd9137f3db7684c4 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Prepare RemoveSnapshotCommand for testing

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Prepare RemoveSnapshotCommand for testing ...................................................................... core: Prepare RemoveSnapshotCommand for testing Replaced singleton calls with protected accessors, which can later be spied in the test. Change-Id: I3e935b4324bba1b0cd2b501bfcd8738f1302cea1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 3 files changed, 63 insertions(+), 42 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e935b4324bba1b0cd2b501bfcd8738f1302cea1 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Remove disk from snapshots (#828192)

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove disk from snapshots (#828192) ...................................................................... core: Remove disk from snapshots (#828192) https://bugzilla.redhat.com/828192 When a disk is removed all its snapshots are removed. However, they are not removed from the snapshot's configuration - instead, they are marked as ILLEGAL (upon reading!). Unfortunately, many flows disregard illegal snapshot disks (e.g., BZ 828192), which leads to a bunch of broken flows. This patch proposes a different approach - since the disk is removed entirely, with its snapshots, it should also be removed from the snapshots' configuration, as if it never existed. Change-Id: I97dedb9b8e8cd4dd0cae6c7b01d4b5678ba0a2d0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveImageCommandTest.java 2 files changed, 225 insertions(+), 28 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97dedb9b8e8cd4dd0cae6c7b01d4b5678ba0a2d0 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: RemoveImageCommand: clean up logging

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: RemoveImageCommand: clean up logging ...................................................................... core: RemoveImageCommand: clean up logging Removed a redundant prefix in the log message in case an image cannot be removed. Change-Id: If918d86e0bcc8f24373d927b5ffcd8ca6d02e8b7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If918d86e0bcc8f24373d927b5ffcd8ca6d02e8b7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

12 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits July 2012