July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: filter storage format versions on new SD
by derez＠redhat.com 31 Jul '12

31 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: filter storage format versions on new SD ...................................................................... webadmin: filter storage format versions on new SD https://bugzilla.redhat.com/842656 https://bugzilla.redhat.com/840558 New/Import storage domain dialog, changes in 'UpdateFormat' logic: * DataCenter Unassigned (none) - NFS SDs: only V1/V3 should be available. - Block SDs: only V2/V3 should be available. - V3 as default * Export/ISO storage domains - only V1. * (removed redundant '//$NON-NLS-1$' comments) Change-Id: Ic4986e9aa12a14201adf9ac4d718d33eaaf4b8e7 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 18 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4986e9aa12a14201adf9ac4d718d33eaaf4b8e7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: add disk - external disk selection validation
by derez＠redhat.com 31 Jul '12

31 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: add disk - external disk selection validation ...................................................................... webadmin: add disk - external disk selection validation Add Disk dialog, added a validation for external disk selection. Change-Id: Ibbddebe246a3b8a0cc3ae38d4e103f70aef54a28 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbddebe246a3b8a0cc3ae38d4e103f70aef54a28 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: Send Storage-Domain type for update
by oliel＠redhat.com 31 Jul '12

31 Jul '12

Ori Liel has submitted this change and it was merged. Change subject: Send Storage-Domain type for update ...................................................................... Send Storage-Domain type for update Change-Id: I7e0f17a81d9bb32ae941cadd58e237d782b837d0 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e0f17a81d9bb32ae941cadd58e237d782b837d0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Can remove proxy for host but left entry at DB (#84430...
by mkublin＠redhat.com 31 Jul '12

31 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Can remove proxy for host but left entry at DB (#844306) ...................................................................... core: Can remove proxy for host but left entry at DB (#844306) https://bugzilla.redhat.com/844306 The problem described at bug is very rare and very difficult for reproduce but , it can cause for serous trouble at engine side The problem is following: 1. We are removing host 2. The removing of host and removing its proxy done inside same transaction 3. Transaction was rollbacked due to some error 4. Entry at dabase left, proxy was removed Result: we have an orphan entry of host at DB which we can not remove, activate , etc. Our process can try to choose that entry as SPM or try to activate via Auto recovery, it is obvious that we will not success. Solution: Diasable global transaction, perform removefrom DB at separete transaction if it fails, the proxy will left, if it success the proxy will be removed. Change-Id: I79610be56eab28a74627db66846d41702b9a440d Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java 1 file changed, 18 insertions(+), 4 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79610be56eab28a74627db66846d41702b9a440d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: backend: Error message for VM remove when host non operation...
by ofrenkel＠redhat.com 31 Jul '12

31 Jul '12

Omer Frenkel has submitted this change and it was merged. Change subject: backend: Error message for VM remove when host non operational isn't informative enough (#836263) ...................................................................... backend: Error message for VM remove when host non operational isn't informative enough (#836263) https://bugzilla.redhat.com/836263 This patch adds a test for the validity of the DC when trying to remove a VM without disks. Change-Id: I780dc8f5999e8a297d61742535df5d40e626fb25 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/6786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I780dc8f5999e8a297d61742535df5d40e626fb25 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Wrong bootproto for non-bridged networks(#842986)
by masayag＠redhat.com 31 Jul '12

31 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Wrong bootproto for non-bridged networks(#842986) ...................................................................... core: Wrong bootproto for non-bridged networks(#842986) https://bugzilla.redhat.com/842986 The patch relies on getVdsCapabilities api change that reports the interface element for each network (instead only for bridgeless). The 3.1 and above hosts will use the interface property from network to resolve the underlying interface the network is defined on. Previous 3.1 hosts will use same method as before: resolve the interface by the ports elements reported for the bridged network. An audit log event will be created for bridged networks defined over multiple interface. Change-Id: Ie60ac43e27d90c8de2b434a506651360fedd6d9c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 7 files changed, 102 insertions(+), 32 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie60ac43e27d90c8de2b434a506651360fedd6d9c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Don't pass type when updating storage-domain
by oliel＠redhat.com 31 Jul '12

31 Jul '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Don't pass type when updating storage-domain ...................................................................... restapi: Don't pass type when updating storage-domain This patch solves a bug where if user supplied <type>data</type> to update of a storage-domain, the operation would fail even if the SD is already a data SD (meaning no update needs to be done Change-Id: I04beececba4b411c1ec28c77fa3e1e42505298d3 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04beececba4b411c1ec28c77fa3e1e42505298d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: disks tab - adding Attached To column
by derez＠redhat.com 31 Jul '12

31 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disks tab - adding Attached To column ...................................................................... webadmin: disks tab - adding Attached To column Adding 'Attached To' column (displays VMs/Templates names): * Disks main-tab * VMs -> disks sub-tab Change-Id: I247ea95c111e3e9fbb80dbd5e1dcd98d7d6a3b6e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskContainersCell.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskContainersColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 6 files changed, 122 insertions(+), 10 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I247ea95c111e3e9fbb80dbd5e1dcd98d7d6a3b6e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: DirectLUN - send getDeviceList on selection
by derez＠redhat.com 31 Jul '12

31 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: DirectLUN - send getDeviceList on selection ...................................................................... webadmin: DirectLUN - send getDeviceList on selection https://bugzilla.redhat.com/844168 Add Disk dialog - External Disk, send 'getDeviceList' on selection (DC/Host/StorageType). Change-Id: I8fee65bf60ba194c37d674d6b83503336563e11a Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/ProgressPopupContent.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiDiscoverTargetsView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiLunToTargetView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiTargetToLunView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanImportStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/VmDiskPopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDiskPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/vm/VmDiskPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDiskPopupView.java 19 files changed, 182 insertions(+), 120 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fee65bf60ba194c37d674d6b83503336563e11a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Small code improvements
by mkublin＠redhat.com 31 Jul '12

31 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Small code improvements ...................................................................... core: Small code improvements The code was written at correct way Change-Id: Id0e239cf2ce50e1cde9f4211c13ffa227c6211b0 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Michael Kublin: Verified -- To view, visit http://gerrit.ovirt.org/6782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0e239cf2ce50e1cde9f4211c13ffa227c6211b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0