Change in ovirt-engine[master]: webadmin: Set connectivity timeout of SetupNetworks in secon...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Set connectivity timeout of SetupNetworks in seconds
......................................................................
webadmin: Set connectivity timeout of SetupNetworks in seconds
The provided connectivity timeout for SetupNetworks is expected to be in
seconds. In addition, the connectivity timeout is set to 120 seconds.
Change-Id: I826905eb993a7669a838c228e9d7289f50cbc65f
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6081
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I826905eb993a7669a838c228e9d7289f50cbc65f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: restapi: UnPowerMock REST-API Types tests
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: restapi: UnPowerMock REST-API Types tests
......................................................................
restapi: UnPowerMock REST-API Types tests
Removed PowerMock from REST API Types tests in order to improve the
build performance. This improvement cuts down the build time by 50%-60%.
Since PowerMock was only used to mock the Config object, it could easily
be removed and replaced with the more modern MockConfigRule class.
A side effect of not using the PowerMockRunner anymore is that the
default JUnit runner is used, with forced changing all the tests'
constructors to public instead of protected.
Change-Id: I44d281c8f8c8568967ef657409d597f6b07bffe0
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/restapi/types/pom.xml
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/AbstractInvertibleMappingTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ClusterMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DataCenterMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostNicMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/LunDiskMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NetworkMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NicMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageDomainMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageVolumeGroupMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TagMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmPoolMapperTest.java
16 files changed, 97 insertions(+), 135 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6099
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44d281c8f8c8568967ef657409d597f6b07bffe0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: webadmin: allow multiple spice sessions description is too l...
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: allow multiple spice sessions description is too long(#834873)
......................................................................
webadmin: allow multiple spice sessions description is too long(#834873)
https://bugzilla.redhat.com/834873
In Edit VM dialog for the dektops, the Console tab contained
the checkbox "allow multiple spice sessions description is too long..."
which was too long.
Moved to Advanced Parameters section with label:
"Disable strict user checking".
This patch also contains the extraction of the logic behind
the Abstract Parameters expander button from NfsStorageView
to standalone reusable class AdvancedParametersExpander.
Change-Id: I5ee08f678ee285bf762612ba4676d258d9ddd2d5
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/AdvancedParametersExpander.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/AdvancedParametersExpander.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDesktopNewPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmServerNewPopupWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml
10 files changed, 132 insertions(+), 47 deletions(-)
Approvals:
Tomas Jelinek: Verified
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5903
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ee08f678ee285bf762612ba4676d258d9ddd2d5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: core: toString method for XmlRpcStruct
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: toString method for XmlRpcStruct
......................................................................
core: toString method for XmlRpcStruct
Adds a toString method to XmlRpcStruct in order to have some information
that makes sense in the logs rahter than the object ID in the logs.
Change-Id: I74bf7843bbfb19e4461859ef41c98661c34af23b
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcStruct.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6086
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74bf7843bbfb19e4461859ef41c98661c34af23b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: core: changing audit messages to contain UNKNOWN when no suc...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: changing audit messages to contain UNKNOWN when no such variable
......................................................................
core: changing audit messages to contain UNKNOWN when no such variable
This patch changes the audit messages to contain <UNKNOWN> instead of
the variable name, in case this variable cannot be resolved.
Change-Id: If5fcc0859ce037186f2aa08e08263a8ec650c4a2
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorTest.java
3 files changed, 28 insertions(+), 4 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6080
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5fcc0859ce037186f2aa08e08263a8ec650c4a2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: core: making all tag and bookmark operations non-monitored
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: making all tag and bookmark operations non-monitored
......................................................................
core: making all tag and bookmark operations non-monitored
This patch changes all the tag and bookmark related operations, and
makes them non-monitored (so that they would not appear in the tasks
tab).
Change-Id: I9ebb9e9fdef3c21eee02514b5c53270b3c494962
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
1 file changed, 13 insertions(+), 13 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6079
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ebb9e9fdef3c21eee02514b5c53270b3c494962
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: core: Fix disk messages and tasks description
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Fix disk messages and tasks description
......................................................................
core: Fix disk messages and tasks description
This patch:
1. Changes the disk-related messaged to use the DiskAlias
variable instead of the DiskName one, as the DiskName variable doesn't
exist.
2. Sets the diskalias variable for the tasks description.
3. Splits the AddDiskCommand audit log message in case adding a floating
disk - no VM information, when adding a disk to VM, put the VM
information in the message.
Change-Id: I63b62bac9a8ea9b19ae2c963ad23f0cd49668d9c
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
8 files changed, 86 insertions(+), 7 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63b62bac9a8ea9b19ae2c963ad23f0cd49668d9c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: core: expose the V3 domain format in dc 3.1
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: expose the V3 domain format in dc 3.1
......................................................................
core: expose the V3 domain format in dc 3.1
This patch introduces the new V3 format used for the Storage Domains
attached to a DC 3.1. A complete description can be found at:
http://www.ovirt.org/wiki/Storage_Domain_Versions
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
Change-Id: Ibafcb53007eb6e531f024cd054ff2673a7d431e1
---
M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageFormatType.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StorageFormat.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/model/StorageFormat.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageFormatMapper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
9 files changed, 36 insertions(+), 13 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibafcb53007eb6e531f024cd054ff2673a7d431e1
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
12 years, 5 months
Change in ovirt-engine[master]: core: Added validation for removal of LUN disk
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Added validation for removal of LUN disk
......................................................................
core: Added validation for removal of LUN disk
Since there was no validation for removal of LUN disk, it was possible
to remove a LUN disk which was plugged to a running VM
Change-Id: Ibf2cd6640fa05777bba72db489a94c7bd20d5eda
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
1 file changed, 17 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Michael Kublin: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf2cd6640fa05777bba72db489a94c7bd20d5eda
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
12 years, 5 months
Change in ovirt-engine-sdk[master]: add a new tool for auto-generate python entities from schema
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: add a new tool for auto-generate python entities from schema
......................................................................
add a new tool for auto-generate python entities from schema
It is troublesome to generate python entities by the current
code generation suites of ovirt-engine-sdk.
This new tool as extension of generateDS.py to simplify the
code generation.
All NOT_GENERATED codes are configurable in paramsconf.py
1. add import module
2. update a new function or attribute of a class
3. add a new attribute of a class
4. add a new function
5. gernerate _rootClassMap
Change-Id: I916f63f1ac68ce2e31456a90c1291997f671af99
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
---
M src/codegen/README
A src/codegen/genparams.py
M src/codegen/main.py
A src/codegen/paramsconf.py
4 files changed, 939 insertions(+), 15 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4880
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I916f63f1ac68ce2e31456a90c1291997f671af99
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Lei Li <lilei(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
12 years, 5 months