August 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: minor SearchObjectAutoCompleter cleanup
by lhornyak＠redhat.com 31 Aug '12

31 Aug '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: minor SearchObjectAutoCompleter cleanup ...................................................................... core: minor SearchObjectAutoCompleter cleanup simplifications and cleanups for findbugs warnings. Change-Id: I1f0395d9e7d12034ca1e849999a5b1dc48f7b0f5 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 2 files changed, 16 insertions(+), 19 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f0395d9e7d12034ca1e849999a5b1dc48f7b0f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: packaging: updated utility function for parsing web-conf.js
by juan.hernandez＠redhat.com 31 Aug '12

31 Aug '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: updated utility function for parsing web-conf.js ...................................................................... packaging: updated utility function for parsing web-conf.js Change-Id: Ic81a7a10d33a608fee3011ccdf462d7e74ecf52c Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/common_utils.py 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic81a7a10d33a608fee3011ccdf462d7e74ecf52c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: utils: support external host for VdsInstallerSSH tests
by dfediuck＠redhat.com 30 Aug '12

30 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: utils: support external host for VdsInstallerSSH tests ...................................................................... utils: support external host for VdsInstallerSSH tests Useful for problem determination using real sshd. Similar to low level SSH tests, only that it cannot receive custom key store. Change-Id: I007282dbb9404f0a0a898ae2443dccf9f0c0e404 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java 1 file changed, 50 insertions(+), 25 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I007282dbb9404f0a0a898ae2443dccf9f0c0e404 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: common: handle resources if path contains special characters
by dfediuck＠redhat.com 30 Aug '12

30 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: common: handle resources if path contains special characters ...................................................................... common: handle resources if path contains special characters ClassLoader.getResource() returns URL, URL.getPath() returns URI encoded string. Trying to use this string to access file will fail without decoding it first. Change-Id: Iff53340e6243b9e7c634ba00f30bac685b82ef80 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/generic/DomainsPasswordMapTest.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/PackageExplorer.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/ReflectionHelper.java M backend/manager/tools/engine-config/src/test/java/org/ovirt/engine/core/config/EngineConfigTest.java 4 files changed, 14 insertions(+), 8 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff53340e6243b9e7c634ba00f30bac685b82ef80 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Modify Vm names key in message (#824497)
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Modify Vm names key in message (#824497) ...................................................................... engine: Modify Vm names key in message (#824497) https://bugzilla.redhat.com/824497 The patch modifies the VM names key in error message so it could be utilized by the SetupNetwork commands for reporting a multiple entities. Change-Id: I01eaaf33a8becb77ab2378e7aa1df008ad399119 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkFromVdsInterfaceCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 7 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01eaaf33a8becb77ab2378e7aa1df008ad399119 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Deny removal of used network (#824497)
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Deny removal of used network (#824497) ...................................................................... engine: Deny removal of used network (#824497) https://bugzilla.redhat.com/824497 The patch denies removal of a network which is currently used by running VMs via SetupNetworks command. If the network is used, an appropriate error message will appear. Change-Id: Idbe45c13d0e86fd64096dd28d7df4381feeb075c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java 2 files changed, 21 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbe45c13d0e86fd64096dd28d7df4381feeb075c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Extracts method to find VMs using nets (#824497)
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extracts method to find VMs using nets (#824497) ...................................................................... engine: Extracts method to find VMs using nets (#824497) https://bugzilla.redhat.com/824497 The patch extracts a method which finds VMs that uses a given list of networks. The method will be used by SetupNetworks to enforce same validation. Change-Id: I07cfac66a34618772aaf87bafb01b870d4d38322 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkFromVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java 3 files changed, 88 insertions(+), 14 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07cfac66a34618772aaf87bafb01b870d4d38322 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "engine: Change iteration to foreach (#849971)"
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: Revert "engine: Change iteration to foreach (#849971)" ...................................................................... Revert "engine: Change iteration to foreach (#849971)" This reverts commit a11ea98b0ec411e8fdde6898a1ca02ebc40c13d2. Change-Id: Ia7f3648090329109838fd8f1dffd235579968b3e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7f3648090329109838fd8f1dffd235579968b3e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "core: Fix validation of Updating attached network"
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: Revert "core: Fix validation of Updating attached network" ...................................................................... Revert "core: Fix validation of Updating attached network" This reverts commit b06f11509e488f2888ed4044081f5041d00fa93e Change-Id: Ica21e3fa8f823cc750e35a494e0d0364ea7462c6 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java 1 file changed, 28 insertions(+), 24 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica21e3fa8f823cc750e35a494e0d0364ea7462c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "core: Cannot replace management network nic (#840888...
by masayag＠redhat.com 30 Aug '12

30 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: Revert "core: Cannot replace management network nic (#840888)" ...................................................................... Revert "core: Cannot replace management network nic (#840888)" This reverts commit e8590ce0e5a37df793873c7b0f9a51eb990d48d2. Change-Id: I3c15d815c4963dab9c58800a884734b3d1236ccd Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java 1 file changed, 8 insertions(+), 38 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c15d815c4963dab9c58800a884734b3d1236ccd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0