Change in ovirt-engine[master]: core: Remove deprecated StringHelper in UpdateStoragePoolCom...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Remove deprecated StringHelper in UpdateStoragePoolCommand.
......................................................................
core: Remove deprecated StringHelper in UpdateStoragePoolCommand.
Replaced StringHelper with StringUtils
Change-Id: I90eb8bc79a4e079fa2d3cfe79d3df0309084f504
Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7235
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90eb8bc79a4e079fa2d3cfe79d3df0309084f504
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months
Change in ovirt-engine[master]: core: Remove deprecated StringHelper in SetStoragePoolStatus...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Remove deprecated StringHelper in SetStoragePoolStatusCommand.
......................................................................
core: Remove deprecated StringHelper in SetStoragePoolStatusCommand.
Replaced StringHelper with StringUtils
Change-Id: I026582eeed637bcd44f3b8263885a00e6ec9662f
Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SetStoragePoolStatusCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7234
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I026582eeed637bcd44f3b8263885a00e6ec9662f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months
Change in ovirt-engine[master]: core: Remove deprecated StringHelper in GetNonOperationalVds...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Remove deprecated StringHelper in GetNonOperationalVdsQuery.
......................................................................
core: Remove deprecated StringHelper in GetNonOperationalVdsQuery.
Replaced StringHelper with StringUtils
Change-Id: I27dc9be766e6546b07e24810edf7358d4a49a3a3
Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNonOperationalVdsQuery.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7233
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I27dc9be766e6546b07e24810edf7358d4a49a3a3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months
Change in ovirt-engine[master]: pki: remove the need to store ssh public key
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: pki: remove the need to store ssh public key
......................................................................
pki: remove the need to store ssh public key
Add PKIResource servlet to retrieve public key based resource. It is
used to retrieve CA certificate or server SSH public key.
The input of PKIResource is X.509 certificate taken from CA store,
as a result the openssh public key is not needed any more.
Change-Id: I328baded92b2e7c5169bc87e7c19680f598389b9
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/conf/ca/installCA.sh
M backend/manager/conf/ca/installCA_dev.sh
M backend/manager/modules/root/pom.xml
A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/pki/PKIResourceServlet.java
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/engine-setup.py
7 files changed, 189 insertions(+), 28 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Doron Fediuck: Looks good to me, approved
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4853
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I328baded92b2e7c5169bc87e7c19680f598389b9
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months
Change in ovirt-engine[master]: bootstrap: send complete bootstrap from engine
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: bootstrap: send complete bootstrap from engine
......................................................................
bootstrap: send complete bootstrap from engine
CURRENT BEHAVIOR
vds_installer.py is part of ovirt-engine, upon bootstrap, the script is
sent to the node using ssh.
Then vds_installer.py pulls vds-bootstrap* files using HTTP from
engine.
The vds_installer.py and vds_bootstrap pulls ssh public key from engine
using HTTP.
NEW BEHAVIOR
vds_installer.py was moved into the vdsm-bootstrap and renamed to setup.
vdsm-bootstrap repository was updated to create directory per bootstrap
interface with 'setup' script.
ovirt-engine copies public key to node in similar way of firewall rules.
At bootstrap time, engine create tar archive from the bootstrap
directory, cache it and pipe the archive into node in order to extract
it and run the setup script.
No HTTP communication is needed.
No conflict with existing files.
CONFIGURATION
New: BootstrapCommand
Control which command is sent during bootstrap.
New: BootstrapCacheRefreshInterval
Control the interval of testing if cache is valid.
New: BootstrapPackageDirectory
Directory to pack and send to node.
New: BootstrapPackageName
Cache archive name (basename).
New: SSHKeyAlias
Engine SSH key alias
MODIFICATIONS
Use umask 0077 when transferring installations so accessible only to
logged on user.
Change-Id: I6f4a09ca9e66f0c9f5f4f7b283a5f43986b7e603
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
D backend/manager/conf/vds_installer.py
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/Config.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/FileUtil.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/CachedTar.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/Tar.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java
M packaging/fedora/engine-service.py
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/spec/ovirt-engine.spec.in
M pom.xml
17 files changed, 611 insertions(+), 545 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6963
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f4a09ca9e66f0c9f5f4f7b283a5f43986b7e603
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months
Change in ovirt-engine[master]: history: stopped ETL of templates images as disks (#781979)
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: history: stopped ETL of templates images as disks (#781979)
......................................................................
history: stopped ETL of templates images as disks (#781979)
This is due to the fact that templates data is not saved in
history db.
https://bugzilla.redhat.com/781979
Change-Id: Ia8168934f8559685a49a3e5cc02cf053f379ea69
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M backend/manager/dbscripts/create_dwh_views.sql
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Yaniv Dary: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7346
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8168934f8559685a49a3e5cc02cf053f379ea69
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: when iso domain is inactive we still go to the cache
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: when iso domain is inactive we still go to the cache
......................................................................
core: when iso domain is inactive we still go to the cache
when iso domain is inactive we still go to the cache list which results
in ERROR_CANNOT_FIND_ISO_IMAGE_PATH
Now, if ISO is not found , iso drop-down is shown as empty.
Also, run VM fails if VM is supposed to attach CD and the ISO domain is
not attached or in maintenance
Change-Id: I9d24c94c4dd630c5a76ae1fee65bee257b5e40f0
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractGetAllImagesListByStoragePoolIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
8 files changed, 75 insertions(+), 15 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5184
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d24c94c4dd630c5a76ae1fee65bee257b5e40f0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months
Change in ovirt-engine[master]: core: Fix uninformative quota messages (#838589)
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Fix uninformative quota messages (#838589)
......................................................................
core: Fix uninformative quota messages (#838589)
https://bugzilla.redhat.com/838589
When a quota is exceeded or reaches the warning threshold a log message
is shown. The messages were amended to be more informative.
Different messages are shown for Storage and Runtime qoutas and for
passing the warning threshold, the qouta limit and the grace zone.
Change-Id: Ie7c83616b773d7471447944e6dd9adcd49d2d5ac
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
2 files changed, 204 insertions(+), 144 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7c83616b773d7471447944e6dd9adcd49d2d5ac
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine: Add validation that network exists (#743830)
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Add validation that network exists (#743830)
......................................................................
engine: Add validation that network exists (#743830)
https://bugzilla.redhat.com/743830
If the network being sent doesn't exist, an error will be returned.
Change-Id: I8f4908cfca5fc282512ad245f7b4f458f450113f
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommandTest.java
2 files changed, 27 insertions(+), 2 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7333
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f4908cfca5fc282512ad245f7b4f458f450113f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 8 months
Change in ovirt-dwh[master]: history: fixed fqdn_or_ip column name (#841217)
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: history: fixed fqdn_or_ip column name (#841217)
......................................................................
history: fixed fqdn_or_ip column name (#841217)
fqn_or_ip was changed to fqdn_or_ip.
https://bugzilla.redhat.com/841217
Change-Id: Ic463f19a08a1957f9357380435b3d7a8f6b9d90a
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/configurationsync_3_1/ConfigurationSync.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/hostconfigcheck_3_1/HostConfigCheck.java
M data-warehouse/history_etl/tos_project/configuration/ExpressionBuilder/ConfigurationSync.xml
M data-warehouse/history_etl/tos_project/process/ConfigurationSync_3.1.item
M data-warehouse/history_etl/tos_project/process/HostConfigCheck_3.1.item
M data-warehouse/history_etl/tos_project/process/StatisticsSync_3.1.item
M data-warehouse/historydbscripts_postgres/create_views_3_0.sql
M data-warehouse/historydbscripts_postgres/create_views_3_1.sql
A data-warehouse/historydbscripts_postgres/upgrade/03_00_0140_rename_fqdn_host_column.sql
9 files changed, 129 insertions(+), 128 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7342
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic463f19a08a1957f9357380435b3d7a8f6b9d90a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 8 months