Change in ovirt-engine[master]: core: user query for quota (#847511)
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: user query for quota (#847511)
......................................................................
core: user query for quota (#847511)
https://bugzilla.redhat.com/847511
When user fetches quota from the engine, it should be
filtered by the quota that the user/group/everyone has consume quota
role defined on that quota.
Change-Id: Ic0b7fc712c742c90087e2b4b138b9ade37cf8668
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/dbscripts/quota_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllRelevantQuotasForStorageQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllRelevantQuotasForVdsGroupQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllRelevantQuotasForStorageQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllRelevantQuotasForVdsGroupQueryTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDAOTest.java
8 files changed, 58 insertions(+), 18 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7183
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0b7fc712c742c90087e2b4b138b9ade37cf8668
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months
Change in ovirt-engine[master]: webadmin: set default quota in quota drop down (#838454)
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: set default quota in quota drop down (#838454)
......................................................................
webadmin: set default quota in quota drop down (#838454)
https://bugzilla.redhat.com/838454
"Move Disk resets quota to default":
in case a quota is already given to a disk, choose the same
quota (if exists in the list) in move/copy the quota.
Change-Id: Ib7238cb1112a66d9f34ec7845c0c66d06356e077
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7182
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7238cb1112a66d9f34ec7845c0c66d06356e077
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months
Change in ovirt-engine[master]: webadmin: fix bug in disks subtab (#834240)
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: fix bug in disks subtab (#834240)
......................................................................
webadmin: fix bug in disks subtab (#834240)
https://bugzilla.redhat.com/834240
Change-Id: I806552b95070ff43ce8cccfb4fdb9b7600654069
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskGeneralView.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7181
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I806552b95070ff43ce8cccfb4fdb9b7600654069
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 8 months
Change in ovirt-engine[master]: engine: Permission given to a group doesn't apply to its mem...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine: Permission given to a group doesn't apply to its member (#847333)
......................................................................
engine: Permission given to a group doesn't apply to its member (#847333)
This patch fixes creation of user_permission_permissions_view.
The error was that user of a group doesn't get the same permissions that the group does have.
The user gets its own specific permissions only.
This happens because the view user_permissions_permissions_view uses user_flat_groups in a wrong way,
the view is supposed to make a table of permissions connected to user_id as permission_view, but this view
connects also subusers of groups to their group's permissions.
It uses ad_element_id instead of use_id field, that's the reason why GetPermissionsByAdElementIdQuery
returns only permissions on specific user without including its group permissions.
Change-Id: Ice68f05528f5952848f47c029f2216d7ddd7899e
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M backend/manager/dbscripts/create_views.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7262
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice68f05528f5952848f47c029f2216d7ddd7899e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 9 months
Change in ovirt-engine[master]: webadmin: VM subtab disks corrections (#846551)
by asaf＠redhat.com
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin: VM subtab disks corrections (#846551)
......................................................................
webadmin: VM subtab disks corrections (#846551)
https://bugzilla.redhat.com/846551
- Fixed auto collapse of snapshots when tree gets refreshed.
- VMsTree supported DiskImage only, extended support for LunDisks as
well.
Change-Id: I059bf7a8b18232640eaa7f2f5c49ee1cbc6d5486
Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/storage/VMsTree.java
1 file changed, 70 insertions(+), 30 deletions(-)
Approvals:
Asaf Shakarchi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I059bf7a8b18232640eaa7f2f5c49ee1cbc6d5486
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: core: avoid prms check when quota unchanged
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: avoid prms check when quota unchanged
......................................................................
core: avoid prms check when quota unchanged
incase the quota refernce of an object (vm, disk or template)
isn't changed, do not perform quota permission check on that quota.
Change-Id: I6d1fe74b4d4c6f23077c70d4779265b354147259
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
4 files changed, 22 insertions(+), 6 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7180
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d1fe74b4d4c6f23077c70d4779265b354147259
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: core: Fixing account disabled handling
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fixing account disabled handling
......................................................................
core: Fixing account disabled handling
The following patch fix account disabled handling.
It fixes:
1. Improper usage of AuditLog to log account locked or disabled event
2. AuditLog also in case of OperationNotSUppotedException - this error
might occure if account got locked after authentication succeeds.
3. Fix of EngineDirectoryServiceException - in case of OperationNotSuppoortedException
there should be not attempt to proceed to next LDAP server and a proper
detailed error should be printed. The fix fixes the detailed error printing
Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6588
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/EngineDirectoryServiceException.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ExceptionHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPIDirContextAuthenticationStrategy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchExceptionHandler.java
6 files changed, 23 insertions(+), 14 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7025
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6588
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: core: Fix disk permission view (#849404)
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix disk permission view (#849404)
......................................................................
core: Fix disk permission view (#849404)
https://bugzilla.redhat.com/show_bug.cgi?id=849404
This patch fixes the user disk permissions view, to contain disks from
SDs and DCs the user has permissions on. The problem is that the current
views return the image_id and not the image_group_id (disk id).
Change-Id: I6cf88c61b054b0e791c7e2c2e4313908dd7a2fc5
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/dbscripts/create_views.sql
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7319
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6cf88c61b054b0e791c7e2c2e4313908dd7a2fc5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 9 months
Change in ovirt-engine[master]: engine: StoragePool storage_pool_format_type is lost in upda...
by asaf＠redhat.com
Asaf Shakarchi has submitted this change and it was merged.
Change subject: engine: StoragePool storage_pool_format_type is lost in update (#845310)
......................................................................
engine: StoragePool storage_pool_format_type is lost in update (#845310)
https://bugzilla.redhat.com/845310
StoragePool's storage_pool_format_type property is not set in
params entity (as it's not visible in UI) so the value is lost
during storage pool update,
This patch copies the property value from the old entity.
Change-Id: I4e19bc2102e40c818b8953a08d1203c3a9b042b0
Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Asaf Shakarchi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7265
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e19bc2102e40c818b8953a08d1203c3a9b042b0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 9 months
Change in ovirt-engine-sdk[master]: sdk: make request error being capable to handle any type of ...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: make request error being capable to handle any type of response
......................................................................
sdk: make request error being capable to handle any type of response
Change-Id: Ia457618f7b86977c14bd6b1fb1397de484dd0371
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/ovirtsdk/infrastructure/errors.py
1 file changed, 33 insertions(+), 23 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7318
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia457618f7b86977c14bd6b1fb1397de484dd0371
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 9 months