Change in ovirt-engine[master]: webadmin: Add DirectLUN dialog - single selection
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Add DirectLUN dialog - single selection
......................................................................
webadmin: Add DirectLUN dialog - single selection
https://bugzilla.redhat.com/834240
Add DirectLUN disk dialog,
making sure the only a single LUN can be selected.
Change-Id: Ifaf7ffeff599be11f153913b2b40dca185698c78
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskGeneralModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/LunModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskGeneralView.java
10 files changed, 205 insertions(+), 76 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifaf7ffeff599be11f153913b2b40dca185698c78
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: webadmin: adding warnings to disk removal dialog
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: adding warnings to disk removal dialog
......................................................................
webadmin: adding warnings to disk removal dialog
https://bugzilla.redhat.com/819277
https://bugzilla.redhat.com/726444
Disk removal dialog warnings:
* Shareable Disk
* Shared Disk
* Bootable disk
(e.g. Note: disk1 is Shareable, Bootable and Attached to 2 VMs)
Change-Id: I4428dc3bc0bc905d7e60d56a67fb550f2b5005f9
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractDiskRemoveConfirmationPopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDiskRemovePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDiskRemovePopupView.java
9 files changed, 149 insertions(+), 18 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6905
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4428dc3bc0bc905d7e60d56a67fb550f2b5005f9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Preventing two Network Interfaces with same IP (#83919...
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Preventing two Network Interfaces with same IP (#839199)
......................................................................
core: Preventing two Network Interfaces with same IP (#839199)
https://bugzilla.redhat.com/839199
This patch adds a validation to setup networks to make
sure two network interfaces on the same host do not have
the same static ip.
Signed-off-by: Muli Salem <msalem(a)redhat.com>
Change-Id: I879959b49c7b8160bd2c7bb66284bb40d284011a
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NoRepetitiveStaticIpInListConstraint.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/NoRepetitiveStaticIpInList.java
A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/NoRepetitiveStaticIpInListConstraintTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 163 insertions(+), 2 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6695
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I879959b49c7b8160bd2c7bb66284bb40d284011a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Improve AutoRecoveryManagerTest
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Improve AutoRecoveryManagerTest
......................................................................
core: Improve AutoRecoveryManagerTest
Before this patch, the test ran the OnTime() method and checked that no
exception was thrown.
This patch extends it functionality and used Mockito's verification
capabilities to assert that the correct recovery actions are called.
Change-Id: I5410ad3b5aa383ed0145b0b03ec1b86ef63fb011
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AutoRecoveryManagerTest.java
1 file changed, 27 insertions(+), 4 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5410ad3b5aa383ed0145b0b03ec1b86ef63fb011
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Configuration to Enable/Disable Autorecovery
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Configuration to Enable/Disable Autorecovery
......................................................................
core: Configuration to Enable/Disable Autorecovery
Added configuration to enable/disable autorecovery per entity.
This patch contains:
1. A new configuration value for enabling/disabling autorecovery per
entity type.
2. Code that checks, per type, if auto recovery is enabled or disabled,
and only launches recovery actions if it is.
3. A unit test to check said functionality.
Change-Id: I5b80d51726650c499be9595a639e0103280619f2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AutoRecoveryManagerTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
4 files changed, 79 insertions(+), 23 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6865
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b80d51726650c499be9595a639e0103280619f2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Unrequired Network Causes Non-operational (#844739)
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Unrequired Network Causes Non-operational (#844739)
......................................................................
core: Unrequired Network Causes Non-operational (#844739)
https://bugzilla.redhat.com/844739
This patch checks whether a network over a bond
is required in the cluster before setting the host
to non-operational because it is down.
Signed-off-by: Muli Salem <msalem(a)redhat.com>
Change-Id: Ib6ead9de25e81e1f8c14d9161d36edb8dd0eefab
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 24 insertions(+), 21 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6902
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6ead9de25e81e1f8c14d9161d36edb8dd0eefab
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: engine: Fix NPE in SetupNetworksHelper (#842324)
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: engine: Fix NPE in SetupNetworksHelper (#842324)
......................................................................
engine: Fix NPE in SetupNetworksHelper (#842324)
https://bugzilla.redhat.com/842324
The method had relied on the new interface sent to determine if it's a
bond or a VLAN device, but it should instead check it on the existing
interface, thus avoiding relying on parameters that are sent by user.
Change-Id: I8d9a6f31a3c04068fac9bbcf2a06dc08d4b9794b
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d9a6f31a3c04068fac9bbcf2a06dc08d4b9794b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: added snapshot id to attached disk (#834004)
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: added snapshot id to attached disk (#834004)
......................................................................
core: added snapshot id to attached disk (#834004)
https://bugzilla.redhat.com/834004
when attaching a disk to an existing vm, the active vm snapshot id
wasn't set to the disk which caused errors when trying to delete a
snapshot.
Change-Id: Ie0945cecc63dc041fdb56e2fd7b733b287a9904c
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/dbscripts/images_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java
7 files changed, 92 insertions(+), 14 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0945cecc63dc041fdb56e2fd7b733b287a9904c
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: bootstrap: cleanup command used to gather node id
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: bootstrap: cleanup command used to gather node id
......................................................................
bootstrap: cleanup command used to gather node id
1. There is no apparent reason to encapsulate within echo.
2. There is no reason to explicit execute bash.
3. There is no reason to use full path for system utilities,
utilities may reside at different locations at differnt
setups.
If an issue will be found, it should be clearly documented.
Change-Id: Iace5593ab5585d1c8e25dcf76882480f3b6676d0
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iace5593ab5585d1c8e25dcf76882480f3b6676d0
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: cleanup: rename CBCInstaller->OVirtInstaller
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: cleanup: rename CBCInstaller->OVirtInstaller
......................................................................
cleanup: rename CBCInstaller->OVirtInstaller
Better name for this class implementation.
Change-Id: Ic63bee2afa5d125cc3f1ee3bb956abcd05b3ffca
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtInstaller.java
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6773
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic63bee2afa5d125cc3f1ee3bb956abcd05b3ffca
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months