Change in ovirt-engine[master]: webadmin, userportal: Implement dialog close button (icon)
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Implement dialog close button (icon)
......................................................................
webadmin,userportal: Implement dialog close button (icon)
This patch adds a close button (icon) into top-right corner
section of each application dialog (SimpleDialogPanel).
This patch also refactors/improves dialog (PresenterWidget)
hierarchy (common behavior) and fixes some issues:
1. Created AbstractPopupPresenterWidget as the base class
for all application dialogs (previously, each popup
extended GWTP PresenterWidget class directly)
2. Common close button (bottom-right), close icon button
(top-right) and key press handling logic moved to
AbstractPopupPresenterWidget (lots of duplicate code
in different popup PresenterWidgets eliminated)
3. Fixed a problem with singleton popup PresenterWidgets,
which were calling unbind() as part of handling Escape
key (singleton popups MUST NOT call unbind(), their
handlers must live till the very end!)
Besides unified behavior (AbstractPopupPresenterWidget),
the popup PresenterWidget hierarchy is flexible enough
to handle different kinds of dialogs, for example:
a. Model-bound dialogs (dialogs bound to UiCommon model),
which don't have dedicated close button (they handle
this through 'Cancel' Model command/button instead)
b. Login dialog, which doesn't have any kind of close
button or Escape key handling at all
Change-Id: Ia659415962e9dc01052c501805758a18c90512a2
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/FrontendUrlUtils.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/DefaultConfirmationPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ErrorPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/RemoveConfirmationPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginPopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractPopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractModelBoundPopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ErrorPopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/AbstractDialogPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/but_close.png
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/but_close_down.png
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/but_close_over.png
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/AboutPopupPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/VmDiskPopupPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/AboutPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AboutPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/configure/ConfigurePopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/storage/StoragePopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/vm/VmDiskPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AboutPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.ui.xml
30 files changed, 413 insertions(+), 311 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6112
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia659415962e9dc01052c501805758a18c90512a2
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: avoid unneeded method call
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: avoid unneeded method call
......................................................................
core: avoid unneeded method call
remove unneeded call to getStorageDomainStatus()
Change-Id: I72ca1f6ad63552b8fcdb4edc791faad738566565
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10763
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72ca1f6ad63552b8fcdb4edc791faad738566565
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: restapi: adding host specifying cluster by-name is not suppo...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: adding host specifying cluster by-name is not supported(#890329)
......................................................................
restapi: adding host specifying cluster by-name is not supported(#890329)
Using cli, when trying to add a host to a cluster the cluster
name is not supported as a way to indicate which cluster the
host should be added to.
This patch exposes the already existing functionality in the
api code to add host to a cluster by cluster name.
Change-Id: I6b8268b016d83f3a963774b097f78f980503e8dd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=890329
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Looks good to me, approved
Ravi Nori: Verified
--
To view, visit http://gerrit.ovirt.org/10726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b8268b016d83f3a963774b097f78f980503e8dd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: minor cleanup in VdsUpdateRunTimeInfo
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: minor cleanup in VdsUpdateRunTimeInfo
......................................................................
core: minor cleanup in VdsUpdateRunTimeInfo
- Replace documentation comments within methods with single line
comments.
- Replace fields initializations which consist of two consecutive
statements - one for declaration + null assignment and another
one for value assignment, with one initialization statement
which include the field declaration plus value assignment.
- Change private method names that begin with upper-case letter
to start with lower case letter
Change-Id: I21cc745d9034cbf97b1d39ad65a96c30c01e7dd2
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 44 insertions(+), 58 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10705
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21cc745d9034cbf97b1d39ad65a96c30c01e7dd2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: webadmin: Fix Volume Dialog cluster validation issue
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Fix Volume Dialog cluster validation issue
......................................................................
webadmin: Fix Volume Dialog cluster validation issue
Error message will be cleared if the user selects different
cluster. If the user changes the cluster before the call is
returned from backend, nothing will be done with the result
of the first call.
Change-Id: I457fe781fc4c54f2e705d1c0febfc73ccb2ab2ff
Bug-Url: https://bugzilla.redhat.com/883774
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
1 file changed, 8 insertions(+), 2 deletions(-)
Approvals:
Kanagaraj M: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10744
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I457fe781fc4c54f2e705d1c0febfc73ccb2ab2ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: Renamed event_map.java to EventMap.java
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: Renamed event_map.java to EventMap.java
......................................................................
core: Renamed event_map.java to EventMap.java
Change-Id: If79d19988555eefd7c94e5f8989a01910b3a41e9
Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddEventSubscriptionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveEventSubscriptionCommand.java
R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EventMap.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAOWrapperImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/events/MapDAOHibernateImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
10 files changed, 55 insertions(+), 55 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10053
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If79d19988555eefd7c94e5f8989a01910b3a41e9
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: gluster: Fixed deadlock in nested command execution
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: gluster: Fixed deadlock in nested command execution
......................................................................
gluster: Fixed deadlock in nested command execution
The CreateGlusterVolume command internally calls SetGlusterVolumeOption.
Both these try to acquire exclusive lock on the cluster, resulting in a
deadlock. To fix this, Modified GlusterCommandBase to acquire a lock on
the cluster only if it is not an internal execution.
Change-Id: Id080ad6ac3587ab9c3443cb83969783955dfb082
Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java
2 files changed, 4 insertions(+), 8 deletions(-)
Approvals:
Shireesh Anjal: Verified
Omer Frenkel: Looks good to me, approved
Yair Zaslavsky: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10448
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id080ad6ac3587ab9c3443cb83969783955dfb082
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months
Change in ovirt-guest-agent[master]: Report multiple IPv4 addresses per device if available
by bazulay＠redhat.com
Barak Azulay has submitted this change and it was merged.
Change subject: Report multiple IPv4 addresses per device if available
......................................................................
Report multiple IPv4 addresses per device if available
A future version of python-ethtool is going to expose
ethtool.etherinfo.get_ipv4_addresses() method, reporting multiple
addresses of a single device. Use this method if available.
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
Change-Id: I77bfd63874134b8d0c626c6d179643c2ec781b44
---
M ovirt-guest-agent/GuestAgentLinux2.py
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Barak Azulay: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77bfd63874134b8d0c626c6d179643c2ec781b44
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
11 years, 11 months
Change in ovirt-guest-agent[master]: agent: Send 'uninstalled' notification non blocking
by bazulay＠redhat.com
Barak Azulay has submitted this change and it was merged.
Change subject: agent: Send 'uninstalled' notification non blocking
......................................................................
agent: Send 'uninstalled' notification non blocking
The "echo" command blocks if the host is not connected to the
virtio-serial port. Replace it with a short python script that
opens the port with the O_NONBLOCK flag. This way, removing the
agent's doesn't hung if vdsm (or any other listener) doesn't
exist during the removal.
Change-Id: I5b49e53cda2f21bd759b0f3f67619f7f1e45688f
Signed-off-by: Gal Hammer <ghammer(a)redhat.com>
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent.spec
1 file changed, 12 insertions(+), 1 deletion(-)
Approvals:
Barak Azulay: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b49e53cda2f21bd759b0f3f67619f7f1e45688f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
11 years, 11 months
Change in ovirt-guest-agent[master]: agent: fixed "modified" files after clone.
by bazulay＠redhat.com
Barak Azulay has submitted this change and it was merged.
Change subject: agent: fixed "modified" files after clone.
......................................................................
agent: fixed "modified" files after clone.
Due to CR/LF issue some files were reported as "modified" even after
new clone or hard reset. Recommited the files with the right line-
ending.
Change-Id: I147b60f91335e18d786f79e3ab5d3799c1b18ab8
Signed-off-by: Gal Hammer <ghammer(a)redhat.com>
---
M GinaSSO/GinaSSO.sln
M GinaSSO/GinaSSO.vcproj
M ovirt-guest-agent/ovirt-guest-agent.ini
M ovirt-guest-agent/win-guest-agent-build-exe.bat
M windows-credprov/OVirtCredProv.sln
M windows-credprov/OVirtCredProv.vcproj
6 files changed, 824 insertions(+), 824 deletions(-)
Approvals:
Vinzenz Feenstra: Looks good to me, but someone else must approve
Barak Azulay: Looks good to me, approved
Gal Hammer: Verified
--
To view, visit http://gerrit.ovirt.org/10420
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I147b60f91335e18d786f79e3ab5d3799c1b18ab8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
11 years, 11 months