January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Raise event log severity to warning
by masayag＠redhat.com 09 Jan '13

09 Jan '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Raise event log severity to warning ...................................................................... engine: Raise event log severity to warning Since IMPORTEXPORT_IMPORT_VM_INVALID_INTERFACES audit log describes a problem in the system, it should be marked with a distinguishable severity to reflects its nature better. Change-Id: I5ec6ab5f48a6ed2e34d976a383685231886a1e93 Bug-Url: http://bugzilla.redhat.com/870121 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ec6ab5f48a6ed2e34d976a383685231886a1e93 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Change enums to fit common enum names
by masayag＠redhat.com 09 Jan '13

09 Jan '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Change enums to fit common enum names ...................................................................... webadmin: Change enums to fit common enum names The patch completes changes introduced by patch http://gerrit.ovirt.org/#/c/10588 which modifies the enums to comply with java naming conventions. Change-Id: If1fae65da08103c83b2add9e5db8510bc68955ee Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 2 files changed, 10 insertions(+), 10 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1fae65da08103c83b2add9e5db8510bc68955ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Restrict vlan-id range to 0-4094
by masayag＠redhat.com 09 Jan '13

09 Jan '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Restrict vlan-id range to 0-4094 ...................................................................... engine: Restrict vlan-id range to 0-4094 VDSM restricts vlan-id range to 0-4094 due to Linux limitation. The engine should be aligned with VDSM with this matter. Change-Id: I6d22b7d4a8b8482c9d844d8a29a13590c3e2a9cd Bug-Url: https://bugzilla.redhat.com/880254 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/test/resources/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 7 insertions(+), 7 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d22b7d4a8b8482c9d844d8a29a13590c3e2a9cd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add validation for updating a network
by masayag＠redhat.com 09 Jan '13

09 Jan '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add validation for updating a network ...................................................................... engine: Add validation for updating a network Validate that network isn't being used by templates when it is being updated so templates won't contain a network that doesn't exist or non-VM network. Change-Id: I8e480d908aa6e3cf55c5bccd5f84a92cb9f3d6be Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e480d908aa6e3cf55c5bccd5f84a92cb9f3d6be Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Modify network-not-used-by-vms validation
by masayag＠redhat.com 09 Jan '13

09 Jan '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Modify network-not-used-by-vms validation ...................................................................... engine: Modify network-not-used-by-vms validation The validation was changed so its output will contains a list of VM names that use the network. Change-Id: Ie522e4798d89d71ac7056c6b31a87baf095be342 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 3 files changed, 11 insertions(+), 12 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie522e4798d89d71ac7056c6b31a87baf095be342 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Rename methods to reflect their purpose
by masayag＠redhat.com 09 Jan '13

09 Jan '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Rename methods to reflect their purpose ...................................................................... engine: Rename methods to reflect their purpose Change-Id: I65883b6b1e70c9fb0ad88670a2e7ff0a16c5ea79 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65883b6b1e70c9fb0ad88670a2e7ff0a16c5ea79 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add validations for removing a network
by masayag＠redhat.com 09 Jan '13

09 Jan '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add validations for removing a network ...................................................................... engine: Add validations for removing a network The patch adds several validations for removing a network: 1. Prevent removing a management network 2. Prevent removing a network used by VMs 3. Prevent removing a network which is attached to hosts 4. Prevent removing a network which is used by templates. Change-Id: Ia3b797f79aac104ff73d5ad21a87ede259276b4c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 3 files changed, 84 insertions(+), 52 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3b797f79aac104ff73d5ad21a87ede259276b4c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Generalize network-in-use message
by masayag＠redhat.com 09 Jan '13

09 Jan '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Generalize network-in-use message ...................................................................... engine: Generalize network-in-use message The patch modifies the 'network-in-use' message so it could be used by any entity type for unified message format and DRY. Change-Id: Ie2d155616022c849f2395a0fd0f969386650426c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 11 insertions(+), 11 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2d155616022c849f2395a0fd0f969386650426c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replace return type of ReplacementUtils
by masayag＠redhat.com 09 Jan '13

09 Jan '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Replace return type of ReplacementUtils ...................................................................... engine: Replace return type of ReplacementUtils To ease usability of ReplacementUtils.replaceWith* return value, it is changed from a static array into a Collection. Change-Id: If0733f3bb5fec70896a685452125c67d1f14784f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReplacementUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReplacementUtilsTest.java 2 files changed, 67 insertions(+), 36 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0733f3bb5fec70896a685452125c67d1f14784f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add constructor to ValidationResult for collections
by masayag＠redhat.com 09 Jan '13

09 Jan '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add constructor to ValidationResult for collections ...................................................................... engine: Add constructor to ValidationResult for collections The patch adds a c'tor which gets a Collection of strings in order to extend the instantiation method of the class. Change-Id: I7de4dcb823b10a20135c1af1e5cb32d9bdf04082 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7de4dcb823b10a20135c1af1e5cb32d9bdf04082 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0