November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: core: ImagesHandler - lock multiple disks snapshots in one t...
by iheim＠redhat.com 28 Nov '13

28 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: ImagesHandler - lock multiple disks snapshots in one transaction ...................................................................... core: ImagesHandler - lock multiple disks snapshots in one transaction this patch adds support and usage of locking the snapshots of multiple disks in one transaction (including support for using compensation) Change-Id: If873e23983757e9e9bb41a760d07779fc1512cd4 Related To: https://bugzilla.redhat.com/show_bug.cgi?id=1028768 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java 2 files changed, 32 insertions(+), 13 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If873e23983757e9e9bb41a760d07779fc1512cd4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: VM dialog Host tab for Local SD
by gchaplik＠redhat.com 28 Nov '13

28 Nov '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: VM dialog Host tab for Local SD ...................................................................... webadmin: VM dialog Host tab for Local SD In vm/template/pool dialog Host tab will be visible for local SD data center (to show other host fields, used to be hidden). In local DC Migration fields will be disabled and set to non-migratable and pinned. Change-Id: I490f19a9a66c78d9f0d81bf5fb009d2a8eec38a4 Bug-Url: https://bugzilla.redhat.com/1018201 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 4 files changed, 16 insertions(+), 28 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I490f19a9a66c78d9f0d81bf5fb009d2a8eec38a4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.1]: vdsm: packages: adjust to new method of vdsm configure
by Alon Bar-Lev 28 Nov '13

28 Nov '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: packages: adjust to new method of vdsm configure ...................................................................... vdsm: packages: adjust to new method of vdsm configure Change-Id: Iec69d6ab5cdd00132198f882b0f1d0a1ff790f8b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/packages.py 2 files changed, 3 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec69d6ab5cdd00132198f882b0f1d0a1ff790f8b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.1 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: LSM - lock changes, added support for disk snapshot sc...
by iheim＠redhat.com 28 Nov '13

28 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: LSM - lock changes, added support for disk snapshot scenarios ...................................................................... core: LSM - lock changes, added support for disk snapshot scenarios This patch contains the following changes: *When live migrating a disk, the disk (and it's snapshots) would be locked for the whole flow preventing other operations to be done on the disk. Therefore the create snapshot command will ignore those disks in its checks and they won't be unlocked as the snapshot phase ends. *Disk can be live migrated when snapshots of it are attached to other vms unless those vms are not in "Down" status as it means that the disk is being used by them. *When live migrating the disk (after creating the snapshot for the migration) all the disk snapshots would be locked and not just the active volume. *Task Handlers should be able to use the compensation context of the enclosing command. Change-Id: I0c7cb49ff37f28d0b3ab0df9f4ee1f3082aba018 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1028768 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDisksTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskHandlerCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LiveMigrateDiskParameters.java 19 files changed, 348 insertions(+), 79 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c7cb49ff37f28d0b3ab0df9f4ee1f3082aba018 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: MoveOrCopyDiskCommand - reduce query count
by iheim＠redhat.com 28 Nov '13

28 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: MoveOrCopyDiskCommand - reduce query count ...................................................................... core: MoveOrCopyDiskCommand - reduce query count When loading the vms for a disk, the vm device information is already loaded - therefore there's no need to filter it out and then reload it for each vm, we can use the values that were loaded during the first query execution. Change-Id: Ic4b15114bc72dc07de917692b60703008008ae13 Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1032807 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java 2 files changed, 26 insertions(+), 34 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4b15114bc72dc07de917692b60703008008ae13 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.1]: openstack: neutron: renamed quantum to neutron
by Alon Bar-Lev 28 Nov '13

28 Nov '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: openstack: neutron: renamed quantum to neutron ...................................................................... openstack: neutron: renamed quantum to neutron Renamed quantum to neutron in all references to packages and configuration files in order to support the new naming scheme that the OpenStack Networking project uses. Bug-Url: https://bugzilla.redhat.com/1032890 Change-Id: Ia0629b2f3693f89bfd5fa1bbe16f2f029617b3d9 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M ChangeLog M src/ovirt_host_deploy/constants.py M src/plugins/ovirt-host-deploy/openstack/neutron.py M src/plugins/ovirt-host-deploy/openstack/neutron_linuxbridge.py M src/plugins/ovirt-host-deploy/openstack/neutron_openvswitch.py 5 files changed, 14 insertions(+), 12 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0629b2f3693f89bfd5fa1bbe16f2f029617b3d9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.1 Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: ignore in findbugs EventArgs unconfirmed cast errors
by amureini＠redhat.com 28 Nov '13

28 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: frontend: ignore in findbugs EventArgs unconfirmed cast errors ...................................................................... frontend: ignore in findbugs EventArgs unconfirmed cast errors Ignore in findbugs errors related to casting EventArgs. The casting is safe in this case, and a future refactoring will make findbug warning resolved in any case.(RFE #1034844) This is a second patch following http://gerrit.ovirt.org/#/c/21797/ Change-Id: I3ddb7d18ba1758c137dc92c44d5082837cebd18f Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/exclude-filters.xml 1 file changed, 31 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ddb7d18ba1758c137dc92c44d5082837cebd18f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: change gluster to use LATEST
by sbonazzo＠redhat.com 28 Nov '13

28 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: change gluster to use LATEST ...................................................................... change gluster to use LATEST bumped release to 9-1 and added appropriate changelog. Change-Id: I5711f1d558ec4d4869913f2c9b48cde0a4153e04 Signed-off-by: Mike Burns <mburns(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M glusterfs-epel.repo M ovirt-release.spec.in 3 files changed, 7 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Kiril Nesenko: Verified Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5711f1d558ec4d4869913f2c9b48cde0a4153e04 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: allow external plugins yum locking
by iheim＠redhat.com 28 Nov '13

28 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: allow external plugins yum locking ...................................................................... packaging: setup: allow external plugins yum locking Added infrastructure for allowing external plugins to filter and add packages to version locking transaction. Change-Id: Ic5a33d3a09e1c5aa9fed8a08d81a4ce583c12797 Bug-Url: https://bugzilla.redhat.com/1011087 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/distro-rpm/packages.py 2 files changed, 35 insertions(+), 4 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5a33d3a09e1c5aa9fed8a08d81a4ce583c12797 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: post ovirt-engine-3.3.2
by oschreib＠redhat.com 28 Nov '13

28 Nov '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: post ovirt-engine-3.3.2 ...................................................................... packaging: post ovirt-engine-3.3.2 Updated version to 3.3.3-0.0 Change-Id: I71933a20c533ae0c3282aa9e8fccecea7798b4f0 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M version.mak 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71933a20c533ae0c3282aa9e8fccecea7798b4f0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0