November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: fix remove issues in Add-Bricks popup
by kmayilsa＠redhat.com 28 Nov '13

28 Nov '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: fix remove issues in Add-Bricks popup ...................................................................... webadmin: fix remove issues in Add-Bricks popup When the user clicks 'Remove' button after selecting one or more brick in the Add-Bricks popup, the data is not rendered properly post removal. This is now fixed. Change-Id: I809d894d81ec6f46f6fb11085b5a5cdc0be00f3d Bug-Url: https://bugzilla.redhat.com/989213 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I809d894d81ec6f46f6fb11085b5a5cdc0be00f3d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rename method to lowercase in EnumTranslator.
by tnisan＠redhat.com 28 Nov '13

28 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename method to lowercase in EnumTranslator. ...................................................................... core: rename method to lowercase in EnumTranslator. Fixes a findbug warning. Change-Id: I3cb44e654838149c07d84504599e50ced50e2678 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/VolumeTransportTypeRenderer.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleNode.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java 11 files changed, 21 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cb44e654838149c07d84504599e50ced50e2678 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup: remove trailing spaces
by emesika＠redhat.com 28 Nov '13

28 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: core: cleanup: remove trailing spaces ...................................................................... core: cleanup: remove trailing spaces Change-Id: I535c8e86d13f89d860569f4c582e4fe17cee5e0f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/text/DateFormat.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/DateTime.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/Regex.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/RegexOptions.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/TimeSpan.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/searchbackend/DateUtils.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendActionAsyncResult.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IEnlistmentNotification.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Task.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/CharEncoding.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/DecoderException.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/EncoderException.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java 13 files changed, 105 insertions(+), 105 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I535c8e86d13f89d860569f4c582e4fe17cee5e0f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup: remove tabs
by emesika＠redhat.com 28 Nov '13

28 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: core: cleanup: remove tabs ...................................................................... core: cleanup: remove tabs Change-Id: I53f42834829fc4d3d743cb25e80a8af03944fba9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/UUID.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/common/config/ConfigUtil.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/common/utils/EnumUtils.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/DateTime.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/TimeSpan.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/DateTimeUtils.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Dispatcher.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EventProvidingCollection.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendActionAsyncResult.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendMultipleQueryAsyncResult.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendQueryAsyncResult.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IAsyncCallback.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IEqualityComparer.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IFrontendActionAsyncCallback.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IFrontendMultipleQueryAsyncCallback.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ITaskTarget.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IteratorUtils.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/PropertyChangeNotifier.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Task.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TaskContext.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Translator.java 23 files changed, 596 insertions(+), 596 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53f42834829fc4d3d743cb25e80a8af03944fba9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup: dos2unix
by emesika＠redhat.com 28 Nov '13

28 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: core: cleanup: dos2unix ...................................................................... core: cleanup: dos2unix Change-Id: I2a5e2d74ec28e40daf33f7edd9d7cc43c06bc0c2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/CustomSQLErrorCodeSQLExceptionTranslator.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewRadioGroup.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/UUID.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ValueEventArgs.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDomainModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/DateTimeUtils.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enlistment.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EventProvidingCollection.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendActionAsyncResult.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendMultipleActionAsyncResult.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendMultipleQueryAsyncResult.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendQueryAsyncResult.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IAsyncCallback.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IEnlistmentNotification.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IFrontendActionAsyncCallback.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IFrontendMultipleActionAsyncCallback.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IFrontendMultipleQueryAsyncCallback.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IProvideCollectionChangedEvent.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IProvidePropertyChangedEvent.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ITaskTarget.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/PreparingEnlistment.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ProvideCollectionChangedEvent.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ProvidePropertyChangedEvent.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ReversibleFlow.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Task.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TaskContext.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TypeUtil.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/CharEncoding.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/DecoderException.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/EncoderException.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/ConfigureLocalStoragePopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/DisksTree.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/StoragesTree.java 35 files changed, 2,390 insertions(+), 2,390 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a5e2d74ec28e40daf33f7edd9d7cc43c06bc0c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: [cleanup] Remove unused function RunAutoQuery
by tnisan＠redhat.com 28 Nov '13

28 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: engine: [cleanup] Remove unused function RunAutoQuery ...................................................................... engine: [cleanup] Remove unused function RunAutoQuery When fixing findbugs method naming convention errors the method RunAutoQuery was flagged. Since this method is not used, just remove it instead of renaming it. Change-Id: Ie5389865d16a157aff32705c7493f71e19084536 Signed-off-by: Adam Litke <alitke(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java 2 files changed, 0 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5389865d16a157aff32705c7493f71e19084536 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: [cleanup] Remove unused function RunAutoAction
by tnisan＠redhat.com 28 Nov '13

28 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: engine: [cleanup] Remove unused function RunAutoAction ...................................................................... engine: [cleanup] Remove unused function RunAutoAction When fixing findbugs naming convention errors the function RunAutoAction was flagged. Since this function is no longer used, remove it instead of renaming it. Change-Id: I6be00cdaf1652659dd73d45f4da281281876e130 Signed-off-by: Adam Litke <alitke(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java 2 files changed, 0 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6be00cdaf1652659dd73d45f4da281281876e130 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: [cleanup] Rename RunPublicQuery to runPublicQuery
by tnisan＠redhat.com 28 Nov '13

28 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: engine: [cleanup] Rename RunPublicQuery to runPublicQuery ...................................................................... engine: [cleanup] Rename RunPublicQuery to runPublicQuery Findbugs warning message: Backend.java:598, NM_METHOD_NAMING_CONVENTION, Priority: Low The method name org.ovirt.engine.core.bll.Backend.RunPublicQuery(VdcQueryType, VdcQueryParametersBase) doesn't start with a lower case letter Methods should be verbs, in mixed case with the first letter lowercase, with the first letter of each internal word capitalized. Change-Id: If105d68de5ad76d61a9123efac5c14440a8a3032 Signed-off-by: Adam Litke <alitke(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/security/auth/LoginValidatorTest.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java M backend/manager/modules/welcome/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/AbstractGwtDynamicHostPageServletTest.java 9 files changed, 13 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If105d68de5ad76d61a9123efac5c14440a8a3032 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: [cleanup] Rename RunMultipleActions to runMultipleAc...
by tnisan＠redhat.com 28 Nov '13

28 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: engine: [cleanup] Rename RunMultipleActions to runMultipleActions ...................................................................... engine: [cleanup] Rename RunMultipleActions to runMultipleActions Findbugs warning message: Backend.java:508, NM_METHOD_NAMING_CONVENTION, Priority: Low The method name org.ovirt.engine.core.bll.Backend.RunMultipleActions(VdcActionType, ArrayList, boolean) doesn't start with a lower case letter Methods should be verbs, in mixed case with the first letter lowercase, with the first letter of each internal word capitalized. Change-Id: I0bfa0221abc1a533f39ec114238b89dbe437164c Signed-off-by: Adam Litke <alitke(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java 5 files changed, 6 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bfa0221abc1a533f39ec114238b89dbe437164c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: [cleanup] Rename RunQuery to runQuery
by tnisan＠redhat.com 28 Nov '13

28 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: engine: [cleanup] Rename RunQuery to runQuery ...................................................................... engine: [cleanup] Rename RunQuery to runQuery Findbugs warning message: Backend.java:458, NM_METHOD_NAMING_CONVENTION, Priority: Low The method name org.ovirt.engine.core.bll.Backend.RunQuery(VdcQueryType, VdcQueryParametersBase) doesn't start with a lower case letter Methods should be verbs, in mixed case with the first letter lowercase, with the first letter of each internal word capitalized. Change-Id: Ia339bc402d36fe22e4017a8b891ed64af2e0cef2 Signed-off-by: Adam Litke <alitke(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsByStorageDomainQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfilesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendWatchdogsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterHooksResourceTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/AbstractGwtDynamicHostPageServletTest.java 19 files changed, 34 insertions(+), 34 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia339bc402d36fe22e4017a8b891ed64af2e0cef2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0