November 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-node-plugin-vdsm[master]: engine_page: fix logic to show fingerprint msg

by fabiand＠fedoraproject.org

Fabian Deutsch has submitted this change and it was merged. Change subject: engine_page: fix logic to show fingerprint msg ...................................................................... engine_page: fix logic to show fingerprint msg Show fingerprint review message only when there is fingerprint. Change-Id: I30f4d8657f196ecdd23ff7d5e8ebdfbdca764963 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Fabian Deutsch: Looks good to me, approved Douglas Schilling Landgraf: Verified -- To view, visit http://gerrit.ovirt.org/20995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30f4d8657f196ecdd23ff7d5e8ebdfbdca764963 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: possible NPE in UpdateVmDisk

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: possible NPE in UpdateVmDisk ...................................................................... core: possible NPE in UpdateVmDisk During UpdateVmDisk command, if the disk doesn't exist anymore in the db the private commands lists won't be initialized causing to NPE on getSharedLocks() method. Change-Id: I787b4a9e723e3096b5d22a5a925cd976940497ff Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=922475 Signed-off-by: Liron Aravot <laravot(a)redhat.com> Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I787b4a9e723e3096b5d22a5a925cd976940497ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Fix ClassCastException while attempting to detach di...

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: engine: Fix ClassCastException while attempting to detach direct LUN ...................................................................... engine: Fix ClassCastException while attempting to detach direct LUN Engine mistakenly trying to update VM snapshot id on direct LUN and fails with ClassCastException. This patch restores code checking the type of the disk before updating snapshot id. Change-Id: I2b60d19f8832392d6f2df5cb05552560b7e10d1c Bug-Url: https://bugzilla.redhat.com/1026920 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b60d19f8832392d6f2df5cb05552560b7e10d1c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Remove support for ib700 watchdog

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: Remove support for ib700 watchdog ...................................................................... core: Remove support for ib700 watchdog This watchdog is no longer supported as it is an ISA device. Change-Id: I83242f3ccd7c2fc6ed7c4321ecaa89fca0140093 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014531 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmWatchdogType.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/WatchdogModel.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/WatchdogMapper.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 6 files changed, 5 insertions(+), 12 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83242f3ccd7c2fc6ed7c4321ecaa89fca0140093 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: handle ovf empty UUID for quota

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: handle ovf empty UUID for quota ...................................................................... core: handle ovf empty UUID for quota Due to latest changes, quota field cannot accept empty UUID. prior to that change, a VM could have been exported with an empty UUID to OVF file. Altering the ovf reader to ignore empty UUID for quota. Change-Id: Ibcd0b29861a43bcb77acd7c3e0bae58d7b27b8f4 Bug-Url: https://bugzilla.redhat.com/1025773 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20979 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcd0b29861a43bcb77acd7c3e0bae58d7b27b8f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: cpu pinning is disabled for Local SD

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: cpu pinning is disabled for Local SD ...................................................................... webadmin: cpu pinning is disabled for Local SD Should be enabled without any consideration to other VM's migration properties. Bug-Url: https://bugzilla.redhat.com/1018201 Change-Id: I4706419295d67f7a022a85bc61f75bb46def2b6b Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 15 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4706419295d67f7a022a85bc61f75bb46def2b6b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: radiobutton text is truncated & unaligned

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: radiobutton text is truncated & unaligned ...................................................................... webadmin: radiobutton text is truncated & unaligned Discovered in pt-BR locale Cluster dialog: radio buttons labels in "optimization" section are truncated and unaligned for long text Change-Id: I5bd4ef709ada858140cd33d909aed3dc3171f6df Bug-Url: https://bugzilla.redhat.com/1018382 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 3 files changed, 25 insertions(+), 16 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bd4ef709ada858140cd33d909aed3dc3171f6df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: wrong memory overcommit unit

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: wrong memory overcommit unit ...................................................................... webadmin: wrong memory overcommit unit in cluster general info sub tab, Max Memory Over Commitment unit is MB, and should be % Change-Id: Ie572092251bc5d5a87f9734f18194389cf1fbe29 Bug-Url: https://bugzilla.redhat.com/1021326 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie572092251bc5d5a87f9734f18194389cf1fbe29 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: change required permissions for removing template from...

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: change required permissions for removing template from export domain ...................................................................... core: change required permissions for removing template from export domain Require 'delete template' permission on the export domain instead of 'import-export' permission on the template for removing a template from export domain. Change-Id: I16755e45c0ac884fd05a6564b201e15a35e34dd5 Bug-Url: https://bugzilla.redhat.com/1010963 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16755e45c0ac884fd05a6564b201e15a35e34dd5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: change required permissions for removing VM from expor...

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: change required permissions for removing VM from export domain ...................................................................... core: change required permissions for removing VM from export domain This patch changes the permissions which are required for removing a VM from export domain. Until now, the user had to have import-export permissions on the VM in order to be able to remove it from the export domain - It was problematic in case the VM which is going to be removed doesn't exist in the system. >From now on, we require 'delete vm' permissions on the export domain in order to be able to remove VMs from the export domain, which makes it possible for everyone who has 'delete vm' permissions on the export domain to remove those VMs, also in case they don't exist in the DB. Change-Id: I9f63cc6e53cd082d011bbef72c6a9435b6c1620b Bug-Url: https://bugzilla.redhat.com/1010963 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 10 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f63cc6e53cd082d011bbef72c6a9435b6c1620b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2013