November 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-node-plugin-vdsm[master]: engine_page: valid.Empty() handling None

by fabiand＠fedoraproject.org

Fabian Deutsch has submitted this change and it was merged. Change subject: engine_page: valid.Empty() handling None ...................................................................... engine_page: valid.Empty() handling None On update() we should validate None as well. Change-Id: Ia0d9e94c719bac40d6adb4e4939e3c2cfcec6fe8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1019884 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0d9e94c719bac40d6adb4e4939e3c2cfcec6fe8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: core: change required permissions for removing template from...

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: change required permissions for removing template from export domain ...................................................................... core: change required permissions for removing template from export domain Require 'delete template' permission on the export domain instead of 'import-export' permission on the template for removing a template from export domain. Change-Id: I16755e45c0ac884fd05a6564b201e15a35e34dd5 Bug-Url: https://bugzilla.redhat.com/1010963 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16755e45c0ac884fd05a6564b201e15a35e34dd5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: userportal, webadmin: remove double slash in link

by vszocs＠redhat.com

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal,webadmin: remove double slash in link ...................................................................... userportal,webadmin: remove double slash in link Due to some of the URI rework, the base URI has a starting slash, but some of the code assumed it didn't this patch adds method to get the base URI without the leading slash. Change-Id: Ica1ee3cce0c98dffe781b7d0e9ec5c2d667b4acd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026593 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/BaseContextPathData.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java 4 files changed, 22 insertions(+), 10 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica1ee3cce0c98dffe781b7d0e9ec5c2d667b4acd Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Small fix for removing profiles

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Small fix for removing profiles ...................................................................... webadmin: Small fix for removing profiles As part of a very recent large refactoring, some regression was introduced in the add/remove profiles widget in the edit network dialog, that disregarded removal of profiles. This patch fixes it. Change-Id: Iea8aa1b670dc12109da30549ab61975215e0c174 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea8aa1b670dc12109da30549ab61975215e0c174 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Fix few eclipse warning

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix few eclipse warning ...................................................................... engine: Fix few eclipse warning The AuditLogableBase doesn't implement Serializable, therefore it doesn't required any serial id. The serial warning can be removed from CommandBase as well. Clear the type from CommandBase.validate() signature which hides the T type defined as a parameter class type on the class signature. Change-Id: I4c6e80252f0a9d907488be6ede45271c936f5de6 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 4 files changed, 4 insertions(+), 7 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c6e80252f0a9d907488be6ede45271c936f5de6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: gluster: fix create volume brick validation

by kmayilsa＠redhat.com

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: fix create volume brick validation ...................................................................... gluster: fix create volume brick validation While creating a Striped-Replicated volume, the code which validates the number of bricks is missing 'break' in a swith-case. This is now fixed. Change-Id: I16a5b93f687f5411c08a59804d731d7f4644b12b Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16a5b93f687f5411c08a59804d731d7f4644b12b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-reports[master]: packaging: setup: add answerfile option

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: add answerfile option ...................................................................... packaging: setup: add answerfile option This new implementation allows unattended reports installation. Change-Id: Ia8a1bd52965f0f16f68ac9948622d22f1299edef Bug-Url: https://bugzilla.redhat.com/1025339 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-reports-setup.py 2 files changed, 128 insertions(+), 60 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8a1bd52965f0f16f68ac9948622d22f1299edef Gerrit-PatchSet: 5 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: setup: check database object ownership on upgrade

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: check database object ownership on upgrade ...................................................................... packaging: setup: check database object ownership on upgrade check database object ownership to engine before upgrade. If the owner is not engine, abort setup asking the user to run changedbowner.sh script for fixing it. Change-Id: I45b655e88c25dd51e567405cc6747b42dfd8a98b Bug-Url: https://bugzilla.redhat.com/1022691 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/db/schema.py 2 files changed, 79 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45b655e88c25dd51e567405cc6747b42dfd8a98b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[master]: Engine: remove timelease from pool type

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: Engine: remove timelease from pool type ...................................................................... Engine: remove timelease from pool type It's not supported for a long time. Change-Id: I4485501d4cd4a73d889ebb656751d674f55eae87 https://bugzilla.redhat.com/858958 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPoolType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M packaging/dbscripts/user_sp.sql 13 files changed, 3 insertions(+), 172 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4485501d4cd4a73d889ebb656751d674f55eae87 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: [TEXT] restore.sh woes, unable to...

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: [TEXT] restore.sh woes, unable to... ...................................................................... core: [TEXT] restore.sh woes, unable to... [TEXT] restore.sh woes, unable to restore engine DB without using -u postgres 1) removing the internal create/drop of the database, this should be done manually as explained in the script usage statement 2) adding a comment that this script will work only for DB engine user 3) removing from backup script the -C flag to prevent database creation statements generation 4) If an old backup having "CREATE DATABASE" or "ALTER DATABASE" is used, those statements are removed before an attempt to restore the database is done. Change-Id: I44921d6fac57cfc565dacca52ed5a6d3b5b57f66 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=976337 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/backup.sh M packaging/dbscripts/restore.sh 2 files changed, 36 insertions(+), 31 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44921d6fac57cfc565dacca52ed5a6d3b5b57f66 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 2 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2013