Change in ovirt-engine[master]: webadmin: clear connection on import SD rollback
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: clear connection on import SD rollback
......................................................................
webadmin: clear connection on import SD rollback
In order to avoid stale connections data in the DB,
clear storage connection when an export/iso domain
doesn't exist on the specified path
(GetExistingStorageDomainList returns an empty list)
Change-Id: Ia2e70353494ce97a6c2ae0ad74868c1f502a309c
Bug-Url: https://bugzilla.redhat.com/1020812
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 13 insertions(+), 21 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20725
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2e70353494ce97a6c2ae0ad74868c1f502a309c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: webadmin: remove unused member from ClusterListModel
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: remove unused member from ClusterListModel
......................................................................
webadmin: remove unused member from ClusterListModel
Solves findbug warning of type URF_UNREAD_FIELD
Change-Id: I2d95c323450206166225f7cfabc32db5f2cf09aa
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20927
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d95c323450206166225f7cfabc32db5f2cf09aa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: webadmin: adjust action table vertical scroll-bar
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: adjust action table vertical scroll-bar
......................................................................
webadmin: adjust action table vertical scroll-bar
Action table vertical scroll-bar is cropped
when the items list is empty (Fedora19/Firefox21).
The issue was overlapping of the bottom table
over the header (which cropped the header
also when the table isn't empty).
Fixed by altering table's styles.
Screenshots-Before:
http://i.imgur.com/aP64ZzY.png
http://i.imgur.com/koRMhc1.png
Screenshots-After:
http://i.imgur.com/j7CjGN6.png
http://i.imgur.com/HjUPhu4.png
Change-Id: I8ed7202f2ff13ec5adf2c5de341f2b8223a85a63
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.ui.xml
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20881
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ed7202f2ff13ec5adf2c5de341f2b8223a85a63
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: rename methods in tags class to lowercase
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: rename methods in tags class to lowercase
......................................................................
core: rename methods in tags class to lowercase
Change-Id: I84713ffbecaa3fa9bf1db7b9794de2ba3ffdf612
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java
2 files changed, 16 insertions(+), 16 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20924
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84713ffbecaa3fa9bf1db7b9794de2ba3ffdf612
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: rename methods to lower case in vm commands and handler
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: rename methods to lower case in vm commands and handler
......................................................................
core: rename methods to lower case in vm commands and handler
Change-Id: I701170efd0081ea60c1e5da8fd4d124c1c326f04
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmToPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PauseVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java
10 files changed, 15 insertions(+), 15 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I701170efd0081ea60c1e5da8fd4d124c1c326f04
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: webadmin: clean connection on new GlusterFS failure
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: clean connection on new GlusterFS failure
......................................................................
webadmin: clean connection on new GlusterFS failure
StorageListModel -> saveNewGlusterStorage() -> AddStorageServerConnection:
Set connection ID (using action's return value) to enable connection
clean-up on failure [as 'StorageListModel -> cleanConnection()' invokes
RemoveStorageServerConnection iff connection's ID exists].
Change-Id: Id50f5230e5548e50ff17a7bc6af1bf098ccb8c15
Bug-Url: https://bugzilla.redhat.com/1021882
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id50f5230e5548e50ff17a7bc6af1bf098ccb8c15
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine-cli[cli_3.3]: cli: do not ask for credentials when -h--/help in args
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: do not ask for credentials when -h--/help in args
......................................................................
cli: do not ask for credentials when -h--/help in args
Change-Id: I26eb25ef079bd7335c71bcc935276176ff781b66
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M src/cli/context.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20920
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26eb25ef079bd7335c71bcc935276176ff781b66
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.3
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: core: Remove support for ib700 watchdog
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Remove support for ib700 watchdog
......................................................................
core: Remove support for ib700 watchdog
This watchdog is no longer supported as it is an ISA device.
Change-Id: I83242f3ccd7c2fc6ed7c4321ecaa89fca0140093
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014531
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmWatchdogType.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/WatchdogModel.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogsResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/WatchdogMapper.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
6 files changed, 5 insertions(+), 12 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20035
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83242f3ccd7c2fc6ed7c4321ecaa89fca0140093
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eoghan Glynn <eoghan.glynn(a)gmail.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: [TEXT] restore.sh woes, unable to...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: [TEXT] restore.sh woes, unable to...
......................................................................
core: [TEXT] restore.sh woes, unable to...
[TEXT] restore.sh woes, unable to restore engine DB without using -u postgres
1) removing the internal create/drop of the database, this should be
done manually as explained in the script usage statement
2) adding a comment that this script will work only for DB engine user
3) removing from backup script the -C flag to prevent database creation
statements generation
4) If an old backup having "CREATE DATABASE" or "ALTER DATABASE" is
used, those statements are removed before an attempt to restore the
database is done.
Change-Id: I44921d6fac57cfc565dacca52ed5a6d3b5b57f66
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=976337
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/backup.sh
M packaging/dbscripts/restore.sh
2 files changed, 36 insertions(+), 31 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19329
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44921d6fac57cfc565dacca52ed5a6d3b5b57f66
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: core: Log filtering progress in scheduling
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Log filtering progress in scheduling
......................................................................
core: Log filtering progress in scheduling
This logs the filtering step for each Host removal during the
scheduling operation to make debugging easier.
It also improves the error popup when scheduling
fails. The goal is to tell the user why his hosts
were removed from the decision process.
A logging is also added for the Pin To Host policy
unit.
https://bugzilla.redhat.com/show_bug.cgi?id=1002005
Change-Id: I4edcc33b0d280ab92e3c98d8d5a7a75386592e32
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1002005
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PinToHostPolicyUnit.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationMessages.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
15 files changed, 181 insertions(+), 50 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19213
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4edcc33b0d280ab92e3c98d8d5a7a75386592e32
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
