Change in ovirt-engine[master]: core: rename Login/Logoff in Backend to lowercase.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: rename Login/Logoff in Backend to lowercase.
......................................................................
core: rename Login/Logoff in Backend to lowercase.
As well as in its interface and all usages.
Change-Id: I6a9be2db6d7c5e0680e2d9e286845b53261e2e9f
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/security/auth/LoginValidatorTest.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
7 files changed, 16 insertions(+), 16 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20911
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a9be2db6d7c5e0680e2d9e286845b53261e2e9f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: restapi : Rename power management agent user_name in rsdl(#1...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: restapi : Rename power management agent user_name in rsdl(#1005751)
......................................................................
restapi : Rename power management agent user_name in rsdl(#1005751)
updating hosts powermanagent fails from cli. The correct
option for agent.user_name is agent.username.
Fixes the parameter name in rsdl
Change-Id: Ie3bdab3a775e5280d1d16ef3409c9eb420ec43ef
Bug-Url: https://bugzilla.redhat.com/1005751
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20874
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3bdab3a775e5280d1d16ef3409c9eb420ec43ef
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: engine: Fix issue with thread naming
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: engine: Fix issue with thread naming
......................................................................
engine: Fix issue with thread naming
Patch http://gerrit.ovirt.org/#/c/19744/ appended org.ovirt.thread
to the thread name. However, this happened again and again, with
no limit. This patch fixes it.
Change-Id: I4094f70859802a11cbd9150461e5af1ae583a17a
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/threadpool/ThreadPoolUtil.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20916
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4094f70859802a11cbd9150461e5af1ae583a17a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: rest: use engine query for CPU caps parsing
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: rest: use engine query for CPU caps parsing
......................................................................
rest: use engine query for CPU caps parsing
Capabilities is parsing the engine's config value for CPU list which is
redundant as this is handled in GetAllServerCpuListQuery
Change-Id: I768f444f4ac6e5ee37ccba191d0588f00b8e3a44
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/ServerCpuParser.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilityResourceTest.java
D backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/util/ServerCpuParserTest.java
6 files changed, 14 insertions(+), 176 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I768f444f4ac6e5ee37ccba191d0588f00b8e3a44
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: core: rename methods in AsyncTaskManager to lowercase
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: rename methods in AsyncTaskManager to lowercase
......................................................................
core: rename methods in AsyncTaskManager to lowercase
Change-Id: If7a306df2d3eea086bf54c78dfc088ac0afff5ed
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandMultiAsyncTasks.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTasksStatusesByTasksIDsQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java
11 files changed, 36 insertions(+), 47 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20910
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If7a306df2d3eea086bf54c78dfc088ac0afff5ed
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: webadmin: Improve UI Plugin data reload logic
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Improve UI Plugin data reload logic
......................................................................
webadmin: Improve UI Plugin data reload logic
UI Plugin infra was designed to allow reloading plugin
meta-data and configuration without having to restart
Engine, i.e. refreshing WebAdmin in browser reloads the
plugin data automatically.
This patch improves existing data reload logic, comparing
cached data against (possibly missing) files, in addition
to comparing (possibly added or modified) files against
cached data.
Change-Id: Ibefec7f4a5748b89e762b88eafed044fab977d04
Bug-Url: https://bugzilla.redhat.com/996563
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/plugin/PluginDataManager.java
1 file changed, 47 insertions(+), 9 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20522
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibefec7f4a5748b89e762b88eafed044fab977d04
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: core: RemoveVm - fill quota release parameters when needed
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: RemoveVm - fill quota release parameters when needed
......................................................................
core: RemoveVm - fill quota release parameters when needed
*If the vm disks aren't going to be removed, there's no need to create
quota release parameters.
*The vm snapshots should be filled only once and not on every iteration.
*The operation should be done for the disks that would be removed only.
Change-Id: I666091dbc64b03b9cf19b76f26a4afb8100b8373
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026083
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20898
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I666091dbc64b03b9cf19b76f26a4afb8100b8373
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: core: snapshot disks should be part of the vm disk map only.
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: snapshot disks should be part of the vm disk map only.
......................................................................
core: snapshot disks should be part of the vm disk map only.
*Currently the vm populated DiskList should contain only it's actual
image disks.
The vm attached snapshot disks should be treated as LUN/shareable
disks.
Regardless to this change, it needs to be inspected if we want to
perform the filtering of the disks when loading it from the db or by
using ImagesHandler.filterImageDisks, as currently in many flows the
filtering is done although VM.getDiskList() contains only the needed
disks - therefore in this change I fixed only this part.
*When filtering the vm disks/devices - LUN disks should be filtered out
as well.
Change-Id: I5d18e5d3e321b871f4c7c283c8950fa7645eed5c
Related to Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=922475
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java
3 files changed, 15 insertions(+), 13 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20897
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d18e5d3e321b871f4c7c283c8950fa7645eed5c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-hosted-engine-ha[master]: broker, agent: more robust service startup/shutdown
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: broker, agent: more robust service startup/shutdown
......................................................................
broker, agent: more robust service startup/shutdown
The agent and broker had no ordering, and there was no way for an
external program to reliably tell when the broker was ready to
serve requests.
With this change:
- The agent and broker services gain an ordering dependency between
them in systemd.
- The broker attempts to clean its socket file upon exit, so that the
existence of the file generally indicates that the broker is ready
to serve requests.
- The agent will be more patient in attempting to connect to the broker.
Change-Id: I392ddf54503d7b9ef3448d22385b547222c0cc86
Bug-Url: https://bugzilla.redhat.com/1018829
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M initscripts/ovirt-ha-agent.init.in
M initscripts/ovirt-ha-agent.service
M ovirt_hosted_engine_ha/agent/constants.py.in
M ovirt_hosted_engine_ha/agent/hosted_engine.py
M ovirt_hosted_engine_ha/broker/broker.py
M ovirt_hosted_engine_ha/broker/listener.py
M ovirt_hosted_engine_ha/lib/brokerlink.py
7 files changed, 48 insertions(+), 8 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I392ddf54503d7b9ef3448d22385b547222c0cc86
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-reports[master]: packaging: setup: fix prompting the admin password
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: fix prompting the admin password
......................................................................
packaging: setup: fix prompting the admin password
Change-Id: I1563ed5d83ac6656fa9e9f7aadc39a369a1ec608
Bug-Url: https://bugzilla.redhat.com/1026093
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/ovirt-engine-reports-setup.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20835
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1563ed5d83ac6656fa9e9f7aadc39a369a1ec608
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 6 months