Change in ovirt-engine[master]: packaging: add timestamps to engine-db-install logs
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: add timestamps to engine-db-install logs
......................................................................
packaging: add timestamps to engine-db-install logs
Added new function logmsg that add a timestamp to the message that
will be logged.
Refactored the code for using logmsg for writing log messages.
Change-Id: I2ed2bfd889da31ee4626365653d9ea2dee37fd9f
Bug-Url: https://bugzilla.redhat.com/885611
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M backend/manager/dbscripts/engine-db-install.sh
1 file changed, 30 insertions(+), 22 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12238
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ed2bfd889da31ee4626365653d9ea2dee37fd9f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: packaging: changed psql parser in engine-upgrade.getCompensa...
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: changed psql parser in engine-upgrade.getCompensations
......................................................................
packaging: changed psql parser in engine-upgrade.getCompensations
In engine-upgrade getCompensations previously parsed the output
of psql searching for "0 rows" as flag for "no records found" and
failed on locale like Italian where it is "0 righe".
It also avoid to do the wrong thing if it contains a string like
"10 rows".
Now the parser doesn't rely on a localized string for detecting an
empty set.
Change-Id: I397d609fce6826e02b0f409e81228fe7d9d7be0a
Bug-Url: https://bugzilla.redhat.com/912426
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M packaging/fedora/setup/engine-upgrade.py
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I397d609fce6826e02b0f409e81228fe7d9d7be0a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: packaging: allow importing ISO domain on setup, exports.d su...
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: allow importing ISO domain on setup, exports.d support
......................................................................
packaging: allow importing ISO domain on setup, exports.d support
moved the private function engine_validators._isPathInExportFs
to common_utils.isPathInExportFs and made it public.
isPathInExportFs previously redefined the built-in file,
I've fixed it.
engine_validators.validateMountPoint now accept an existing ISO
domain as a valid path even if it's already exported allowing the
user to re-import it.
engine-setup._configNfsShare need to add the ISO domain path to
/etc/exports only if it is not already there.
If /etc/exports.d exists, then
/etc/exports.d/ovirt-engine-iso-domain.exports
will be used instead of /etc/exports and in this case
existing configuration will be migrated to
/etc/exports.d/ovirt-engine-iso-domain.exports as well.
engine-setup._configNfsShare generate a new uuid and create a new
domain only if it doesn't already exists in the supplied domain path.
nfsutils.cleanNfsExports refactored taking advantage of the new
private method _updateNfsExports.
engine-cleanup: add support for /etc/exports.d
Change-Id: I3a4343f8374e6439b0ee0a14fff233a0d4a0d5a3
Bug-Url: https://bugzilla.redhat.com/904149
Bug-Url: https://bugzilla.redhat.com/907899
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/common_utils.py
M packaging/fedora/setup/engine-cleanup.py
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/setup/engine_validators.py
M packaging/fedora/setup/nfsutils.py
6 files changed, 135 insertions(+), 37 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a4343f8374e6439b0ee0a14fff233a0d4a0d5a3
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Send Bonded Network with bonding
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Send Bonded Network with bonding
......................................................................
core: Send Bonded Network with bonding
This patch locates the underlying interface
that the changed network is defined on and sends
bonding type instead of nic, if the interface is a bond.
In case we changed from a vlan network over a bond to a non-vlan
network over a bond, we need to look up the interface
using the interface name after stripping the vlan off
of it. This may be the case even if the target network
is not a vlan, since the source network was a vlan network.
Change-Id: Ifa48513b89ba7a972826d31d7fc65ee5898d5741
Bug-Url: https://bugzilla.redhat.com/909678
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12060
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa48513b89ba7a972826d31d7fc65ee5898d5741
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Refactor SetupNetworksVdsCommand
by msalem＠redhat.com
Muli Salem has submitted this change and it was merged.
Change subject: core: Refactor SetupNetworksVdsCommand
......................................................................
core: Refactor SetupNetworksVdsCommand
This patch refactors the block of code that
generate networks that were modified. for sending to Vdsm.
Change-Id: Ic12d9c601dad77f77808bbec46271ea675509530
Bug-Url: https://bugzilla.redhat.com/909678
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
1 file changed, 33 insertions(+), 29 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic12d9c601dad77f77808bbec46271ea675509530
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: packaging: Updated the skipTests instruction for mvn build
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Updated the skipTests instruction for mvn build
......................................................................
packaging: Updated the skipTests instruction for mvn build
Replaced maven.test.skip=true in rpm-quick make target with the
more correct skipTests=true.
Change-Id: If506bcdedb064a10675f5f838e75d17e9c0cdcd4
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12275
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If506bcdedb064a10675f5f838e75d17e9c0cdcd4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 10 months
Change in ovirt-engine-sdk-java[master]: sdk: regenerate against the latest api
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: regenerate against the latest api
......................................................................
sdk: regenerate against the latest api
- to cluster added tunnel_migration property
- to DataCenter added Clusters sub-collection
- to root collection resource Disk added Permissions sub-collectio
- to root collection resource Disk added Statistic sub-collection
- host can be attached to cluster now either by id or name
- to StorageDomainTemplate added Disks sub-collection
- to StorageDomainVM added Disks sub-collection
- to template.display added keyboard_layout property
- to template added tunnel_migration property
- to vm.display added keyboard_layout property
- to vm added tunnel_migration property
- to VMSnapshot added preview method
- to VMSnapshot added undo method
- to VMSnapshot added commit method
Change-Id: Ic645cc6fe5eecd5a8529e842049f696f2acc6f70
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ApiTemplate
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/Api.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Cluster.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Clusters.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenter.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterCluster.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolume.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumeGlusterBrick.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumeGlusterBricks.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumes.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterNetwork.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterNetworks.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterPermission.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterPermissions.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusters.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskPermissions.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DiskStatistics.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Host.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplate.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplateDisk.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainTemplateDisks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVM.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVMDisk.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVMDisks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Template.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Templates.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMSnapshot.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Cluster.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Display.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Template.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VM.java
34 files changed, 3,835 insertions(+), 1,273 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic645cc6fe5eecd5a8529e842049f696f2acc6f70
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 10 months
Change in ovirt-engine-sdk-java[master]: codegen: refactor ApiTemplate to comply with latest changes
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: refactor ApiTemplate to comply with latest changes
......................................................................
codegen: refactor ApiTemplate to comply with latest changes
Change-Id: I56fb14080f4b00accfc03e044fba3f7bf04a9f4d
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ApiTemplate
1 file changed, 66 insertions(+), 83 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56fb14080f4b00accfc03e044fba3f7bf04a9f4d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: packaging: updated executing backupDB function
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: updated executing backupDB function
......................................................................
packaging: updated executing backupDB function
Calling backupDB function from the setup flow
was incorrect. This patch fixes that behavior
by supplying named parameters to the function
and making sure that all the parameters are
correct.
Change-Id: Icef79b53992210c547af13deffd57039fa43e9b0
Bug-Url: https://bugzilla.redhat.com/913176
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/fedora/setup/engine-setup.py
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12236
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icef79b53992210c547af13deffd57039fa43e9b0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: webadmin: cleanup volume and brick models
by sanjal＠redhat.com
Shireesh Anjal has submitted this change and it was merged.
Change subject: webadmin: cleanup volume and brick models
......................................................................
webadmin: cleanup volume and brick models
Removed the unnecessary fully qualified class names for
ArrayList.
Change-Id: I909176fa63a6282758304016e53b9f0b6397ed90
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
2 files changed, 8 insertions(+), 9 deletions(-)
Approvals:
Shireesh Anjal: Looks good to me, approved
Kanagaraj M: Verified
--
To view, visit http://gerrit.ovirt.org/12243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I909176fa63a6282758304016e53b9f0b6397ed90
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 10 months