Change in ovirt-engine[master]: webadmin: passing back fingerprint while updating host
by sanjal＠redhat.com
Shireesh Anjal has submitted this change and it was merged.
Change subject: webadmin: passing back fingerprint while updating host
......................................................................
webadmin: passing back fingerprint while updating host
While importing the hosts from a gluster cluster,
the hosts are saved along with their sshKeyFingerprint.
While updating the details of the hosts, the sshKeyFingerprint
will be passed back to the backend as it is. If it is not
passed, then backend thinks that the user is trying to update the
sshFingerprint with null and returns an update error to frontend.
Change-Id: I9e73b8bbbf5e7f2281f7a192a0157c2cc395dfc5
Bug-Url: https://bugzilla.redhat.com/888247
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Shireesh Anjal: Looks good to me, approved
Kanagaraj M: Verified
--
To view, visit http://gerrit.ovirt.org/12234
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e73b8bbbf5e7f2281f7a192a0157c2cc395dfc5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: restapi: Rx and Tx should be displayed as BYTES_PER_SECOND
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: restapi: Rx and Tx should be displayed as BYTES_PER_SECOND
......................................................................
restapi: Rx and Tx should be displayed as BYTES_PER_SECOND
The rx and tx are reported and displayed in the rest as percent of the
speed. It should be converted and displayed as BYTES_PER_SECOND.
Change-Id: Icb004ae50c00acbcb7aeb53fb3962028e6966fbc
Bug-Url: https://bugzilla.redhat.com/887230
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/HostNicStatisticalQuery.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/NicStatisticalQuery.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/RxTxCalculator.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNicsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendSubResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResourceTest.java
8 files changed, 58 insertions(+), 24 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12164
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb004ae50c00acbcb7aeb53fb3962028e6966fbc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 7 months
Change in ovirt-reports[master]: reports: fixed period list order (#913084)
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: fixed period list order (#913084)
......................................................................
reports: fixed period list order (#913084)
https://bugzilla.redhat.com/913084
Change-Id: Ic8d19f7126535bffa4d7874054cb0b56eaf3cade
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/P_Period.xml
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12270
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8d19f7126535bffa4d7874054cb0b56eaf3cade
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: tools : taskcleaner.sh utility returns always 0 as return co...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools : taskcleaner.sh utility returns always 0 as return code
......................................................................
tools : taskcleaner.sh utility returns always 0 as return code
taskcleaner.sh always returns exit code of 0 even on failure
Change-Id: If0c61616e0c4962ee141baba7eda40341d4f721b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=910796
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/tools/dbutils/taskcleaner.sh
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12103
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0c61616e0c4962ee141baba7eda40341d4f721b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: engine: Adding support for lock to survive restart
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Adding support for lock to survive restart
......................................................................
engine: Adding support for lock to survive restart
The following patch will add the following functionality:
1. Introduced annotation parameter which should add a possibility not to relase in memory lock
in the end of execute
2. By using this parameter we are enforcing command to release a lock only after that all
child commands are finished
3. Added code which should solve restart problem - added acquireLockAsyncTask method
Change-Id: I8c73dac12f6f56ce92a16f94d3b49e0795ab2e46
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LockIdNameAttribute.java
5 files changed, 74 insertions(+), 14 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11976
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c73dac12f6f56ce92a16f94d3b49e0795ab2e46
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: restapi : malformated guid's cause http 500 (#902242)
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi : malformated guid's cause http 500 (#902242)
......................................................................
restapi : malformated guid's cause http 500 (#902242)
When malformed Guids are passed in post data for action
the backend throws an internal error.
This patch moves MalformedIdException to restapi-types and
throws the exception if any invalid guids are passed.
Change-Id: Iebce833327654e1635632fb4a00ca8a3cf14fab5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=902242
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/MalformedIdExceptionMapper.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DataCenterMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/MappingLocator.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermissionMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QuotaMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ReportedDeviceMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/RoleMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TagMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/GuidUtils.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/MalformedIdException.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java
23 files changed, 95 insertions(+), 70 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11758
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebce833327654e1635632fb4a00ca8a3cf14fab5
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: core: Remove unused variables and methods
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove unused variables and methods
......................................................................
core: Remove unused variables and methods
Remove unused variables and methods in several commands
Change-Id: Icdd3fe989a1aa8e257daee634478e4f188d2d3f3
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
4 files changed, 0 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12233
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icdd3fe989a1aa8e257daee634478e4f188d2d3f3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 7 months
Change in ovirt-engine-sdk-java[master]: sdk: implement shutdown() to deallocate system resources
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: implement shutdown() to deallocate system resources
......................................................................
sdk: implement shutdown() to deallocate system resources
Change-Id: I2e8f28979e454d6373507c3095c09dc600a27b24
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/Api.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPool.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPoolBuilder.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxy.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxyBroker.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/IdleConnectionMonitorThread.java
6 files changed, 59 insertions(+), 10 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12232
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e8f28979e454d6373507c3095c09dc600a27b24
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: core: Create artifact for PostgreSQL module
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Create artifact for PostgreSQL module
......................................................................
core: Create artifact for PostgreSQL module
Currently we are deploying the PostgreSQL module using the "setup"
profile, but we don't have an artifact for the required module. This
patch reuses the module description that we had and uses it to build a
new "dependencies" artifact that can then be easily installed.
Change-Id: Iad7ee2264fde3badf7d242fe3a20874e1d24d6bf
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
A backend/manager/dependencies/pom.xml
R backend/manager/dependencies/src/main/modules/org/postgresql/main/module.xml
M backend/manager/pom.xml
M ear/pom.xml
M packaging/fedora/spec/ovirt-engine.spec.in
6 files changed, 68 insertions(+), 36 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11685
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad7ee2264fde3badf7d242fe3a20874e1d24d6bf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: core: Maven plugin to generate JBoss modules
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Maven plugin to generate JBoss modules
......................................................................
core: Maven plugin to generate JBoss modules
This change introduces a new maven plugin that generates .zip files
containing JBoss modules and attaches them as artifacts.
Change-Id: Ie9f3eb59fd67d4ce97f3e2802e7058fa76feb4eb
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A build-tools-root/jboss-modules-maven-plugin/pom.xml
A build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/Module.java
A build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/ModulesMojo.java
M build-tools-root/pom.xml
M pom.xml
5 files changed, 373 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9f3eb59fd67d4ce97f3e2802e7058fa76feb4eb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 7 months