Change in ovirt-engine-sdk[sdk_3.2]: sdk: prepare for the next development iteration
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: prepare for the next development iteration
......................................................................
sdk: prepare for the next development iteration
Change-Id: Ib10f20628e1c010e7f3da63bafbdb0bf198e5026
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M setup.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12221
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib10f20628e1c010e7f3da63bafbdb0bf198e5026
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.2
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: Move fkvalidator.sh to tools/dbutils
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: Move fkvalidator.sh to tools/dbutils
......................................................................
Move fkvalidator.sh to tools/dbutils
Moving the fkvalidator.sh script to tools/dbutils and make it stand
alone.
Also, defined common settings for dbutils in common.sh to be used by all
scripts.
Change-Id: I313a7066a7e7a70c8e97d3b13099d5f5695c33a5
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=912305
---
M backend/manager/dbscripts/dbfunctions.sh
R backend/manager/tools/dbutils/fkvalidator.sh
M backend/manager/tools/dbutils/taskcleaner.sh
3 files changed, 13 insertions(+), 17 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12172
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I313a7066a7e7a70c8e97d3b13099d5f5695c33a5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: packaging: Fix text aligned not properly for long strings.
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Fix text aligned not properly for long strings.
......................................................................
packaging: Fix text aligned not properly for long strings.
During the upgrade process we display the stages of of upgrade.
When strings are longer than 70 chars the text doesn't align
correctly. This patch fixes the issue by taking into cosideration
only the last part of a multiline string.
Bug-Url: https://bugzilla.redhat.com/882689
Change-Id: Id242e8a247ae720b3aeb37f40004241dfc3920de
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/fedora/setup/engine-upgrade.py
1 file changed, 17 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12194
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id242e8a247ae720b3aeb37f40004241dfc3920de
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: tools: Don't send events on startup
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: Don't send events on startup
......................................................................
tools: Don't send events on startup
Currently the event notifier sends all the pending events during
startup. This can flood the recipients and it is not very useful as old
events are not valuable. This patch adds a new DAYS_TO_SEND_ON_STARTUP
parameter to the notifier. The value of this parameter is the number of
days of old audit log messages that will be sent during startup.
Messages older than that will be marked as processed and not sent.
Change-Id: Id1b8044533d29fa69585a157d3f8409c81a437cd
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/tools/src/main/conf/engine-notifier.conf
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
3 files changed, 89 insertions(+), 26 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11483
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1b8044533d29fa69585a157d3f8409c81a437cd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Fix dao tests not to print lookup error
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix dao tests not to print lookup error
......................................................................
core: Fix dao tests not to print lookup error
Although this does not break tests, seeing an exception
when running the first test in a bunch of tests is not something nice.
This patch solve this by introducing an EJBUtilsStrategy that uses the
createDataSource static method to "lookup" the dataSource, and set it
before DbFacadadeLocator.getDbFacade is called.
Change-Id: I9f37acaea5c21463c4e126799524a3c41b6071a3
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java
1 file changed, 10 insertions(+), 3 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f37acaea5c21463c4e126799524a3c41b6071a3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Changes to MockEJBStrategyRule
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Changes to MockEJBStrategyRule
......................................................................
core: Changes to MockEJBStrategyRule
The following patch introduces the following changes:
1. Gives the ability to allow to mock a managed resource, not just a bean
2. mockBean should actually use Mocikto to define the actual mock using when..thenReturn as
the "startingMethod" was not aware to that bean when it was called
Change-Id: Ia23cbe33abe5a080cd599c6af468e3ce728c190a
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MockEJBStrategyRule.java
1 file changed, 24 insertions(+), 2 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12186
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia23cbe33abe5a080cd599c6af468e3ce728c190a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: packaging: Updated getEngineVersion functionality
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Updated getEngineVersion functionality
......................................................................
packaging: Updated getEngineVersion functionality
If we use the getEngineVersion code on upgrades from
versions where the version file does not exist, we will
experience an error with opening the version file.
This patch tries to solve it by checking the presence of
the version file. If the file doesn't exist it will use
the getRpmVersion function to fetch the real version of
the engine package from the rpm.
Change-Id: I57c62cf64d0c44f824a8ec5071f2ef50ec97854e
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/fedora/setup/common_utils.py
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12211
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57c62cf64d0c44f824a8ec5071f2ef50ec97854e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: engine: add qouta mode check in consume storage
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: engine: add qouta mode check in consume storage
......................................................................
engine: add qouta mode check in consume storage
Problem: When qouta mode is set to audit, error "no qouta" on storage
was returned
Solution: In checkConsumptionForSpecificStorageQuota we did not make
sure that qouta was set to enforce before returning an error.
Change-Id: I21cc59098ede7044ebde1d544e295300d8b40cb7
Bug-Url: https://bugzilla.redhat.com/906485
Signed-off-by: Noam Slomianko <nslomian(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12049
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21cc59098ede7044ebde1d544e295300d8b40cb7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: userportal : Events sorting - oldest first
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: userportal : Events sorting - oldest first
......................................................................
userportal : Events sorting - oldest first
Incorrect sorting of events in user portal.
The events are not sorted in any particular order
resulting in newer events being displayed after
older ones.
Change-Id: I93eeae05af9d07ad1fea0f3ee9c0dee9c8023f81
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=907421
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Ravi Nori: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12181
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93eeae05af9d07ad1fea0f3ee9c0dee9c8023f81
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: webadmin: Change move to quota enforcing mode message
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: webadmin: Change move to quota enforcing mode message
......................................................................
webadmin: Change move to quota enforcing mode message
The message presented when moving the DC into enforcing quota mode was
rephrased.
Change-Id: Ie24d00f6523d4600962820ff2b88ed4eaf60443f
Bug-Url: https://bugzilla.redhat.com/903684
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie24d00f6523d4600962820ff2b88ed4eaf60443f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 10 months