February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: TimeoutBase: Prevent updating mutable Date
by amureini＠redhat.com 13 Feb '13

13 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: TimeoutBase: Prevent updating mutable Date ...................................................................... core: TimeoutBase: Prevent updating mutable Date TimeoutBase contains a java.util.Date member, mEndTime. The value of this member can be passed into (by setEndTime(Date)) and out of (by getEndTime()) the class. Since java.util.Date is a mutable class, the end time of the TimeoutBase may be manipulated, maliciously or mistakenly, by someone holding a reference to that object. This patch removes this vulnerability by replacing this member by a simple primitive long, representing the unix time (System.currTimeMillis()), since the Date semantics (e.g., DST) isn't used anyway. Change-Id: Icd77e518369fa25bfe684d249d12e0f8e2bb1a0f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBaseTest.java 3 files changed, 12 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd77e518369fa25bfe684d249d12e0f8e2bb1a0f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: validation for "Use Host CPU" setting
by lhornyak＠redhat.com 13 Feb '13

13 Feb '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: webadmin: validation for "Use Host CPU" setting ...................................................................... webadmin: validation for "Use Host CPU" setting To enable CPU Host, one of the two no-migrate flags for a VM (run on selected host, or allow migration only upon admin request) must be enabled. If CPU Host was disabled along with the no-migrate flag in the same save action, the new CPU Host value was not propagated to the VM object which caused a validation error. This patch propagates the CPU Host value to the VM object, allowing the CPU Host flag and no-migrate flag to be disabled in the same edit. Change-Id: I786a725f6ff20e64d2d094b4c8c183c907978229 Bug-Url: https://bugzilla.redhat.com/905843 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I786a725f6ff20e64d2d094b4c8c183c907978229 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : Add Role with wrong permit id leads to 500 error(#...
by mpastern＠redhat.com 13 Feb '13

13 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Add Role with wrong permit id leads to 500 error(#908392) ...................................................................... restapi : Add Role with wrong permit id leads to 500 error(#908392) Add Role with wrong permit id leads to internal server error. This patch returns a proper error message when the permit id is invalid. Change-Id: I9adfda37e67d24f96933aa4eb8f79a8fdb416d62 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908392 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendRolesResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java 2 files changed, 30 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/11931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9adfda37e67d24f96933aa4eb8f79a8fdb416d62 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removing harmfull code from persitance of task to DB
by mkublin＠redhat.com 13 Feb '13

13 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing harmfull code from persitance of task to DB ...................................................................... engine: Removing harmfull code from persitance of task to DB The following code which is removed is useless, because of json serializer will not serialize parentParameters because of it is transient, but during setting them to null we can create a race which will destroy a correct value, in case if command triggered couple parallel tasks Change-Id: Ib64fd00c207eaab51585dca5634cfb15f3b83820 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib64fd00c207eaab51585dca5634cfb15f3b83820 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Added infrastructure for providing a canDoactions in...
by mkublin＠redhat.com 13 Feb '13

13 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Added infrastructure for providing a canDoactions in case of locks ...................................................................... engine: Added infrastructure for providing a canDoactions in case of locks The following patch is introducing an infrastracture for providing a more convinient messages in case of using lock util. What is done: from now it is possible to pass appropriate message for every acquired lock. What is not done: I did not change a generic message, so it still will be VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED, but I provide an easy way to change it Change-Id: I87698da36ddb6e7556e98612d299da68f2eb53dc Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LockMessagesMatchUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lock/InMemoryLockManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ForceRemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lock/InMemoryLockManagerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/EngineLock.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/LockManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 48 files changed, 359 insertions(+), 229 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87698da36ddb6e7556e98612d299da68f2eb53dc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: changed pom's repositories
by ydary＠redhat.com 13 Feb '13

13 Feb '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: changed pom's repositories ...................................................................... reports: changed pom's repositories Change-Id: I483f5ac06af2abd47845fd0980bab6e90a7ae8d3 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/jars/CustomOvirtReportsQueryManipulator/pom.xml M reports/jars/EngineAuthentication/pom.xml 2 files changed, 45 insertions(+), 28 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I483f5ac06af2abd47845fd0980bab6e90a7ae8d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: When updating entity name the event...
by masayag＠redhat.com 13 Feb '13

13 Feb '13

Moti Asayag has submitted this change and it was merged. Change subject: core: When updating entity name the event... ...................................................................... core: When updating entity name the event... When updating entity name the event message should contain the former entity name. This patch adds a event log message when an entity is renamed so the proceeding log message on the entity update that uses the new name is clear. This is done by introducing a RenamedEntityInfoProvider interface that all relevant Update*Command are implementing. The interface forces those commands to state the affected entity name, the old entity name, the new entity name and to set the relevant object ID such that the relevant event will be shown when the entity is selected in the UI. The CommandBase is checking for each command if it implements the RenamedEntityInfoProvider interface and checks if the entity was renamed. If it founds that the entity was renamed, a proper message is written to the audit log. Change-Id: I17f0049ca0ffb1a3868ba404b112a8c10ee7778e Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RenamedEntityInfoProvider.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 13 files changed, 233 insertions(+), 13 deletions(-) Approvals: Eli Mesika: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17f0049ca0ffb1a3868ba404b112a8c10ee7778e Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: remove empty else branch from DbFacade
by lhornyak＠redhat.com 13 Feb '13

13 Feb '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: remove empty else branch from DbFacade ...................................................................... engine: remove empty else branch from DbFacade The else branch was for hibernate. Change-Id: I87e1628814f7cdd2a725bcef92f5d1639f957e70 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87e1628814f7cdd2a725bcef92f5d1639f957e70 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: tools: add the nossl option for the engine connection
by oschreib＠redhat.com 13 Feb '13

13 Feb '13

Ofer Schreiber has submitted this change and it was merged. Change subject: tools: add the nossl option for the engine connection ...................................................................... tools: add the nossl option for the engine connection Change-Id: I84dcfe472006add3e0a7ba42661ea9d1cee85f8c Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M src/__main__.py 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Federico Simoncelli: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84dcfe472006add3e0a7ba42661ea9d1cee85f8c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Allow Removal of Network on Host from DC
by msalem＠redhat.com 13 Feb '13

13 Feb '13

Muli Salem has submitted this change and it was merged. Change subject: core: Allow Removal of Network on Host from DC ...................................................................... core: Allow Removal of Network on Host from DC This patch removes the canDoAction that checks whether a network that is being removed from a data center is used by one of its hosts. This creates uniform behaviour, since detaching a network from a cluster that has a host that uses the network is allowed. Change-Id: Ie66fc9ee6ebbc9a907bca4b1925bffaaeb111725 Bug-Url: https://bugzilla.redhat.com/909820 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11968 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie66fc9ee6ebbc9a907bca4b1925bffaaeb111725 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0