February 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: Remove the Helper class

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove the Helper class ...................................................................... core: Remove the Helper class org.ovirt.engine.core.utils.Helper had only one method, ToList, which was, in fact, just creating a new ArrayList around a given iterable. This patch removes this useless class, and just calls ArrayList's constructor instead. Change-Id: I2563766d08aeece478ac7659103f26f19b90deb3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Helper.java 2 files changed, 3 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2563766d08aeece478ac7659103f26f19b90deb3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: remove read lock of template while creating VM from it

by mkublin＠redhat.com

Michael Kublin has submitted this change and it was merged. Change subject: core: remove read lock of template while creating VM from it ...................................................................... core: remove read lock of template while creating VM from it This patch is using the new mechanism that let us run commands without release their lock at the end of the sync execution part, in order to remove the unnecessary read lock of template while we create VM that is based on this template. so with this patch, it is now possible to create multiple VMs that are based on the same template with preallocated disks in parallel, which wasn't possible before. The AddVmFromTemplate command was modified in such a way that it won't lock the template in the DB. instead, we take a shared-lock for the whole execution process (sync + async, until the command is finished). The call to "freeLock" in AddVmCommand#executeVmCommand was also removed, so that the shared lock would not be released. it seems that this call was not required for the AddVmCommand (because it is set to release the lock at the end of this method anyway) and not for the commands that inherit it. Change-Id: If1b74347110c468b90e75b4dc6470595576f94f4 Bug-Url: https://bugzilla.redhat.com/815642 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java 2 files changed, 3 insertions(+), 17 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1b74347110c468b90e75b4dc6470595576f94f4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-reports[master]: reports: made tooltip clearer in ccp report (#913081)

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: reports: made tooltip clearer in ccp report (#913081) ...................................................................... reports: made tooltip clearer in ccp report (#913081) uptime and existence now have tooltip in the format: 'DDd HHh MMm' (upper case letters is the actual data) Bug-Url: https://bugzilla.redhat.com/913081 Change-Id: I3505c6c3c0d8e6dc353d07007bb197a30890c0c3 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/Inventory/ccp_vm_inventory_br44_files/ccp_vm_inventory_br44_jrxml.data 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3505c6c3c0d8e6dc353d07007bb197a30890c0c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Upgrade maven-checkstyle-plugin to 2.9.1

by dfediuck＠redhat.com

Doron Fediuck has submitted this change and it was merged. Change subject: core: Upgrade maven-checkstyle-plugin to 2.9.1 ...................................................................... core: Upgrade maven-checkstyle-plugin to 2.9.1 Upgraded maven-checkstyle-plugin to 2.9.1 in order to facilitate a future move to Java 7. This version of maven-checkstyle-plugin requires a higher version of checkstyle, so it was upgraded too, to 5.4. Change-Id: Icccfb347a27ed0f2ff9a706d42b31f6a9d102fce Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/ovirt-checkstyle-extension/pom.xml M pom.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icccfb347a27ed0f2ff9a706d42b31f6a9d102fce Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Small code improvement at VdsEventListener.vdsUpEven...

by mkublin＠redhat.com

Michael Kublin has submitted this change and it was merged. Change subject: engine: Small code improvement at VdsEventListener.vdsUpEvent ...................................................................... engine: Small code improvement at VdsEventListener.vdsUpEvent No reason to create a MultipleActionRunner when there are no vms Change-Id: I66e1db82357a0b0cfc3260dc6aaf27ae51d3b803 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 20 insertions(+), 15 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66e1db82357a0b0cfc3260dc6aaf27ae51d3b803 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Removing compensation code from ActivateVds

by mkublin＠redhat.com

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing compensation code from ActivateVds ...................................................................... engine: Removing compensation code from ActivateVds No need for that code, so removing it. At any case status will be updated during monitoring no need to revert it Change-Id: I3b265fad5ce0399265482cd5b44ff6a579008115 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11923 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b265fad5ce0399265482cd5b44ff6a579008115 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Removed un needed calls to DB at VdsManager

by mkublin＠redhat.com

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removed un needed calls to DB at VdsManager ...................................................................... engine: Removed un needed calls to DB at VdsManager The following patch is removing un needed queries to db, such query was retrieving VdsGroup from db. Reason: no reason, one time is enough. Change-Id: I8f6b3c214d0b5606b6bff3261d9a0ea6ed36a124 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java 3 files changed, 5 insertions(+), 15 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f6b3c214d0b5606b6bff3261d9a0ea6ed36a124 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Correct error message on diskless VM run

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Correct error message on diskless VM run ...................................................................... engine: Correct error message on diskless VM run Display correct error message when a diskless VM is run on a cluster with no valid hosts instead of Internal Engine Error. VmRunHandler.canRunVm now checks if there are available hosts in the cluster even if the VM has no disks. Change-Id: I8b346b341cbe3a84b32dff32d14b12aa80c17881 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908397 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java 1 file changed, 13 insertions(+), 13 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b346b341cbe3a84b32dff32d14b12aa80c17881 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix quota release for Remove-Template

by dfediuck＠redhat.com

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix quota release for Remove-Template ...................................................................... core: Fix quota release for Remove-Template Quota resources are not released when deleting a template. This happened because the template disk list was not initialized before the quota consumption parameters check. Added initialization of the list when before quota consumption parameters check. Change-Id: Iaf9326bfb81df2cdf1132f693d30014056df5d66 Bug-Url: https://bugzilla.redhat.com/913452 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf9326bfb81df2cdf1132f693d30014056df5d66 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Don't let quartz call home for updates

by lhornyak＠redhat.com

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Don't let quartz call home for updates ...................................................................... core: Don't let quartz call home for updates The quartz scheduler connects to its web site to check for updates. We should disable that to avoid security issues. Change-Id: I8bc230bb8c370318285fefd6debc1c938a9be98f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/conf/standalone.xml M packaging/fedora/engine-service.xml.in 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bc230bb8c370318285fefd6debc1c938a9be98f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

11 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits February 2013