Change in ovirt-engine-sdk[sdk_3.2]: codegen: refactor rsdl/xsd codegen
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: refactor rsdl/xsd codegen
......................................................................
codegen: refactor rsdl/xsd codegen
Change-Id: I6a885eab0cefc58d9e8385d6a863c98bff2fd6a0
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
A src/codegen/common/__init__.py
A src/codegen/common/icodegen.py
M src/codegen/main.py
A src/codegen/rsdl/__init__.py
A src/codegen/rsdl/abstractrsdlcodegen.py
A src/codegen/rsdl/rsdlcodegen.py
A src/codegen/utils/fileutils.py
A src/codegen/utils/stringutils.py
M src/codegen/utils/typeutil.py
A src/codegen/xsd/__init__.py
A src/codegen/xsd/abstractxsdcodegen.py
A src/codegen/xsd/xsdcodegen.py
M src/ovirtsdk/infrastructure/proxy.py
13 files changed, 983 insertions(+), 413 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12483
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a885eab0cefc58d9e8385d6a863c98bff2fd6a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.2
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 10 months
Change in ovirt-engine-sdk[sdk_3.2]: codegen: cleanup
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: cleanup
......................................................................
codegen: cleanup
Change-Id: I1d10588d325ad3b0249988a1252dbf529267b527
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/codegen/main.py
1 file changed, 87 insertions(+), 118 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d10588d325ad3b0249988a1252dbf529267b527
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.2
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 10 months
Change in ovirt-engine-sdk[sdk_3.2]: sdk: cleanup
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: cleanup
......................................................................
sdk: cleanup
Change-Id: I62a42b189f30505a5f68fe759b264c70c0094f11
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/codegen/entrypoint/entrypoint.py
M src/codegen/subcollection/subresource.py
M src/ovirtsdk/api.py
3 files changed, 17 insertions(+), 31 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12481
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62a42b189f30505a5f68fe759b264c70c0094f11
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.2
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 10 months
Change in ovirt-engine-sdk[sdk_3.2]: sdk: document errors
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: document errors
......................................................................
sdk: document errors
Change-Id: Ia6194cef427e7202a0bd77488efd3bb77fabe89e
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/codegen/entrypoint/entrypoint.py
M src/ovirtsdk/api.py
2 files changed, 35 insertions(+), 5 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12480
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6194cef427e7202a0bd77488efd3bb77fabe89e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.2
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: fix missing/extra fields in equals() methods
by lhornyak@redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: fix missing/extra fields in equals() methods
......................................................................
core: fix missing/extra fields in equals() methods
While refactoring businessentity equals() methods, some missing and
extraneous fields were discovered. Add/remove these fields as needed.
(The change to remove fields from VmPool.equals() was borrowed from
I17b92858345de398dbc89d9141468ccea67963fe.)
Change-Id: I7477f8ee854ca303d0f9de1ea405e1c77a99360d
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaStorage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaVdsGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java
4 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12456
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7477f8ee854ca303d0f9de1ea405e1c77a99360d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: packaging: changed tasks polling in engine-upgrade
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: changed tasks polling in engine-upgrade
......................................................................
packaging: changed tasks polling in engine-upgrade
Modified checkRunningTasks: during engine upgrade, sample the current
situation of asynchronous tasks and compensations and continue the
upgrade, exiting the check loop one second after there are no async
tasks or compensations left.
Currently the stopping of asynchronous tasks and compensations
could take 3 minutes so every ~3 minutes
(MAINTENANCE_TASKS_WAIT_PERIOD) if there are async tasks still around,
allows the user to retry or abort.
Other than that it doesn't change the behavior of the script.
Removed MAINTENANCE_TASKS_CYCLES since it's not used anymore.
Fixed a small typo in MSG_ERROR_FAILED_CONVERT_ENGINE_KEY.
Change-Id: I32eaeb2427fcc9c4566ca12bf547d49a308a8937
Bug-Url: https://bugzilla.redhat.com/877749
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M packaging/fedora/setup/engine-upgrade.py
1 file changed, 23 insertions(+), 12 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12177
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32eaeb2427fcc9c4566ca12bf547d49a308a8937
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: LSM - standardize version checks in CDA
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: LSM - standardize version checks in CDA
......................................................................
core: LSM - standardize version checks in CDA
Removed the canDoAction check that relies on the LiveMigrationEnabled
config value and used the standard action_version_map instead.
Change-Id: I3527c79ee77bc60c9ff7ca5030f3cd5f2ee28f39
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
A backend/manager/dbscripts/upgrade/03_02_0470_lsm_version_support.sql
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
8 files changed, 15 insertions(+), 53 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12375
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3527c79ee77bc60c9ff7ca5030f3cd5f2ee28f39
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: tools : Unable to add remote domain using engine-manage-doma...
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools : Unable to add remote domain using engine-manage-domains
......................................................................
tools : Unable to add remote domain using engine-manage-domains
When there is an error with engine config while adding a remote
domain the toll does not log the error to the log file.
This patch sets the default log level of engine config to DEBUG
instead of OFF. This write the debug messages to the log file
instead of supressing it.
Change-Id: I8457b778274acabaab30b27b0605b8600e338873
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=912736
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ravi Nori: Verified
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12428
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8457b778274acabaab30b27b0605b8600e338873
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: webadmin: fix IAE on run once dialog
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: webadmin: fix IAE on run once dialog
......................................................................
webadmin: fix IAE on run once dialog
This patch fixes IllegalArgumentException that was thrown when trying to
run-once a VM with no bootable device.
Before change http://gerrit.ovirt.org/#/c/11735 the boot sequence that
was generated when trying to run-once a VM was never empty - it always
contained at least the hard-disk (even for diskless VM).
After applying the change above, the returned boot sequence for a VM
with no bootable device is empty, and wrong handling of the empty
string that represents it results in IllegalArgumentException.
Change-Id: I42197615331c6b62f5978e1d4546298aee617db4
Bug-Url: https://bugzilla.redhat.com/885994
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java
3 files changed, 3 insertions(+), 7 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/12454
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42197615331c6b62f5978e1d4546298aee617db4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: packaging: Remove Module.resourcePath
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: packaging: Remove Module.resourcePath
......................................................................
packaging: Remove Module.resourcePath
The resourcePath member in Module is never initialized, and in fact,
there is no way to initialize it - i.e., it is always null.
This patch removes it and all references to it.
Change-Id: I1ca9f1a35ffc461311e61e649fdf1a1375ffd0a7
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/Module.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ca9f1a35ffc461311e61e649fdf1a1375ffd0a7
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months