April 2013 - Engine-commits - oVirt List Archives

Change in otopi[master]: dialog: human: accept empty note text
by Alon Bar-Lev 07 Apr '13

07 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: dialog: human: accept empty note text ...................................................................... dialog: human: accept empty note text Change-Id: I739d19094423e694b738ddb8c99eb13c7718fe85 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/otopi/dialog/human.py 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I739d19094423e694b738ddb8c99eb13c7718fe85 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: "dual mode" on vm with agent should be reported as "...
by alkaplan＠redhat.com 07 Apr '13

07 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: "dual mode" on vm with agent should be reported as "virtio" ...................................................................... engine: "dual mode" on vm with agent should be reported as "virtio" vnic with "dual mode" on vm with an agent should be reported to the vdsm as "virtio" only. Currently, there is a leftover code that prepares also an interface with "rtl8139" type. But does nothing with it. So there is not a real bug, just a code fix. Also, the vm.getHasAgent() returned false even if there is an agent on the vm. The cause of the bug is that the guest-agent-version was updated in the RunVmCommand.attachCd method only if there was an active ISO domain in the dc. In this patch the guest agent version update was moved to the runVm method to make sure the version is always updated when trying to run the vm. Change-Id: I072ee66172027d5b4bea1b0ff2f0033d69bf6111 Bug-Url: https://bugzilla.redhat.com/923889 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 2 files changed, 2 insertions(+), 9 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I072ee66172027d5b4bea1b0ff2f0033d69bf6111 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removing EvenlyDistributeVDComparer
by mkublin＠redhat.com 07 Apr '13

07 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing EvenlyDistributeVDComparer ...................................................................... engine: Removing EvenlyDistributeVDComparer The following class is not in use anymore Change-Id: I76739488192cf13bc5d6356f9feda6f452d6edf4 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EvenlyDistributeVDComparer.java 1 file changed, 0 insertions(+), 25 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76739488192cf13bc5d6356f9feda6f452d6edf4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: It is not possible add non-operational network to ...
by alkaplan＠redhat.com 07 Apr '13

07 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: It is not possible add non-operational network to vNic of vm. ...................................................................... webadmin: It is not possible add non-operational network to vNic of vm. Removed the if that avoided adding the non-operational networks to the network list. Change-Id: I6183a5abcddc343323b82c39111de9f2f1ba5166 Bug-Url: https://bugzilla.redhat.com/948160 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6183a5abcddc343323b82c39111de9f2f1ba5166 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : Add permit to role issues(#919202)
by mpastern＠redhat.com 07 Apr '13

07 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Add permit to role issues(#919202) ...................................................................... restapi : Add permit to role issues(#919202) When trying to add permit to role the permit name needs to accept both lower case and upper case names. Change-Id: I7ae176b9b6d60b4f8a51c16354ec6210f13870c9 Bug-Url: https://bugzilla.redhat.com/919202 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ae176b9b6d60b4f8a51c16354ec6210f13870c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Improving update of vds dynamic data - status
by mkublin＠redhat.com 07 Apr '13

07 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improving update of vds dynamic data - status ...................................................................... engine: Improving update of vds dynamic data - status Instead of updating all vds dynamic data we can update only its status Change-Id: I59c0c1c34c7c9ddcb481fda17decc91875eb1638 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 2 files changed, 4 insertions(+), 12 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59c0c1c34c7c9ddcb481fda17decc91875eb1638 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Imroving updates of vds dynamic
by mkublin＠redhat.com 07 Apr '13

07 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Imroving updates of vds dynamic ...................................................................... engine: Imroving updates of vds dynamic The following patch is removing call for UpdateVdsDynamicData command in order to update net_config_dirty field. The change is make a simple update instead of: 1. Run query for VdsDynamic 2. Acquire lock on VdsManager 3. Perform update Change-Id: Ic9e76b6ddd20ebd36a00d68b44da3a3a954ad87d Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/dbscripts/vds_sp.sql M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 5 files changed, 41 insertions(+), 8 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9e76b6ddd20ebd36a00d68b44da3a3a954ad87d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: "help add" fails to format the error when number of pro...
by mpastern＠redhat.com 07 Apr '13

07 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: "help add" fails to format the error when number of provided args in incorrect ...................................................................... cli: "help add" fails to format the error when number of provided args in incorrect 'help add' command for gluster-related entities like glustervolume and brick does not work. The following error is seen - (connected)]# help add glustervolume unknown error: not enough arguments for format string Change-Id: I48b8880078bb2f9c035b5325af60366bf1c94ae1 Bug-Url: https://bugzilla.redhat.com/922018 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/13565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48b8880078bb2f9c035b5325af60366bf1c94ae1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Improving GetAsyncTasksByStoragePoolId query
by mkublin＠redhat.com 07 Apr '13

07 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improving GetAsyncTasksByStoragePoolId query ...................................................................... engine: Improving GetAsyncTasksByStoragePoolId query The following patch will simplify a query, we don't need to make any join, access to async_tasks table is enough Change-Id: I295291a2ac84e021b7354a3fd072ba5534af533d Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/dbscripts/async_tasks_sp.sql M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java 2 files changed, 5 insertions(+), 6 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I295291a2ac84e021b7354a3fd072ba5534af533d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replacing call to host by query
by mkublin＠redhat.com 07 Apr '13

07 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Replacing call to host by query ...................................................................... engine: Replacing call to host by query The following patch should replace a call to host by query during moving host to maintenance. All task should be kept in Db so no need to perform an XML RPC call. Query to DB is much more efficient and faster. Change-Id: I1e864961ab05538bd565d74f31869f64aa40b758 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 3 files changed, 9 insertions(+), 32 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13616 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e864961ab05538bd565d74f31869f64aa40b758 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixing saveOrUpdate qmethod in AsyncTaskUtils
by mkublin＠redhat.com 07 Apr '13

07 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing saveOrUpdate qmethod in AsyncTaskUtils ...................................................................... engine: Fixing saveOrUpdate qmethod in AsyncTaskUtils The following patch should solve a bug, when async_task_entities table never filled. The bug was caused because of using a wrong API, so a fix is start to use a correct API and remove unused APIs Change-Id: I8874a4222ac17ecc4ca9de3fbccc18e16efe20c8 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java 3 files changed, 5 insertions(+), 32 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8874a4222ac17ecc4ca9de3fbccc18e16efe20c8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: provide activation.jar
by amureini＠redhat.com 07 Apr '13

07 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: packaging: provide activation.jar ...................................................................... packaging: provide activation.jar activation.jar is required by hibernate-validator, which causes maven to bring it as a transient dependency, even though it is part of the JDK. Explicitly adding it to the root pom.xml and marking it as provided (in a similar fashion to javax.transaction) makes sure it is not brought twice. Change-Id: If6bbed19bee01bcd76b15e709f50810b88aaa973 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M pom.xml 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6bbed19bee01bcd76b15e709f50810b88aaa973 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: fix NPE when trying to export not existing template
by ofrenkel＠redhat.com 07 Apr '13

07 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: fix NPE when trying to export not existing template ...................................................................... engine: fix NPE when trying to export not existing template The fix is all about checking whether the template exists before trying to get its storage pool id. This patch contains two other changes: 1. the description of the command moved from #canDoAction to the constructor which is a more appropriate place to initialize things. 2. add a check that the template exists as the first thing that is checked in #canDoAction(). this check is already made at MoveOrCopyTemplateCommand#canDoAction but it is taking place too late - we should address this issue but in a different patch in order to keep this one simple fix. Change-Id: I757672ec2f989f4dc1bc5403878c5cbee69f9cf0 Bug-Url: https://bugzilla.redhat.com/928365 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I757672ec2f989f4dc1bc5403878c5cbee69f9cf0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: searchbackend - sort VMs by host name
by derez＠redhat.com 07 Apr '13

07 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: core: searchbackend - sort VMs by host name ...................................................................... core: searchbackend - sort VMs by host name Adding support for sorting VMs by host name (using search - 'Vms: sortby host'. Change-Id: If556479a2a00868f803ef4639eef9dc9453592ff Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If556479a2a00868f803ef4639eef9dc9453592ff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: make storage type field non editable
by derez＠redhat.com 07 Apr '13

07 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: make storage type field non editable ...................................................................... webadmin: make storage type field non editable In edit dialog of storage domain make the "Domain Function / Storage Type" field not editable. It remains editable when adding a new storage domain. Change-Id: I7c6c3db97ca8a2d07ec7ec50b0765828b902e5a8 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c6c3db97ca8a2d07ec7ec50b0765828b902e5a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: AddVmFromSnapshot - avoid early end method run
by amureini＠redhat.com 07 Apr '13

07 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmFromSnapshot - avoid early end method run ...................................................................... core: AddVmFromSnapshot - avoid early end method run When adding vm as a clone of snapshot, the vm id should be set as the entity id for the child commands parameters - this prevent a situation in which the end method is called too early. NOTE: seems like the MoveOrCopyImageGroupParameters class might be re-factored so that in a case of given ContainerId, it will be set as the entity id - but that's not in the scope of this change. Change-Id: I7a536cb3c530fd9caa0b121830481604c0558d53 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a536cb3c530fd9caa0b121830481604c0558d53 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Events tab - Details dialog
by derez＠redhat.com 07 Apr '13

07 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Events tab - Details dialog ...................................................................... webadmin: Events tab - Details dialog Events tab: * Created a new dialog for showing event's details (ID, Time, Message). Event message is displayed in a text-area for easy copy-paste. * Added context menu 'Details' button (invoked on double-click) Change-Id: If9bccd2e8a692dd7f9745ed240de3ebd1b7ff376 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/AbstractModelBoundTableWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/EventModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/event/EventPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabEventPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/event/EventPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/event/EventPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java 13 files changed, 294 insertions(+), 32 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9bccd2e8a692dd7f9745ed240de3ebd1b7ff376 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: i18n refresh 'sec'
by derez＠redhat.com 05 Apr '13

05 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal, webadmin: i18n refresh 'sec' ...................................................................... userportal, webadmin: i18n refresh 'sec' - Fixed 'sec' not being i18ned on the refresh panel drop down. - Renamed MilisecondRenderer to MillisecondRenderer Change-Id: I0eadb1085e6b59239d1091d894de52ca3fc3e88a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=871354 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/BaseRefreshPanel.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/MilisecondRenderer.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/MillisecondRenderer.java 4 files changed, 43 insertions(+), 20 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eadb1085e6b59239d1091d894de52ca3fc3e88a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: provided cleared frontend logging
by ecohen＠redhat.com 05 Apr '13

05 Apr '13

Einav Cohen has submitted this change and it was merged. Change subject: core: provided cleared frontend logging ...................................................................... core: provided cleared frontend logging - Added code to display better debug messages for -- RunQuery -- RunPublicQuery -- RunMultipleQueries -- RunAction -- RunMultipleActions Change-Id: I845aa47da03168f1a0f988203df7ab0a51e94804 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=903312 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetConfigurationValueParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SearchParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java 5 files changed, 80 insertions(+), 3 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I845aa47da03168f1a0f988203df7ab0a51e94804 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Move scheduler to modules
by juan.hernandez＠redhat.com 05 Apr '13

05 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Move scheduler to modules ...................................................................... core: Move scheduler to modules The scheduler component used to be into a "beans" folder, but it is not different from other components, like "dal" or "bll", so it makes more sense to have it in the same folder. Change-Id: I291a87742ddb2d536bd0d11f54515ac531b69659 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D backend/manager/modules/beans/pom.xml M backend/manager/modules/pom.xml R backend/manager/modules/scheduler/pom.xml R backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/FixedDelayJobListener.java R backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/JobWrapper.java R backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/OnTimerMethodAnnotation.java R backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java R backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java R backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java 9 files changed, 2 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I291a87742ddb2d536bd0d11f54515ac531b69659 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Refactored BackendGlusterBrickResource
by sanjal＠redhat.com 05 Apr '13

05 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: restapi: Refactored BackendGlusterBrickResource ...................................................................... restapi: Refactored BackendGlusterBrickResource Refactored BackendGlusterBrickResource to use parent's populateAdvancedDetails method to populate brick with advance details in case of All-Content set to true. Change-Id: I70354105b57159e6ba872804701910b4111b734b Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResourceTest.java 3 files changed, 24 insertions(+), 33 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70354105b57159e6ba872804701910b4111b734b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: do not allow execution as non-roo...
by juan.hernandez＠redhat.com 05 Apr '13

05 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: do not allow execution as non-root ...................................................................... packaging: engine-service: do not allow execution as non-root all downstream has a mean to execute the script under the correct account. So no need for us to change identity nor expect other user. Change-Id: Ic30ce5316918a98bf2ef4cbf17d0eb91b85c74d1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in 1 file changed, 7 insertions(+), 26 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic30ce5316918a98bf2ef4cbf17d0eb91b85c74d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: remove /usr/bin symlink
by juan.hernandez＠redhat.com 05 Apr '13

05 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: remove /usr/bin symlink ...................................................................... packaging: engine-service: remove /usr/bin symlink The engine-service script is not a utility to be used by user but by downstream packager, hence no reason to install at /usr/bin. Change-Id: I49fc25ad586b8f04e1588d04ab772858f2bfd169 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/fedora/engine-service.systemd.in M packaging/fedora/engine-service.sysv.in M packaging/fedora/spec/ovirt-engine.spec.in 4 files changed, 2 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49fc25ad586b8f04e1588d04ab772858f2bfd169 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: add missing global
by juan.hernandez＠redhat.com 05 Apr '13

05 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: add missing global ...................................................................... packaging: engine-service: add missing global Change-Id: Id7df1b3c222c5de67e96423ef0fd686e9cf579b0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7df1b3c222c5de67e96423ef0fd686e9cf579b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: support setting attributes on generated files
by juan.hernandez＠redhat.com 05 Apr '13

05 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: support setting attributes on generated files ...................................................................... packaging: support setting attributes on generated files ensure generated scripts are executable. Change-Id: Iacd9614777540f6ed6da741de5157b888beb7629 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/fedora/engine-service.sysv.in M packaging/fedora/spec/ovirt-engine.spec.in 3 files changed, 6 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacd9614777540f6ed6da741de5157b888beb7629 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: doc: fix wrong setting for fake and development
by Alon Bar-Lev 04 Apr '13

04 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: fix wrong setting for fake and development ...................................................................... doc: fix wrong setting for fake and development Change-Id: I3ac15f934f821be73f96065e7de938b1dec28d0d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ac15f934f821be73f96065e7de938b1dec28d0d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove api's StrigUtils
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove api's StrigUtils ...................................................................... core: Remove api's StrigUtils This patch removes the class org.ovirt.engine.api.common.util.StringUtils. It only had one method (isNullOrEmpty(String)), which was only used in two places. This method's body is completely identical to org.apache.commons.lang.StringUtils.isEmpty(String), so it could easily be replaced. Change-Id: Ia6f116f861975db24b710db457b40491908ff1d1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/StatusUtils.java D backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/StringUtils.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DataCenterMapper.java 3 files changed, 5 insertions(+), 29 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6f116f861975db24b710db457b40491908ff1d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Short comparison findbugs
by tnisan＠redhat.com 04 Apr '13

04 Apr '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Short comparison findbugs ...................................................................... webadmin: Short comparison findbugs Fixed findbugs warnings in StorageGeneralModel.java:129 and StorageGeneralModel.java:142 Change-Id: I8d06ece4dbaddb4ecd5372eae19bf729278e7572 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d06ece4dbaddb4ecd5372eae19bf729278e7572 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : Creating template by specifing vm name, does not w...
by mpastern＠redhat.com 04 Apr '13

04 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Creating template by specifing vm name, does not work (#915285) ...................................................................... restapi : Creating template by specifing vm name, does not work (#915285) Creating template by specifing vm name, does not work, works only when vm id is specified. This patch lets the user create a template from a VM by specifying the vm name. Change-Id: Ibe6ff6059c22a853c76a0720e5c9e330f600712b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=915285 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/dbscripts/vms_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmByVmNameForDataCenterQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmByVmNameForDataCenterQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmByVmNameForDataCenterParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java 10 files changed, 234 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe6ff6059c22a853c76a0720e5c9e330f600712b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add an alert when adding a Domain to uninitialized...
by tnisan＠redhat.com 04 Apr '13

04 Apr '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add an alert when adding a Domain to uninitialized pool ...................................................................... webadmin: Add an alert when adding a Domain to uninitialized pool When trying to add a Storage Domain to an uninitialized Storage Pool there should be a warning message that the Pool is uninitialized and that the user should first add a data domain to initialize the pool Change-Id: I30c2b37f2cf59ef9c57ff96d1ffc4c23d452819e Bug-Url: https://bugzilla.redhat.com/887378 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml 4 files changed, 53 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30c2b37f2cf59ef9c57ff96d1ffc4c23d452819e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Added POSIX VFS validation & hint on storage creat...
by tnisan＠redhat.com 04 Apr '13

04 Apr '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Added POSIX VFS validation & hint on storage create ...................................................................... webadmin: Added POSIX VFS validation & hint on storage create Added a validation of special characters to a VFS type when creating a POSIX domain to allow only ascii characters, also added a tooltip hint on the input field to explain and show common types Change-Id: I6a34d269da73f1b42b2b2917469f8ea337ca51ee Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.java 3 files changed, 9 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a34d269da73f1b42b2b2917469f8ea337ca51ee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Provide snapshot name to audit log
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Provide snapshot name to audit log ...................................................................... core: Provide snapshot name to audit log VM snapshot name not provided in the event log when a snapshot is previewed problem fixed. Change-Id: I6988302018ff04966f973f3950c12cad6072ab82 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 20 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6988302018ff04966f973f3950c12cad6072ab82 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused GetUsersByVmidQuery
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused GetUsersByVmidQuery ...................................................................... core: Remove unused GetUsersByVmidQuery Remove the GetUsersByVmidQuery, which is not used anywhere in the code base. This patch removes the redundant GetUsersBVmidQuery class, its parameter class GetUsersByVmidParameters and its corresponding constant in VdcQueryType. Change-Id: I1f3dc0aa392c89c03e43c34f98df3fbf68dbd493 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUsersByVmidQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUsersByVmidParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 43 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f3dc0aa392c89c03e43c34f98df3fbf68dbd493 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove the unused GetNonOperationalVdsQuery
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove the unused GetNonOperationalVdsQuery ...................................................................... core: Remove the unused GetNonOperationalVdsQuery Remove GetNonOperationalVdsQuery, since it is not used anywhere in the codebase. This patch removes: 1. The GetNonOperationalVdsQuery class. 2. The NetworkNonOperationalQueryParameters only used by the aforementioned class. 3. The corresponding GetNonOperationalVds constant in VdcQueryType. Please enter the commit message for your changes. Lines starting Change-Id: I21bef4c93c3f40ebcbb39182ca18dda55ef0a7b0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNonOperationalVdsQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/NetworkNonOperationalQueryParamenters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 68 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21bef4c93c3f40ebcbb39182ca18dda55ef0a7b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetVdsByTypeQuery leftovers
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetVdsByTypeQuery leftovers ...................................................................... core: Remove GetVdsByTypeQuery leftovers Removed the VdcQueryType.GetVdsByType constant and the GetVdsByTypeParameters class as the GetVdsByType query no longer exists in the codebase. Change-Id: I42ecd45ccf58e544305df394e727926097f63dda Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsByTypeParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 0 insertions(+), 21 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42ecd45ccf58e544305df394e727926097f63dda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetVdsByHostQuery leftovers
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetVdsByHostQuery leftovers ...................................................................... core: Remove GetVdsByHostQuery leftovers Removed the VdcQueryType.GetVdsByHost constant and the GetVdsByHostParameters class as the GetVdsByHost query no longer exists in the codebase. Change-Id: Ib426d8ae35d8536286f02dc67141b0f641f43971 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVdsByHostParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 0 insertions(+), 19 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib426d8ae35d8536286f02dc67141b0f641f43971 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Adding "MIGRATION" role as a network usage.
by alkaplan＠redhat.com 04 Apr '13

04 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: restapi: Adding "MIGRATION" role as a network usage. ...................................................................... restapi: Adding "MIGRATION" role as a network usage. Migration role on a NetworkCluster indicates the migration of vm's in the cluster will be done via this network. Change-Id: If001d1388e3054f9f6215e3cb3d2f23cc84de05f Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNetworkResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNetworksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkUsage.java 5 files changed, 56 insertions(+), 20 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If001d1388e3054f9f6215e3cb3d2f23cc84de05f Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Martin Pavlik <xpavli44(a)gmail.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: reimplemented engine_firewalld
by juan.hernandez＠redhat.com 04 Apr '13

04 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: reimplemented engine_firewalld ...................................................................... packaging: reimplemented engine_firewalld Reimplemented using the firewall-cmd command instead of the python API, avoiding issues with dbus. The firewall-cmd command will be used also in otopi based rewrite of the engine-setup command. Change-Id: Ie0d819c9607d4c99b3093e364ca504ae96acca36 Bug-Url: https://bugzilla.redhat.com/924071 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine_firewalld.py 2 files changed, 42 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0d819c9607d4c99b3093e364ca504ae96acca36 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine, webdmin: Restrict destination host parameter for admi...
by ofrenkel＠redhat.com 04 Apr '13

04 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine,webdmin: Restrict destination host parameter for administrators ...................................................................... engine,webdmin: Restrict destination host parameter for administrators Users aren't supposed to be able to provide any host level parameters to commands. New action groups added: - EDIT_ADMIN_VM_PROPERTIES - EDIT_ADMIN_TEMPLATE_PROPERTIES The permission check is applied if e.g. destination host is specified and is different from the default VM destination host for Run/RunOnce/UpdateVM/UpdateVmTemplate/AddVM/AddVmTemplate VM actions. The new action groups are assigned to: - SuperUser, DataCenterAdmin, (ClusterAdmin, TemplateAdmin) roles. GUI role tree is updated. Permissions are propagated into REST API layer. Change-Id: I5294854d24b235f2c50fa7f3d4e7472cf7598b53 Bug-Url: https://bugzilla.redhat.com/902353 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_03_0030_add_edit_admin_vm_props.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 15 files changed, 177 insertions(+), 29 deletions(-) Approvals: Libor Spevak: Verified Omer Frenkel: Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5294854d24b235f2c50fa7f3d4e7472cf7598b53 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: prepare for the next development iteration
by mpastern＠redhat.com 04 Apr '13

04 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: prepare for the next development iteration ...................................................................... sdk: prepare for the next development iteration Change-Id: I0ddd39938451686d00b0391d109fdc2cac897403 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ddd39938451686d00b0391d109fdc2cac897403 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: release 1.0.0.6-1
by mpastern＠redhat.com 04 Apr '13

04 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 1.0.0.6-1 ...................................................................... sdk: release 1.0.0.6-1 - added new collection ClusterGlusterVolumeGlusterBrickStatistics - added new properties to the GlusterBrick - to vm added cpu.mode - to host install action added "image" parameter - ignore case in factory method lookup Change-Id: Iffdd36f9dd5de713672696463432f3d2c70f0c36 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffdd36f9dd5de713672696463432f3d2c70f0c36 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: Revert "sdk: release 1.0.0.6-1"
by mpastern＠redhat.com 04 Apr '13

04 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: Revert "sdk: release 1.0.0.6-1" ...................................................................... Revert "sdk: release 1.0.0.6-1" This reverts commit 6e6a74efa475cf8b1dfcd462bfb355385093d6f9. Change-Id: Ib342a94d86c62551de8a8ccae57a69b8b545b3fc Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib342a94d86c62551de8a8ccae57a69b8b545b3fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: release 1.0.0.6-1
by mpastern＠redhat.com 04 Apr '13

04 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 1.0.0.6-1 ...................................................................... sdk: release 1.0.0.6-1 Change-Id: Ib298a7c180f6b0232fa05a18255f18e66d185259 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib298a7c180f6b0232fa05a18255f18e66d185259 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: regenerate against the latest api
by mpastern＠redhat.com 04 Apr '13

04 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: regenerate against the latest api ...................................................................... sdk: regenerate against the latest api - added new collection ClusterGlusterVolumeGlusterBrickStatistics - added new properties to the GlusterBrick - to vm added cpu.mode - to host install action added "image" parameter Change-Id: Id0fdcd5ecb6466790d36b02edf01214f5a9108d4 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBrick.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBrickStatistic.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBrickStatistics.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBricks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumeGlusterBrick.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumeGlusterBrickStatistic.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterGlusterVolumeGlusterBrickStatistics.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Host.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/BaseResource.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/BaseResources.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/CpuModes.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/DetailedLink.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/GeneralMetadata.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/GlusterBrick.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/GlusterBrickAdvancedDetails.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/GlusterBrickMemoryInfo.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/GlusterClient.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/GlusterClients.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/GlusterMemoryPool.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/GlusterMemoryPools.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/RSDL.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Statistic.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VersionCaps.java 26 files changed, 3,105 insertions(+), 1,148 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0fdcd5ecb6466790d36b02edf01214f5a9108d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused IsUserPowerUserOrAboveQuery
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused IsUserPowerUserOrAboveQuery ...................................................................... core: Remove unused IsUserPowerUserOrAboveQuery Removed the IsUserPowerUserOrAboveQuery and its corresponding constant in VdcQueryType since it is not used anywhere in the code. Change-Id: I82982b3a6950339a9c3623078f4bd0e36c9d8f6f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsUserPowerUserOrAboveQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 0 insertions(+), 34 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82982b3a6950339a9c3623078f4bd0e36c9d8f6f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed unused VdcQueryType.CanFenceVds
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed unused VdcQueryType.CanFenceVds ...................................................................... core: Removed unused VdcQueryType.CanFenceVds Removed the CanFenceVds constant from VdcQueryType, as the CanFenceVdsQuery associated with it no longer exists. Change-Id: I5a9d97e7adbebccdc70760d0e11667d81bf55ff6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a9d97e7adbebccdc70760d0e11667d81bf55ff6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused bookmark queries
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused bookmark queries ...................................................................... core: Remove unused bookmark queries This patch removed the unused GetBookmarkById and GetBookmarkByName queries. Removed in this patch: 1. The query classes. 2. The parameter classes used by the aforementioned queries. 3. The validation methods used to validate the aforementioned parameters. 4. The constants from VdcQueryType corresponding to the aforementioned queries. Change-Id: If130d51f240beebcfdda56e8c03c9f0321100ebf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetBookmarkByIdQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetBookmarkByNameQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetBookmarkByIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetBookmarkByNameParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 0 insertions(+), 97 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If130d51f240beebcfdda56e8c03c9f0321100ebf Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused GetVmsByVmTemplateGuidQuery
by amureini＠redhat.com 04 Apr '13

04 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused GetVmsByVmTemplateGuidQuery ...................................................................... core: Remove unused GetVmsByVmTemplateGuidQuery GetVmsByVmTemplateGuidQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The unused GetVmsByVmTemplateGuidQuery class. 2. The GetVmsByVmTemplateGuidParameters class used by the aforementioned query class. All its meaningful methods (i.e., getId() and the constructor from Guid were pulled up to GetVmTemplatesDisksParameters which used to extend it. 3. The GetVmsByVmTemplateGuid constant in VdcQueryType corresponding to the removed class. Change-Id: Ieef493712c75bc386dce066f9774ffe83c1be8fa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsByVmTemplateGuidQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplatesDisksParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsByVmTemplateGuidParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 4 files changed, 9 insertions(+), 42 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieef493712c75bc386dce066f9774ffe83c1be8fa Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: ignore case in factory method lookup
by mpastern＠redhat.com 04 Apr '13

04 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: ignore case in factory method lookup ...................................................................... sdk: ignore case in factory method lookup Change-Id: I8c9578f041f64fd41e5c9dd7c1568e5383f5d39c Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/utils/SerializationHelper.java 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c9578f041f64fd41e5c9dd7c1568e5383f5d39c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix NPE on add NFS
by derez＠redhat.com 04 Apr '13

04 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fix NPE on add NFS ...................................................................... webadmin: fix NPE on add NFS Fix regression introduced by: bfd9299661c6f6adeea998e93232c8a8789b9dc0 Change-Id: Ibf0f41ceb4d58997a918674bd1919337911d09ef Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf0f41ceb4d58997a918674bd1919337911d09ef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0