April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: truncated text in VMs-Disks sub-tab
by derez＠redhat.com 21 Apr '13

21 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: truncated text in VMs-Disks sub-tab ...................................................................... webadmin: truncated text in VMs-Disks sub-tab Fixed truncated headers VMs -> Disks sub-tab. Change-Id: I2e9c4853bdd6da18801be7c04a0c201331afb7a4 Bug-Url: https://bugzilla.redhat.com/952457 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e9c4853bdd6da18801be7c04a0c201331afb7a4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : name is invalid argument segment error when adding...
by mpastern＠redhat.com 21 Apr '13

21 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : name is invalid argument segment error when adding tag with parent id(#950450) ...................................................................... restapi : name is invalid argument segment error when adding tag with parent id(#950450) add tag --name newtag --parent-name ooo2 Results in error: "name" is invalid argument segment. the command should be add tag --name newtag --parent-tag-name ooo2 Change-Id: I904888aa9cadb8cfcf9f7119f1bc4ac301cee7f9 Bug-Url: https://bugzilla.redhat.com/950450 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I904888aa9cadb8cfcf9f7119f1bc4ac301cee7f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : missing sync option for action vm import in RSDL(#...
by mpastern＠redhat.com 21 Apr '13

21 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : missing sync option for action vm import in RSDL(#949881) ...................................................................... restapi : missing sync option for action vm import in RSDL(#949881) No sync option in cli for action vm import. Change-Id: I84799bf942dd87956cb2f42c5b57201687d32fda Bug-Url: https://bugzilla.redhat.com/949881 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84799bf942dd87956cb2f42c5b57201687d32fda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: truncated text in Storage main-tab
by derez＠redhat.com 21 Apr '13

21 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: truncated text in Storage main-tab ...................................................................... webadmin: truncated text in Storage main-tab Fixed truncated headers in Storage main-tab. Change-Id: I31820f0820767cd993b21c57711b25a310706d97 Bug-Url: https://bugzilla.redhat.com/950019 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31820f0820767cd993b21c57711b25a310706d97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: engine : ovirt-node enter installing status when the install...
by yzaslavs＠redhat.com 21 Apr '13

21 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : ovirt-node enter installing status when the install fails ...................................................................... engine : ovirt-node enter installing status when the install fails When ovirt-node installation fails because of missing iso file the status of the host is left as Installing. This patch adds VdsDynamic data to compensation context if can do action of InstalllVdsCommand fails. The status is reverted back to the previous status in compensation logic. The error messages are added to the return values CanDoActionMessages so the message can be displayed in cli Change-Id: I2d74e946cb68d2b9dbc11fc5c6bed9f63ba35fe2 Bug-Url: https://bugzilla.redhat.com/947982 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d74e946cb68d2b9dbc11fc5c6bed9f63ba35fe2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Host General sub-tab unlocalized strings found
by gchaplik＠redhat.com 21 Apr '13

21 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Host General sub-tab unlocalized strings found ...................................................................... webadmin: Host General sub-tab unlocalized strings found changes are described in bugzilla. Change-Id: I59b0ba281c912d1a9e09b9ab3dde1be93b0c7e56 Bug-Url: https://bugzilla.redhat.com/952091 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskStatusColumn.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java 12 files changed, 69 insertions(+), 35 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59b0ba281c912d1a9e09b9ab3dde1be93b0c7e56 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-upgrade - log DB upgrade in the right plac...
by oschreib＠redhat.com 21 Apr '13

21 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-upgrade - log DB upgrade in the right place ...................................................................... packaging: engine-upgrade - log DB upgrade in the right place DB Upgrade script should be run with the wanted log location, otherwise, it creates the upgrade log in the dbscripts directory (currently, in /usr/share) Change-Id: I15cb1e0d7ce12a27ae07c92025db6b21636957c9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=947344 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15cb1e0d7ce12a27ae07c92025db6b21636957c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Improve message when network is mis-configured
by masayag＠redhat.com 21 Apr '13

21 Apr '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Improve message when network is mis-configured ...................................................................... engine: Improve message when network is mis-configured The patch adds a specific message to the host general sub tab for the case of a VM network isn't implemented so on the host. In addition, it adjusts the indicator of the same error in the event log to warning so it could be noticeable easily. Change-Id: I0f51fdc0d66cc55020858391dabd026b88e4fe35 Bug-Url: https://bugzilla.redhat.com/951920 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 7 files changed, 32 insertions(+), 21 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/14082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f51fdc0d66cc55020858391dabd026b88e4fe35 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Extract SD validations from ImagesHandler
by amureini＠redhat.com 19 Apr '13

19 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Extract SD validations from ImagesHandler ...................................................................... core: Extract SD validations from ImagesHandler Extracted the logic to perform validations on Storage Domains from ImagesHandler.PerformImagesChecks, and made the relevant commands use it directly. In order to do this, a new type of validator was introduced, MultipleStorageDomainsValidator, which aggregates validations from individual StorageDomainValidators in a fast-fail pattern. This is done for performance reasons, so there is no need to load all the storage domains from the database preemptively. This refactoring removes three parameters from PerformImagesChecks: * checkStorageDomain and diskSpaceCheck - are now done directly by MultipleStorageDomainsValidator. * storageDomainId - is used by the previous two checks, and by the image existence check. However, it is always equal to the storage domain id member of the DiskImage, so it is redundant as an additional parameter. The changes in the commands are as follows: * The parameters detailed above were removed from the ImagesHandler.PerformImagesCheck calls. * Wherever appropriate, a direct call to StorageDomainValidator or MultipleStorageDomainsValidator was added. Change-Id: I4cfc895dceed4de520476ed5e3fa9c1c7cfd78f4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java 19 files changed, 356 insertions(+), 123 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cfc895dceed4de520476ed5e3fa9c1c7cfd78f4 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove PerformImagesChecks from AddDisk
by amureini＠redhat.com 19 Apr '13

19 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove PerformImagesChecks from AddDisk ...................................................................... core: Remove PerformImagesChecks from AddDisk Several previous patches have removed checks not related to DiskImages from PerformImagesChecks (The last one being change id I4cfc895dceed4de520476ed5e3fa9c1c7cfd78f4, that removed storage domain validation). Now, since PerformImagesChecks only checks DiskImages, passing an emptyList() to it is meaningless, and can safely be removed. Change-Id: I457dee7645dd16c430eda6886e03df77c7e91383 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java 2 files changed, 0 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I457dee7645dd16c430eda6886e03df77c7e91383 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Unfilter ImagesHandler.PerformImagesChecks
by amureini＠redhat.com 19 Apr '13

19 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Unfilter ImagesHandler.PerformImagesChecks ...................................................................... core: Unfilter ImagesHandler.PerformImagesChecks Before this patch, ImagesHandler.PerformImagesChecks received a collection of Disks, and filtered them so only DiskImages that aren't sharable were evaluated. This patch removes the filtering from this methods, and makes it the responsibility of the calling method to perform any required filtering. This patch also adds said filtering wherever relevant, so no behavior is changed. This achieves two goals: 1. Added flexibility, to allow possible validation on sharable disks. 2. A clearer API - it is now clear, in compile time, that this method only performs validations on DiskImages, as opposed to the way it was before the patch, where the function could be passed a faulty (e.g., non-existent) LunDisk, which would just be silently ignored. Change-Id: Icc93d1bb72daed053f0f37ae3c3f12efef915669 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java 10 files changed, 18 insertions(+), 18 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc93d1bb72daed053f0f37ae3c3f12efef915669 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, webadmin: Host reboot false for gluster only host
by kmayilsa＠redhat.com 19 Apr '13

19 Apr '13

Kanagaraj M has submitted this change and it was merged. Change subject: core,webadmin: Host reboot false for gluster only host ...................................................................... core,webadmin: Host reboot false for gluster only host This patch sets requiresRebootAfterInstallation to false in case of gluster only host. Following UI flows for add host are changed - Add New Host - Reinstall Host - Configure host (for Add Cluster) - Import Cluster Change-Id: I8c52e32de914b21998fa334088b302ec70aef49f Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 6 files changed, 38 insertions(+), 17 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/13384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c52e32de914b21998fa334088b302ec70aef49f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.0]: vdsm: vdsmid: do not attempt to install dmidecode on platfor...
by Alon Bar-Lev 19 Apr '13

19 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: vdsmid: do not attempt to install dmidecode on platforms other than x86 ...................................................................... vdsm: vdsmid: do not attempt to install dmidecode on platforms other than x86 Change-Id: Ib683ad399287f2a9502a2851557269cabeaded4d Reported-By: Pradipta Kumar Banerjee <bpradip(a)in.ibm.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/vdsmid.py 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib683ad399287f2a9502a2851557269cabeaded4d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: vdsmid: do not attempt to install dmidecode on platfor...
by Alon Bar-Lev 19 Apr '13

19 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: vdsmid: do not attempt to install dmidecode on platforms other than x86 ...................................................................... vdsm: vdsmid: do not attempt to install dmidecode on platforms other than x86 Change-Id: Ib683ad399287f2a9502a2851557269cabeaded4d Reported-By: Pradipta Kumar Banerjee <bpradip(a)in.ibm.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/vdsmid.py 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib683ad399287f2a9502a2851557269cabeaded4d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com>

1 0

Change in ovirt-engine[master]: engine, webadmin: Run and pause action enabled
by tjelinek＠redhat.com 19 Apr '13

19 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: engine,webadmin: Run and pause action enabled ...................................................................... engine,webadmin: Run and pause action enabled 'Start in Pause Mode' checkbox added to the Edit VM properties dialog, instead of only in the Run Once dialog. This is needed to assist the admin in boot-level troubleshooting. Allowing the VM to always start in paused mode without having to select "Run once" will save the admin time and hassle when starting and stopping VMs multiple times. Change-Id: Ib1fe46a9946f7914095310ddac9ab1a9e5a6564b Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_03_0040_add_run_and_pause_to_vm.sql M backend/manager/dbscripts/vm_templates_sp.sql M backend/manager/dbscripts/vms_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/AbstractVmRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolNewPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 34 files changed, 191 insertions(+), 68 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1fe46a9946f7914095310ddac9ab1a9e5a6564b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: stricter FQDN validation
by juan.hernandez＠redhat.com 19 Apr '13

19 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: stricter FQDN validation ...................................................................... packaging: stricter FQDN validation common_utils.getConfiguredIps now returns only Ips configured on non loopback devices. engine_validators.validateFQDN now tolerates that the FQDN provided could not be resolved through a DNS but just only by /etc/hosts. However, if the FQDN is resolved by DNS, it has also to reverse resolve the ip address provided by the DNS. engine-setup doesn't accept anymore a FQDN that doesn't pass the validation, avoiding failures at later stages. Change-Id: I512446c80dfa9c83adb179a445bfae82736d403f Bug-Url: https://bugzilla.redhat.com/948311 Bug-Url: https://bugzilla.redhat.com/928667 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/output_messages.py 4 files changed, 87 insertions(+), 46 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I512446c80dfa9c83adb179a445bfae82736d403f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Log stacktrace when VDS command execution failed
by yzaslavs＠redhat.com 19 Apr '13

19 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Log stacktrace when VDS command execution failed ...................................................................... core: Log stacktrace when VDS command execution failed Added stacktrace to debug log when an exception is raised during VDS command execution. Change-Id: I67d502dd74d45cf75a4fe98c840a41df58ac8425 Bug-Url: https://bugzilla.redhat.com/948744 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java 1 file changed, 6 insertions(+), 9 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67d502dd74d45cf75a4fe98c840a41df58ac8425 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: findbugs + improving code
by yzaslavs＠redhat.com 19 Apr '13

19 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: findbugs + improving code ...................................................................... core: findbugs + improving code Fixing findbugs issue + improving code readability 1. Removed dictemp + assigntmet 2. Changed the if instanceof map "pattern" Change-Id: Icc7794df32b8d0f4cf08f7c5259b83a5a17db14f Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 5 insertions(+), 11 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc7794df32b8d0f4cf08f7c5259b83a5a17db14f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove redundant image listing by pool
by amureini＠redhat.com 18 Apr '13

18 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: remove redundant image listing by pool ...................................................................... core: remove redundant image listing by pool There is no need for a specific procedure (and specific DAO methods) to get the list of ISO images for a Pool since it is possible to use the regular getStorageDomainId method using the storage domain id returned by getIsoStorageDomainIdForPool. Change-Id: I6ed7de8141b73cec53899cf277a9fdfdc06f2fc1 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/dbscripts/repo_files_meta_data_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQueryBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAODbFacadeImpl.java 7 files changed, 14 insertions(+), 130 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ed7de8141b73cec53899cf277a9fdfdc06f2fc1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: unify GetImagesList using ImageFileType.All
by amureini＠redhat.com 18 Apr '13

18 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: unify GetImagesList using ImageFileType.All ...................................................................... core: unify GetImagesList using ImageFileType.All It is possible to unify the two separate requests for Floppy and ISO images using the enum ImageFileType.All. In order to do so the stored procedures and the DAO methods have been updated to not filter by type when ImageFileType.All is used. Change-Id: I4e8fb85c3f0d58778b03fd0aa101d95bbeebf3f6 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/dbscripts/repo_files_meta_data_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAODbFacadeImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java 4 files changed, 75 insertions(+), 84 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e8fb85c3f0d58778b03fd0aa101d95bbeebf3f6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: update POSIX sh compatibility
by bazulay＠redhat.com 18 Apr '13

18 Apr '13

Barak Azulay has submitted this change and it was merged. Change subject: pki: update POSIX sh compatibility ...................................................................... pki: update POSIX sh compatibility Change-Id: I3ae7b6a9d88b87d134676acbd216a075bbad76f8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/conf/ca/CreateCA.sh M backend/manager/conf/ca/SignReq.sh M backend/manager/conf/ca/installCA.sh 3 files changed, 84 insertions(+), 91 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ae7b6a9d88b87d134676acbd216a075bbad76f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix the phrasing of error message
by dfediuck＠redhat.com 18 Apr '13

18 Apr '13

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: Fix the phrasing of error message ...................................................................... webadmin: Fix the phrasing of error message message was: Cannot edit VM. Dedicated Host Cluster is not identical to VM Cluster. changed to: Cannot edit VM. VM is pinned to a specific host. The host's cluster must be the same as the selected VM cluster. Change-Id: I298bacc9ce5c2ca9729d79ee3136a71360d329d5 Bug-Url: https://bugzilla.redhat.com/950693 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I298bacc9ce5c2ca9729d79ee3136a71360d329d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: build: re-use external gettext
by Alon Bar-Lev 18 Apr '13

18 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: build: re-use external gettext ...................................................................... build: re-use external gettext Change-Id: Ie10b6003d1c5ebb32e9c6cea216a56c9b5422e15 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M ChangeLog M Makefile.am M configure.ac M ovirt-host-deploy.spec.in 5 files changed, 3 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie10b6003d1c5ebb32e9c6cea216a56c9b5422e15 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : fix message when removing template from export domain
by mlipchuk＠redhat.com 18 Apr '13

18 Apr '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core : fix message when removing template from export domain ...................................................................... core : fix message when removing template from export domain Change-Id: I44b8f026bf381c114157f557375381fff4ca8d8c Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/14056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44b8f026bf381c114157f557375381fff4ca8d8c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in otopi[master]: build: re-use external gettext
by Alon Bar-Lev 18 Apr '13

18 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: build: re-use external gettext ...................................................................... build: re-use external gettext Change-Id: Ic124ffe0e24eb9b469535db221f64bdce2ff0351 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M ChangeLog M Makefile.am M configure.ac M otopi.spec.in 5 files changed, 3 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic124ffe0e24eb9b469535db221f64bdce2ff0351 Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: gluster: starting glusterd after install
by Alon Bar-Lev 18 Apr '13

18 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: gluster: starting glusterd after install ...................................................................... gluster: starting glusterd after install glusterd service was not started after installing. Added an event which will get triggered after the gluster installation which starts the glusterd service. Change-Id: I4f65ea6cbb54c844fb42ad1a14c61c438ac0865a Signed-off-by: Aravinda VK <avishwan(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/gluster/packages.py 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, approved Aravinda VK: Verified -- To view, visit http://gerrit.ovirt.org/14030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f65ea6cbb54c844fb42ad1a14c61c438ac0865a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Aravinda VK <avishwan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Auto recovery ignores hosts with problematic NICs
by masayag＠redhat.com 18 Apr '13

18 Apr '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Auto recovery ignores hosts with problematic NICs ...................................................................... engine: Auto recovery ignores hosts with problematic NICs Such hosts cannot be automatically recovered since the NICs are down and the host will just go back to non-operational state. Change-Id: I70bff4ba5541156c31fb8afdd38ff6f706c0d869 Bug-Url: https://bugzilla.redhat.com/953115 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AutoRecoveryManagerTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 3 files changed, 124 insertions(+), 50 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70bff4ba5541156c31fb8afdd38ff6f706c0d869 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Method fail to close stream
by shavivi＠redhat.com 18 Apr '13

18 Apr '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Method fail to close stream ...................................................................... findbugs: Method fail to close stream Change-Id: I5bea678c1aaeeb6dfe92b16e380e4bc631e3d09c Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TestCommon.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TransferTest.java 5 files changed, 69 insertions(+), 11 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bea678c1aaeeb6dfe92b16e380e4bc631e3d09c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.2]: packaging: post ovirt-image-uploader-3.2.2
by knesenko＠redhat.com 18 Apr '13

18 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: packaging: post ovirt-image-uploader-3.2.2 ...................................................................... packaging: post ovirt-image-uploader-3.2.2 Change-Id: I174d8008553764953b19727b3223eb809322aa99 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I174d8008553764953b19727b3223eb809322aa99 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: Implement Session-TTL header support #928314
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: Implement Session-TTL header support #928314 ...................................................................... cli: Implement Session-TTL header support #928314 https://bugzilla.redhat.com/show_bug.cgi?id=928314 Change-Id: I4a404493235255d795c3554af4ffe7db471f2cc1 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-cli.spec.in M setup.py M src/cli/settings.py M src/ovirtcli/command/connect.py M src/ovirtcli/context.py M src/ovirtcli/options.py M src/ovirtcli/settings.py M src/ovirtcli/shell/connectcmdshell.py 8 files changed, 42 insertions(+), 20 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a404493235255d795c3554af4ffe7db471f2cc1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.2]: sdk: Implement Session-TTL header support #928313
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: Implement Session-TTL header support #928313 ...................................................................... sdk: Implement Session-TTL header support #928313 https://bugzilla.redhat.com/show_bug.cgi?id=928313 Change-Id: I03ae76a9a5e40019da191175c44986fa871e6f0f Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/templates/entrypointmethodstemplate M src/codegen/templates/entrypointtemplate M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/cache.py M src/ovirtsdk/web/connection.py 5 files changed, 106 insertions(+), 31 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03ae76a9a5e40019da191175c44986fa871e6f0f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.2]: sdk: refactor invocation flow #949189, #949187
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: refactor invocation flow #949189, #949187 ...................................................................... sdk: refactor invocation flow #949189, #949187 This change introduces workaround for the race conditions on [1] and [2] which are caused by the non ability of the former to supply tread safe environment as seen in #949187 and #949189. https://bugzilla.redhat.com/show_bug.cgi?id=949189 https://bugzilla.redhat.com/show_bug.cgi?id=949187 [1] cookielib.DefaultCookiePolicy [2] httplib.HTTPConnection Change-Id: I4c50e04ef763d4f572cfb4a5e4df0bb045401453 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/connectionspool.py M src/ovirtsdk/infrastructure/proxy.py A src/ovirtsdk/utils/synchronizationhelper.py M src/ovirtsdk/web/connection.py A src/ovirtsdk/web/cookiejaradapter.py 5 files changed, 285 insertions(+), 172 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c50e04ef763d4f572cfb4a5e4df0bb045401453 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: Implement Session-TTL header support #928314
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: Implement Session-TTL header support #928314 ...................................................................... cli: Implement Session-TTL header support #928314 https://bugzilla.redhat.com/show_bug.cgi?id=928314 Change-Id: I4a404493235255d795c3554af4ffe7db471f2cc1 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-cli.spec.in M setup.py M src/cli/settings.py M src/ovirtcli/command/connect.py M src/ovirtcli/context.py M src/ovirtcli/options.py M src/ovirtcli/settings.py M src/ovirtcli/shell/connectcmdshell.py 8 files changed, 42 insertions(+), 20 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a404493235255d795c3554af4ffe7db471f2cc1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: Implement Session-TTL header support #928313
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: Implement Session-TTL header support #928313 ...................................................................... sdk: Implement Session-TTL header support #928313 https://bugzilla.redhat.com/show_bug.cgi?id=928313 Change-Id: I03ae76a9a5e40019da191175c44986fa871e6f0f Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/templates/entrypointmethodstemplate M src/codegen/templates/entrypointtemplate M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/cache.py M src/ovirtsdk/web/connection.py 5 files changed, 106 insertions(+), 31 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13979 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03ae76a9a5e40019da191175c44986fa871e6f0f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix audit logging when removing template from export
by tnisan＠redhat.com 18 Apr '13

18 Apr '13

Tal Nisan has submitted this change and it was merged. Change subject: core: fix audit logging when removing template from export ...................................................................... core: fix audit logging when removing template from export When removing a template from export domain, audit log was never printed. Change-Id: I09093f9d5f83314262493ea8bcbe37beb8732661 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java 1 file changed, 10 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09093f9d5f83314262493ea8bcbe37beb8732661 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Added new canDoAction check for gluster
by sanjal＠redhat.com 18 Apr '13

18 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Added new canDoAction check for gluster ...................................................................... engine: Added new canDoAction check for gluster In case the server being added is already part of an existing gluster cluster, canDoAction should fail with an appropriate error message. Also added new test cases for gluster related canDoAction errors. Change-Id: I81427fa940bf1edabf316acebc428becac0171f8 Bug-Url: https://bugzilla.redhat.com/916982 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/gluster/GlusterUtil.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/gluster/GlusterUtilTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java 7 files changed, 180 insertions(+), 47 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81427fa940bf1edabf316acebc428becac0171f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Vijay Bellur <vbellur(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: connect --help will log the user out of the disconnecte...
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: connect --help will log the user out of the disconnected cli ...................................................................... cli: connect --help will log the user out of the disconnected cli Running connect --help in a disconnect cli will print help message and log user off cli. This patch uses a regex to convert command --help to help command and execute it. Change-Id: Icffe101260edc5072aec4c8d2a6df0f763591f8b Bug-Url: https://bugzilla.redhat.com/890340 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icffe101260edc5072aec4c8d2a6df0f763591f8b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: engine : User can see events which don't belong to him
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: engine : User can see events which don't belong to him ...................................................................... engine : User can see events which don't belong to him User can see events which are not related to objects he has permissions on. This patch introduces a new view user_object_permissions_view which has the object on which the user has been granted permissions on and uses it for retrieving the events. Change-Id: I7b7a6691f6cfa2ca1c0d0d90294ecd93781fce38 Bug-Url: https://bugzilla.redhat.com/921274 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/dbscripts/audit_log_sp.sql M backend/manager/dbscripts/create_views.sql 2 files changed, 30 insertions(+), 18 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b7a6691f6cfa2ca1c0d0d90294ecd93781fce38 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removing XmlRpcStruct
by mkublin＠redhat.com 18 Apr '13

18 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing XmlRpcStruct ...................................................................... engine: Removing XmlRpcStruct The following patch is removing XmlRpcStruct. The XmlRpcStruct was wrapper for HahsMap, we don't need any wrapper for HashMap Benefits: 1. Simple code 2. Reduced number of created HashMaps and XmlRpcStruct objects (thouthands of objects per second) 3. Less JVM work Time estimation for patch including tests: 2 hours (I drink a lot coffe) Change-Id: Id7f5de61b8b0ea31f6fd16beb02d37b524f39879 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetStoragePoolInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVmsInfoReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVmsInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsStatsAndStatusXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/OneImageInfoReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/StoragePoolInfoReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FullListVdsCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageConnectionsListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageDomainStatsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetAllTasksStatusesVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/LUNListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneLUNReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneStorageDomainInfoReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneStorageDomainStatsReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneVGReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneVmReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ServerConnectionListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ServerConnectionStatusReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStatusReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskStatusListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/UpdateVmInterfaceVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VDSInfoReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VGListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VMInfoListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VMListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcObjectDescriptor.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcStruct.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommandTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java 51 files changed, 730 insertions(+), 915 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7f5de61b8b0ea31f6fd16beb02d37b524f39879 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: added cluster level check
by sanjal＠redhat.com 18 Apr '13

18 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: added cluster level check ...................................................................... gluster: added cluster level check refreshHeavyWeightData uses the vdsm verb glusterVolumeStatus which is not available in cluster level 3.1. So added a check in GlusterManager to not perform the refresh in case of a 3.1 cluster. Also enhanced the AddVdsGroup and UpdateVdsGroup commands to throw an error if their compatibility version doesn't support gluster service. Created a separate GlusterFeatureSupported class in it's own package so that it can be separated out easily in future. Change-Id: Id3944e8b1d8d82eb19643b99f606da2364d6b582 Bug-Url: https://bugzilla.redhat.com/920575 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterManagerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 13 files changed, 124 insertions(+), 21 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3944e8b1d8d82eb19643b99f606da2364d6b582 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Clean warnings
by masayag＠redhat.com 18 Apr '13

18 Apr '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Clean warnings ...................................................................... engine: Clean warnings Change-Id: Iff1abf6cd8a535732a910ba1e4035182dd705e8f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/Pair.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff1abf6cd8a535732a910ba1e4035182dd705e8f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Refactor GetGlusterServersForImportQuery
by sanjal＠redhat.com 18 Apr '13

18 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Refactor GetGlusterServersForImportQuery ...................................................................... gluster: Refactor GetGlusterServersForImportQuery Extracted methods related to fetching gluster peers of a given server into a new utility class GlusterUtil Also added few more tests in GetGlusterServersForImportQueryTest Change-Id: Ib4620c19997c10b202ef5dc5abdbeee9f245937d Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQueryTest.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/gluster/GlusterUtil.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/gluster/GlusterUtilTest.java 4 files changed, 380 insertions(+), 178 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4620c19997c10b202ef5dc5abdbeee9f245937d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RemoveImage as sync operation
by amureini＠redhat.com 18 Apr '13

18 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveImage as sync operation ...................................................................... core: RemoveImage as sync operation * When performing RemoveImage command, the engine can treat the vds command DeleteImageGroup as synchronous operation instead of asynchronous (as it does before this patch). The call might be treated as synchronous because when the call returns, the image is considered to be non existent on the storage side, we shouldn't wait for the deletion to end before proceeding with the related db updates. *When receiving an ImageDoesNotExist error from vdsm during remove image - proceed with removing the image as it doesn't exist. *known issue - when performing remove disk, in case of an engine crash after RemoveImage completed but before the vm's ovf generation was incremented - the ovf won't be updated. That's a non issue as the ovf can contain also today images that where deleted from the storage and can be fixed in a separate patch to reduce the 'noise' here. Change-Id: Ic822a92acb8231d2ca84ae092bd98659507925d8 Bug-Url: https://bugzilla.redhat.com/884635 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveImageParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 9 files changed, 84 insertions(+), 92 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic822a92acb8231d2ca84ae092bd98659507925d8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "restapi: provide full_version in product_info"
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: Revert "restapi: provide full_version in product_info" ...................................................................... Revert "restapi: provide full_version in product_info" Reverted due to junit failures This reverts commit a853f738895e04ec6db4a7e2a1f2e2df31eab177. Change-Id: Ie291b936b9ffaebb555fd6a4e80f26a410e0f90d Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java 2 files changed, 0 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie291b936b9ffaebb555fd6a4e80f26a410e0f90d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: "help add" fails to format the error when number of pro...
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: "help add" fails to format the error when number of provided args in incorrect ...................................................................... cli: "help add" fails to format the error when number of provided args in incorrect 'help add' command for gluster-related entities like glustervolume and brick does not work. The following error is seen - (connected)]# help add glustervolume unknown error: not enough arguments for format string Change-Id: I48b8880078bb2f9c035b5325af60366bf1c94ae1 Bug-Url: https://bugzilla.redhat.com/922018 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/13707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48b8880078bb2f9c035b5325af60366bf1c94ae1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: Send non-blocking uninstalled notification without py...
by bazulay＠redhat.com 18 Apr '13

18 Apr '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: Send non-blocking uninstalled notification without python ...................................................................... agent: Send non-blocking uninstalled notification without python Remove the inline python script to send the non-blocking uninstalled message and replace it with echo + dd Change-Id: I8b2f84d56377ba4ba42ee206966b7b68deae7fc9 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent.spec 1 file changed, 3 insertions(+), 12 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b2f84d56377ba4ba42ee206966b7b68deae7fc9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: Ignore usbfs filesystems'
by bazulay＠redhat.com 18 Apr '13

18 Apr '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: Ignore usbfs filesystems' ...................................................................... agent: Ignore usbfs filesystems' Change-Id: Iee799b05f3c700e8e3912305e2984dad6e049f7d Bug-Url: https://bugzilla.redhat.com/947792 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py M ovirt-guest-agent/ovirt-guest-agent.conf 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Barak Azulay: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee799b05f3c700e8e3912305e2984dad6e049f7d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>

1 0

Change in ovirt-guest-agent[master]: agent: avoid failing to get disk stat when deal with gvfs-fu...
by bazulay＠redhat.com 18 Apr '13

18 Apr '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: avoid failing to get disk stat when deal with gvfs-fuse ...................................................................... agent: avoid failing to get disk stat when deal with gvfs-fuse gvfs-fuse filesystem prevents other user from stat it. Even root can not stat other user's gvfs-fuse fs. Stat on it fails then the whole disk stat function fails. This patch skips gvfs-fuse related filesystem when collecting disk stat. Moreover, this patch try..except in a finner per fs granularity, so that failing on stat one fs does not fails the whole operation. Change-Id: I69c674904c2ad9cb508c5294591a8ba0813e4238 Signed-off-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> --- M ovirt-guest-agent/GuestAgentLinux2.py M ovirt-guest-agent/ovirt-guest-agent.conf 2 files changed, 16 insertions(+), 16 deletions(-) Approvals: Vinzenz Feenstra: Looks good to me, but someone else must approve Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69c674904c2ad9cb508c5294591a8ba0813e4238 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine-cli[master]: cli: unclear error message when using unsupported 2 levels a...
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: unclear error message when using unsupported 2 levels attribute(#949642) ...................................................................... cli: unclear error message when using unsupported 2 levels attribute(#949642) unclear error message (error: type "%s" does not exist.) when using unsupported 2 levels attribute. when using unsupported 2 levels attribute (both are not supported) the returned error is not user friendly Change-Id: Ia96c23ad2462d2d4f2cbe0a4d64996eae8f40854 Bug-Url: https://bugzilla.redhat.com/949642 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia96c23ad2462d2d4f2cbe0a4d64996eae8f40854 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: correlation_id is not attached to update command(#95044...
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: correlation_id is not attached to update command(#950441) ...................................................................... cli: correlation_id is not attached to update command(#950441) update command does not attach correlation-id to request header. Change-Id: If4605ac4dcae8bd12cfefba029dac7867e393016 Bug-Url: https://bugzilla.redhat.com/950441 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/update.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/13846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4605ac4dcae8bd12cfefba029dac7867e393016 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0