April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi : name is invalid argument segment error when adding...
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : name is invalid argument segment error when adding tag with parent id(#950450) ...................................................................... restapi : name is invalid argument segment error when adding tag with parent id(#950450) add tag --name newtag --parent-name ooo2 Results in error: "name" is invalid argument segment. the command should be add tag --name newtag --parent-tag-name ooo2 Change-Id: I904888aa9cadb8cfcf9f7119f1bc4ac301cee7f9 Bug-Url: https://bugzilla.redhat.com/950450 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I904888aa9cadb8cfcf9f7119f1bc4ac301cee7f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: Recommend python 2.7.3 for windows in the README
by bazulay＠redhat.com 18 Apr '13

18 Apr '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: Recommend python 2.7.3 for windows in the README ...................................................................... agent: Recommend python 2.7.3 for windows in the README Change-Id: Ib051c8f8890e70c3382f366f7272c51f9e711162 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/README-windows.txt 1 file changed, 9 insertions(+), 8 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Barak Azulay: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib051c8f8890e70c3382f366f7272c51f9e711162 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: Windows Guest - ini file lookup
by bazulay＠redhat.com 18 Apr '13

18 Apr '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: Windows Guest - ini file lookup ...................................................................... agent: Windows Guest - ini file lookup The ini file is now expected to be in the same folder as the service executable. Change-Id: I4d1927a429fcb780119f78f8dc05999f3bae9148 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/OVirtGuestService.py 1 file changed, 14 insertions(+), 11 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Barak Azulay: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d1927a429fcb780119f78f8dc05999f3bae9148 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: Include windows files in tar balls
by Gerrit Code Review 18 Apr '13

18 Apr '13

Anonymous Coward has submitted this change and it was merged. Change subject: agent: Include windows files in tar balls ...................................................................... agent: Include windows files in tar balls In order to be able providing source tar balls and src zips containing all possible build targets we're now including all files necessary. Previously we did not include all files and it was necessary to checkout the source git repository to be able building windows targets for the guest agent. This commit provides the necessary changes to include all necessary files for building it from source tar balls. Change-Id: I793b84ac78127593a11ab9894fdbc68fa45d224d Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M GinaSSO/GinaSSO.sln A GinaSSO/Makefile.am M Makefile.am M configure.ac M gdm-plugin/Makefile.am M kdm-plugin/Makefile.am M ovirt-guest-agent/Makefile.am A windows-credprov/Makefile.am 8 files changed, 137 insertions(+), 39 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I793b84ac78127593a11ab9894fdbc68fa45d224d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: refactor invocation flow #949189, #949187
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: refactor invocation flow #949189, #949187 ...................................................................... sdk: refactor invocation flow #949189, #949187 This change introduces workaround for the race conditions on [1] and [2] which are caused by the non ability of the former to supply tread safe environment as seen in #949187 and #949189. https://bugzilla.redhat.com/show_bug.cgi?id=949189 https://bugzilla.redhat.com/show_bug.cgi?id=949187 [1] cookielib.DefaultCookiePolicy [2] httplib.HTTPConnection Change-Id: I4c50e04ef763d4f572cfb4a5e4df0bb045401453 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/connectionspool.py M src/ovirtsdk/infrastructure/proxy.py A src/ovirtsdk/utils/synchronizationhelper.py M src/ovirtsdk/web/connection.py A src/ovirtsdk/web/cookiejaradapter.py 5 files changed, 285 insertions(+), 172 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/13894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c50e04ef763d4f572cfb4a5e4df0bb045401453 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: provide full_version in product_info
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: provide full_version in product_info ...................................................................... restapi: provide full_version in product_info Frontend uses ProductRPMVersion from vdc_options to show Engine version. This patch will include a new element called full_version into ProductInfo xsd schema, which will provide to users the same version info from Frontend. Change-Id: Ie5c03460ef1af943278ab6f5171c042afdf4d392 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=905398 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5c03460ef1af943278ab6f5171c042afdf4d392 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : Error when adding/removing permissions with filter...
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Error when adding/removing permissions with filtered api(#919686) ...................................................................... restapi : Error when adding/removing permissions with filtered api(#919686) Internal server error when UserVmManager adds a User role permission on a VM, the permission gets added. Insufficent privileges error when removing the permission which was added. Change-Id: I47cbb6e06599fc64afcb491bef15b46a82afd681 Bug-Url: https://bugzilla.redhat.com/919686 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java 2 files changed, 9 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47cbb6e06599fc64afcb491bef15b46a82afd681 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : Add permit to role issues(#919202)
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Add permit to role issues(#919202) ...................................................................... restapi : Add permit to role issues(#919202) When trying to add permit to role the permit name needs to accept both lower case and upper case names. Change-Id: I7ae176b9b6d60b4f8a51c16354ec6210f13870c9 Bug-Url: https://bugzilla.redhat.com/919202 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ae176b9b6d60b4f8a51c16354ec6210f13870c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused shutdown commands.
by mlipchuk＠redhat.com 18 Apr '13

18 Apr '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove unused shutdown commands. ...................................................................... core: Remove unused shutdown commands. 1. Removing unused vdc command ShutdownVdsCommand and its parameter class. 2. Removing vds command ShutdownVdsVDSCommand and its parameter class. 3. Finally remove all the their related unused references. Change-Id: I42cb8777ea1838229e05c17cae46e75305510dc6 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsShutdownParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ShutdownVdsVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ShutdownVdsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 22 files changed, 0 insertions(+), 163 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42cb8777ea1838229e05c17cae46e75305510dc6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : missing sync option for action vm import in RSDL(#...
by mpastern＠redhat.com 18 Apr '13

18 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : missing sync option for action vm import in RSDL(#949881) ...................................................................... restapi : missing sync option for action vm import in RSDL(#949881) No sync option in cli for action vm import. Change-Id: I84799bf942dd87956cb2f42c5b57201687d32fda Bug-Url: https://bugzilla.redhat.com/949881 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84799bf942dd87956cb2f42c5b57201687d32fda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: disable SPICE proxy has no effect
by tjelinek＠redhat.com 18 Apr '13

18 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: disable SPICE proxy has no effect ...................................................................... userportal,webadmin: disable SPICE proxy has no effect Edit console dialog -> enable SPICE proxy -> connect to VM-> edit console dialog again -> disable SPICE proxy -> connect to VM After this, the SPICE will connect to the VM using the proxy, because it remembered it from the previous setting. Fixed by resetting the Proxy property if the proxy is not enabled. Change-Id: I5931b4242bdba7755e29c3942a1df2eab03f7b5f Bug-Url: https://bugzilla.redhat.com/924605 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5931b4242bdba7755e29c3942a1df2eab03f7b5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: fixing boxing-unboxing issues
by shavivi＠redhat.com 18 Apr '13

18 Apr '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: fixing boxing-unboxing issues ...................................................................... findbugs: fixing boxing-unboxing issues Change-Id: Ibcec12523c2d09b15c2322e3b82ee47e27d03836 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/VmStatisticalQuery.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java 11 files changed, 15 insertions(+), 13 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcec12523c2d09b15c2322e3b82ee47e27d03836 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: PoolModelBehavior fix disk availability
by derez＠redhat.com 18 Apr '13

18 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: PoolModelBehavior fix disk availability ...................................................................... webadmin: PoolModelBehavior fix disk availability * Removed a redundant call to setIsDisksAvailable, 'setIsDisksAvailable' is already set correctly on InitDisks (causes an NPE in DisksAllocationModel -> sortDisks). * UpdateIsDisksAvailable -> added the same logic as in NewVmModelBehavior. Change-Id: I888147a7b61c49de7eb4ba9426f9e933113cb04b Bug-Url: https://bugzilla.redhat.com/928410 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I888147a7b61c49de7eb4ba9426f9e933113cb04b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Classes that implements Comparator need to impleme...
by shavivi＠redhat.com 18 Apr '13

18 Apr '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Classes that implements Comparator need to implement Serializable ...................................................................... findbugs: Classes that implements Comparator need to implement Serializable Change-Id: I6cac31263f151b2494845234f6ab21366b124181 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainsByTypeComparer.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/LexoNumericComparator.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java 6 files changed, 30 insertions(+), 24 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cac31263f151b2494845234f6ab21366b124181 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: VmTemplate cleanup (2/3)
by lhornyak＠redhat.com 18 Apr '13

18 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: VmTemplate cleanup (2/3) ...................................................................... engine: VmTemplate cleanup (2/3) - getters and setters renamed Change-Id: I3dcb9493953a7206dab16bf30aeec87a43358093 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByVmTemplateIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/OvfDataUpdaterTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDAOTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkTemplateView.java 33 files changed, 72 insertions(+), 72 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3dcb9493953a7206dab16bf30aeec87a43358093 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix QuotaManager internal rollback
by gchaplik＠redhat.com 18 Apr '13

18 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix QuotaManager internal rollback ...................................................................... core: Fix QuotaManager internal rollback When two or more VDSGroup quota request were sent to the QuotaManager together and one consumption request failed - the QuotaMAnager didnot roll back the requests that already passed. Added a rollback for the VDSGroup quotas if one request failed. Change-Id: I3cee6810900c17f64d6ae47056969e656b1a4840 Bug-Url: https://bugzilla.redhat.com/950926 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java 1 file changed, 41 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cee6810900c17f64d6ae47056969e656b1a4840 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: VmTemplate cleanup (1/3)
by lhornyak＠redhat.com 18 Apr '13

18 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: VmTemplate cleanup (1/3) ...................................................................... engine: VmTemplate cleanup (1/3) - constructor param names - field names Change-Id: Ie40a67a3172fe6c812ee8fc0b8c0e170fb7b8e59 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java 1 file changed, 24 insertions(+), 24 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie40a67a3172fe6c812ee8fc0b8c0e170fb7b8e59 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: always update console from local storage
by tjelinek＠redhat.com 18 Apr '13

18 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: always update console from local storage ...................................................................... userportal: always update console from local storage The details view of the basic view shows the SPICE instead of RDP even the RDP has been selected in the edit console. The problem was, that the UserPortalItemModel has been updated from local storage only: - before the popup dialog has been opened - before the console connect has been called This patch adds this update right after the UserPortalItemModel is created so it will be up to date right after loading the data from the server. Change-Id: I87e0cd9d8b1912845b5b7ae5ebedf3a9b02bd2b5 Bug-Url: https://bugzilla.redhat.com/924610 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13948 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87e0cd9d8b1912845b5b7ae5ebedf3a9b02bd2b5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: pass smartcard option also to ActiveX
by tjelinek＠redhat.com 18 Apr '13

18 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: pass smartcard option also to ActiveX ...................................................................... userportal,webadmin: pass smartcard option also to ActiveX Since the SPICE ActiveX plugin already supports the smartcard option, passing this option also to it (the same way as already done for XPI) Change-Id: Ib1fc9c237cb29b48b255174c4669974ef56e0f12 Bug-Url: https://bugzilla.redhat.com/953098 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1fc9c237cb29b48b255174c4669974ef56e0f12 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DLS in OvfLogEventHandler.addValueForAlias
by rgolan＠redhat.com 18 Apr '13

18 Apr '13

Roy Golan has submitted this change and it was merged. Change subject: core: DLS in OvfLogEventHandler.addValueForAlias ...................................................................... core: DLS in OvfLogEventHandler.addValueForAlias Removed the DLs regarding the OvfExportOnlyField annotation in said method. Change-Id: Iebd4a93d37553fe73977d68fa694aa61119edf1f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfLogEventHandler.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebd4a93d37553fe73977d68fa694aa61119edf1f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Japanese - truncated text in snapshots sub-tab
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Japanese - truncated text in snapshots sub-tab ...................................................................... webadmin: Japanese - truncated text in snapshots sub-tab VMs - snapshots sub-tab: - fix columns width. - change header cells 'white-space' to normal (to allow multiple rows). Change-Id: I02f7afb0b7521886df2cf0d99fa9d2b19e077d31 Bug-Url: https://bugzilla.redhat.com/927617 Bug-Url: https://bugzilla.redhat.com/951067 Bug-Url: https://bugzilla.redhat.com/950289 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.ui.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/PopupCellTable.css 3 files changed, 10 insertions(+), 10 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02f7afb0b7521886df2cf0d99fa9d2b19e077d31 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Japanese - truncated text in disk dialog
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Japanese - truncated text in disk dialog ...................................................................... webadmin: Japanese - truncated text in disk dialog Attach Disk dialog: fix columns' width. Change-Id: Ie630bbc4b0647d04454ecc585f5c07f150b580ed Bug-Url: https://bugzilla.redhat.com/927613 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDiskPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDiskPopupView.java 3 files changed, 13 insertions(+), 13 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie630bbc4b0647d04454ecc585f5c07f150b580ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: French - truncated text in luns list
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: French - truncated text in luns list ...................................................................... webadmin: French - truncated text in luns list Storage Domain dialog: fix '#path' and 'Vendor Id' width. Change-Id: Ie6bb918b26eda3a283d23495947b1fa83a6a0939 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/SanStorageListLunRoot.css M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/SanStorageListLunTable.css M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/SanStorageListTargetRoot.css M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/SanStorageListTargetTable.css 6 files changed, 10 insertions(+), 10 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6bb918b26eda3a283d23495947b1fa83a6a0939 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Japanese - truncated text in login button
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Japanese - truncated text in login button ...................................................................... webadmin: Japanese - truncated text in login button Storage Domain dialog - target list: fix 'Login' button style. Change-Id: I1a94eab7bfae4c852d0abe1fdbde1175a3509234 Bug-Url: https://bugzilla.redhat.com/927504 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a94eab7bfae4c852d0abe1fdbde1175a3509234 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Japanese - truncated text in target list
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Japanese - truncated text in target list ...................................................................... webadmin: Japanese - truncated text in target list Storage Domain dialog - target list: fix 'Dev.Size' column width. Change-Id: I569b5f86bdd00ecb1f9c78a47306a44aeb89e209 Bug-Url: https://bugzilla.redhat.com/927504 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I569b5f86bdd00ecb1f9c78a47306a44aeb89e209 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Remove deprecated CopyTemplate logic
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Remove deprecated CopyTemplate logic ...................................................................... webadmin: Remove deprecated CopyTemplate logic CopyTemplate is deprecated since MSD (multiple storage domains), hence its logic is no longer needed in the UI. Change-Id: I481ee7bd0c81d8d72d8bc4b6c2a09f22d4d6867a Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/TemplateModule.java 2 files changed, 0 insertions(+), 82 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I481ee7bd0c81d8d72d8bc4b6c2a09f22d4d6867a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Remove deprecated MoveVm logic
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Remove deprecated MoveVm logic ...................................................................... webadmin: Remove deprecated MoveVm logic MoveVm is deprecated since MSD (multiple storage domains), hence its logic is no longer needed in the UI. Change-Id: Ia564a1fc35d1d76e3a2331d43a03afa5b53df4a8 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java 2 files changed, 0 insertions(+), 57 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia564a1fc35d1d76e3a2331d43a03afa5b53df4a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VmInfoBuilder - use VdsProperties.IDE
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: core: VmInfoBuilder - use VdsProperties.IDE ...................................................................... core: VmInfoBuilder - use VdsProperties.IDE VmInfoBuilder - use VdsProperties.IDE constant instead of hard-coded "ide". Change-Id: I3563cc71a37cfa23e55d8e4748086aadf2d92e2e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3563cc71a37cfa23e55d8e4748086aadf2d92e2e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: Perform string sanitization on messages
by bazulay＠redhat.com 17 Apr '13

17 Apr '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: Perform string sanitization on messages ...................................................................... agent: Perform string sanitization on messages Messages sent via VirtIO are now checked for being presentable and additionally filtered for invalid characters due to invalid encodings. Change-Id: I499a22e1572b55d1a3a4de7ce6f89ebb130861a8 Bug-Url: https://bugzilla.redhat.com/947014 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/VirtIoChannel.py 1 file changed, 67 insertions(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Barak Azulay: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I499a22e1572b55d1a3a4de7ce6f89ebb130861a8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DiskInterface enum - remove deprecated SCSI
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: core: DiskInterface enum - remove deprecated SCSI ...................................................................... core: DiskInterface enum - remove deprecated SCSI SCSI DiskInterface is not supported, hence removing it. Change-Id: I416bd5ccce35b82b943506e6c6542ba44aa5d0c9 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskInterface.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 3 files changed, 1 insertion(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I416bd5ccce35b82b943506e6c6542ba44aa5d0c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VdsProperties - rename NETWORK_INTERFACE
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: core: VdsProperties - rename NETWORK_INTERFACE ...................................................................... core: VdsProperties - rename NETWORK_INTERFACE VdsProperties -> NETWORK_INTERFACE constant is used both for network-interface and disk-interface. Hence, renaming to the generic concept: INTERFACE. Change-Id: I208f8369084d5a3d42cfb7ebb592569f6063a4d3 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 4 files changed, 8 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I208f8369084d5a3d42cfb7ebb592569f6063a4d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix the enable-dao-tests
by amureini＠redhat.com 17 Apr '13

17 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix the enable-dao-tests ...................................................................... core: Fix the enable-dao-tests Change Ia736419e added a database test to DbConfigUtilsTest, which was not a database test originally. This causes the regular test suite to fail since no database is present. The following patch amends the dal module's pom not to run this test by default, but only when -Penable-dao-tests is specified. This is done by adding this test to the default ignore list, and overriding the surefire-plugin configuration in the profile. Change-Id: Icbc55a014a54c584a476e66612e54b8b926d02c4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/pom.xml 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbc55a014a54c584a476e66612e54b8b926d02c4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine : incomplete error when trying to add host with wrong...
by yzaslavs＠redhat.com 17 Apr '13

17 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : incomplete error when trying to add host with wrong cluster ID ...................................................................... engine : incomplete error when trying to add host with wrong cluster ID An internal error when wrong cluster id is passed causing incomplete error message. Change-Id: If54bcf4ab325d607c869bb8aec609718c15e8b26 Bug-Url: https://bugzilla.redhat.com/890469 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If54bcf4ab325d607c869bb8aec609718c15e8b26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: engine : incomplete error when trying to add host with wrong...
by yzaslavs＠redhat.com 17 Apr '13

17 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : incomplete error when trying to add host with wrong cluster ID ...................................................................... engine : incomplete error when trying to add host with wrong cluster ID An internal error when wrong cluster id is passed causing incomplete error message. Change-Id: If54bcf4ab325d607c869bb8aec609718c15e8b26 Bug-Url: https://bugzilla.redhat.com/890469 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If54bcf4ab325d607c869bb8aec609718c15e8b26 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Do not add disk in snapshot preview
by ofrenkel＠redhat.com 17 Apr '13

17 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Do not add disk in snapshot preview ...................................................................... engine: Do not add disk in snapshot preview Do not allow to add image disk, sharable disk or LUN to a VM in snapshot preview mode (in shutdown or up states). The condition is indicated by the error dialog message: "Cannot add Virtual Machine Disk. VM is previewing a Snapshot." Change-Id: Ibfde0540f1d77456ed1412b015a0963f4682039f Bug-Url: https://bugzilla.redhat.com/909708 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 8 files changed, 47 insertions(+), 21 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfde0540f1d77456ed1412b015a0963f4682039f Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix backend allow 'cpu pinning' with no host
by lhornyak＠redhat.com 17 Apr '13

17 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Fix backend allow 'cpu pinning' with no host ...................................................................... core: Fix backend allow 'cpu pinning' with no host When working via API the user could add a VM with no defined host (start from any host in cluster) and set the 'cpu pinning' string. This should not be permitted. Fixed the validity checked in the AddVmCommand and UpdateVmCommand. Added a new error message. Change-Id: Iff00debc039a5476c19966dd91425566a3562e02 Bug-Url: https://bugzilla.redhat.com/928689 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 6 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff00debc039a5476c19966dd91425566a3562e02 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: packaging: post ovirt-log-collector-3.2.2
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: packaging: post ovirt-log-collector-3.2.2 ...................................................................... packaging: post ovirt-log-collector-3.2.2 Change-Id: I7280b4af6bd72ed7c8b0a91aa2bfcda8aba109fb Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7280b4af6bd72ed7c8b0a91aa2bfcda8aba109fb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: packaging: ovirt-log-collector-3.2.2
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: packaging: ovirt-log-collector-3.2.2 ...................................................................... packaging: ovirt-log-collector-3.2.2 Change-Id: Ic964c2af85c53a8c3d2c1f7ebdc0a0a47dc3003c Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac M ovirt-log-collector.spec.in 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic964c2af85c53a8c3d2c1f7ebdc0a0a47dc3003c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.2]: packaging: ovirt-image-uploader-3.2.2
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: packaging: ovirt-image-uploader-3.2.2 ...................................................................... packaging: ovirt-image-uploader-3.2.2 Change-Id: I667b9f3eb86a487f128e79d0845cb0c4d823f671 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac M ovirt-image-uploader.spec.in 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I667b9f3eb86a487f128e79d0845cb0c4d823f671 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: enhance warning dialog on host restart
by oourfali＠redhat.com 17 Apr '13

17 Apr '13

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: enhance warning dialog on host restart ...................................................................... webadmin: enhance warning dialog on host restart When restarting a host using power management, running VMs will be ungracefully stopped. This patch adds the number of VMs on each host to the warning dialog. Change-Id: If1c09b529d445ce4e6c3131d227ceffb22cd292d Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 3 files changed, 19 insertions(+), 7 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1c09b529d445ce4e6c3131d227ceffb22cd292d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.2]: packaging: post ovirt-iso-uploader-3.2.2
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: packaging: post ovirt-iso-uploader-3.2.2 ...................................................................... packaging: post ovirt-iso-uploader-3.2.2 Change-Id: I2c692dc31d87d4486a641c5bab1e1d32987ca974 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c692dc31d87d4486a641c5bab1e1d32987ca974 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.2]: packaging: ovirt-iso-uploader-3.2.2
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: packaging: ovirt-iso-uploader-3.2.2 ...................................................................... packaging: ovirt-iso-uploader-3.2.2 Change-Id: I2c9c45c5e05618a5a8709866605041fdb6f4552d Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac M ovirt-iso-uploader.spec.in 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c9c45c5e05618a5a8709866605041fdb6f4552d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove validateStorageServerConnection
by lhornyak＠redhat.com 17 Apr '13

17 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove validateStorageServerConnection ...................................................................... core: Remove validateStorageServerConnection After change I7b3bc2491943a6daa21228e37169c83f32865984 removed all usages of the validateStorageServerConnection method from the engine's code, this patch removes the method itself. Change-Id: I2d87168e52e3b9df15418cbf3a6693ae00214de4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 3 files changed, 0 insertions(+), 20 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d87168e52e3b9df15418cbf3a6693ae00214de4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed AddSelfPermissionCommand
by lhornyak＠redhat.com 17 Apr '13

17 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Removed AddSelfPermissionCommand ...................................................................... core: Removed AddSelfPermissionCommand This command is unused, and it does not seem to have any meaningful content, and thus can be removed. This patch removes the following: 1. The MigrateIrsSnapshotsRoVdcCommand class 2. The corresponding constant in VdcActionType Change-Id: I479e62b29570b8e6c3b7fec811efd58b50a5dc86 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddSelfPermissionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 0 insertions(+), 24 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I479e62b29570b8e6c3b7fec811efd58b50a5dc86 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused ExportCandaidateVDSCommand
by lhornyak＠redhat.com 17 Apr '13

17 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove unused ExportCandaidateVDSCommand ...................................................................... core: Remove unused ExportCandaidateVDSCommand ExportCandidateVDSCommand was not used anywhere in the code, and should thus be removed. This patch removes the following: 1. The ExportCandidateVDSCommand class 2. The corresponding ExportCandidateVDSCommandParameters class 3. The corresponding ExportCandidate constant in VDSCommandType 4. The exportCandidate method from IIrsServer/IrsServerConnector/IrsServerWrapper Change-Id: I7bfcdf24b05a7e90fe4a2d1b536c5a927297fd16 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ExportCandidateVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ExportCandidateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java 6 files changed, 0 insertions(+), 194 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bfcdf24b05a7e90fe4a2d1b536c5a927297fd16 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed MigrateIrsSnapshotsToVdcCommand
by lhornyak＠redhat.com 17 Apr '13

17 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Removed MigrateIrsSnapshotsToVdcCommand ...................................................................... core: Removed MigrateIrsSnapshotsToVdcCommand This command is unused (and all its content is commented out anyway), and thus can (and should be removed). This patch removes the following: 1. The MigrateIrsSnapshotsRoVdcCommand class 2. The corresponding constant in VdcActionType Change-Id: I6584a79c777c8b44c23159850d133c7c514b5c87 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateIrsSnapshotsToVdcCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 1 insertion(+), 30 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6584a79c777c8b44c23159850d133c7c514b5c87 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused VmLockCommad
by lhornyak＠redhat.com 17 Apr '13

17 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove unused VmLockCommad ...................................................................... core: Remove unused VmLockCommad VmLockCommand is not used anywhere in the codebsae, and can thus be removed. This patch removes: 1. The VmLockCommand class 2. Its corresponding constant in VdcActionType 3. The VmLockVDSCommand class, only used by VmLockCommand 4. The corresponding constant in VDSCommantType 5. The VmLockVDSCommandParameters class, only used by VmLockVDSCommand 6. The vmLock method in IVdsServer/VdsServerConnector/VdsServerWrapper which was only used by VmLockVDSCommand Change-Id: I00ffd5da1a93271cd4cc31de0f72953d78e4d62a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLockCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmLockVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmLockVDSCommand.java 8 files changed, 0 insertions(+), 68 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00ffd5da1a93271cd4cc31de0f72953d78e4d62a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: quota: general subtab: set empty label
by gchaplik＠redhat.com 17 Apr '13

17 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: quota: general subtab: set empty label ...................................................................... webadmin: quota: general subtab: set empty label In case quota is enforced, and not configured per vm/template, set the general-subtab quota name label with not-configured. Change-Id: I500aca2003f31c7bd77b501a734224d082002740 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java 3 files changed, 33 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I500aca2003f31c7bd77b501a734224d082002740 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.2]: Revert "packaging: ovirt-iso-uploader-3.2.1-2"
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: Revert "packaging: ovirt-iso-uploader-3.2.1-2" ...................................................................... Revert "packaging: ovirt-iso-uploader-3.2.1-2" This reverts commit 5729686b0ddeb0135fe0a9e625d980bddbadf793 --- M configure.ac M ovirt-iso-uploader.spec.in 2 files changed, 3 insertions(+), 6 deletions(-) Approvals: Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8839eceb98e4bea9a60978ee087a70b62eb8b461 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.2]: packaging: ovirt-iso-uploader-3.2.1-2
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: packaging: ovirt-iso-uploader-3.2.1-2 ...................................................................... packaging: ovirt-iso-uploader-3.2.1-2 Change-Id: Ie2d11579ca12387a147eb615225395b185afa603 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac M ovirt-iso-uploader.spec.in 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2d11579ca12387a147eb615225395b185afa603 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0