April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: pki: set keys permission to world readable and owned by root
by bazulay＠redhat.com 03 Apr '13

03 Apr '13

Barak Azulay has submitted this change and it was merged. Change subject: pki: set keys permission to world readable and owned by root ...................................................................... pki: set keys permission to world readable and owned by root This enables all applications to access the keys. Each key is protected by its own permissions, so we are not exposing anything new. Engine does not generate new keys so no need to be writable by engine. Change-Id: Iedd916d41aca4f80a25c9ab13a240b57a5577b0b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedd916d41aca4f80a25c9ab13a240b57a5577b0b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: set ownership of apache key to root
by bazulay＠redhat.com 03 Apr '13

03 Apr '13

Barak Azulay has submitted this change and it was merged. Change subject: pki: set ownership of apache key to root ...................................................................... pki: set ownership of apache key to root Apache reads the keys before dropping privileges, correct permissions are read by root. Change-Id: I7f3ab38f6e3f4e03244878877d4bab0fd72bc3c4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f3ab38f6e3f4e03244878877d4bab0fd72bc3c4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: ensure restored engine db objects are owned by engine user
by emesika＠redhat.com 03 Apr '13

03 Apr '13

Eli Mesika has submitted this change and it was merged. Change subject: ensure restored engine db objects are owned by engine user ...................................................................... ensure restored engine db objects are owned by engine user When restoring a DB from a 3.1 system that upgraded from 3.0, onto another 3.1 system that wasn't upgraded from 3.0, then you encounter permission denied messages from postgresql because the engine DB objects are owned by the postgres user instead of the engine user. This patch checks to see if the engine DB objects are owned by the engine user and if not, alters the ownership. Change-Id: I5f16f66066d9056c97a32f180c02d8bd248d1eac Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=923614 Signed-off-by: Mark Huth <mhuth(a)redhat.com> --- M backend/manager/dbscripts/dbcustomfunctions.sh M backend/manager/dbscripts/restore.sh 2 files changed, 29 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f16f66066d9056c97a32f180c02d8bd248d1eac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mark Huth <mhuth(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mark Huth <mhuth(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Power Management or fence errors are not...
by emesika＠redhat.com 03 Apr '13

03 Apr '13

Eli Mesika has submitted this change and it was merged. Change subject: core:Power Management or fence errors are not... ...................................................................... core:Power Management or fence errors are not... Power Management or fence errors are not logged in EVENT tab of GUI. Adding missing handling in VdsNotRespondingTreatmentCommand::canDoAction to log the failure as an alert if validation of this command fail as a result of a PM that was not configured properly. (Actually removing the "if" that did that only if Host PM is not configured at all...) Change-Id: Ic6aac13138c33f2631a1ea424428b4785c1d5700 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6aac13138c33f2631a1ea424428b4785c1d5700 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: taskcleaner.sh should treat null argument as -h
by emesika＠redhat.com 03 Apr '13

03 Apr '13

Eli Mesika has submitted this change and it was merged. Change subject: core: taskcleaner.sh should treat null argument as -h ...................................................................... core: taskcleaner.sh should treat null argument as -h Adding a check for the USERNAME which is mandatory. Change-Id: I8505ff75d1b22eb27b3aa928d254cc6830b9f4c5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=924246 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/tools/dbutils/taskcleaner.sh 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8505ff75d1b22eb27b3aa928d254cc6830b9f4c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: on handing over a VM mark it as MigratingTo
by rgolan＠redhat.com 03 Apr '13

03 Apr '13

Roy Golan has submitted this change and it was merged. Change subject: core: on handing over a VM mark it as MigratingTo ...................................................................... core: on handing over a VM mark it as MigratingTo This patch aims to reflect the VM handover more clear so instead of moving a VM to Unknown it will move to MigratingTo (unless the host is *already* NonResponging) so tracking a VM status transition wouldn't puzzle users (at least would be less confusing and more script friendly as the script won't discover a VM is suddenly Uknown) Non responding treatment has been changed to collect also VMs that are migrating to the host (i.e status MigratingTo and run_on_vds == nonRespongindVds) Change-Id: I96b855c11171fd5f65cd2e22801d09608cba805d Signed-off-by: Roy Golan <rgolan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/909932 --- M backend/manager/dbscripts/vms_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 5 files changed, 32 insertions(+), 7 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96b855c11171fd5f65cd2e22801d09608cba805d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove default locking pairs
by mkublin＠redhat.com 03 Apr '13

03 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: core: remove default locking pairs ...................................................................... core: remove default locking pairs This patch remove the default locking pairs in LockMessagesMatchUtil. The error message in those pairs was too general and not informative enough, so they should not be used. The usages of those pairs were replaced with calls to LockMessagesMatchUtil#makeLockingPair, using the locking group that was used before and the error message ACTION_TYPE_FAILED_OBJECT_LOCKED, and the error message ACTION_TYPE_FAILED_OBJECT_LOCKED is now marked as deprecated. Change-Id: Ic24c713bb1f38f32a4109b951131b47da20345ea Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LockMessagesMatchUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ForceRemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java 40 files changed, 140 insertions(+), 74 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic24c713bb1f38f32a4109b951131b47da20345ea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removing CustomLogFields annotattion (Second super f...
by mkublin＠redhat.com 03 Apr '13

03 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing CustomLogFields annotattion (Second super fix in AuditLogDirector) ...................................................................... engine: Removing CustomLogFields annotattion (Second super fix in AuditLogDirector) After some investigation I found out that we don't need CustomLogFields annotaattion at all, this is a best optimization which can be done here. We don't need it because of all required names of parameters are located inside our audit log message and their values will be retrieved via reflection, that's why we don't need to keep additional list of parameters names inside annotattion. Benefits: 1. Reduced number of operations for processing annotattion (Improved CPU consaption) 2. Simplified development of audit log messages, no need for annotattion. 3. Code becomes understandable for everyone (at least I hope) This is a kind of patch that I like: 1. Improved perfromance 2. Code becomes more clear 3. A lot of garbage removed Change-Id: Ied60d0000e26158baee64c83540d683093485dd8 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BookmarkCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeFloppyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveTagCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PermissionsCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaCRUDCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAdGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RolesCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateDisplayToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolSimpleUserCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolToAdGroupBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VdsBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VdsNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SetStoragePoolStatusCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogHelper.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/CustomLogFields.java D backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogHelperTest.java D backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/BaseClass.java D backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/MultiChild.java D backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/SingleChild.java 41 files changed, 0 insertions(+), 182 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied60d0000e26158baee64c83540d683093485dd8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removing CustomLogField annotation
by mkublin＠redhat.com 03 Apr '13

03 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing CustomLogField annotation ...................................................................... engine: Removing CustomLogField annotation The following annotation is not required, the uses of this annotation is not required. The annotation is removed, from now code look like regular java-style code Change-Id: I8a520707c979ab6b9ce479398facc364515d406f Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BookmarkCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeFloppyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveTagCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PermissionsCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaCRUDCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAdGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RolesCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateDisplayToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolSimpleUserCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolToAdGroupBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VdsBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VdsNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SetStoragePoolStatusCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogHelper.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/CustomLogField.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/CustomLogFields.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/BaseClass.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/MultiChild.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/SingleChild.java 40 files changed, 42 insertions(+), 94 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a520707c979ab6b9ce479398facc364515d406f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Improving job messages for event subscription commands
by yzaslavs＠redhat.com 03 Apr '13

03 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Improving job messages for event subscription commands ...................................................................... core: Improving job messages for event subscription commands Improving job messages for AddEventSubscription and RemoveEventSubscription Change-Id: Ic263b8f59c36fc97f1733317edbd17dbaa5487dd Bug-Url: https://bugzilla.redhat.com/919045 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic263b8f59c36fc97f1733317edbd17dbaa5487dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: java.lang.NullPointerException for SpmStatusVDS
by mkublin＠redhat.com 03 Apr '13

03 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: java.lang.NullPointerException for SpmStatusVDS ...................................................................... engine: java.lang.NullPointerException for SpmStatusVDS The NullPointerException is occurred because of internal race between SPM stop and monitoring of storage pool. The race is not dangereous, so as workaround I solved an exception. A race will be solved in the future Change-Id: I4417d1721cfe8365780345e01dbe84c6636cca6e Bug-Url: https://bugzilla.redhat.com/920736 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Michael Kublin: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4417d1721cfe8365780345e01dbe84c6636cca6e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Extract code of network role columns
by alkaplan＠redhat.com 02 Apr '13

02 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Extract code of network role columns ...................................................................... webadmin: Extract code of network role columns NetworkRoleColumnHelper is introduced to re-use the construction of value and tool tip in various network role columns (Network Main tab, Network Cluster sub tab and Cluster Network sub tab). Change-Id: I36ea65cce1ec3718838d5d2f8252adcc996b2fa7 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterNetworkView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/NetworkRoleColumnHelper.java 4 files changed, 108 insertions(+), 68 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36ea65cce1ec3718838d5d2f8252adcc996b2fa7 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: adding migration role to a network.
by alkaplan＠redhat.com 02 Apr '13

02 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: adding migration role to a network. ...................................................................... webadmin: adding migration role to a network. Just one network in a cluster can have this role. The effected dialogs are- Migration column was added- Network->Cluster->Assign/Unassing Cluster->Network->Assign/Unassign Migration icon was added to the roles icons on network panel and tooltip Network->Host->SetupNetworks Host->Network Interfaces->SetupNetworks The effected sub-tabs are- The role column was update to show also migration network Network->Cluster Cluster->Network Change-Id: I9752b182fd15f0557575ebe7e0271f6dd7a916f9 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterNetworkView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/migration_network.png 12 files changed, 216 insertions(+), 42 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9752b182fd15f0557575ebe7e0271f6dd7a916f9 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: add copy of migration property to NetworkCluster c...
by alkaplan＠redhat.com 02 Apr '13

02 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: add copy of migration property to NetworkCluster cloner. ...................................................................... webadmin: add copy of migration property to NetworkCluster cloner. "migration" is a property that was added to NetworkCluster business entity. The cloner of NetworkCluster should clone also this entity. Change-Id: I29d61c9cea1cc6d6269352297fd22f16d988450f Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29d61c9cea1cc6d6269352297fd22f16d988450f Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Extending migrate verb with an additional parameter-...
by alkaplan＠redhat.com 02 Apr '13

02 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Extending migrate verb with an additional parameter- "dstqemu" ...................................................................... engine: Extending migrate verb with an additional parameter- "dstqemu" The dstqemu will contain the dedicated migration address of destination host (the ip of the cluster-migration network on the destination host). If there is no migration network in the cluster or the destination host doesn't contain the migration network, "dstqemu" won't be sent to the vdsm. (vdsm will use the management network sent on "dst" pararamer for the migration). Change-Id: Ic460c2b8ebfb870a610f5816643d9855495dc7b1 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MigrateVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 4 files changed, 54 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic460c2b8ebfb870a610f5816643d9855495dc7b1 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: adding "migration" property to NetworkCluster
by alkaplan＠redhat.com 02 Apr '13

02 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: adding "migration" property to NetworkCluster ...................................................................... engine: adding "migration" property to NetworkCluster Updating the business entity and the related db scripts. This property will be used to indicate whether the network is the cluster's migration network. Change-Id: I199b1f48b6d6096db2425c594e88455640dc626c Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/network_sp.sql A backend/manager/dbscripts/upgrade/03_03_0010_add_migration_to_network_cluster.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToVdsGroupParameter.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkCluster.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkClusterDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkClusterDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkClusterDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 21 files changed, 224 insertions(+), 30 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I199b1f48b6d6096db2425c594e88455640dc626c Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: adding "NetworkMigrationEnabled" to vdc_options.
by alkaplan＠redhat.com 02 Apr '13

02 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: adding "NetworkMigrationEnabled" to vdc_options. ...................................................................... engine: adding "NetworkMigrationEnabled" to vdc_options. Migration network is 3.3 feature. Each cluster can have one migration network. If a network is signed as a "migration network" the vm migration inside the cluster will be done via this network. If there is no migration network the migration proccess will be done via the managment network. Change-Id: Ib553b8ac2c2015659c59c8cddfd2329530133b30 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java 4 files changed, 19 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib553b8ac2c2015659c59c8cddfd2329530133b30 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fix brick validation during create volume
by sanjal＠redhat.com 02 Apr '13

02 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Fix brick validation during create volume ...................................................................... engine: Fix brick validation during create volume while creating a volume, the bricks will be validated against the entries in gluster_volume_bricks table. The above check is already present during add bricks(after volume creation), now this is included in create volume as well. Change-Id: Ie5c9afac29c2c982544b636c9d731ac39803cc7c Bug-Url: https://bugzilla.redhat.com/856109 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java 5 files changed, 42 insertions(+), 34 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5c9afac29c2c982544b636c9d731ac39803cc7c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Unit test cases for create gluster volume command
by sanjal＠redhat.com 02 Apr '13

02 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Unit test cases for create gluster volume command ...................................................................... engine: Unit test cases for create gluster volume command Unit test cases are added for create gluster volume command. Change-Id: Ie26c6df7c6697abd786a5625783e17d4293c7241 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java 1 file changed, 168 insertions(+), 0 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie26c6df7c6697abd786a5625783e17d4293c7241 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: release 3.3.0.1-1
by mpastern＠redhat.com 02 Apr '13

02 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: release 3.3.0.1-1 ...................................................................... cli: release 3.3.0.1-1 Change-Id: I34361ce8da253cc2f633e51ecdbd2f81d0c173f8 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 18 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34361ce8da253cc2f633e51ecdbd2f81d0c173f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: release 3.3.0.1-1
by mpastern＠redhat.com 02 Apr '13

02 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 3.3.0.1-1 ...................................................................... sdk: release 3.3.0.1-1 Change-Id: I3981966bb960a0e1d0fd6a15f06fe7bba97641f7 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-sdk.spec.in 2 files changed, 27 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3981966bb960a0e1d0fd6a15f06fe7bba97641f7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: regenerate against the latest api
by mpastern＠redhat.com 02 Apr '13

02 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: regenerate against the latest api ...................................................................... sdk: regenerate against the latest api - added new collection ClusterGlusterVolumeBrickStatistics - added new argument to the ClusterGlusterVolumeBricks.list(all_content=None) - added NetUp 'cloned disk' importing capabilities - to host install method added new parameter "image" - to host add method added new parameter "display.address" - to vm add method added new parameter "vm.cpu.mode" - to vm add method added new overload for creating vm from snapshot Change-Id: Ice91c2cd3744b177baf9dcabd091108990d01ee4 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 2 files changed, 1,239 insertions(+), 21 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice91c2cd3744b177baf9dcabd091108990d01ee4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Wrong error message is shown, when SuperUser permi...
by mkublin＠redhat.com 02 Apr '13

02 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: webadmin: Wrong error message is shown, when SuperUser permissions are removing from admin internal ...................................................................... webadmin: Wrong error message is shown, when SuperUser permissions are removing from admin internal The following bug contains two errors: 1. Fixing error message: Cannot ${action} ${type}. 2. In canDoAction() , if we failed at first condition, no reason to perfrom additional checks Change-Id: I825a379b383fd923046e17e6f1d27c6003c48900 Bug-Url: https://bugzilla.redhat.com/924880 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 15 insertions(+), 4 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I825a379b383fd923046e17e6f1d27c6003c48900 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.2]: sdk: return error if amount of fetched objects in X.get() is...
by mpastern＠redhat.com 02 Apr '13

02 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: return error if amount of fetched objects in X.get() is > 1 #890327 ...................................................................... sdk: return error if amount of fetched objects in X.get() is > 1 #890327 https://bugzilla.redhat.com/show_bug.cgi?id=890327 Change-Id: I98b72a9235825f62297b35a26c0bd76413bc0143 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/templates/collectiongetdiskstemplate M src/codegen/templates/collectiongetnotsearchabletemplate M src/codegen/templates/collectiongetsearchabletemplate M src/codegen/templates/subcollectiongettemplate M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/infrastructure/errors.py M src/ovirtsdk/utils/filterhelper.py M src/ovirtsdk/xml/params.py 8 files changed, 415 insertions(+), 85 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98b72a9235825f62297b35a26c0bd76413bc0143 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Block Hot Adding a Nic in 3.0
by msalem＠redhat.com 02 Apr '13

02 Apr '13

Muli Salem has submitted this change and it was merged. Change subject: engine: Block Hot Adding a Nic in 3.0 ...................................................................... engine: Block Hot Adding a Nic in 3.0 This patch makes sure not to hot-plug a nic in a VM that belongs to a cluster with a version that does not support hot-plugging. Previously, the condition that was used in the canDoAction coupled between two conditions that are not related. Change-Id: Ic0ee6563b55a84421b3a9a068e6d69ff228d46ae Bug-Url: https://bugzilla.redhat.com/923332 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0ee6563b55a84421b3a9a068e6d69ff228d46ae Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Additional clean up in AuditLogDirector
by mkublin＠redhat.com 02 Apr '13

02 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Additional clean up in AuditLogDirector ...................................................................... engine: Additional clean up in AuditLogDirector Variable auditLogable can not be null, if it null we will fail on NullPointerException inside updateTimeoutLogableObject method. After removing such condition, were removed all relevant and dead code. Also, I chnaged tempVar to auditLog varibale, don't see reason for using tempVar Change-Id: Ia0eb406d78965bb0d84c7ce80761028877ab2879 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 38 insertions(+), 48 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0eb406d78965bb0d84c7ce80761028877ab2879 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Clean unused method
by mkublin＠redhat.com 02 Apr '13

02 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Clean unused method ...................................................................... engine: Clean unused method The following method is not in use, so removed Change-Id: I82d7ae999a38c4ec9690192e4e26d09bf0f5343f Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java 2 files changed, 0 insertions(+), 25 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82d7ae999a38c4ec9690192e4e26d09bf0f5343f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Super audit log improvement
by mkublin＠redhat.com 02 Apr '13

02 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Super audit log improvement ...................................................................... engine: Super audit log improvement So what is current (before patch) behaviour inorder to make some audit log message: 1. Pass class that extends AuditLogableBase 2. Pass a message with keys that should be replaces based on properties from passed class 3. Go over all properties in passed class, collect them and create a HashMap with key as property name and value as property value 4. Replace keys in message using a created HashMap. Now, lets take a look on 3, how we retrieve a properties - we invoke all getXXX methods in our class. How many getXXX methods has simple AuditLogableBase class? How big will be our HashMap? How many queries/calculations will run during invoking some of the getXXX messages, because our class not simple bean? The only answer is a lot, only in simple run I saw a HashMap with 150 values (sic!). I fix this, if I have a message I know all keys that I need, I don't need to go throught all getXXX methods. Intresting fact: optimized solution required less code. Another intresting fact - adding of additional getter to AuditLogableBase, before a fix, was like adding a small brake to the system. Change-Id: Id68a098be36fcfc47c23c57fce3abea50e6273e3 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorTest.java 2 files changed, 23 insertions(+), 23 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id68a098be36fcfc47c23c57fce3abea50e6273e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Improving memory footprint for almost every command ...
by mkublin＠redhat.com 02 Apr '13

02 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improving memory footprint for almost every command in the system ...................................................................... engine: Improving memory footprint for almost every command in the system The custom properties is private case, so allocation of HashMap is required only in small number of commands, benefit - we will not allocate thouthands of HashMaps In case that we need a custom properties , map will be allocated Change-Id: I266ac0abd5e53ec7c7948059ee575aac6b53c17b Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I266ac0abd5e53ec7c7948059ee575aac6b53c17b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Simplify AuditLogHelper
by mkublin＠redhat.com 02 Apr '13

02 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Simplify AuditLogHelper ...................................................................... engine: Simplify AuditLogHelper Replacing hand made code by java standard code. Change-Id: Ibf52160dba842985b6cb1fa66fc08c538b2ead6a Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogHelper.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogHelperTest.java 2 files changed, 23 insertions(+), 28 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf52160dba842985b6cb1fa66fc08c538b2ead6a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Improving memory footprint during audit logging - ea...
by mkublin＠redhat.com 02 Apr '13

02 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improving memory footprint during audit logging - easy one ...................................................................... engine: Improving memory footprint during audit logging - easy one The following variable allocation is unneeded. Improved memory allocation during every get from DB operation Change-Id: I21b4964f278d067aa9daa0b153099b20f348919b Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21b4964f278d067aa9daa0b153099b20f348919b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: hiding virt related fields in Gluster mode
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: hiding virt related fields in Gluster mode ...................................................................... webadmin: hiding virt related fields in Gluster mode The following ui fields will be hidden when the Application mode is Gluster only. - CPU colum in Cluster main tab - Data Center name in Cluster general tab - Console tab in Host popup - SPM Priority in Host general tab Change-Id: I5352cf678161905d46281331168df4fb7b97b622 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java 4 files changed, 16 insertions(+), 9 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5352cf678161905d46281331168df4fb7b97b622 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix unpermitted storage related commands in Audit mode
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix unpermitted storage related commands in Audit mode ...................................................................... core: Fix unpermitted storage related commands in Audit mode When Data Center is in quota enforcement mode 'Audit', a user can perform disk actions on a SD which he does not have permission for (e.g. move disk). This was caused by wrong permission subjects list creation which neglected the 'Audit' mode. Fixed the permission subjects list creation to include 'Audit' mode as well as 'Disabled' mode (in 'Enforcing' mode this operation will be blocked by the quota QuotaManager) Change-Id: Ie50e7dd91611c2b959cea3a78c2684451836760b Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie50e7dd91611c2b959cea3a78c2684451836760b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core+webadmin: Fix aggregate unlimited quota
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core+webadmin: Fix aggregate unlimited quota ...................................................................... core+webadmin: Fix aggregate unlimited quota Unlimited specific quota was not aggregated to unlimited. This was fixed both in QuotaManager and in the WebAdmin. Added a pop-up confirmation window alerting the user that using unlimited specific quota is inadvisable and asking his confirmation. Change-Id: If8f5eb7b2ad1fd5264039ede728c746b0a3cf1b3 Bug-Url: https://bugzilla.redhat.com/923868 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java 4 files changed, 110 insertions(+), 8 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8f5eb7b2ad1fd5264039ede728c746b0a3cf1b3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: avoid passing userId in User queries
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: avoid passing userId in User queries ...................................................................... engine: avoid passing userId in User queries Motivation: in the included queries (user queries), a user id is passed in parameters. In user query there is no point in passing userId (it can be taken from session in server side). Removed user id paramerters classes, query base class, related tests, and references both in UI and REST. Note: although there can be a use case for fetching other user vm/pools, it can be revisited upon request (currently there is no use for that). Change-Id: I06bec1770adbc6dce07baae8e5fc7f163b39fc52 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmPoolsAttachedToUserQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsAndVmPoolsQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDataByUserIDQueriesBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUserVmsByUserIdAndGroupsQuery.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllVmPoolsAttachedToUserQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUserVmsByUserIdAndGroupsQueryTest.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllVmPoolsAttachedToUserParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUserVmsByUserIdAndGroupsParameters.java D backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/GetAllVmPoolsAttachedToUserParametersTest.java D backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/GetUserVmsByUserIdAndGroupsParametersTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java 12 files changed, 16 insertions(+), 216 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06bec1770adbc6dce07baae8e5fc7f163b39fc52 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Adding validation for volume name
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Adding validation for volume name ...................................................................... webadmin: Adding validation for volume name The following validations are added for volume name. - length cannot be more than 50 - name can have only ASCII letters, numbers, '_' or '-' signs Change-Id: I691c7bbaecb764dcc722fd4d9f3fa7be5018a6d2 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I691c7bbaecb764dcc722fd4d9f3fa7be5018a6d2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: ConcurrentModificationException in AdElementListMo...
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: frontend: ConcurrentModificationException in AdElementListModel ...................................................................... frontend: ConcurrentModificationException in AdElementListModel The exception occured in the populateRoles method when user is adding permissions to the VM in permissions subtab. The problem is introduced by refactoring in 05c06da3 and is only visible in gwt-debug console. The problem was caused by removing items from the list in the for-each loop. Fixed by introducing a copy of the modified list (to avoid modifying the collection passed in the argument). Change-Id: Id845725507782162c14f6e7b214f65cc6060f59b Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id845725507782162c14f6e7b214f65cc6060f59b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: noam slomianko <drekmastermind(a)gmail.com> Gerrit-Reviewer: noam slomianko <nslomian(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: recover from corrupted pid file
by juan.hernandez＠redhat.com 02 Apr '13

02 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: recover from corrupted pid file ...................................................................... packaging: engine-service: recover from corrupted pid file The case in which pidfile is empty is common. Change-Id: I1b2a175cd0ef14bb6f60822f510059ee5be23c43 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b2a175cd0ef14bb6f60822f510059ee5be23c43 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: display N/A for gluster services port if not appli...
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: display N/A for gluster services port if not applicable ...................................................................... webadmin: display N/A for gluster services port if not applicable 'SHD' services may not have port numbers and it will be displayed as 'N/A' if portNo is 0. Change-Id: I92485213c23ed26742b70db26c1230ea662bc0e5 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92485213c23ed26742b70db26c1230ea662bc0e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.2]: cleanup: pep8 compliant
by knesenko＠redhat.com 02 Apr '13

02 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: cleanup: pep8 compliant ...................................................................... cleanup: pep8 compliant (cherry picked from commit dd8bb93b7d7217825b5821655eb5e5deeec48b64) Change-Id: Ic1c47d19ba75c7b681c132d6a5738448d9a5d5b8 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 29 insertions(+), 21 deletions(-) Approvals: Sandro Bonazzola: Verified Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1c47d19ba75c7b681c132d6a5738448d9a5d5b8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix gluster host force detach message
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix gluster host force detach message ...................................................................... webadmin: Fix gluster host force detach message The message is changed to 'Force Detach' to be inline with force remove message. Change-Id: I05508feb015f92d85dc5a55cf0ffb57a5e6ac4ca Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05508feb015f92d85dc5a55cf0ffb57a5e6ac4ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix for wrong error massage in add disk
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix for wrong error massage in add disk ...................................................................... core: Fix for wrong error massage in add disk while quota in audit mode, when user tried to add a disk to an SD which has no assigned quota - an error message was presented and the operation was blocked. The error message was not correctly formatted. This happens because when the DC was moved from Enforced to Audit mode the quota cache was not refreshed. So all quotas on that DC remained in the old enforcement mode. Fixed the cache refresh rule. Now that the error is thrown from the correct place in the code and only in Enforced mode, it is correctly formatted. Change-Id: Ifb23898a52c654dd03b7c9d1421fe456c9196da2 Bug-Url: https://bugzilla.redhat.com/906485 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java 2 files changed, 4 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb23898a52c654dd03b7c9d1421fe456c9196da2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: noam slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Application continue polling after logout
by ecohen＠redhat.com 01 Apr '13

01 Apr '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Application continue polling after logout ...................................................................... webadmin: Application continue polling after logout - Fixed queries to BookMarks not stopping when logging out. - Fixed queries to RoleListModel not stopping when logging out. - Fixed queries to SystemPermissionListModel not stopping when logging out. Change-Id: Ibd2718649ab4031e6ff2b0d0e6c449f53164ff9f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=888492 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendFailureEventListener.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/CommonModelManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/presenter/LoginSectionPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/presenter/LoginSectionPresenter.java 6 files changed, 12 insertions(+), 52 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd2718649ab4031e6ff2b0d0e6c449f53164ff9f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal,webadmin: fix dtd check
by derez＠redhat.com 01 Apr '13

01 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal,webadmin: fix dtd check ...................................................................... userportal,webadmin: fix dtd check In another patch we added set-property-fallback which is not defined in the GWT dtd before 2.5. This patch sets the DTD to 2.5 so that eclipse doesn't complain about it. Note that the DTD version for userportal was 2.3 and webadmin was 2.2. The build doesn't actually care about the DTD. Change-Id: I9523686fa7b7e005830b4f247d998fbfb01259e2 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Alexander Wels: Verified Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9523686fa7b7e005830b4f247d998fbfb01259e2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: removed --no-mem-check from engine-setup
by juan.hernandez＠redhat.com 01 Apr '13

01 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: removed --no-mem-check from engine-setup ...................................................................... packaging: removed --no-mem-check from engine-setup If minimum memory requirements are not met: - on interactive mode, stop, warn and ask if to abort - on answer file mode don't stop, issue the warning in the log. The assumption here is that users of the answer file are aware of the requirements and had to read the manual to use this option. Moved requirements check after process initialization avoiding double execution of the check. Change-Id: I7180589490cf74fcb402bd3b957ae8ae8479715d Bug-Url: https://bugzilla.redhat.com/928386 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 23 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7180589490cf74fcb402bd3b957ae8ae8479715d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: remove redundant file from spec
by juan.hernandez＠redhat.com 01 Apr '13

01 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: remove redundant file from spec ...................................................................... packaging: remove redundant file from spec Change-Id: Icf65792b0ce1ab1774852a8d2f17a409a92e1620 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13380 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf65792b0ce1ab1774852a8d2f17a409a92e1620 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: cleanup: merge check for running ...
by juan.hernandez＠redhat.com 01 Apr '13

01 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: cleanup: merge check for running process ...................................................................... packaging: engine-service: cleanup: merge check for running process Change-Id: I20238c634c418029c669bdf2b4b77e329b39faa1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20238c634c418029c669bdf2b4b77e329b39faa1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: cleanup pyflakes warnings
by juan.hernandez＠redhat.com 01 Apr '13

01 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: cleanup pyflakes warnings ...................................................................... packaging: engine-service: cleanup pyflakes warnings Change-Id: I2186d79e96aaf2789ee860e7e7e34a20d71e6287 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2186d79e96aaf2789ee860e7e7e34a20d71e6287 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: /etc/ovirt-engine/engine.conf* should not be owne...
by juan.hernandez＠redhat.com 01 Apr '13

01 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: /etc/ovirt-engine/engine.conf* should not be owned by engine ...................................................................... packaging: /etc/ovirt-engine/engine.conf* should not be owned by engine engine does not and should not write into it. if there is secret configuration it can be explicitly written owned by engine. Change-Id: I6d9ca270bd1d3a16591a3d4fae65bbaac65c8654 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/fedora/setup/common_utils.py M packaging/fedora/spec/ovirt-engine.spec.in 3 files changed, 7 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d9ca270bd1d3a16591a3d4fae65bbaac65c8654 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: /etc/ovirt-engine should not be owned by engine
by juan.hernandez＠redhat.com 01 Apr '13

01 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: /etc/ovirt-engine should not be owned by engine ...................................................................... packaging: /etc/ovirt-engine should not be owned by engine engine does not and should not write into it. Change-Id: Ic24afe853410a56bd27dd613764bb8dd8b18e1c3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic24afe853410a56bd27dd613764bb8dd8b18e1c3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0