April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: New test method in DBConfigUtilsTest
by yzaslavs＠redhat.com 17 Apr '13

17 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: New test method in DBConfigUtilsTest ...................................................................... engine: New test method in DBConfigUtilsTest There seems to be a perception in the community that there is some bug in the config framework because of which the api returns a null value if there is no entry in vdc_options for a given config. This patch attempts to add a new test case that verifies that this is not the case, and if entry is missing in vdc_options, value returned is from the @DefaultValueAttribute annotation in ConfigValues enum. For this purpose, - Modified DBConfigUtilsTest to extend from BaseDAOTestCase, so that fixtures.xml can be used to insert entries in vdc_options - Modified fixtures.xml to insert two entries in vdc_options for the config NonVmNetworkSupported for version 3.0 and 3.2 - Renamed DBConfigUtils#RefreshVdcOptionCache to refreshVdcOptionCache and made it protected so that it can be called from test class passing the test dbFacade - Added new test method testGetValue() to verify that default value is returned if entry is not present in vdc_options Change-Id: Ia736419e766bc6ce2e82158f775817e885b90dfd Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtilsTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdcOptionDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 4 files changed, 30 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia736419e766bc6ce2e82158f775817e885b90dfd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: AssignQuota button under disks refresh bug
by gchaplik＠redhat.com 17 Apr '13

17 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: AssignQuota button under disks refresh bug ...................................................................... engine: AssignQuota button under disks refresh bug In case a quota mode set to !Disabled (or vice-versa) the Assign Quota button (in various disk tabs) availability wasn't refreshed. The problem caused because we relied on the selected DC tree item quota mode, which not getting refreshed in current ui infrastructure. Instead we will fetch quota mode from disk BE itself. A bug was fixed in DB to reference data center even if there is no quota for the disk (using the storageDomain DC instead of quota table). To allow new functionality for all tabs, introduced a new interface and static public utility method to avoid code duplication. Change-Id: I21a0886cfe82d441ad93fd9b15d72f8a4e63002c Bug-Url: https://bugzilla.redhat.com/950519 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/ChangeQuotaModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 5 files changed, 100 insertions(+), 67 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21a0886cfe82d441ad93fd9b15d72f8a4e63002c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: unlocalized properties in common general tab
by gchaplik＠redhat.com 17 Apr '13

17 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: unlocalized properties in common general tab ...................................................................... webadmin: unlocalized properties in common general tab Changes are made in vm, template and pool general subtabs: - vm priority - vm sockets count - run on 'any host in cluster' Change-Id: I24151bc17538fb7489458ac0c34e10b98726812f Bug-Url: https://bugzilla.redhat.com/950826 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 5 files changed, 49 insertions(+), 60 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24151bc17538fb7489458ac0c34e10b98726812f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Multiple consoles in WebAdmin
by tjelinek＠redhat.com 17 Apr '13

17 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Multiple consoles in WebAdmin ...................................................................... webadmin: Multiple consoles in WebAdmin Multiple consoles can be opened for selected VMs in WebAdmin using one command. The Console button/menu item is enabled, when at least one VM has a valid console. Tested for Spice plugin as well as MIME attachment servlet. Change-Id: I894eaeafab22614af3f219169ef73d7fbeed3a11 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WebAdminItemModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostVmView.java 4 files changed, 205 insertions(+), 105 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Libor Spevak: Verified -- To view, visit http://gerrit.ovirt.org/13847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I894eaeafab22614af3f219169ef73d7fbeed3a11 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: sos - refactored engine sos plugin
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: sos - refactored engine sos plugin ...................................................................... sos - refactored engine sos plugin engine sos plugin used two flags: vdsmlogs and prefix. Both flags were implemented with behaviors not acceptable by sos developers: - vdsmlogs is not a boolean flag: it was used for specifying a path containing logs collected by sosreport runs on other hosts; if required the path should have been determined without allowing the user to specify a generic path like '/' - prefix is not a boolean flag and was used for changing the name of the report tarball. The name was changed altering the sosreport policy instead of creating a new policy. Both these 2 flag are meaningless if you run sosreport -a -o engine because -a set both the flags to True and because running sosreport you can't collect hypervisors sosreport in vdsmlogs and you want a standard sosreport. I've refactored the engine sos plugin removing both the flags. It's engine-log-collector that will take care to rename the tarball with the desired prefix and it's engine-log-collector that will take care of adding the vdsmlogs to the archive. PREVIOUS: - collect and archive postgres data in a scratch dir - collect and archive hypervisors data in a scratch dir - collect and archive engine data (including the above in /tmp) NOW: - collect engine data - collect and archive postgres data in log-collector-data - collect and archive hypervisors data in log-collector-data - archive all the above in a single tarball. (cherry picked from commit 6a09d066192507c01b775f15c16dd2d5af11778d) Change-Id: Ib226ec23b98450a03ebd2a64043a911645a62235 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py M src/sos/plugins/engine.py 2 files changed, 71 insertions(+), 50 deletions(-) Approvals: Sandro Bonazzola: Verified Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib226ec23b98450a03ebd2a64043a911645a62235 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: sos - refactored engine sos plugin
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: sos - refactored engine sos plugin ...................................................................... sos - refactored engine sos plugin engine sos plugin used two flags: vdsmlogs and prefix. Both flags were implemented with behaviors not acceptable by sos developers: - vdsmlogs is not a boolean flag: it was used for specifying a path containing logs collected by sosreport runs on other hosts; if required the path should have been determined without allowing the user to specify a generic path like '/' - prefix is not a boolean flag and was used for changing the name of the report tarball. The name was changed altering the sosreport policy instead of creating a new policy. Both these 2 flag are meaningless if you run sosreport -a -o engine because -a set both the flags to True and because running sosreport you can't collect hypervisors sosreport in vdsmlogs and you want a standard sosreport. I've refactored the engine sos plugin removing both the flags. It's engine-log-collector that will take care to rename the tarball with the desired prefix and it's engine-log-collector that will take care of adding the vdsmlogs to the archive. PREVIOUS: - collect and archive postgres data in a scratch dir - collect and archive hypervisors data in a scratch dir - collect and archive engine data (including the above in /tmp) NOW: - collect engine data - collect and archive postgres data in log-collector-data - collect and archive hypervisors data in log-collector-data - archive all the above in a single tarball. Change-Id: Ib226ec23b98450a03ebd2a64043a911645a62235 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py M src/sos/plugins/engine.py 2 files changed, 71 insertions(+), 50 deletions(-) Approvals: Sandro Bonazzola: Verified Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13939 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib226ec23b98450a03ebd2a64043a911645a62235 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: [cleanup] extract building parameters code from execut...
by ofrenkel＠redhat.com 17 Apr '13

17 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: [cleanup] extract building parameters code from execute methods ...................................................................... core: [cleanup] extract building parameters code from execute methods Extract the sections that build parameters for internal commands from the execute methods of CreateAllSnapshotsFromVmCommand, RemoveAllVmImagesCommand and RemoveDiskCommand. that way, the execute methods are shorter and more readable. Change-Id: Iedcdcefe63c75927ed709faa9c1a64c5e983bc12 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 3 files changed, 42 insertions(+), 35 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedcdcefe63c75927ed709faa9c1a64c5e983bc12 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix single sign on for all guests
by ofrenkel＠redhat.com 17 Apr '13

17 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix single sign on for all guests ...................................................................... core: fix single sign on for all guests This patch fix a problem that caused single-sign-on capability not to work for some guests: vdsm sends the name of the guest agent application in the applications list. the engine expects to receive RHEV-Agent as the guest agent application name, but that's true only for guest agent running on Windows and in d/s version. This solution is: 1. set all the possible names for the guest agent application, on all operating systems, in the configuration so that the engine will look for all of them (instead of only RHEV-Agent). 2. set the relevant names of the guest agent application in u/s, in ovirt's engine configuration. Change-Id: If256ddda586eb53af0ca55d6b97dd98e10139d8a Bug-Url: https://bugzilla.redhat.com/922398 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 3 files changed, 13 insertions(+), 12 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If256ddda586eb53af0ca55d6b97dd98e10139d8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixing update of host status during restart host
by mkublin＠redhat.com 17 Apr '13

17 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing update of host status during restart host ...................................................................... engine: Fixing update of host status during restart host If we failed during restart a host status should be switched to NonResponsive, the status was switched at roollback() nethod, but because of command is NonTransactive a rollback will be never called, so moving an update of status to execute Change-Id: I1d44a3ee76e2dc2490f8cf937a768c80826af46c Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java 1 file changed, 7 insertions(+), 11 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d44a3ee76e2dc2490f8cf937a768c80826af46c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Switching spice invoker implementation in console ...
by tjelinek＠redhat.com 17 Apr '13

17 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Switching spice invoker implementation in console dialog ...................................................................... frontend: Switching spice invoker implementation in console dialog This patch allows switching spice invoker implementation in console dialog. Change-Id: Ib9fdc00931e3b25858b792b47339b3c5ab4a954c Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 8 files changed, 195 insertions(+), 16 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9fdc00931e3b25858b792b47339b3c5ab4a954c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Update maven-war-plugin and maven-ear-plugin
by juan.hernandez＠redhat.com 17 Apr '13

17 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Update maven-war-plugin and maven-ear-plugin ...................................................................... core: Update maven-war-plugin and maven-ear-plugin This change updates the maven-war-plugin version to 2.2 and the maven-ear-plugin version to 2.8. This update is required in order to use the packagingIncludes and packagingExcludes configuration parameters that are silently ignored in previous versions. Change-Id: Iffc6ac741d4bb864246f67ea5c1e207013b96405 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M pom.xml 4 files changed, 2 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffc6ac741d4bb864246f67ea5c1e207013b96405 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: packaging: Change spec file according to the packaging stand...
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: packaging: Change spec file according to the packaging standards. ...................................................................... packaging: Change spec file according to the packaging standards. Change-Id: Ib4b85bffcadf4fed89b24837aa190874a60647c6 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M ovirt-log-collector.spec.in 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13968 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4b85bffcadf4fed89b24837aa190874a60647c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.2]: packaging: Change spec file according to the packaging stand...
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: packaging: Change spec file according to the packaging standards. ...................................................................... packaging: Change spec file according to the packaging standards. Change-Id: Ice0a3eaf3c3143b6af765c4ab06842a9304444d2 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M ovirt-iso-uploader.spec.in 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice0a3eaf3c3143b6af765c4ab06842a9304444d2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.2]: packaging: Change spec file according to the packaging stand...
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: packaging: Change spec file according to the packaging standards. ...................................................................... packaging: Change spec file according to the packaging standards. Change-Id: I76932778002b2e6a7c2b395cbad7a1882900e91f Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M ovirt-image-uploader.spec.in 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76932778002b2e6a7c2b395cbad7a1882900e91f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: TryBackToAllSnapshots - avoid attempt to remove illega...
by amureini＠redhat.com 17 Apr '13

17 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: TryBackToAllSnapshots - avoid attempt to remove illegal disks ...................................................................... core: TryBackToAllSnapshots - avoid attempt to remove illegal disks In change I8ee0e807 previewing a snapshot of vm with illegal disks was blocked, so we will never actually remove any illegal disks as if there were some - the action would have failed in the CDA phase. Related-To: https://bugzilla.redhat.com/949624 Change-Id: Ie59bb1de3e9431998c9aa5269e3b65de8165dee9 Signed-off-by: Liron Aravot <laravot(a)redhat.com> Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie59bb1de3e9431998c9aa5269e3b65de8165dee9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: packaging: Change spec file according to the packaging stand...
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: packaging: Change spec file according to the packaging standards. ...................................................................... packaging: Change spec file according to the packaging standards. Change-Id: Ib4b85bffcadf4fed89b24837aa190874a60647c6 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M ovirt-log-collector.spec.in 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4b85bffcadf4fed89b24837aa190874a60647c6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: packaging: Change spec file according to the packaging stand...
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: packaging: Change spec file according to the packaging standards. ...................................................................... packaging: Change spec file according to the packaging standards. Change-Id: Ice0a3eaf3c3143b6af765c4ab06842a9304444d2 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M ovirt-iso-uploader.spec.in 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice0a3eaf3c3143b6af765c4ab06842a9304444d2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-image-uploader[master]: packaging: Change spec file according to the packaging stand...
by knesenko＠redhat.com 17 Apr '13

17 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: packaging: Change spec file according to the packaging standards. ...................................................................... packaging: Change spec file according to the packaging standards. Change-Id: I76932778002b2e6a7c2b395cbad7a1882900e91f Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M ovirt-image-uploader.spec.in 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76932778002b2e6a7c2b395cbad7a1882900e91f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: packaging: spec: add newline after each changelog entry
by Alon Bar-Lev 17 Apr '13

17 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: spec: add newline after each changelog entry ...................................................................... packaging: spec: add newline after each changelog entry Change-Id: I06df2152c0302ea2dd494f940b4bc448260331de Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-host-deploy.spec.in 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06df2152c0302ea2dd494f940b4bc448260331de Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.0]: packaging: spec: add newline after each changelog entry
by Alon Bar-Lev 17 Apr '13

17 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: spec: add newline after each changelog entry ...................................................................... packaging: spec: add newline after each changelog entry Change-Id: Ib5a5a3b421f69b6a94bb1dae6958c15e097681bd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-host-deploy.spec.in 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5a5a3b421f69b6a94bb1dae6958c15e097681bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[otopi-1.0]: packaging: spec: add newline after each changelog entry
by Alon Bar-Lev 17 Apr '13

17 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: spec: add newline after each changelog entry ...................................................................... packaging: spec: add newline after each changelog entry Change-Id: I3b1e51246b8826bfa6466426805b7f20bcfe6ca8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M otopi.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b1e51246b8826bfa6466426805b7f20bcfe6ca8 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packaging: spec: add newline after each changelog entry
by Alon Bar-Lev 17 Apr '13

17 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: spec: add newline after each changelog entry ...................................................................... packaging: spec: add newline after each changelog entry Change-Id: I933027c541bbd0f1514ab726886d1962dbf741b5 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M otopi.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I933027c541bbd0f1514ab726886d1962dbf741b5 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: notifier startup script startup directory
by yzaslavs＠redhat.com 17 Apr '13

17 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: notifier startup script startup directory ...................................................................... tools: notifier startup script startup directory The notification daemon startup script attempts to change to the ovirt user home directory to avoid permissions errors. This directory doesn't always exist, so it will now use / as a fallback. Change-Id: Iba8b163881bd31eeb970da82003dd184ffcad9b9 Bug-Url: https://bugzilla.redhat.com/949975 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-notifier-service.sh 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba8b163881bd31eeb970da82003dd184ffcad9b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: test for AddVdsCommand
by lhornyak＠redhat.com 16 Apr '13

16 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: test for AddVdsCommand ...................................................................... engine: test for AddVdsCommand Adds test for canDoAction. Change-Id: Iaa8b31e3bb4f96e34d7ea7e97ec8c4c5b1f19984 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsCommandTest.java 2 files changed, 78 insertions(+), 10 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa8b31e3bb4f96e34d7ea7e97ec8c4c5b1f19984 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: enable/disable hooks -use GlusterMultipleActionRunne...
by sanjal＠redhat.com 16 Apr '13

16 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: enable/disable hooks -use GlusterMultipleActionRunner ...................................................................... engine: enable/disable hooks -use GlusterMultipleActionRunner Changed factory to use GlusterMulitpleActionRunner for Enable/Disable hooks Change-Id: I702296e95491cb9770dc235bd2f4f0cb1eaa822e Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunnersFactory.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I702296e95491cb9770dc235bd2f4f0cb1eaa822e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Disable gluster hook command
by sanjal＠redhat.com 16 Apr '13

16 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Disable gluster hook command ...................................................................... engine: Disable gluster hook command Added bll command to disable gluster hook on all servers in a cluster. This command extends from GlusterHookStatusChangeCommand which does the work of calling the VDS command for each of the server in the cluster. The command succeeds if atleast one of the servers returns success. Refactored enable and disable hook tests to extend from a common class. Change-Id: I6fb3e034013d2ceb3590a61efc9bc46b1c3f378f Signed-off-by: Selvasundaram <sesubram(a)redhat.com> Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DisableGlusterHookCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DisableGlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties 7 files changed, 317 insertions(+), 145 deletions(-) Approvals: Shireesh Anjal: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/11073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fb3e034013d2ceb3590a61efc9bc46b1c3f378f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: VDS disable gluster hook command
by sanjal＠redhat.com 16 Apr '13

16 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: VDS disable gluster hook command ...................................................................... engine: VDS disable gluster hook command Added VDS command to disable a gluster hook on a server given the hook details - gluster command, stage and hook name Change-Id: I65c11b9406673d5dd5bcf648f2ce18b8e9f9d259 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/DisableGlusterHookVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 6 files changed, 39 insertions(+), 0 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65c11b9406673d5dd5bcf648f2ce18b8e9f9d259 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Disable gluster hook - constants and messages
by sanjal＠redhat.com 16 Apr '13

16 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Disable gluster hook - constants and messages ...................................................................... engine: Disable gluster hook - constants and messages Adding constants and messages required by disable gluster hook BLL and VDS commands. Change-Id: I8776106ee00441b82f29a1fb9282123805369d66 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 11 files changed, 33 insertions(+), 0 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8776106ee00441b82f29a1fb9282123805369d66 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Unused field in ConfigureLocalStorageModel
by amureini＠redhat.com 16 Apr '13

16 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Unused field in ConfigureLocalStorageModel ...................................................................... webadmin: Unused field in ConfigureLocalStorageModel Removed the unused field ConfigureLocalStorageModel.Context.candidate. Change-Id: Ic90f950dfc9b02f1e7beb7939814b0f0c82e2c66 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic90f950dfc9b02f1e7beb7939814b0f0c82e2c66 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetAgentFenceOptions2Query
by amureini＠redhat.com 16 Apr '13

16 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetAgentFenceOptions2Query ...................................................................... core: Remove GetAgentFenceOptions2Query GetAgentFenceOptionsQuery and GetAgentFenceOptions2Query are completely identical except for the usage of different APIs of VdsFenceOptions. Since GetAgentFenceOptions is not used anywhere, it is removed, and GetAgentFenceOptions2 loses it "2" and get a name the better suits conventions (not to mention common sense). This patch includes: 1. Removing the old GetAgentFenceOptionsQuery class and renaming GetAgentFenceOptions2Query to take its place. 2. Removing the old GetAgentFenceOptions constant in the VdsQueryTye enum, and renaming GetAgentFenceOptions2 to take its place. 3. Clearing up the VdsFenceOptions class from methods with "2" in their name - either by removing unused methods, or by renaming them to a more sensible name. Change-Id: Id2d7f15c16257f39f162b52d22f7c2faf8eb291a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAgentFenceOptions2Query.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAgentFenceOptionsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/VdcQueryTypeTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 6 files changed, 8 insertions(+), 44 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13606 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2d7f15c16257f39f162b52d22f7c2faf8eb291a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: clarify conditional expression in checkImageValidity
by lhornyak＠redhat.com 15 Apr '13

15 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: clarify conditional expression in checkImageValidity ...................................................................... core: clarify conditional expression in checkImageValidity Add indentation and parenthesis to improve readability. Change-Id: Ib82b97eb4670faa8ff456028fc89d23c6c2c79c2 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib82b97eb4670faa8ff456028fc89d23c6c2c79c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: prevent performing preview when the vm has illegal dis...
by amureini＠redhat.com 15 Apr '13

15 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: prevent performing preview when the vm has illegal disks ...................................................................... core: prevent performing preview when the vm has illegal disks When attempting to preview vm - do not allow to perform it when the vm has illegal disks contained within the filtered disk list. Change-Id: I8ee0e8070fb91bd2e0f18cf7bdb7a44aa51f70af Bug-Url: https://bugzilla.redhat.com/949624 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ee0e8070fb91bd2e0f18cf7bdb7a44aa51f70af Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, weadmin: fix root pom
by ecohen＠redhat.com 15 Apr '13

15 Apr '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal, weadmin: fix root pom ...................................................................... userportal, weadmin: fix root pom - fixed backend root pom, by removed extra dependency that is not needed as commons-logging is properly included already. Change-Id: I2ca63b5346266ac0c15e385787adb881586fd029 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/root/pom.xml 1 file changed, 0 insertions(+), 11 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ca63b5346266ac0c15e385787adb881586fd029 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VdsDAO.getAllWithName now returns instance
by lhornyak＠redhat.com 15 Apr '13

15 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: VdsDAO.getAllWithName now returns instance ...................................................................... core: VdsDAO.getAllWithName now returns instance List<VDS> VdsDAO.getAllWithName(String) has been changed to VDS VdsDAO.getByName(String) because VDS name is unique Change-Id: I1a0cb37c98f1a4373028e6210e45261cd432eed3 Bug-Url: https://bugzilla.redhat.com/894382 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsByNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java 8 files changed, 45 insertions(+), 58 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a0cb37c98f1a4373028e6210e45261cd432eed3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix volume labels in ja and fr locale
by kmayilsa＠redhat.com 15 Apr '13

15 Apr '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: fix volume labels in ja and fr locale ...................................................................... webadmin: fix volume labels in ja and fr locale Increased the width of Gluster Volume column in events tab to avoid striping the label in ja locale. Increased the height of the create volume dialog to avoid the text overflowing in fr locale. Bug-Url: https://bugzilla.redhat.com/950302 Change-Id: I6c831be1d3339bc293e1af46b1af2ead5de8ab6c Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13919 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c831be1d3339bc293e1af46b1af2ead5de8ab6c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused manifest from root webapp
by juan.hernandez＠redhat.com 15 Apr '13

15 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove unused manifest from root webapp ...................................................................... core: Remove unused manifest from root webapp The file src/resources/META-INF/MANIFEST.MF is not used, it is the result of a mistake. Change-Id: Ifbf46b718956b45029ab2c0479509688f82291f6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D backend/manager/modules/root/src/resources/META-INF/MANIFEST.MF 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbf46b718956b45029ab2c0479509688f82291f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: move new disk logic to NewDiskModel
by derez＠redhat.com 15 Apr '13

15 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: move new disk logic to NewDiskModel ...................................................................... webadmin: move new disk logic to NewDiskModel Move logic relevant only for new disk from AbstractDiskModel to NewDiskModel. Change-Id: If6bd49b1c513eb06d33a765738d5fd2587a88b13 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java 3 files changed, 21 insertions(+), 10 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6bd49b1c513eb06d33a765738d5fd2587a88b13 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:we are fencing a host when putting it in...
by emesika＠redhat.com 15 Apr '13

15 Apr '13

Eli Mesika has submitted this change and it was merged. Change subject: core:we are fencing a host when putting it in... ...................................................................... core:we are fencing a host when putting it in... we are fencing a host when putting it in maintenance after failed reinstall. There are two commands that handle Host Maintenance 1) MaintenanceVdsCommand 2) MaintenanceNumberOfVdssCommand In 1) there is handling in canDoAction that prevents the operation for InstalledFailed status while this handling is omitted from 2) I would expect that 2) will contain all validation checks done by 1) and the best will be that they will call the same validation code. but this is not the case right now. To keep my change minimal and risk-less, I will have to copy the relevant validation block from 1) code to 2) Change-Id: I1ed67cb14b31597d147cee3a64056e3486f51d26 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=906389 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java 1 file changed, 40 insertions(+), 30 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ed67cb14b31597d147cee3a64056e3486f51d26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Use proper method to mark net changes as saved
by masayag＠redhat.com 15 Apr '13

15 Apr '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use proper method to mark net changes as saved ...................................................................... engine: Use proper method to mark net changes as saved The patch reduces the need for updating the entire VdsDynamic data by using a designated method for saving the dirty-network indicator of the host. Change-Id: Ib4c54214a275a1653c46bca7c95ff847975dd7d4 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/CommitNetworkChangesCommand.java 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/13905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4c54214a275a1653c46bca7c95ff847975dd7d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Refactoring gluster hook labels
by kmayilsa＠redhat.com 15 Apr '13

15 Apr '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Refactoring gluster hook labels ...................................................................... webadmin: Refactoring gluster hook labels Gluster hook command label is changed to 'Volume Event' and unused constants are removed. Change-Id: Ieed8b5176d484e49fe507bf3f1460447c5a9179e Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGlusterHookView.java 2 files changed, 3 insertions(+), 6 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieed8b5176d484e49fe507bf3f1460447c5a9179e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Improving memory footprint - JSON part
by mkublin＠redhat.com 14 Apr '13

14 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improving memory footprint - JSON part ...................................................................... engine: Improving memory footprint - JSON part The following patch should imprtove a used memory in all work related to JSON. The scenarious which will be improved: all scenarios which are using compensation and vm monitoring. Motivation is due to wiki of Jackson serializer it is thread safe, except configuration part, but we are not changing configuration (Also I did short code review in order to verify that ObjectMapper is thread safe) ObjectMapper is not lightweight object and also has some internal cache in order to improve it performance, so a change is obvious: serializer and desirializer which are based on ObjectMapper should be single instance. Change-Id: I11a76b46a5bfa269605249c3dfc2d69a55d8bbef Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SerializationFactory.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 7 files changed, 72 insertions(+), 74 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11a76b46a5bfa269605249c3dfc2d69a55d8bbef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: "Any Host in Cluster" broken into two lines
by gchaplik＠redhat.com 14 Apr '13

14 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: "Any Host in Cluster" broken into two lines ...................................................................... webadmin: "Any Host in Cluster" broken into two lines in ja_JP locale; removing width property from widget. Bug-Url: https://bugzilla.redhat.com/950244 Change-Id: I1963e606651994efc48c4f1dfaf2c261c0746cbf Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1963e606651994efc48c4f1dfaf2c261c0746cbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: localize quota mode enum
by gchaplik＠redhat.com 14 Apr '13

14 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: localize quota mode enum ...................................................................... webadmin: localize quota mode enum Change-Id: I98ae26b44e82cc0ca1dd0507ad32d76207132f2a Bug-Url: https://bugzilla.redhat.com/950475 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 4 files changed, 10 insertions(+), 9 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98ae26b44e82cc0ca1dd0507ad32d76207132f2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: HibernateVmCommand canDoAction cleanup
by ofrenkel＠redhat.com 14 Apr '13

14 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: HibernateVmCommand canDoAction cleanup ...................................................................... core: HibernateVmCommand canDoAction cleanup return canDoAction on failed check instead of if-else, move storage domains check to be last, removed useless call to update vm disks, removed useless comment. Change-Id: Ib2c7682a7b1b47e84f71fe1a6f91b3af78d799ab Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java 1 file changed, 23 insertions(+), 40 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2c7682a7b1b47e84f71fe1a6f91b3af78d799ab Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: allow hibernate for vm without image disks (#928708)
by ofrenkel＠redhat.com 14 Apr '13

14 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: allow hibernate for vm without image disks (#928708) ...................................................................... core: allow hibernate for vm without image disks (#928708) remove check for image disks, move storage domain space check to storage domain selection method Change-Id: I83a5ffc4653929c65174e27eae3e605dbef75c4c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=928708 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 21 insertions(+), 30 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83a5ffc4653929c65174e27eae3e605dbef75c4c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Fix text alignment in JP localization
by derez＠redhat.com 14 Apr '13

14 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal: Fix text alignment in JP localization ...................................................................... userportal: Fix text alignment in JP localization In Jp localization some text lines were miss aligned. Fixed width of the table column to support longer text. Change-Id: Iddf44aeb457bffe3deb59cd7d151caac0230060b Bug-Url: https://bugzilla.redhat.com/951082 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddf44aeb457bffe3deb59cd7d151caac0230060b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove not used ExtendVolume.
by mlipchuk＠redhat.com 14 Apr '13

14 Apr '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove not used ExtendVolume. ...................................................................... core: Remove not used ExtendVolume. Removed ExtendVolumeVDSCommand. There is no use of it in the engine code. VDSM side should be re-examined. Change-Id: I7d9eb342e4ab09c87bc30544cc0820b50cc0c692 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ExtendVolumeVDSCommandParameters.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ExtendVolumeVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java 5 files changed, 0 insertions(+), 55 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d9eb342e4ab09c87bc30544cc0820b50cc0c692 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove not used powerDownVDSCommand.
by mlipchuk＠redhat.com 14 Apr '13

14 Apr '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove not used powerDownVDSCommand. ...................................................................... core: Remove not used powerDownVDSCommand. Removed powerDownVDSCommand, there is no use of it in the engine code, nor in VDSM. Change-Id: I72590a278574f9b29589623042543ba3cba16c81 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PowerDownVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 4 files changed, 0 insertions(+), 32 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72590a278574f9b29589623042543ba3cba16c81 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused command VmPoolToAdGroupBaseCommand
by mlipchuk＠redhat.com 14 Apr '13

14 Apr '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove unused command VmPoolToAdGroupBaseCommand ...................................................................... core: Remove unused command VmPoolToAdGroupBaseCommand Change-Id: I1b77995d8443e93ee8246606d4834c2a4e3031a4 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolToAdGroupBaseCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmPoolToAdElementParameters.java 2 files changed, 0 insertions(+), 50 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b77995d8443e93ee8246606d4834c2a4e3031a4 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused command VmToUserCommand.
by mlipchuk＠redhat.com 14 Apr '13

14 Apr '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove unused command VmToUserCommand. ...................................................................... core: Remove unused command VmToUserCommand. Change-Id: Id750a0549e6b9ae0cdd8d3edf039ea04ddff0a78 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmToUserCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmToAdElementParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmToUserParameters.java 3 files changed, 0 insertions(+), 52 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id750a0549e6b9ae0cdd8d3edf039ea04ddff0a78 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0