April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[engine_3.2]: packaging: reimplemented engine_firewalld
by oschreib＠redhat.com 14 Apr '13

14 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: reimplemented engine_firewalld ...................................................................... packaging: reimplemented engine_firewalld Reimplemented using the firewall-cmd command instead of the python API, avoiding issues with dbus. The firewall-cmd command will be used also in otopi based rewrite of the engine-setup command. (cherry picked from commit a5d9a59c043709f9515b287f45cae0cdd3996183) Change-Id: Ie0d819c9607d4c99b3093e364ca504ae96acca36 Bug-Url: https://bugzilla.redhat.com/924071 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine_firewalld.py 2 files changed, 42 insertions(+), 13 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0d819c9607d4c99b3093e364ca504ae96acca36 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-cleanup: cleanup legacy proxy
by oschreib＠redhat.com 14 Apr '13

14 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-cleanup: cleanup legacy proxy ...................................................................... packaging: engine-cleanup: cleanup legacy proxy Change-Id: I5144e4e7f868a657580fa0cb394d649d9226b77b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-cleanup.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5144e4e7f868a657580fa0cb394d649d9226b77b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: StorageDomainsColumn - value verification
by derez＠redhat.com 14 Apr '13

14 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: StorageDomainsColumn - value verification ...................................................................... webadmin: StorageDomainsColumn - value verification StorageDomainsColumn: Verify that 'storagesNames' field (in DiskImage) is not null. Change-Id: I951d3d3760334907d4e9159203ee4599b8a26fae Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StorageDomainsColumn.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I951d3d3760334907d4e9159203ee4599b8a26fae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use @Before in searchbackend tests
by amureini＠redhat.com 14 Apr '13

14 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use @Before in searchbackend tests ...................................................................... core: Use @Before in searchbackend tests Added an set up method (with @Before) to initialize the object being tested in test cases that have more than one test, as per proper JUnit4 conventions. Change-Id: Id3a1ca0aca1f570bf2763d6991d56427d0c17764 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/BitValueAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/DateEnumValueAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/EnumValueAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleterTest.java 4 files changed, 31 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3a1ca0aca1f570bf2763d6991d56427d0c17764 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed searchbackend tests stdout printing
by amureini＠redhat.com 14 Apr '13

14 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed searchbackend tests stdout printing ...................................................................... core: Removed searchbackend tests stdout printing Stopped printing (using System.out.println) in searchbackend tests since the information printed out is useless (and even if it wasn't, logging should have been used instead). Change-Id: I749c91fcc6c5f3558b9af6a426a251fc20eb279d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/AdGroupConditionFieldAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/DateEnumValueAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/EnumValueAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 4 files changed, 1 insertion(+), 17 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I749c91fcc6c5f3558b9af6a426a251fc20eb279d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Convert searchbackend tests to JUnit4
by amureini＠redhat.com 14 Apr '13

14 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Convert searchbackend tests to JUnit4 ...................................................................... core: Convert searchbackend tests to JUnit4 Change-Id: Id02d02f82f2d63642c52c92194a2c44f1b614473 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/BaseAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/BitValueAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/DateEnumValueAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/EnumValueAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/NetworkConditionFieldAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/NumericConditionRelationAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SearchObjectsBaseAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/StorageDomainFieldAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/VdsConditionFieldAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleterTest.java 12 files changed, 83 insertions(+), 29 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id02d02f82f2d63642c52c92194a2c44f1b614473 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Convert ObjectIdentityCheckerTest to JUnit4
by amureini＠redhat.com 14 Apr '13

14 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Convert ObjectIdentityCheckerTest to JUnit4 ...................................................................... core: Convert ObjectIdentityCheckerTest to JUnit4 Change-Id: If443c443e49c6a268eb305c19bb8b290ee21f75d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ObjectIdentityCheckerTest.java 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If443c443e49c6a268eb305c19bb8b290ee21f75d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove browser attribute from IVdcUser
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove browser attribute from IVdcUser ...................................................................... core: Remove browser attribute from IVdcUser This attribute is not used. Change-Id: I1e94d0182d2c522367d41f95a9ea5372badce76c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/IVdcUser.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java 2 files changed, 0 insertions(+), 15 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e94d0182d2c522367d41f95a9ea5372badce76c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Move MultiValueMapUtils
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Move MultiValueMapUtils ...................................................................... core: Move MultiValueMapUtils Moved MultiValueMapUtils from org.ovirt.engine.core.utils to org.ovirt.engine.core.utils.collections, where all the map-related utilities reside. Change-Id: I4d4b7278e43dd4bf5700c3b65e73833c3bda43dc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/MultiValueMapUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/vmproperties/VmPropertiesUtils.java R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/collections/MultiValueMapUtilsTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 13 files changed, 15 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13851 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d4b7278e43dd4bf5700c3b65e73833c3bda43dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove the ISession interface
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove the ISession interface ...................................................................... core: Remove the ISession interface This interface is not implemented nor used anywhere in the codebase. Change-Id: I354a9470e4ca9d541417f3418ff05b8cca52b002 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISession.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I354a9470e4ca9d541417f3418ff05b8cca52b002 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Convert TicketingTest to JUnit4 syntax
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Convert TicketingTest to JUnit4 syntax ...................................................................... core: Convert TicketingTest to JUnit4 syntax Change-Id: I4fcf3a2b80abe94a4357a9aa10e801212d8e6f4f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/TicketingTest.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fcf3a2b80abe94a4357a9aa10e801212d8e6f4f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Convert FileUtilTest to JUnit4 syntax
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Convert FileUtilTest to JUnit4 syntax ...................................................................... core: Convert FileUtilTest to JUnit4 syntax Change-Id: I18fd9f0fa1ade26c732eaf84013427eccfdfb800 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/FileUtilTest.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18fd9f0fa1ade26c732eaf84013427eccfdfb800 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Convert ErrorTranslatorTest to JUnit4 syntax
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Convert ErrorTranslatorTest to JUnit4 syntax ...................................................................... core: Convert ErrorTranslatorTest to JUnit4 syntax Change-Id: I072de540ba81f6ac79edeaf5657ffdb4fc1cdf79 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ErrorTranslatorTest.java 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I072de540ba81f6ac79edeaf5657ffdb4fc1cdf79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix modifiers in ErrorTranslatorTest
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix modifiers in ErrorTranslatorTest ...................................................................... core: Fix modifiers in ErrorTranslatorTest Added missing static modifiers as pee Eclipse IDE warnings. Change-Id: Ie5ebb48b2be333b1cd85e9770a233b1bae67a1fc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ErrorTranslatorTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5ebb48b2be333b1cd85e9770a233b1bae67a1fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Convert TimeSpanTest to JUnit4 syntax
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Convert TimeSpanTest to JUnit4 syntax ...................................................................... core: Convert TimeSpanTest to JUnit4 syntax Change-Id: I5c8660975a1f0500fe2fc455330c0f2198d54cc5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/TimeSpanTest.java 1 file changed, 12 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c8660975a1f0500fe2fc455330c0f2198d54cc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: corei: Remove prints from TimeSpanTest
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: corei: Remove prints from TimeSpanTest ...................................................................... corei: Remove prints from TimeSpanTest Removed useless class to System.out.println() from TimeSpanTest. Change-Id: I343ae713822fffdc74708f6502f579a4eb8b3cca Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/TimeSpanTest.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I343ae713822fffdc74708f6502f579a4eb8b3cca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: use JUnit 4 syntax in RegexTest
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: use JUnit 4 syntax in RegexTest ...................................................................... core: use JUnit 4 syntax in RegexTest Change-Id: I4633091a1b929af23fea333f2a1fa661b83bc575 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/RegexTest.java 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4633091a1b929af23fea333f2a1fa661b83bc575 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove XmlRpcUtilsTest
by amureini＠redhat.com 13 Apr '13

13 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove XmlRpcUtilsTest ...................................................................... core: Remove XmlRpcUtilsTest Removed XmlRpcUtilsTest, as it had no usable code anyway - it was a component test, not a unit test, and was all commented out anyway. Change-Id: I59c21980fecdfed3bf6e98b1cbbbd3d483032512 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtilsTest.java 1 file changed, 0 insertions(+), 24 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59c21980fecdfed3bf6e98b1cbbbd3d483032512 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Cross-window communication support for UI plugins
by vszocs＠redhat.com 12 Apr '13

12 Apr '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Cross-window communication support for UI plugins ...................................................................... webadmin: Cross-window communication support for UI plugins This patch introduces support for cross-window (cross-origin) communication that can be utilized by UI plugins, i.e. custom content (contributed by UI plugin) talks back to UI plugin code via WebAdmin (parent) window. This enables custom content to pass arbitrary messages back to given UI plugin(s) which might, or might not, react to them. The implementation is based on HTML5 window.postMessage API that triggers 'message' events on the target (i.e. WebAdmin parent) window. WebAdmin takes care of intercepting such messages, doing allowed source origin checks, and passing message data to UI plugins as appropriate. Sample UI plugin code: <snip> var api = parent.pluginApi('showcase'); // New function - define custom API options api.options({ // Can be either a string (single origin) // or a string array (multiple origins) // "*" means "any origin", as per HTML5 spec allowedMessageOrigins: 'http://nicedomain:8080' }); api.register({ UiInit: function() { // Assuming dialog content sends message via: // parent.postMessage(message, targetOrigin) api.showDialog(...); }, // New event handler function MessageReceived: function(data, sourceWindow) { // Source origin check already passed here window.alert('MessageReceived: ' + data); } }); api.ready(); </snip> Aside from message processing, 'sourceWindow' can be used to establish two-way communication between custom content window and UI plugin code. This patch also includes smaller (general) improvements. Change-Id: I8a159bed88e0709b54a31f0959fb08b6cdf508cb Bug-Url: https://bugzilla.redhat.com/895103 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/SystemModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/Plugin.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginEventHandler.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/ApiOptions.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsArrayHelper.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsObjectWithProperties.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/MessageEventData.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/MessageReceived.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/PostMessageDispatcher.java 10 files changed, 341 insertions(+), 27 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a159bed88e0709b54a31f0959fb08b6cdf508cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Chris Morrissey <cmorriss(a)netapp.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetStorageServerConnectionsQuery
by amureini＠redhat.com 12 Apr '13

12 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetStorageServerConnectionsQuery ...................................................................... core: Remove GetStorageServerConnectionsQuery GetStorageServerConnectionsQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetStorageServerConnectionsQuery class 2. The GetStorageServerConnections constant representing it in VdcQueryType 3. The getAll() method in StorageServerConnectionsDAO (which was only used by the query), its implementation, and its test. 4. The GetAllFromstoage_server_connections stored procedure that was only used by the said DAO function. Note that the test for StorageServerConnectionsDao.get(Guid) is slightly redone so it no longer depends on getAll()'s implementation. Change-Id: I352f819dd3a7b272ccf1b39cfcf76cca62a8ee10 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/storages_san_sp.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageServerConnectionsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java 6 files changed, 5 insertions(+), 62 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I352f819dd3a7b272ccf1b39cfcf76cca62a8ee10 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Locale docs servlet.
by vszocs＠redhat.com 12 Apr '13

12 Apr '13

Vojtech Szocs has submitted this change and it was merged. Change subject: core: Locale docs servlet. ...................................................................... core: Locale docs servlet. - Added DocsServlet to automatically redirect users if the servlet cannot find the documentation in the users locale. - Added a check to make sure we are being passed a valid locale. - Added an intermediate page to inform the user that the documentation in their locale does not exist and how to install it. - Added unit tests for all used classes. Change-Id: I37156061cbdd7d2df3290c88dee933c41e0087c5 Bug-Url: https://bugzilla.redhat.com/885823 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/root/pom.xml A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/DocsServlet.java M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/FileServlet.java A backend/manager/modules/root/src/main/webapp/WEB-INF/help/no_lang.jsp M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml A backend/manager/modules/root/src/test/java/org/ovirt/engine/core/DocsServletTest.java A backend/manager/modules/root/src/test/java/org/ovirt/engine/core/FileServletTest.java A backend/manager/modules/root/src/test/resources/org/ovirt/engine/core/filetest/en-US/index.html A backend/manager/modules/root/src/test/resources/org/ovirt/engine/core/filetest/fr/index.html A backend/manager/modules/root/src/test/resources/org/ovirt/engine/core/filetest/index.html A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocaleUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ServletUtils.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/LocaleUtilsTest.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ServletUtilsTest.java A backend/manager/modules/utils/src/test/resources/org/ovirt/engine/core/utils/zerosize 15 files changed, 1,130 insertions(+), 70 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37156061cbdd7d2df3290c88dee933c41e0087c5 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Fix compilation error
by tjelinek＠redhat.com 12 Apr '13

12 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: Fix compilation error ...................................................................... userportal: Fix compilation error Fix unused import checkstyle violation introduced by f4fcac9d9a6873ea294ab1f14c24a83a61264d07 Change-Id: I167902214c3ed88fc8955883eb5b6197ed0c2795 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Martin Beták: Verified -- To view, visit http://gerrit.ovirt.org/13845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I167902214c3ed88fc8955883eb5b6197ed0c2795 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Frontend support for setting per-VM VncKeyboardLayou...
by tjelinek＠redhat.com 12 Apr '13

12 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Frontend support for setting per-VM VncKeyboardLayout ...................................................................... engine: Frontend support for setting per-VM VncKeyboardLayout Added combobox to EditVM dialog for setting the VncKeyboardLayout per individual VM. Change-Id: I8f143e5b8425805ea87651ec382f0bc95f584591 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=916866 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 16 files changed, 81 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Beták: Verified -- To view, visit http://gerrit.ovirt.org/12787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f143e5b8425805ea87651ec382f0bc95f584591 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: cleanup console utils usage
by tjelinek＠redhat.com 12 Apr '13

12 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: cleanup console utils usage ...................................................................... userportal,webadmin: cleanup console utils usage Following cleanups: - removed code which was copy/pasted to configurator - moved common configurator configuration from UtilsModule to BaseUtilsModule - removed couple of unused declarations Change-Id: If073bd036a46d9bae3aa21f088cc76c83af613ee Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUtilsModule.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UtilsModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/UtilsModule.java 5 files changed, 10 insertions(+), 58 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If073bd036a46d9bae3aa21f088cc76c83af613ee Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: fixing fqdn validation
by juan.hernandez＠redhat.com 12 Apr '13

12 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: fixing fqdn validation ...................................................................... packaging: fixing fqdn validation if _getPatternFromNslookup returns an empty set, the validation will have caused a traceback. Change-Id: I4bf1385fbb1770c990c4b31c59d829ce91e4ed00 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine_validators.py 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bf1385fbb1770c990c4b31c59d829ce91e4ed00 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Mark Huth <mhuth(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetEventSubscribersBySubscriberId
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove GetEventSubscribersBySubscriberId ...................................................................... core: Remove GetEventSubscribersBySubscriberId GetEventSubscribersBySubscriberIdQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetEventSubscribersBySubscriberIdQuery class. 2. The GetEventSubscribersBySubscriberId constant representing it in VdcQueryType. Change-Id: Ib58c99f7e73ac7cd3baff5fe6f53955c328e1c9b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetEventSubscribersBySubscriberIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 0 insertions(+), 19 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib58c99f7e73ac7cd3baff5fe6f53955c328e1c9b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetAllEventSubsribers
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove GetAllEventSubsribers ...................................................................... core: Remove GetAllEventSubsribers GetAllEventSubsribersQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetAllEventSubsribersQuery class. 2. The GetAllEventSubsribers constant representing it in VdcQueryType. 3. The getAll() method in EvetDAO, its implementation, test and underlying stored procedure, as this method was only used by the aforementioned query. Change-Id: Ic49e45cfdec1b08d2688d1e33f62a32176510547 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/event_sp.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllEventSubscribersQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java 6 files changed, 0 insertions(+), 59 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic49e45cfdec1b08d2688d1e33f62a32176510547 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetNotificationEventMap
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove GetNotificationEventMap ...................................................................... core: Remove GetNotificationEventMap GetNotificationEventMapQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetNotificationEventMapQuery class. 2. The GetNotificationEventMap constant representing it in VdcQueryType. 3. The getAllEventMaps() method in EvetDAO, its implementation, test and underlying stored procedure, as this method was only used by the aforementioned query. Change-Id: Icfb382d6d294ac4ce940646cc0ef33f35d9e10cc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/event_sp.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNotificationEventMapQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java 6 files changed, 0 insertions(+), 53 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfb382d6d294ac4ce940646cc0ef33f35d9e10cc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetEventNotificationMethodByType
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove GetEventNotificationMethodByType ...................................................................... core: Remove GetEventNotificationMethodByType GetEventNotificationMethodByTypeQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetEventNotificationMethodByTypeQuery class. 2. The GetEventNotificationMethodByType constant representing it in VdcQueryType. 3. The GetEventNotificationMethodByTypeParameters class only used by the aforementioned query. 3. The getAllEventNotificationMethodByTppe() method in EvetDAO, its implementation, test and underlying stored procedure, as this method was only used by the aforementioned query. Change-Id: Ib347d2f60c84924f2b3e3904066c3e9582e8f736 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/event_sp.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetEventNotificationMethodByTypeQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetEventNotificationMethodByTypeParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java 7 files changed, 0 insertions(+), 80 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib347d2f60c84924f2b3e3904066c3e9582e8f736 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetEventNotificationMethods
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove GetEventNotificationMethods ...................................................................... core: Remove GetEventNotificationMethods GetEventNotificationMethodsQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetEventNotificationMethodsQuery class. 2. The GetEventNotificationMethods constant representing it in VdcQueryType. 3. The getAllEventNotificationMethods() method in EvetDAO, its implementation, test and underlying stored procedure, as this method was only used by the aforementioned query. Signed-off-by: Allon Mureinik <amureini(a)redhat.com> Change-Id: I9ab37e8fb5a1602b0d8d0d9b1107c596dd33093b --- M backend/manager/dbscripts/event_sp.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetEventNotificationMethodsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java 6 files changed, 5 insertions(+), 63 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13601 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ab37e8fb5a1602b0d8d0d9b1107c596dd33093b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetAvailableClustersByServerCpu
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove GetAvailableClustersByServerCpu ...................................................................... core: Remove GetAvailableClustersByServerCpu GetAvailableClustersByServerCpuQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetAvailableClustersByServerCpuQuery class. 2. The GetAvailableClustersByServerCpu constant representing it in VdcQueryType. 3. The GetAvailableClustersByServerCpuParameters class only used by the aforementioned query. 4. Methods in CpuFlagsManagerHandler only used by the aforementioned query: GetAllServerCpusBelowCpu(String, Version) and GetAllServerCpusBelowCpu(String). Change-Id: Id8bca65412e18c2c62ead41825b08cddd9506c11 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableClustersByServerCpuQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAvailableClustersByServerCpuParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 4 files changed, 0 insertions(+), 100 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8bca65412e18c2c62ead41825b08cddd9506c11 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove RegisterSearch and UnregisterSearch
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove RegisterSearch and UnregisterSearch ...................................................................... core: Remove RegisterSearch and UnregisterSearch Removed the RegisterSearch and UnregisterSearch constants from VdcQueryType, as the corresponding queries no longer exists, making these constants useless. Change-Id: I2a1bb82d7096fa7cc6ef807739fec10cb44e1cbe Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a1bb82d7096fa7cc6ef807739fec10cb44e1cbe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove CanUpdateFieldGeneric
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove CanUpdateFieldGeneric ...................................................................... core: Remove CanUpdateFieldGeneric CanUpdateFieldGenericQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The CanUpdateFieldGenericQuery class 2. The CanUpdateFieldGeneric constant representing it in VdcQueryType 3. The CanUpdateFieldGenericParameters class which was only used by the removed query class. Change-Id: I644d8b5c6854de5c14b3a93fd37c2e77666a890e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CanUpdateFieldGenericQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/CanUpdateFieldGenericParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 52 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I644d8b5c6854de5c14b3a93fd37c2e77666a890e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove HasFreeVmsInPool
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove HasFreeVmsInPool ...................................................................... core: Remove HasFreeVmsInPool HasFreeVmsInPoolQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The HasFreeVmsInPoolQuery class 2. The HasFreeVmsInPool constant representing it in VdcQueryType 3. The HasFreeVmsInPoolParameters class which was only used by the removed query class. 4. Moved several static methods from VmPoolCommandBase which were used by HasFreeVmsInPoolQuery and AttachUserToVmFromPoolAndRunCommand to AttachUserToVmFromPoolAndRunCommand, as it is now the only command that uses them - getVmToAttach(NGuid), getPrestartedVmToAttach(NGuid), getNonPrestartedVmToAttach(NGuid). These methods' visibility was also reduced to private, as they no longer need to be used outside this class. Change-Id: I3ed0bd42dc7c3c33bffcd97035c5c5e80bdc6df6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HasFreeVmsInPoolQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/HasFreeVmsInPoolParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 5 files changed, 37 insertions(+), 67 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ed0bd42dc7c3c33bffcd97035c5c5e80bdc6df6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetAllVmPools
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove GetAllVmPools ...................................................................... core: Remove GetAllVmPools GetAllVmPoolsQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetAllVmPoolsQuery class 2. The GetAllVmPools constant representing it in VdcQueryType Change-Id: I09730eba7e90bc1372569ca8389ff346c099aa23 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmPoolsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 0 insertions(+), 16 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09730eba7e90bc1372569ca8389ff346c099aa23 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove VdcUtils
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove VdcUtils ...................................................................... core: Remove VdcUtils This class is not used at all. Change-Id: I7de5666a260ad57a30534adc1ea86a5ef5642886 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/VdcUtils.java 1 file changed, 0 insertions(+), 23 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7de5666a260ad57a30534adc1ea86a5ef5642886 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetVmPoolMapByVmPoolId
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove GetVmPoolMapByVmPoolId ...................................................................... core: Remove GetVmPoolMapByVmPoolId GetVmPoolMapByVmPoolIdQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetVmPoolMapByVmPoolIdQuery class 2. The GetVmPoolMapByVmPoolId constant representing it in VdcQueryType 3. The GetVmPoolMapByVmPoolIdParameters class which was only used by the removed query class. Change-Id: I26120323c99b3043321032d3c495dc7faed0a8b3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPoolsMapByVmPoolIdQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmPoolsMapByVmPoolIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 31 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26120323c99b3043321032d3c495dc7faed0a8b3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetVmsByUserid
by lhornyak＠redhat.com 12 Apr '13

12 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove GetVmsByUserid ...................................................................... core: Remove GetVmsByUserid GetVmsByUseridQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetVmsByUseridQuery class 2. The GetVmsByUserid constant representing it in VdcQueryType 3. The GetVmsByUseridParameters class which was only used by the removed query class. Change-Id: I1ed4821fceb06fbce6ac3f4b3851d903637b3132 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsByUseridQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsByUseridParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 39 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ed4821fceb06fbce6ac3f4b3851d903637b3132 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in otopi[otopi-1.0]: java: do not fail set environment with null
by Alon Bar-Lev 11 Apr '13

11 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: java: do not fail set environment with null ...................................................................... java: do not fail set environment with null Change-Id: Icda678d448bcf4d241782e08b2e6c067da3b4790 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/java/MachineDialogParser.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icda678d448bcf4d241782e08b2e6c067da3b4790 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[otopi-1.0]: core: support more complex sequence relationships
by Alon Bar-Lev 11 Apr '13

11 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: support more complex sequence relationships ...................................................................... core: support more complex sequence relationships perform before/after multiple times to allow list to be synchronized. Change-Id: I28ca4fdf48f657feaf72c928d61f4f8a5996bad8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/otopi/context.py 2 files changed, 32 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28ca4fdf48f657feaf72c928d61f4f8a5996bad8 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: core: print environment when error detected
by Alon Bar-Lev 11 Apr '13

11 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: print environment when error detected ...................................................................... core: print environment when error detected this will help to analyze current state from logs Change-Id: Ia7cfbabe815bac4935967feb59fd36c50d04d646 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/context.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7cfbabe815bac4935967feb59fd36c50d04d646 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: NewEditStorageModelBehavior refactor
by derez＠redhat.com 11 Apr '13

11 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: NewEditStorageModelBehavior refactor ...................................................................... webadmin: NewEditStorageModelBehavior refactor - Refactor items availability logic in NewEditStorageModelBehavior (I.e. extract the numerous conditions into boolean flags). - Remove the deprecated export Iscsi/FCP models from the items list (simplifies the availability conditions). Change-Id: Ib8e1914811367726d46c1bfaea08aba37174c11e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 19 insertions(+), 27 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8e1914811367726d46c1bfaea08aba37174c11e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Configure management network at host activation
by masayag＠redhat.com 11 Apr '13

11 Apr '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Configure management network at host activation ...................................................................... engine: Configure management network at host activation If the engine detects a host which has no management network (either due to new installation or misconfiguration), the host activation command will attempt to configure a management network on top of that interface. The network configuration on the host will relies on the same information as reported by VDSM for the host (boot protocol, IP address and subnet mask). Change-Id: Ia82e594b888b84b3aa079cc9aa76fa0dddc59f1d Bug-Url: http://bugzilla.redhat.com/891056 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 7 files changed, 153 insertions(+), 15 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10919 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia82e594b888b84b3aa079cc9aa76fa0dddc59f1d Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: AddVmFromTemplate - remove redundant logic
by derez＠redhat.com 11 Apr '13

11 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: AddVmFromTemplate - remove redundant logic ...................................................................... webadmin: AddVmFromTemplate - remove redundant logic Removing redundant logic from VmListModel -> onSave(): for getting selected storage domains / allocation policies, DisksAllocationModel -> getImageToDestinationDomainMap() should be passed to AddVmFromTemplateParameters. Change-Id: I1eb9157cbf692a8de4e5751390ed925310bdf4a0 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 4 insertions(+), 46 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1eb9157cbf692a8de4e5751390ed925310bdf4a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Enable column resizing in Network main tab
by vszocs＠redhat.com 11 Apr '13

11 Apr '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Enable column resizing in Network main tab ...................................................................... webadmin: Enable column resizing in Network main tab 1. Enabled column resizing in Network main tab table, to keep it consistent with other table-based main tabs 2. Removed maxTextLength restriction since the column resizing makes it unnecessary (the user can simply resize the column) Change-Id: Ib89d494a26a7fb48a5525057ab89e86f2ac07ad6 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib89d494a26a7fb48a5525057ab89e86f2ac07ad6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Modified model logic to support adding new bonds
by alkaplan＠redhat.com 11 Apr '13

11 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Modified model logic to support adding new bonds ...................................................................... webadmin: Modified model logic to support adding new bonds The model used to check that there were actually free bonds reported by the host; this is no longer necessary once we enable the user to add new bonds. Also deleted the corresponding error message. Change-Id: I7d3c2377ff9d95dfff1c3c416e7fc9242795e227 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 2 files changed, 1 insertion(+), 14 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d3c2377ff9d95dfff1c3c416e7fc9242795e227 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Added default created bond to comply with SuggestB...
by alkaplan＠redhat.com 11 Apr '13

11 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Added default created bond to comply with SuggestBox ...................................................................... webadmin: Added default created bond to comply with SuggestBox Since when performing a bonding action, the user may now create a newly-named bond, it doesn't make much sense to choose one of the existing free bonds by default. The solution is to put a "bond" prefix as default, and let the user either proceed to add an arbitrary number or choose one of the suggested existing bonds. Change-Id: I6b68f6b5f89089a7f78609b78df2e3e92827234d Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksAddBondModel.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b68f6b5f89089a7f78609b78df2e3e92827234d Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Added frontend bond name validation
by alkaplan＠redhat.com 11 Apr '13

11 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Added frontend bond name validation ...................................................................... webadmin: Added frontend bond name validation Now that the user may add new bond names, it is necessary to check that the given name is of the correct format; added a specific validation class, as well as the code to actually perform the check on the popup window. Change-Id: I8f5ea2b582f3117817ef72f7d3350977a124681f Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/BondNameValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 4 files changed, 25 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f5ea2b582f3117817ef72f7d3350977a124681f Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Added SuggestBox bond name widget
by alkaplan＠redhat.com 11 Apr '13

11 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Added SuggestBox bond name widget ...................................................................... webadmin: Added SuggestBox bond name widget When creating a new bond or editing an existing one through the newer bond popup window, the widget for picking a bond name is now a SuggestBox rather than a ValueListBox. This enables the user to input a new bond name, as well as choose between suggested bond names that already exist on the host and are free (as was customary historically). Change-Id: I130586dc4787abecf81566a8d3b723d093f6fca2 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelSuggestBox.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelSuggestBoxEditor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksBondModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java 7 files changed, 194 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I130586dc4787abecf81566a8d3b723d093f6fca2 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Changed bond list models to hold String
by alkaplan＠redhat.com 11 Apr '13

11 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Changed bond list models to hold String ...................................................................... webadmin: Changed bond list models to hold String The models all used to hold VdsNetworkInterface entities, but only ever used the NICs' names, so they really should have held String entities all along. This will facilitate adding new bonds in following patches. Change-Id: I4ede413e9c6fdc4b117eb10d6e7ff580f65324d1 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksAddBondModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksEditBondModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java 6 files changed, 22 insertions(+), 25 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ede413e9c6fdc4b117eb10d6e7ff580f65324d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0