April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Created class hierarchy for bond popups
by alkaplan＠redhat.com 11 Apr '13

11 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Created class hierarchy for bond popups ...................................................................... webadmin: Created class hierarchy for bond popups Created a class hierarchy for bond popup windows to replace the "compact mode" boolean parameter mechanism. This to enable better control over which windows enable creating new bonds from the engine in following patches. Change-Id: Ib9f4de41a5d298bf922e9ad7fee64ee2b62c3700 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostBondInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksAddBondModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksBondModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksEditBondModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/SetupNetworksBondPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java 10 files changed, 142 insertions(+), 87 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9f4de41a5d298bf922e9ad7fee64ee2b62c3700 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fixing edit policy button style
by ecohen＠redhat.com 11 Apr '13

11 Apr '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: fixing edit policy button style ...................................................................... webadmin: fixing edit policy button style In other locales the button text overflow. Fixed alignment (margin) and removed button's width. Change-Id: Ibfe84279c19fb9b8824acc8fb3d082c131f5083c Bug-Url: https://bugzilla.redhat.com/921892 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterPolicyView.ui.xml 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfe84279c19fb9b8824acc8fb3d082c131f5083c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: 'for min' label width is too short
by ecohen＠redhat.com 11 Apr '13

11 Apr '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: 'for min' label width is too short ...................................................................... webadmin: 'for min' label width is too short In cluster policy view. Causing line to break in other locales. removed width style. Change-Id: I5cfcdf53b068859c38a4ad00135383c63ddfe303 Bug-Url: https://bugzilla.redhat.com/921901 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cfcdf53b068859c38a4ad00135383c63ddfe303 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: display address override message
by tjelinek＠redhat.com 11 Apr '13

11 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: display address override message ...................................................................... webadmin: display address override message The patch 63867923f1d80fc2527cc78cb3a3dd92b0eff9a6 added possibility to configure the console address of a host but did not add a validation message to all the required places. Change-Id: I5b292c74a7b02796cc780dcebd3c2b66e643d306 Bug-Url: https://bugzilla.redhat.com/928298 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 7 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b292c74a7b02796cc780dcebd3c2b66e643d306 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove IsVdsGroupWithSameNameExist
by lhornyak＠redhat.com 11 Apr '13

11 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove IsVdsGroupWithSameNameExist ...................................................................... core: Remove IsVdsGroupWithSameNameExist IsVdsGroupWithSameNameExistQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The IsVdsGroupWithSameNameExistQuery class 2. The IsVdsGroupWithSameNameExist constant representing it in VdcQueryType 3. The IsVdsGroupWithSameNameExistParameters class which was only used by the removed query class. Change-Id: I45467851d4f11b3f94496974cf6665c7206daeb5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVdsGroupWithSameNameExistQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsGroupWithSameNameExistParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 36 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45467851d4f11b3f94496974cf6665c7206daeb5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: update httpd conf on engine-upgrade
by juan.hernandez＠redhat.com 11 Apr '13

11 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: update httpd conf on engine-upgrade ...................................................................... packaging: update httpd conf on engine-upgrade If /etc/httpd/conf.d/ovirt-engine.conf exists, the httpd configuration will be updated creating: - /etc/httpd/conf.d/proxy_ovirt-engine.conf - /etc/httpd/conf.d/ovirt-engine-root-redirect.conf It will configure mod_deflate also on upgrade and not only on install. Change-Id: I73175ef2acc9cf88261eb7df4f17602085151b1c Bug-Url: https://bugzilla.redhat.com/948783 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-upgrade.py 2 files changed, 31 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73175ef2acc9cf88261eb7df4f17602085151b1c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove IsVdsWithSameIpExistsQurey
by lhornyak＠redhat.com 11 Apr '13

11 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove IsVdsWithSameIpExistsQurey ...................................................................... core: Remove IsVdsWithSameIpExistsQurey This patch removes the unused IsVdsWithSameIpExistQuery. Removed in this patch: 1. The IsVdsWithSameIpExistQuery class. 2. The IsVdsWithSameIpExistParameters class only used by the aforementioned query. 3. The IsVdsWithSameIpExist constant from VdcQueryType corresponding to the aforementioned query. 4. The isVdsWithSameIpExists and isVdsWithSameIpExsitsStatic methods in VdsHandler which are no longer in use. Change-Id: Ife14c2758c8f46b244a32ac67747aecbf9d799b4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVdsWithSameIpExistsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsWithSameIpExistsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 4 files changed, 0 insertions(+), 44 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Michael Kublin: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife14c2758c8f46b244a32ac67747aecbf9d799b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove IsVdsWithSameHostExistsQurey
by lhornyak＠redhat.com 11 Apr '13

11 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Remove IsVdsWithSameHostExistsQurey ...................................................................... core: Remove IsVdsWithSameHostExistsQurey This patch removes the unused IsVdsWithSameHostExistQuery. Removed in this patch: 1. The IsVdsWithSameHostExistQuery class. 2. The IsVdsWithSameHostExistParameters class only used by the aforementioned query. 3. The IsVdsWithSameHostExist constant from VdcQueryType corresponding to the aforementioned query. 4. The isVdsWithSameHostExists and isVdsWithSameHostExsitsStatic methods in VdsHandler which are no longer in use. Change-Id: If6387786899342cf1c9e242aded0ee56053604bc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsVdsWithSameHostExistQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsVdsWithSameHostExistParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 4 files changed, 0 insertions(+), 42 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6387786899342cf1c9e242aded0ee56053604bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Guard against premature CommonModel nullification
by vszocs＠redhat.com 10 Apr '13

10 Apr '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Guard against premature CommonModel nullification ...................................................................... webadmin: Guard against premature CommonModel nullification This patch ensures that CommonModel instance gets nullified via deferred command, only after current UiCommon-related processing is over. In case some SyncSearch response callback still executes after that, "getModel() != null" condition in DataBoundTabModelProvider should guard against potential NullPointerExceptions. This patch also removes "CommonModel != null" assertions from UiCommonModelResolver, since it's possible for CommonModel reference to be null in some edge-case scenarios (i.e. SyncSearch response callback being executed after user signs out). Change-Id: I2bf55e75d97006d230bf503fac026722321435d0 Bug-Url: https://bugzilla.redhat.com/924670 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/CommonModelManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/UiCommonModelResolver.java 3 files changed, 20 insertions(+), 7 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bf55e75d97006d230bf503fac026722321435d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: db: add missing vdc_option for 3.3
by gchaplik＠redhat.com 10 Apr '13

10 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: db: add missing vdc_option for 3.3 ...................................................................... db: add missing vdc_option for 3.3 also removed a single 2.2 property that left behind (SupportForceExtendVG) Change-Id: I12406fd340b778cb2160ec063d68c4f3c5a42518 Bug-Url: https://bugzilla.redhat.com/924201 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 28 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12406fd340b778cb2160ec063d68c4f3c5a42518 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Gateway is not defined after bonding the RHEVM int...
by alkaplan＠redhat.com 10 Apr '13

10 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Gateway is not defined after bonding the RHEVM interface. ...................................................................... webadmin: Gateway is not defined after bonding the RHEVM interface. When detaching the network its parameters (boot protocol, address, subnet and gateway- for managenemt network) are saved for the next attach. The bug was that in case of managemnet network the gateway parameter was always determined from the nicEntity. But if the management network is over vlan it should be taken from the vlanNic. Change-Id: I7deff4305d04a6cfc943bb38cb795373ea7ff6e4 Bug-Url: https://bugzilla.redhat.com/923443 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7deff4305d04a6cfc943bb38cb795373ea7ff6e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: proxy: rename proxy httpd conf.d file
by juan.hernandez＠redhat.com 10 Apr '13

10 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: proxy: rename proxy httpd conf.d file ...................................................................... packaging: proxy: rename proxy httpd conf.d file In rhel the mod_proxy_ajp module is loaded in its own conf.d file named proxy_ajp.conf. Our proxy configuration should be loaded after this configuration file to make sure the proxy is loaded and the proxy_ajp_module symbol is available. Change-Id: Ic37b672d262985b38ea253c165ae2234d70963d2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/ovirt-engine-proxy.conf.in 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic37b672d262985b38ea253c165ae2234d70963d2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: validate vfstype is not empty for Posix conn
by amureini＠redhat.com 10 Apr '13

10 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: validate vfstype is not empty for Posix conn ...................................................................... core: validate vfstype is not empty for Posix conn Add validation when adding a new Posix storage connection that vfsType is not empty. Change-Id: I38bf5820ed6c6220bd2c9b9d6be1fa6dd31934ea Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java 2 files changed, 73 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38bf5820ed6c6220bd2c9b9d6be1fa6dd31934ea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: do not fail if /var/tmp/ovirt-engine missing
by juan.hernandez＠redhat.com 10 Apr '13

10 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: do not fail if /var/tmp/ovirt-engine missing ...................................................................... packaging: do not fail if /var/tmp/ovirt-engine missing Change-Id: If189b0380911f857b5b412436b966801bb4827a2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If189b0380911f857b5b412436b966801bb4827a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Allow skipping management network validation
by masayag＠redhat.com 10 Apr '13

10 Apr '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Allow skipping management network validation ...................................................................... engine: Allow skipping management network validation The management network validation is skipped when refresh capabilities is being executed as part of the host activation flow. In this flow there is a change the host wasn't configured to have the management network, therefore management network is removed from the network validation and it be performed as part of the setup network sequence in which the management network will be created on the host. Change-Id: Idf4bf4affcd901b23e2d4d55ba85763928180fcd Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 3 files changed, 26 insertions(+), 7 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf4bf4affcd901b23e2d4d55ba85763928180fcd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Update host activeNic on GetCapabilities
by masayag＠redhat.com 10 Apr '13

10 Apr '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Update host activeNic on GetCapabilities ...................................................................... engine: Update host activeNic on GetCapabilities The patch saves the value of activeNic provided by VDSM property lastClientIface and returns the vds element which contains it as a return value of the activate command. Change-Id: I04e6452078a56e1aba0b57464ffde529285fb34d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ActivateVdsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 3 files changed, 6 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04e6452078a56e1aba0b57464ffde529285fb34d Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add activeNic attribute to VDS class
by masayag＠redhat.com 10 Apr '13

10 Apr '13

Moti Asayag has submitted this change and it was merged. Change subject: core: Add activeNic attribute to VDS class ...................................................................... core: Add activeNic attribute to VDS class Added activeNic attribute to VDS class which represents the last NIC used to communicate with the host. Change-Id: I95b14d4f8315f85d15b12dde1b67524f5ffe9ae3 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95b14d4f8315f85d15b12dde1b67524f5ffe9ae3 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: fix SD selection on clone VM from template
by derez＠redhat.com 10 Apr '13

10 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal: fix SD selection on clone VM from template ...................................................................... userportal: fix SD selection on clone VM from template Fixing storage domain selection when creating a VM from template using clone allocation. DisksAllocationModel -> getImageToDestinationDomainMap() should be passed to AddVmFromTemplateParameters (for getting user's selected values). Change-Id: I67e6c4af0ffed01f37bf3c5798654a250e45a018 Bug-Url: https://bugzilla.redhat.com/928410 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 3 files changed, 9 insertions(+), 41 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67e6c4af0ffed01f37bf3c5798654a250e45a018 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: Added error handling on -H option
by knesenko＠redhat.com 10 Apr '13

10 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: Added error handling on -H option ...................................................................... Added error handling on -H option If an unknown host is specified using -H option, output an error and exit with critical error code. (cherry picked from dd7085ce5054f8306749b81674ab7ef4cb2423b1) Change-Id: I4939cf66ba787c6970b7c457f2bdd605118a61c6 Bug-Url: https://bugzilla.redhat.com/918020 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4939cf66ba787c6970b7c457f2bdd605118a61c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: Added error handling on -H option
by knesenko＠redhat.com 10 Apr '13

10 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: Added error handling on -H option ...................................................................... Added error handling on -H option If an unknown host is specified using -H option, output an error and exit with critical error code. Change-Id: I4939cf66ba787c6970b7c457f2bdd605118a61c6 Bug-Url: https://bugzilla.redhat.com/918020 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4939cf66ba787c6970b7c457f2bdd605118a61c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: ClassCastException in VmSnapshotListModel fix
by gchaplik＠redhat.com 10 Apr '13

10 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: frontend: ClassCastException in VmSnapshotListModel fix ...................................................................... frontend: ClassCastException in VmSnapshotListModel fix The change in AsyncDataProvider.GetCustomPropertiesList in ada6bac1 caused ClassCastException. This patch fixes handling result of this method in VmSnapshotListModel. Change-Id: Ie23f1994d218742133a7d963173e416d8e94cfcc Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 2 insertions(+), 14 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie23f1994d218742133a7d963173e416d8e94cfcc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Run tests without data source location retry
by sanjal＠redhat.com 10 Apr '13

10 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: core: Run tests without data source location retry ...................................................................... core: Run tests without data source location retry Since commit fd6835 the application retries the location of the data source, this means that some tests will take a long time to run because the data source is never deployed in the testing environment. To prevent that this change adds configuration parameters to run those tests with an alternative configuration that disables the retry. Change-Id: I8583da699ae46ce571bb96aa79809031d8d54990 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/pom.xml A backend/manager/modules/bll/src/test/resources/engine.conf A backend/manager/modules/bll/src/test/resources/engine.conf.defaults 3 files changed, 14 insertions(+), 0 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8583da699ae46ce571bb96aa79809031d8d54990 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Enable Gluster hooks
by kmayilsa＠redhat.com 10 Apr '13

10 Apr '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Enable Gluster hooks ...................................................................... webadmin: Enable Gluster hooks Enable action added for Gluster Hooks sub tab in cluster. Change-Id: If4b3af2c0669278e1fc776420e1ed8bf70ddbe5f Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGlusterHookListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGlusterHookView.java 3 files changed, 85 insertions(+), 16 deletions(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4b3af2c0669278e1fc776420e1ed8bf70ddbe5f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Enable gluster hook on cluster
by sanjal＠redhat.com 10 Apr '13

10 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Enable gluster hook on cluster ...................................................................... engine: Enable gluster hook on cluster Added Bll command to enable a given gluster hook on all available up servers in the gluster cluster. This command will be invoked from the hook management UI. Once the BLL command is invoked, - VDS command is called to enable hook on each of the server. - Hook's status is changed to enabled in DB. - If there are errors enabling the hook on any of the servers in the cluster, the conflict status of hook is updated in DB to indicate that there is a status conflict. Added an abstract class GlusterHookStatusChangeCommand that EnableGlusterHookCommand extends from. This class uses ThreadPoolUtil to invoke the VDS commands simultaneously. Change-Id: Icc6f9c77393ebed2803ec2a1b295a09f61642c31 Signed-off-by: Selvasundaram <sesubram(a)redhat.com> Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ClusterUtils.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterHookParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 18 files changed, 578 insertions(+), 5 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc6f9c77393ebed2803ec2a1b295a09f61642c31 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Fix notifier to safely handle MAIL_SERVER
by yzaslavs＠redhat.com 10 Apr '13

10 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fix notifier to safely handle MAIL_SERVER ...................................................................... tools: Fix notifier to safely handle MAIL_SERVER Change-Id: Ica12831cbb0b1ccae3d1f93c5d67e3ef9e5ae024 signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-notifier.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica12831cbb0b1ccae3d1f93c5d67e3ef9e5ae024 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Host with no display network should not be selected ...
by alkaplan＠redhat.com 10 Apr '13

10 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Host with no display network should not be selected to run VMs ...................................................................... engine: Host with no display network should not be selected to run VMs If ConfigValue.OnlyRequiredNetworksMandatoryForVdsSelection is false, or if the cluster's display network is not attached to the host, the host shouldn't be selected/eligible to run VMs in that cluster. Change-Id: Ie90e2821f2299be85b1d4c9a6f064a4053f93e73 Bug-Url: https://bugzilla.redhat.com/949434 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 82 insertions(+), 15 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie90e2821f2299be85b1d4c9a6f064a4053f93e73 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, core: enable edit Posix storage domains
by amureini＠redhat.com 10 Apr '13

10 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin, core: enable edit Posix storage domains ...................................................................... webadmin, core: enable edit Posix storage domains Enable editing path of Posix storage domains via UI. Domains can be edited when in maintenance, the edited properties are path, vfstype and mount options. Change-Id: I8904ffab80e9d6e6bfdee4b8375872d1ff64b4d4 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 269 insertions(+), 94 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8904ffab80e9d6e6bfdee4b8375872d1ff64b4d4 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Support 3.1 network topologies by AttachNetwork
by mkolesni＠redhat.com 10 Apr '13

10 Apr '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Support 3.1 network topologies by AttachNetwork ...................................................................... engine: Support 3.1 network topologies by AttachNetwork The patch provides support for 3.1 network topologies by the AttachNetworkCommand, also exposed via the api by: api/hosts/{host:id}/nics/{nic:id}/attach The supported network topologies over a nic are: 1. Attach a VM network (with/without vlan) 2. Attach a non-VM network (with/without vlan) 3. Attach a non-VM network to a nic which a vlan is already attached to. 4. Attach a vlan to a nic which a non-VM network is already attached to. The unsupported network topologies are: 1. Attaching any network to a nic which a non-vlan VM network is already attached to. 2. Attach a non-vlan VM network to a nic which any network is already attached to. 3. Attach a non-VM network to a nic which a non-VM network is already attached to. 4. Attach any network to a nic if unmanaged network is already attached to. Change-Id: I9e1abe84e2877171be5af41c9bb3ab590fed3653 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java 1 file changed, 82 insertions(+), 23 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/13722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e1abe84e2877171be5af41c9bb3ab590fed3653 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixing perfomance issue between VdsRunTimeInfo and R...
by mkublin＠redhat.com 10 Apr '13

10 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing perfomance issue between VdsRunTimeInfo and RunVmCommandBase ...................................................................... engine: Fixing perfomance issue between VdsRunTimeInfo and RunVmCommandBase After introducing atomic update, no need for special lock inside of RunVmCommandBase.decreasePendingVms() In order to keep functionality for delay: SynchronousQueue will be used. The thread will stuck until time out or some other thread will add some object to queue Change-Id: Ia6c6e26c79dc6c06c9621e1938ecd034e9ce7ec7 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsMonitor.java 2 files changed, 21 insertions(+), 48 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6c6e26c79dc6c06c9621e1938ecd034e9ce7ec7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Compare and set instead of updateVdsDynamic in VM sc...
by mkublin＠redhat.com 10 Apr '13

10 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Compare and set instead of updateVdsDynamic in VM scenarios ...................................................................... engine: Compare and set instead of updateVdsDynamic in VM scenarios The following patch should solve a following problems: 1. Deadlock between RunVmCommandBase.decreasePendingVms and VdsUpdateRuntimeInfo.AfterRefreshTreatment line with code: ResourceManager.getInstance().getEventListener().processOnVmPoweringUp(...); 2. Replace get for vds dynamic , update some values, and after that update in db by single db update. The old way creates a dirty state fot host status field, fix will reduce a noise in host life cycle scenarios 3. Performance improved: less db access, less locks acquired, no deadlocks What is not solved (problems which were before and should be solved in next patches) 1. Race between VdsManager.OnTimer() and RunVmCommandBase.decreasePendingVms() 2. RunVmDelayer.evaluated can be based on not updated data 3. Interaction of loop over ResourceManager.getInstance().getEventListener().processOnVmPoweringUp(...) inside VdsUpdateRuntimeInfo.AfterRefreshTreatment with RunVmCommands - it is a war for locks, or "code of death" for all system during RunVm scenarious Change-Id: I363afc5c3411b0c13e6d6c9ed5b16004738b6ca7 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/dbscripts/vds_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UpdateVdsDynamicDataVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/UpdateVdsDynamicDataVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 13 files changed, 142 insertions(+), 169 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I363afc5c3411b0c13e6d6c9ed5b16004738b6ca7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: fix SD selection on clone VM from template
by derez＠redhat.com 10 Apr '13

10 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal: fix SD selection on clone VM from template ...................................................................... userportal: fix SD selection on clone VM from template Fixing storage domain selection when creating a VM from template using clone allocation. DisksAllocationModel -> getImageToDestinationDomainMap() should be passed to AddVmFromTemplateParameters (for getting user's selected values). Change-Id: Ic1d372d30b3bcf110fa2f63847f6dfa32f8e6b62 Bug-Url: https://bugzilla.redhat.com/928399 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 2 files changed, 19 insertions(+), 40 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1d372d30b3bcf110fa2f63847f6dfa32f8e6b62 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Fixing mailserver validation
by yzaslavs＠redhat.com 10 Apr '13

10 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fixing mailserver validation ...................................................................... tools: Fixing mailserver validation This solves mail server validation - In case MAIL_SERVER does not exist, a proper error will be reported indicating MAIL_SERVER should exist. In case MAIL_SERVER exists, but empty or with a non resolvable content, a proper error indicating the MAIL_SERVER should contian resolvable address will be reported. Change-Id: Id78bec65bfa883e5fc7ec369a8b4beba6610b4d0 Bug-Url: https://bugzilla.redhat.com/921405 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-notifier.sh 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id78bec65bfa883e5fc7ec369a8b4beba6610b4d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: proxy: add missing /console.vv
by juan.hernandez＠redhat.com 09 Apr '13

09 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: proxy: add missing /console.vv ...................................................................... packaging: proxy: add missing /console.vv Change-Id: Ibfe591cf1087c05c9d6036456b3bb32193cca4e0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/ovirt-engine-proxy.conf.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfe591cf1087c05c9d6036456b3bb32193cca4e0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Display correct error when adding new storage
by tnisan＠redhat.com 09 Apr '13

09 Apr '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Display correct error when adding new storage ...................................................................... webadmin: Display correct error when adding new storage When adding a new Storage Domain (of NFS/Local type) the error displayed when the connection was failed was always "Error creating a storage domain" instead of the actual error from VDSM (no permission error etc.), the connect command was changed to propegated the VDSM error to the client there it will be tranlsated and be displayed as the translated user friendly value Change-Id: Ib8f721d3f10596253ca194a36139ba9ebcdff246 Bug-Url: https://bugzilla.redhat.com/843440 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 4 files changed, 20 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8f721d3f10596253ca194a36139ba9ebcdff246 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Builders infrastructure
by tjelinek＠redhat.com 09 Apr '13

09 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: Builders infrastructure ...................................................................... userportal,webadmin: Builders infrastructure An implementation of a flexible, easy to use, reuse an extend functionality of the builders between backend and frontend models. Change-Id: If81d4c71f9feebd6ececb9a2be46b353383046de Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/BaseSyncBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/Builder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/BuilderExecutor.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/BuilderList.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/CompositeBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/builders/BuilderExecutorTest.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/builders/TestingBackendModel.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/builders/TestingFrontendModel.java 9 files changed, 634 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If81d4c71f9feebd6ececb9a2be46b353383046de Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:delete_async_tasks_and_compensation_data...
by emesika＠redhat.com 09 Apr '13

09 Apr '13

Eli Mesika has submitted this change and it was merged. Change subject: core:delete_async_tasks_and_compensation_data... ...................................................................... core:delete_async_tasks_and_compensation_data... delete_async_tasks_and_compensation_data.sql exits on KeyError Adding a CASCADE to the TRUNCATE commands to force tables cleanup. Change-Id: I097bf1f388f082f768cd50c33d11ea1e9f081004 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=949229 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/delete_async_tasks_and_compensation_data.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I097bf1f388f082f768cd50c33d11ea1e9f081004 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove value from LockIdNameAttribute declaration
by mkublin＠redhat.com 09 Apr '13

09 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: core: remove value from LockIdNameAttribute declaration ...................................................................... core: remove value from LockIdNameAttribute declaration Remove specifying isReleaseAtEndOfExecute=true in @LockIdNameAttribute annotation declaration since it is the default value anyway. Change-Id: I2092f0c6c9a616b2133ce99cb557ba31a9cc1755 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2092f0c6c9a616b2133ce99cb557ba31a9cc1755 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in otopi[master]: core: cleanup pep8 warnings
by Alon Bar-Lev 09 Apr '13

09 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: cleanup pep8 warnings ...................................................................... core: cleanup pep8 warnings not shown at my environment... Change-Id: If3d16997af12e27216bad55339ecfb927ab6cec1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/context.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3d16997af12e27216bad55339ecfb927ab6cec1 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix overriding placeholder val in audit log
by mkublin＠redhat.com 09 Apr '13

09 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: core: fix overriding placeholder val in audit log ...................................................................... core: fix overriding placeholder val in audit log Fix overriding placeholder value set in AugitLogableBase.customValues with empty string in TypeCompat. In cases when the value of a placeholder was already populated with custom value, no need to invoke a method to try populate it again since in some cases an empty string returns causing the override of already set non empty value. Example where bug is shown - storagePoolName is displayed as unknown. "Host cannot access one of the Storage Domains attached to the Data Center <UNKNOWN>. Setting Host state to Non-Operational." Change-Id: I4239085d0bd0246369e93e38a394ab8306c05887 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4239085d0bd0246369e93e38a394ab8306c05887 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Stay in the same tab if possible
by gchaplik＠redhat.com 09 Apr '13

09 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Stay in the same tab if possible ...................................................................... webadmin: Stay in the same tab if possible Suggested behaviour for the system tree: - Dont change the selected main tab if the new tree item can show that tab Example case: Hosts tab is selected -> select spesific storage in system tree old behaviour: switch to clusters tab new behaviour: stay in hosts tab (because it is possible) Change-Id: I2c27536ecb5ef9a8f48205c217fbdf295860e363 Signed-off-by: noam slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 35 insertions(+), 26 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c27536ecb5ef9a8f48205c217fbdf295860e363 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Anonymous Coward #1000376 Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: error in custom properties sheet
by gchaplik＠redhat.com 09 Apr '13

09 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin,userportal: error in custom properties sheet ...................................................................... webadmin,userportal: error in custom properties sheet Current custom properties sheet doesn't handle cases where there are no properties stored in DB. Extracting the new duplicate code (splitting logic) into AsyncDataProvider Change-Id: Ia939952c367b6416ed90bb295f1485ce4ac63368 Bug-Url: https://bugzilla.redhat.com/924201 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java 5 files changed, 42 insertions(+), 57 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia939952c367b6416ed90bb295f1485ce4ac63368 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: cleanup: remove unused Base64 class
by gchaplik＠redhat.com 09 Apr '13

09 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: frontend: cleanup: remove unused Base64 class ...................................................................... frontend: cleanup: remove unused Base64 class Change-Id: Ie3dfa0901b3fd74e8bf35238f5734b1ce5bb61b1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/Base64.java 1 file changed, 0 insertions(+), 1,043 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3dfa0901b3fd74e8bf35238f5734b1ce5bb61b1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine : ovirt-node enter installing status when the install...
by mkublin＠redhat.com 09 Apr '13

09 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine : ovirt-node enter installing status when the install fails ...................................................................... engine : ovirt-node enter installing status when the install fails When ovirt-node installation fails because of missing iso file the status of the host is left as Installing. This patch adds VdsDynamic data to compensation context if can do action of InstalllVdsCommand fails. The status is reverted back to the previous status in compensation logic. The error messages are added to the return values CanDoActionMessages so the message can be displayed in cli Change-Id: I2d74e946cb68d2b9dbc11fc5c6bed9f63ba35fe2 Bug-Url: https://bugzilla.redhat.com/947982 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d74e946cb68d2b9dbc11fc5c6bed9f63ba35fe2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.2]: Added logging of insufficient local space
by knesenko＠redhat.com 09 Apr '13

09 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: Added logging of insufficient local space ...................................................................... Added logging of insufficient local space When checking for space availability for decompressing the ovf file in a temporary directory, notify the user and log an error if there isn't enough space. Also fixed the return value of space_test_ovf when tarfile raises an exception and made space_test_ovf a static method. (cherry picked from commit 9d2aae87f00a699391f9290edf15e0b0cb7ce6d4) Change-Id: Id9742144ed5f28399908d2dde116d34d86b3f119 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9742144ed5f28399908d2dde116d34d86b3f119 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Java7 Engine build
by amureini＠redhat.com 09 Apr '13

09 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Java7 Engine build ...................................................................... core: Java7 Engine build Since Java 6 is reaching its EOL, it is clear that we should start phasing it out, and move to Java 7 where possible. Note that the current GWT version we're using does NOT support Java 7, so the frontend code and the code it depends on remained in Java 6. This patch introduces the following: 1. Upgrading the maven-compiler-plugin setting to 1.7. 2. Upgrading animal-sniffer to 1.9, and using the official artifact from codehaus, in order to support Java 7 JDK validations. 3. Added a whitelist of com.sun classes used by existing code that would be picked up by the newly updated version of animal-sniffer, which is slightly stricter than the previous one. Note that these are unsupported internal classes of the JDK which should probably not be used externally anyway, and it would be a pretty good idea to remove these usages in future patches. Change-Id: I9ea655ab589b9907184b033ea08cc98d7ee57e63 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/searchbackend/pom.xml M frontend/webadmin/modules/pom.xml M pom.xml 5 files changed, 34 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ea655ab589b9907184b033ea08cc98d7ee57e63 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: AddVmCommand - add all SDs to permList
by derez＠redhat.com 09 Apr '13

09 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: core: AddVmCommand - add all SDs to permList ...................................................................... core: AddVmCommand - add all SDs to permList Adding all target storage domains specified in the parameters to permList (instead of getStorageDomainId() which returns an empty guid since MSD). Change-Id: I7b942af8b5093848922f060c6be44e8a69374634 Bug-Url: https://bugzilla.redhat.com/928399 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b942af8b5093848922f060c6be44e8a69374634 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: UnitVmModel - subscribe GetHostsByClusterId
by derez＠redhat.com 09 Apr '13

09 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal: UnitVmModel - subscribe GetHostsByClusterId ...................................................................... userportal: UnitVmModel - subscribe GetHostsByClusterId Adding VdcQueryType.GetHostsByClusterId to subscribed query types in Frontend (for preventing progress 'blink' on new/edit VM dialog). Change-Id: If500f79ee46638dc2a94a73cf673d8bdbd1d8880 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If500f79ee46638dc2a94a73cf673d8bdbd1d8880 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: missing call to ProceedProxyReturnValue
by derez＠redhat.com 09 Apr '13

09 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: core: missing call to ProceedProxyReturnValue ...................................................................... core: missing call to ProceedProxyReturnValue Added missing call to ProceedProxyReturnValue in VmReplicateDiskStartVDSCommand and VmReplicateDiskFinishVDSCommand. Change-Id: I4ed1b66173cd7a644fc1b412c4c28010f92f0fa8 Bug-Url: https://bugzilla.redhat.com/923194 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskFinishVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskStartVDSCommand.java 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ed1b66173cd7a644fc1b412c4c28010f92f0fa8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: IrsServerWrapper formatting
by amureini＠redhat.com 09 Apr '13

09 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: IrsServerWrapper formatting ...................................................................... core: IrsServerWrapper formatting Used Eclipse's auto-formatting to apply @Override annotations to all the methods of IrsServerWrapper. Change-Id: I92219c5a1a1901951524f7a7666822bb8b8f6f27 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java 1 file changed, 34 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92219c5a1a1901951524f7a7666822bb8b8f6f27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Speed up RemoveSnapshotCommandTest
by amureini＠redhat.com 09 Apr '13

09 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Speed up RemoveSnapshotCommandTest ...................................................................... core: Speed up RemoveSnapshotCommandTest Increased the performance of RemoveSnapshotCommandTest by eliminating the use of Mockito Matchers. Change-Id: I4c007059237e0dc4f8631f7e33feff9f41ef2368 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java 1 file changed, 8 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c007059237e0dc4f8631f7e33feff9f41ef2368 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0