May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Attach network to cluster by ID
by masayag＠redhat.com 14 May '13

14 May '13

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Attach network to cluster by ID ...................................................................... restapi: Attach network to cluster by ID The patch resolves the network which is a candidate to be attached to a cluster or to be updated within a cluster by queries all of the networks on DC level instead for all the networks which are currently attached to the cluster. Change-Id: I2293cccf3d88aea384bd61ae75d3c8d5f41408a9 Bug-Url: https://bugzilla.redhat.com/961046 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResourceTest.java 2 files changed, 63 insertions(+), 23 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2293cccf3d88aea384bd61ae75d3c8d5f41408a9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: postgres dependency
by amureini＠redhat.com 14 May '13

14 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: tools: postgres dependency ...................................................................... tools: postgres dependency Moved the postgres dependency from the default profile to the itests profile, since it is only used to connect to the database in component tests, not unit tests. Change-Id: I88aaf2c5798ccf936b455d51e6e29a589eb8f5cb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/tools/pom.xml 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88aaf2c5798ccf936b455d51e6e29a589eb8f5cb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: select all LUNs check-box fix
by derez＠redhat.com 14 May '13

14 May '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: select all LUNs check-box fix ...................................................................... webadmin: select all LUNs check-box fix Catch select all LUNs check-box event and refresh view accordingly. Change-Id: I8bf848f73d95efe9a79ea5df92646e32a4f78613 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bf848f73d95efe9a79ea5df92646e32a4f78613 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: set service name&type in ServerServiceDAO
by sanjal＠redhat.com 14 May '13

14 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: set service name&type in ServerServiceDAO ...................................................................... gluster: set service name&type in ServerServiceDAO Introduced new view gluster_server_services_view with additional columns for service_name and service_type. Updated SPs to fetch from this view instead of the table. (Removed one duplicate SP in this process) Modified GlusterServerServiceRowMapper in the DAO to populate service name and type. Also updated the test case to verify this. Change-Id: I6a4706aae779e73b4aae7ca5810fe998559f62a4 Signed-off-by: Shireesh Anjal <anjalshireesh(a)gmail.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/gluster_services_sp.sql M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerServiceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterServerServiceDaoTest.java 4 files changed, 31 insertions(+), 20 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a4706aae779e73b4aae7ca5810fe998559f62a4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix testGetRootDSENoServers
by amureini＠redhat.com 14 May '13

14 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix testGetRootDSENoServers ...................................................................... core: Fix testGetRootDSENoServers Since urls is a zero length list, urls.get(0) throws an IndexOutOfBoundsException. This exception is caught, and thus the test passes, but it's kind of meaningless - it does not execute any of the DirectorySearcher's code, and essentially tests Java's ArrayList.get(int) implementation. I guess it's safe to assume that it works correctly. Change-Id: I295d9b10495efabf892107187de7ccd91334062f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I295d9b10495efabf892107187de7ccd91334062f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove DirectorySearcherTest's @BeforeClass
by amureini＠redhat.com 14 May '13

14 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove DirectorySearcherTest's @BeforeClass ...................................................................... core: Remove DirectorySearcherTest's @BeforeClass This is a POJO test, there is no need to interact with JBoss' logging folder. Change-Id: I1b9c4df4b79dd061d941aa8d38715572fa0482b8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b9c4df4b79dd061d941aa8d38715572fa0482b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Reduce timeout in DiretorySearcherTest
by amureini＠redhat.com 14 May '13

14 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Reduce timeout in DiretorySearcherTest ...................................................................... core: Reduce timeout in DiretorySearcherTest Reduced timeout to 1 millisecond instead of 1 second. The timeout here is meaningless since all the test are done against mock servers anyway, and reducing the timeout allows the test to pass in in environments where network connectivity is disabled. Change-Id: I2cd5b543963a3c6c16b8cfe2a40e5433c5ac3422 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cd5b543963a3c6c16b8cfe2a40e5433c5ac3422 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DirectorySearcherTest proper failures
by amureini＠redhat.com 14 May '13

14 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: DirectorySearcherTest proper failures ...................................................................... core: DirectorySearcherTest proper failures Used the proper JUnit 4 syntax for failures - @Test with the expected parameter, instead of the ugly hack of catching an exception and returning before the test reaches a fail() statement. Change-Id: Icdc729f0aa78674f45ce11aab844cbf9751a6ac6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java 1 file changed, 9 insertions(+), 31 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdc729f0aa78674f45ce11aab844cbf9751a6ac6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed unused Roles queries
by amureini＠redhat.com 14 May '13

14 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed unused Roles queries ...................................................................... core: Removed unused Roles queries This patch removes several queries for Roles which are not used anymore. This patch includes: 1. Removing GetRolesByAdElementIdQuery, GerRolesByAdElementIdAndNullTagQuery and GetRolesForDelegationByUserQuery. 2. Removing the VdcQueryType constants corresponding to the aforementioned queries. 3. Removing the GetRolesByAdElement constant from VdcQueryType, as it has no corresponding query class. 4. Removing RoleDAO.getAllForAdElement(Guid) and RoleDAO.getForAdElement(Guid) which were only used by the aforementioned queries. This removal includes the interfaces, implementations, underlying stored procedures and tests. Change-Id: If424d0936dc9c7dc89400c7b492febde1d2bf075 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/multi_level_administration_sp.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRolesByAdElementIdAndNullTagQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRolesByAdElementIdQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRolesForDelegationByUserQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java 8 files changed, 0 insertions(+), 197 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If424d0936dc9c7dc89400c7b492febde1d2bf075 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: custom properties: allow '=' in regex
by gchaplik＠redhat.com 13 May '13

13 May '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: custom properties: allow '=' in regex ...................................................................... engine: custom properties: allow '=' in regex In custom properties sheet when regex contains '=', we cannot parse the string using split('=') (the parsing is invalid). To solve that added a hard limit of 2 for the string split. Bug-Url: https://bugzilla.redhat.com/956467 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Change-Id: Ic845e2ab5a0f23d48c1506f4f834a851009ea253 --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/vmproperties/VmPropertiesUtils.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/CustomPropertiesValueHelper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java 4 files changed, 5 insertions(+), 5 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic845e2ab5a0f23d48c1506f4f834a851009ea253 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0