May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine:Gluster hook entity related entries
by sanjal＠redhat.com 16 May '13

16 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine:Gluster hook entity related entries ...................................................................... engine:Gluster hook entity related entries Added name and parents retrieval to entity functions for gluster hook entity. Added missing notitification entries for gluster hook events. Added entries for GlusterHookStage and GlusterHookStatus enums Change-Id: I1fd69508ccd882251540c27b14c855b42c39bec7 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/dbscripts/create_functions.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 6 files changed, 41 insertions(+), 20 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fd69508ccd882251540c27b14c855b42c39bec7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Added null check at couple of places
by sanjal＠redhat.com 16 May '13

16 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Added null check at couple of places ...................................................................... gluster: Added null check at couple of places Change-Id: If3c14530af6a1774274ebb537dcf14cda37c70e6 Signed-off-by: Shireesh Anjal <anjalshireesh(a)gmail.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServerService.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterServicesReturnForXmlRpc.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3c14530af6a1774274ebb537dcf14cda37c70e6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: assigned value never used
by shavivi＠redhat.com 16 May '13

16 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: assigned value never used ...................................................................... findbugs: assigned value never used Assigning Guid.Empty to vmToAttach, but it never used. We override this value in the next statement. findbugs code: DLS: Dead store to local variable that shadows field Change-Id: I42dd82224a31840157cfcbd499e91f607830bc06 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42dd82224a31840157cfcbd499e91f607830bc06 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: using SimpleDateFormat as static field is not thre...
by shavivi＠redhat.com 16 May '13

16 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: using SimpleDateFormat as static field is not thread safe ...................................................................... findbugs: using SimpleDateFormat as static field is not thread safe The field EXPECTED_DATE_FORMAT has no reason to be static, remove from ignore list Change-Id: Idb20bc905a048fa65e9e25abf3c6090ef356dfb1 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- D backend/manager/modules/dal/exclude-filters.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java 3 files changed, 1 insertion(+), 31 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb20bc905a048fa65e9e25abf3c6090ef356dfb1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: remove duplicate ignore from filter
by shavivi＠redhat.com 16 May '13

16 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: remove duplicate ignore from filter ...................................................................... findbugs: remove duplicate ignore from filter Change-Id: I2e9563d758f89ffb02b041005f57922f0f614bad Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e9563d758f89ffb02b041005f57922f0f614bad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: adding comments to exclude filter xml files
by shavivi＠redhat.com 16 May '13

16 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: adding comments to exclude filter xml files ...................................................................... findbugs: adding comments to exclude filter xml files Change-Id: Ica8fcbcbf012b57c2c3289970129c08c4a235d0f Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml M backend/manager/modules/utils/exclude-filters.xml M backend/manager/tools/exclude-filters.xml M frontend/webadmin/modules/webadmin/exclude-filters.xml 4 files changed, 43 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica8fcbcbf012b57c2c3289970129c08c4a235d0f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Move animal-sniffer to pluginManagement
by amureini＠redhat.com 16 May '13

16 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Move animal-sniffer to pluginManagement ...................................................................... core: Move animal-sniffer to pluginManagement Moved animal-sniffer definition from <plugins> to <pluginManagement> so maven does not download the plugin if the animal-sniffer goal is not invoked. Change-Id: I6748886415f8be2ae970b962ec67473dec1729b1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M pom.xml 1 file changed, 16 insertions(+), 19 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6748886415f8be2ae970b962ec67473dec1729b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: manage-domains: have it respect runtime and buildtime...
by yzaslavs＠redhat.com 16 May '13

16 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: manage-domains: have it respect runtime and buildtime configuration ...................................................................... tools: manage-domains: have it respect runtime and buildtime configuration Change-Id: I21c5ecb6ceffa9cf0f6292bd5c63dedc3bcf94a3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java D packaging/etc/engine-manage-domains/engine-manage-domains.conf A packaging/etc/engine-manage-domains/engine-manage-domains.conf.in 5 files changed, 9 insertions(+), 7 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21c5ecb6ceffa9cf0f6292bd5c63dedc3bcf94a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: db: drop the obfuscation of database password
by sbonazzo＠redhat.com 16 May '13

16 May '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: db: drop the obfuscation of database password ...................................................................... db: drop the obfuscation of database password Added support for the new configuration structure for database related parameters. If the new configuration structure can't be found fallback to legacy pg_pass file. Don't ask the DB password if already read from configuration files. Change-Id: I763f5a9d1d3307ee384281b13db5c6c9436060df Bug-Url: https://bugzilla.redhat.com/958532 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M build/subst.inc M src/Makefile.am M src/__main__.py M src/config.py.in.in A src/util.py 5 files changed, 152 insertions(+), 15 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I763f5a9d1d3307ee384281b13db5c6c9436060df Gerrit-PatchSet: 4 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Console buttons clickable area fix
by tjelinek＠redhat.com 16 May '13

16 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: Console buttons clickable area fix ...................................................................... userportal: Console buttons clickable area fix [extended userportal] Console buttons of VMs are clickable on wider area as expected (table cell where the button is present). This patch fixes this incorrect behavior. Now the buttons respond when clicking on their area only. Change-Id: Ib8a0da49e86bc01c73e7a2a7226da773d659a6fc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=953140 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/ConsoleButtonCell.java 1 file changed, 38 insertions(+), 22 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8a0da49e86bc01c73e7a2a7226da773d659a6fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0