Change in ovirt-engine[master]: providers: add the onAddition and onRemoval hooks
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: providers: add the onAddition and onRemoval hooks
......................................................................
providers: add the onAddition and onRemoval hooks
Some providers need to perform additional operations on addition and
on removal, this patch gives the ability to the provider proxies to
override the onAddition and onRemoval methods in order to complete
the required actions.
Change-Id: I4b9a9af042ebd7988d90afeeecec4905a704894b
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/RemoveProviderCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java
5 files changed, 43 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15896
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b9a9af042ebd7988d90afeeecec4905a704894b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: fix for memory being removed from stateless snapshot
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: fix for memory being removed from stateless snapshot
......................................................................
core: fix for memory being removed from stateless snapshot
This patch changes the memory removal on RunVmCommand so that it will be
removed from the active snapshot instead of removing it from the
stateless snapshot for a VM that runs in stateless mode.
Change-Id: Ib4d2db4a5a21217b7ffce9a634524e196064276e
Bug-Url: https://bugzilla.redhat.com/960931
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SnapshotDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/snapshots_sp.sql
6 files changed, 30 insertions(+), 27 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16017
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4d2db4a5a21217b7ffce9a634524e196064276e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: remove read lock of template being exported - cont
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: remove read lock of template being exported - cont
......................................................................
core: remove read lock of template being exported - cont
This is a complementary patch to http://gerrit.ovirt.org/#/c/13109/
which made it possible to create a VM from template, using template
provisioning of type 'clone', while the template is being exported.
This patch makes it possible to create a VM from template, using
template provisioning of type 'thin', while the template is being
exported as well.
The dontCheckTemplateImages field is removed from
VmManagementParameterBase as it was set by all the flows that add VM
besides invoking AddVmCommand directly. now that AddVmCommand doesn't
need to check the template images as well, it becomes redundant.
Instead of checking the template images, the AddVmCommand takes shared
locks for the template and its disks, in a similar way to what was done
in http://gerrit.ovirt.org/#/c/13109/ for AddVmFromTemplateCommand.
Change-Id: I2580bc130e3b9565c8b9f515984c0180a633e3c3
Bug-Url: https://bugzilla.redhat.com/920150
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromSnapshotParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
8 files changed, 95 insertions(+), 67 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/15960
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2580bc130e3b9565c8b9f515984c0180a633e3c3
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: organize can-do methods
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: organize can-do methods
......................................................................
core: organize can-do methods
AddVmCommand#canAddVm:
1. Return false with an error as soon as a problem is detected instead
of using the 'returnValue' field to store the result
2. Inline the 'exists' variable
AddVmFromScratchCommand#canDoAction:
1. Return false with an error as soon as a problem is detected instead
of using the 'result' field to store the result
2. Remove redundant addition of action messages
VdcBllMessages.VAR__ACTION__ADD and VdcBllMessages.VAR__TYPE__VM as they
are already added by AddVmCommand
Change-Id: I4589fa4681913e41b1be595131686932d92ca062
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
2 files changed, 15 insertions(+), 26 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/15959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4589fa4681913e41b1be595131686932d92ca062
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: organize RemoveDiskCommand#getSharedLocks()
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: organize RemoveDiskCommand#getSharedLocks()
......................................................................
core: organize RemoveDiskCommand#getSharedLocks()
Extract some code to seperate methods in order to make the method more
concise and readable
Change-Id: If116452d24f838a9459ee97c88e7e49d13d0de3e
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
1 file changed, 28 insertions(+), 14 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If116452d24f838a9459ee97c88e7e49d13d0de3e
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: cleanup RemoveVmTemplateCommand#canDoAction
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: cleanup RemoveVmTemplateCommand#canDoAction
......................................................................
core: cleanup RemoveVmTemplateCommand#canDoAction
1. Replace consecutive lines of call to addCanDoActionMessage and then
'return false' with 'return failCanDoAction(..)'
2. Replace calls to DbFacade.getInstance() with call to getDbFacade()
3. Replace if-else statement with ternary-if
Change-Id: If669283fc057cff4eee46dfb15e004672d05fac1
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
1 file changed, 7 insertions(+), 14 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If669283fc057cff4eee46dfb15e004672d05fac1
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: organize RemoveDiskCommand#canRemoveTemplateDisk
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: organize RemoveDiskCommand#canRemoveTemplateDisk
......................................................................
core: organize RemoveDiskCommand#canRemoveTemplateDisk
1. Return false as soon as we detect condition that is not met, instead
of using the 'retValue' variable
2. Extract some code to seperate method in order to make this method
more concise and readable
Change-Id: I7ddc1e6abd85c61ac1486cdd60744124ebfb27b9
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
1 file changed, 36 insertions(+), 27 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15876
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ddc1e6abd85c61ac1486cdd60744124ebfb27b9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: organize VDSReturnValue class
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: organize VDSReturnValue class
......................................................................
core: organize VDSReturnValue class
1. Move all fields declarations up to beginning of the class
2. Remove the '_' prefix from fields names
3. Move the constructor to be right after the fields declarations
4. Remove the 'private' prefix from field names
Change-Id: I7a5ceaa2271dc934577a55f7de596cbcef7e25cd
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSReturnValue.java
1 file changed, 22 insertions(+), 23 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a5ceaa2271dc934577a55f7de596cbcef7e25cd
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-dwh[master]: etl: added collection of vm's client ip (#873790)
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: added collection of vm's client ip (#873790)
......................................................................
etl: added collection of vm's client ip (#873790)
Bug-Url: https://bugzilla.redhat.com/873790
Change-Id: Id0bba82bddd822c8b63f4bb9c0f2f831c583dc00
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/aggregationtodaily_3_3/AggregationToDaily.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/aggregationtohourly_3_3/AggregationToHourly.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/statisticssync_3_3/StatisticsSync.java
M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.3.item
M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.3.properties
M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.3.item
M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.3.properties
M data-warehouse/history_etl/tos_project/process/StatisticsSync_3.3.item
M data-warehouse/history_etl/tos_project/process/StatisticsSync_3.3.properties
M data-warehouse/history_etl/tos_project/talend.project
M data-warehouse/historydbscripts_postgres/create_views_3_3.sql
A data-warehouse/historydbscripts_postgres/upgrade/03_03_0010_add_vm_client_ip.sql
12 files changed, 1,928 insertions(+), 1,336 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16007
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0bba82bddd822c8b63f4bb9c0f2f831c583dc00
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: core: VmBase - remove final keyword from diskList
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: VmBase - remove final keyword from diskList
......................................................................
core: VmBase - remove final keyword from diskList
Removing 'final' keyword from diskList member in VmBase.
GWT RPC doesn't serialize 'private final' members
(i.e. diskList is returned as null to the UI).
Change-Id: I372b3b2ba5abcbc2720fa0d3b7d20eabb0750241
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16240
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I372b3b2ba5abcbc2720fa0d3b7d20eabb0750241
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months